From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7074908419729129472 X-Received: by 2002:a05:6512:2288:b0:448:31bc:8a90 with SMTP id f8-20020a056512228800b0044831bc8a90mr18812920lfu.496.1647425557151; Wed, 16 Mar 2022 03:12:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9b13:0:b0:248:f7ff:c777 with SMTP id u19-20020a2e9b13000000b00248f7ffc777ls294608lji.7.gmail; Wed, 16 Mar 2022 03:12:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPoPXMIurx2tELtcySqfnzz3mByIGiqnIkPDYBAW93sav2Gm1d5dJOFF8lpRAgw4aZYDO2 X-Received: by 2002:a2e:7a1a:0:b0:246:210:65cd with SMTP id v26-20020a2e7a1a000000b00246021065cdmr19146116ljc.99.1647425556150; Wed, 16 Mar 2022 03:12:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1647425556; cv=pass; d=google.com; s=arc-20160816; b=nzyxQzdx2nLNo3N9U6wt9bEsDDL51pwWk9q0X/WkLXzWIYUZ1/WYBzTqFHFIiESXqu GzqM3Q0l5cq+uiCl9kylHkQa3G7FAFBcVDZTdNjcvT+GDJocjB5OKX/FyDjlMwSGcals 3t4Itog6GkQNNEo6Z2ix6p0Ti5osocl7RnQyUh+TPSOygwbzaYfipmS3y8lM8Pvm+JId qFbOlrM6EF31mEHRrQZyIh+BILBmcUjqi/rYL3wtbTNG7XR6MvGZcvah8kfAjbhdnoS8 fqaF+OtTJVjBUFzpx0MeJExrxOiASm2nAzd7/XXsZGnk0fORw9jIr5ajVQaJvYPqgPQl XG6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=V1U23Rcd1D+XDLWl1AWJc9tvnDWL2WEX88JzFLSuu08=; b=Ad5wr1/49coKarYq+kEntlsuroR7xA6rKu75URSh6R06CmitgN67obqiEIxFk/KlD4 4fpQyKbUt6lWgJ1Xt1TNk1aeKBHhY0oivasy9rmEhDvfduKcpJoSPCc8f04ogiT416MY X+0OIh5x33iOCJ1uw8IOmdwEt7r4RJf5rKucTajdxmpIZZARTCXvHkPFnMpozTeoUngJ C0AkZ7MvdCAm0Inu1P03SI+bXym7avxGMvcdfJWw4Y9Iek4gE3WhZiI1S2+N6sSI9H5L JGfuQeE3lQ4tWQPkDmbkrZc2lF40aRkk8hkgrmoTycxk3PAl96g+lneAen4oBTKhwaQV 6r0w== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=eFUGHl7J; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0a::625 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03on0625.outbound.protection.outlook.com. [2a01:111:f400:fe0a::625]) by gmr-mx.google.com with ESMTPS id e15-20020ac2546f000000b00448ba65ba9csi55165lfn.13.2022.03.16.03.12.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Mar 2022 03:12:36 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0a::625 as permitted sender) client-ip=2a01:111:f400:fe0a::625; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=eFUGHl7J; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0a::625 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etc9zHoXeAznqBh2j+8Pexc3YPIj1JLBUCXdSS7RmfJdZX6A96UjWa4NBATleG9IHDlMZmqxv5Rj0kXSp8PWzTZHl7srBt6osrmpUMZsgUdnejflqEKvIP+uPoQNPZkCLDCnH525HQviJw0pUnvm1j6qXXzNTy8EEaa0ytQ4K8DG4Ld+cRoMRe5b/g50XjPlN5X7suW/NtI+akVKJNXmnBH1EI6bMuPXsg7Rvqb7BjdNDlLqM0i0bevnQP8aTmTzBzVWFo+uhuWhisTTJIL3rjn/Mj7b9ONvLZw1nl4j9GGHIullnt0/QsgLU6QYBHUQNXLhQKkDrFRVE1hFfROInQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V1U23Rcd1D+XDLWl1AWJc9tvnDWL2WEX88JzFLSuu08=; b=gJS5KIStMBYxRVAIZHgpWoc3fn4EJmSXfoUik4SbRo0lcHeR+IOLb+fYGYX985JCpg3aZCzQ5/vLNgHPUAfyXlwDqECHq3hZZDJ+TZkjG6uS67efIhxp8V7SFg3Bv3OdTOc8osp9UDGj2P45A4HPwNTdSChZspw2AsUAHc3HyExhAOt0+NVphH6nuoOwfYHWYfxSLrncP9GuvDJTXIdztwiKw2RpQqGTYktqAtiSgV/k1EjwJCQKp8q7iY368rmcgUEGo+4FUk3foPp27urd+4GDobnFf+P3TD1wvQa0L+HOUi+y7q8H+PBjbt6TjW03RtSweqhUopLg94msjinn6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V1U23Rcd1D+XDLWl1AWJc9tvnDWL2WEX88JzFLSuu08=; b=eFUGHl7J9n5uBOWWXtRgCppV5FoUJuWRFpCSTCSvsyeR3yua1EpZVl/Km9LPrCsBua7a83KX6kdK7UaIBPt5KYjUd267rbs9texxYhpFrnSohDXGFObNfB56FzlGHDHZfXR0Bh/Wm0Ms18DsHem3JWWF9bsAVfE71cjNrgGMHMhUYUkwOIOr0HNsScEH7/f/KhCAhp0cjo+IR/0kdtaywCtP89z9fcBe6S1BM+uvUso+mUnQoeJ/zziQmO5ZEsXVCc+Yihs6H/DC0IfcThqzI+scoANmnERDMpPwbMJXYpmp/56Ec8QcuCNpJZJsc7wJ3Y5o8O2wyAnROBncsfTteA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:13d::17) by HE1PR1001MB1433.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:3:f3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.26; Wed, 16 Mar 2022 10:12:34 +0000 Received: from AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM ([fe80::c4e4:a67a:d923:4b5f]) by AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM ([fe80::c4e4:a67a:d923:4b5f%7]) with mapi id 15.20.5081.014; Wed, 16 Mar 2022 10:12:34 +0000 Date: Wed, 16 Mar 2022 11:12:30 +0100 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com, Wadim Klincov Subject: Re: [PATCH] Add missing WicError import Message-ID: <20220316111230.35c4b666@md1za8fc.ad001.siemens.net> In-Reply-To: <1df6f1fc-f36b-f008-84b2-55777b934cc2@ilbers.de> References: <20220314105543.100423-1-wadim@klincov.com> <20220316092405.2044eb0f@md1za8fc.ad001.siemens.net> <1df6f1fc-f36b-f008-84b2-55777b934cc2@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0043.eurprd04.prod.outlook.com (2603:10a6:20b:312::18) To AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:13d::17) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20a9d376-f7dc-4308-704e-08da07357c88 X-MS-TrafficTypeDiagnostic: HE1PR1001MB1433:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8s/aZzTCuezIGyJ2ug9JZa8x9/p6fliMFeDXeF6QJ0sJQvsqbZgB2pfuZ1QNwpQjz1cepfVAH35Emfa+DIMHYj8NrWQN+sH8YAgU9UEjObMPoG0Bir+oqC4F1Bm8qL4fFf4cugsWy9H/wp5C+sZD1NAV0sIIVFfA+a/OyHpVpsyNX2R9jFsidmxm7/0MetYNJHOhLJNlEkCmCbSQmYQRsi29g+q2vjH/afPjwKAYguQr/1tYXeau/GJOrNWKBfQemaCZbOLEcFxU2FugJf77tLPwbQxt5F22pvH7PgaP7b3hh4F5ffmuJtQ5aZk50wu3P1fV7geGjt4RZzgFkxCdVLC0Eg8Qr1IJEY+DXoTx+3cCnfUkIm0jQDsCg4tnGl25mnY2dMuAvUyQl5x72HI2ak6VY2dQeBmOzJKk4dr4te67tFfwztTOjde1VWZxi9/W+Lc+ppmdMnPagcTgypRtXZunxntCAwHxav92ipg9h34orWrxc4X8Eu7NDToPRzpkHW0LQoW5eGmmcliW8ltxNaMYuRo0Lr+EqtPSBPtQ0xD53vWG1KEFrTXupmepoZx9TcEznVyatUYwxkjKY85zoA2FaGBVghIuEiSnCmQ3bKFOociGyuNdT7dplIGXc+fyoWvFqLHsUTR/SkSkd/UosA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(5660300002)(4326008)(82960400001)(508600001)(66476007)(4744005)(38100700002)(86362001)(44832011)(66946007)(6512007)(8676002)(66556008)(6486002)(1076003)(316002)(6916009)(186003)(9686003)(6666004)(2906002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dVeqmc+YBuGdWlFsPB8UBMEQPp8gD9OJMMktMQcI9oE8RVuFFwxvmWOYQqmZ?= =?us-ascii?Q?CEURsApgS+xX/8oG363vmjLSgh0ABIp9fdO5RtkfrCeKA+fsskGhKBXmwZqf?= =?us-ascii?Q?WA/NiX2sMUCrln7YPLG0QBI1+kH8QsOdT2S/72YFy0F3RVAPzvLD7VPM34Vd?= =?us-ascii?Q?waT9rRsNvfEfDGKvU2e+SB8sQWoUCOntQFevs+1/GqzNpo2yJgsq6II1c4BQ?= =?us-ascii?Q?7bMKK2XRZcKCP+gissUeQpib2sg6QEv01UWVVLZqGGC4yviTYby20VGUsHYy?= =?us-ascii?Q?cCgrKzSLbBtZKU1r37SixjKPyRg/bqS3nqSnvQhBeUjNFhuMRAaJr0D4N/i8?= =?us-ascii?Q?MPKXlPN57BewjBya6Hkfyph9OG93XLhUoK24kWWl5pBdi5lbotwfJp7+aZvp?= =?us-ascii?Q?EpV3dSbXYd8B4OF/ueCj30Sw2noIHpxq9ksangnphOF1zu0X5HY1Cuu3icy1?= =?us-ascii?Q?U4uCZyFv2ECyNwLFxrdpXILShRD+FzOCFcg+yKKXf4e163fCOrXKZhDqoTJD?= =?us-ascii?Q?xAdiz0phxLpBLv7LxbilkYfcj5STNv6YyDUvf9npOFg5fRw7NOtRGuFnMc/w?= =?us-ascii?Q?cNQgP+fmmlaLZVk8YN2DAN4pU/Ql391i+wthp6FPGKkPv372kvNd1kgryW/n?= =?us-ascii?Q?2+eXr6jTVTpr4Y4LsNLY57leXH80VHwClwiAGjVsQouSO8I5q+NhUxgnuqKx?= =?us-ascii?Q?owDmYRriSjJmaxLkLmmJGAm/uF/CksbfjrHuKO9XLKN9LguFPhlKykbcM0Xi?= =?us-ascii?Q?9nPfW8WpP37Il6ZDPqHcFFZcqr5KBFreifFUa/UGJLRa01B8HqCTxFxU7nCF?= =?us-ascii?Q?2KqH/3FpHAptCMx3RR2AxG0VvGpJcvhJawsIRPPx8Jw9o/WQ+hljt1s+PRW6?= =?us-ascii?Q?Q7ssopPJbab5y6BCiv30d2TtVluLrWuGLgW3gpM+eF5OtXkoiVDIAhEMhm1+?= =?us-ascii?Q?U6/kJ+U3w00x1FgBNWByZ+/Ojl/0rpMjY9omYpBrxJE98tMLWMoMHC43S8aN?= =?us-ascii?Q?ORG4pf3qXOoGTw5b66q8FWprK+Oy4/iODJY6WYxM7hDWL2C3yJJg3Dezz2E6?= =?us-ascii?Q?171yRiqyoaEZgLpeuFKgK7YP1eWGvkbJM//OGG4d2HT4BAcD4lQ+H2CPzWr1?= =?us-ascii?Q?f4bxRiTR9snVU5xfskKHowtPsmNkYXAoV+NRNe5SGBooyaSxpyChIh+5OUJj?= =?us-ascii?Q?hAevsJ0aBFF4NtvXUD2MQq95nWfiFemJO1pZlW3QvDWcKxFtXs1jg3XnxeZv?= =?us-ascii?Q?62w8F+OCBQclZ922DceNOklM5kzk0tdmqZEZv3uIGuait/fQ1xif1KkjBd7J?= =?us-ascii?Q?Dxh8hpuYrW9ubUbMEw+M4lNFXJjzv/YiCa4f7YOL3v6dsOVvAD4At50ZPLbx?= =?us-ascii?Q?LLhu9vwY1+oOSi1U9TP9ng37bhg9Wjskw+I0CqROOAZM/q3iU1dI2OkU2eQ5?= =?us-ascii?Q?zygEDfd0znM7UxH0tgIb/y3YcTzs+HQyah4EnQSrHUS9jQXBhGxMlkDUj6zh?= =?us-ascii?Q?ycaROsE5S41JWjyuL8SgT5xCOzqXToZoVHdtnP7OVkx0hSlmr2uEUXVnYw?= =?us-ascii?Q?=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20a9d376-f7dc-4308-704e-08da07357c88 X-MS-Exchange-CrossTenant-AuthSource: AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2022 10:12:33.1730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yZYAfD0D3ruDkscHSxKEJ5wdf9ayxYyAFsOFby6J4Jl/8EJA6lC+Mw0jpUccXAsJ+UouZ6jhgW554cfdBm9gGRo3PArW3eUqovIrTgDShPA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR1001MB1433 X-TUID: gAklOWyXaAl+ Am Wed, 16 Mar 2022 12:03:36 +0300 schrieb Anton Mikanovich : > 16.03.2022 11:24, Henning Schild wrote: > > This is already done in all the plugins we have in tree. The file > > you are touching here is "what we need to fork", and we do not need > > that. Or does the import in the existing plugins also not work? > > > > In case you need that in your custom plugin, just include the import > > into your own plugin. Maybe you do not even need that "base" lib for > > your custom plugin. Since it is ... what we need to fork. Not what > > we might need for our own plugins. > > > > regards, > > Henning > > I agree we should add this import of WicError in isarpluginbase.py > because it > is really used inside it. Ah yes, ACK! Henning > Any script using isar_get_filenames() can not care about its internal > implementation and can not even use WicError. So the requirement of > importing > something not even used looks wrong in that case. >