From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7074908419729129472 X-Received: by 2002:ac2:5ca9:0:b0:448:1bd8:42ba with SMTP id e9-20020ac25ca9000000b004481bd842bamr20153807lfq.488.1647429218426; Wed, 16 Mar 2022 04:13:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:b05:b0:448:696a:ea62 with SMTP id w5-20020a0565120b0500b00448696aea62ls1169761lfu.0.gmail; Wed, 16 Mar 2022 04:13:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr2gDxlzDUsPXaZj/iZxXC5Ftl2S/6dBNZK8dem1+uYJ8h0GZk6s/o1ieCeKRjJWfggwqr X-Received: by 2002:a05:6512:2e1:b0:448:2781:8db3 with SMTP id m1-20020a05651202e100b0044827818db3mr19037195lfq.21.1647429217358; Wed, 16 Mar 2022 04:13:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1647429217; cv=pass; d=google.com; s=arc-20160816; b=sAtlIGY0FBYhRvPoRaFrob+k/WCQni79kMs6N2+951Xbf8B4yPy/ASfzHHyY6LK5Hf P8cZiVZWYMBaWCsXKtYUVeQ37WjEerf1imzOIAYJgtgqdrMv7rNhqNlgOMohm4h+IKk/ 4QYNR05ogiWt6u8sVhv7N8YvShjMb60yzXbOToxkaS6SGnr8AdDPKi1MgLqkS6QnBep6 FlX5BjZRHshBxViiPsMp9AQuJWXqoV6eYBR5qYxQ5z+NHMRkoQIU3UfldBv2sgeuotvh u/dlTDnr8zBgq5E1XmXysCpmAQ7yMsqGrUjyF0aUDnfi8APheca1MZ3ks4KA6aT6bbcP gaGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=0RVW/5rw97Q/LcymFLo0PUrhALq8a/KmuR50XBNUlMk=; b=cTEknJ/yAchTlLQ/awE8CBLAQXsl36RwWZOc+84ta6lVCm9i8yBQvo4sxKW+ZeQtwF 3HFHWhPVO8lQXXMIY9iiQVqO9r6NIcfSuiMA5weZwMxgp+2u6i1AavFqYvFY2Ri1j5OU 4UqkoCYE+L9cnF5cgJmMs4ivgk0TxQXNyrr2RMLc9MfKhlpiPUZs1Z3t72f9eS8+c5uH e/gfEJPdijp+/boEhJoYXavtDsfA29L1Wsg6twHP9JqGvceHXt31qq5HPh0Mjt4AqaEI yKbUgN1EU33lBrM38WKGaDQeNLDQDoH5FRAuFbMj9mvDXHHIpVVVFUyjxMfkwVFYjf+2 ihpA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="Lkz/aFyu"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0e::623 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0623.outbound.protection.outlook.com. [2a01:111:f400:fe0e::623]) by gmr-mx.google.com with ESMTPS id bu30-20020a056512169e00b0044842a98a98si101289lfb.2.2022.03.16.04.13.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Mar 2022 04:13:37 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0e::623 as permitted sender) client-ip=2a01:111:f400:fe0e::623; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="Lkz/aFyu"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0e::623 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHyzoX7Xv3Hu1N6kae87V2gEouGNBYJrWFxEHVWoWs1vCJAfJ1OW45oGGhXTytp6pmkZ41+Wza44TypT05rGLkYSJmhJjivdFkKXeTOHq9WH13MJmlYUZMGt8seYEmbCeV8Btu3OnAvJqHgLRI4OOOAnwGi47wlt/3Mt2IoaFzODQwJIBZr603zbeiGl1nVRPytAIkyJrC076GG+9DYcO9tAbFMRvB6MbHXptsfq+a3jeQPcLrwEPWwczM6hIGp5E4gBVhyAixheFek2wunAXggB3UEZ5bSCdrWesGvk0BVCeqDtQ1uLta+3L0JYN98Nda9iXKlrTjhwSxje5x8p/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0RVW/5rw97Q/LcymFLo0PUrhALq8a/KmuR50XBNUlMk=; b=FaVerr11XUmsfWBfhu7z0cKDivWyrjuxBGPs5ftR/CAknEDaj99dP4OuZqGsvxbqrcT1WywZUAchJQ/ZRGkoBVaOcjUUBOMvQ3KUG8q5Ozo1NfnORaZJsay17x52uggP4GXIWkgfi4T18na7s/0sf3VtO5K7dg7VUM+2CrcfVLBspAP99n6xj9yQwzJn9jkatU21ZTbr5438//VifxOfxKmfdvHq8GnMSfGKxerVwoWK1RfBjNnxKGQJesF3CN+VUKt+Y9BXMEEe8LgZdf4dFydkYXp20+9jfrKz38SRHDz/UcYElkCPd5U5jW69jOhy4XbnsDzb7vDN9mKBqV4rKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0RVW/5rw97Q/LcymFLo0PUrhALq8a/KmuR50XBNUlMk=; b=Lkz/aFyu7aRVWTAcO2ATrsfnwLuQrGTlHLwdgfmbbEcDZoeJzI+N5Va7+AouCnnY4OHYYi6p/Y7kXiTx7ZcrwlbhjFCChfrXqFZS8h0EeZa1pkcn3ctbdjvJei9GCeyYxhaP37VwBycG9Xphi1s0S4e6dJLY4zChNhLM95JAQOpqapkZRFeU+zqIpIFMZ1BpYmeGVKsd62S/X5isJGao9I/0REcZBi9nGoVAHv7ASF/hXDIIqSSyBLBkqZyvuztHFBWBC8CVtVGhGuZZ9omfeQOq+7Wif5wQ7rOE51Tqe8Gwx5xteIrV6V3mslqv36cY9pfrjvmOq0YHflIDeIhkLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:13d::17) by VI1PR10MB1998.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:34::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.24; Wed, 16 Mar 2022 11:13:35 +0000 Received: from AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM ([fe80::c4e4:a67a:d923:4b5f]) by AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM ([fe80::c4e4:a67a:d923:4b5f%7]) with mapi id 15.20.5081.014; Wed, 16 Mar 2022 11:13:35 +0000 Date: Wed, 16 Mar 2022 12:13:33 +0100 From: Henning Schild To: Wadim Klincov Cc: isar-users@googlegroups.com Subject: Re: [PATCH] Add missing WicError import Message-ID: <20220316121333.3d6b3367@md1za8fc.ad001.siemens.net> In-Reply-To: <05873484-d92b-59ca-e61b-faf1359a8c1c@klincov.com> References: <20220314105543.100423-1-wadim@klincov.com> <20220316092405.2044eb0f@md1za8fc.ad001.siemens.net> <05873484-d92b-59ca-e61b-faf1359a8c1c@klincov.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P192CA0096.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::37) To AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:13d::17) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5d21c1f-fc81-42a3-6978-08da073e0390 X-MS-TrafficTypeDiagnostic: VI1PR10MB1998:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5QhDDzoomWPlll/mw//CjwJAyWEAPEL0ednHfhzgEtGiM9B5TNZY9QdpheXvCzlwsb4DWxervkXDc3VO4HlghoRFLI//Qynv07c7zWePEjzOiL3pa69J2mptKQsQRiQm2NQWWQQuBtQw34z64q4YKoWCwJ4WrVttTXvknYabwP06HCOwJNApQCo6P/CNShU4riJPrwJjUv1b8xcPcrziwrU7U6mBhJKT42nzYX030jx/1C75tQA1HBpmxjrdkD1bWj3FQp6QQ24w7BJRiTYvDtjRmL0DcJnXskVJZyUDNytmwPziFsdqYIaHH2g1LC7udedurKyKNPPdpLh3/CozR0bx8KdkhUXkc8LObN+NaliZiH5fkMeuaDmF/rsx9c3UI9DthLfssE1dYLn2kWiiWVhN9kla4LVcQ+NZ64PM/GLPSFfX2WMaSk6ddUbgxYJ5g84FjPwlsP6KPrGR4ZIZBJGTJD06UpOes9fFLkQZxsIqhvt1xXPvnf0RU+0ANph4kdf/GrY61NoEK66707gE0qnLFx314HSiWMIDO3CmKTerREc847OrVuTKlP+MsXRBrDOepvjYicp59M639lkJsE7O8lpTjOoMQfWdbCOa950gesm0ns5pGU2ki6bVczp6WczP2OYHTPtyuzpNCe1azw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(9686003)(6512007)(6506007)(6916009)(53546011)(4326008)(316002)(66556008)(66476007)(8676002)(66946007)(6486002)(508600001)(38100700002)(82960400001)(1076003)(186003)(83380400001)(8936002)(5660300002)(44832011)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WFoG0ZJjY7rzfp/4pQ4UqE1Ij4em8v62EF4WO1ycLxzWAYeJPGBLemHadUn+?= =?us-ascii?Q?Lq0iOHmVtDCkBad1SpRF8TpJLZwtwu2C/G4bwtzdGfFiGYkez0xgmwfzKXlT?= =?us-ascii?Q?8RdatJuc7yU2jHYZ1XRwkW0aNhci4aGuRwauHyt0mov+bwwennI7j6pVUxch?= =?us-ascii?Q?FKq2lLSxItmKOy46cMH9LtJ8do7QG6+m7MAdHbuj2ruSM1SPL8g0q9J2X1NQ?= =?us-ascii?Q?+TbmcGfEDEkXAe0ZWCZ6U8pjUqnWTPUNRQLb+lruYw4dRw80Ata6ONaxXzR0?= =?us-ascii?Q?MzMfiTXlS98BlKbiTsYv2mL601sW/oyGamVEs8eIrK4C7bwpLKjs7lTlnWGh?= =?us-ascii?Q?ajnqY9IiF8NT/doYpVtS/kftnsDMxJ1YcOwf+Q99dK8HIxyHbjb6CfU3dJXH?= =?us-ascii?Q?WLFLkNysU0cs9rk6sTlSacmN5eKjaoeon1HA7R+DRrvbsb8x0Eu0s2MatjPR?= =?us-ascii?Q?v4/08DGEYLOdtNj0I95IQvAqvIsSVUgIsgNQmteVA2ogSyyOT7S3y+rtL3Rr?= =?us-ascii?Q?dnsGU0PN9ugnBBex3hrbabXCDdPCOSbarueoQT+srghVZABJID5CGSiVSzVP?= =?us-ascii?Q?5MeabdHrVLNrCC46M4SpfT8AjrVn5SS17P4mJollxdSzfKdL+rAN+Rc/VUmX?= =?us-ascii?Q?f0e3i8qTjlxQffHpxchDyzcDmXeJKD/r5tDWMHOFywTrSG4EbXZJrqGKme8U?= =?us-ascii?Q?jG0QQ4398sNYBncBpQ7WXzXgyNk7VagsI1FlPt0o31Ajrh6L02iaoNiIaW0y?= =?us-ascii?Q?mmGXCTT+kOO4wbmunk0e6yRsW6ZPycivyCdTvTBc/tVe+xisFMGACpjqriSX?= =?us-ascii?Q?22ZBCpbJK6ibMLGFW81KiIkCjiD4Tt0k0tvDcRx8EpPTD+2+sIpuGEQlcPmD?= =?us-ascii?Q?H3T6gPfe8ACMvk8J0eCD9u7+G7r3j9T/VRgPyIS4emvQnTNBgcuvad4TBbJb?= =?us-ascii?Q?D3OEUUfNG+wsyY0CFGAIXS+EpYN1UqLd+g3Wdj4CB5AVPwK8CrnXjMN0lgv8?= =?us-ascii?Q?ecC74YKrNO5EMcMxL5gToNPLtdrGQSM4Ee35NbOqGtW9amdo90hLxYTPz4Y+?= =?us-ascii?Q?ELCffyReInms9ZY8SG4ce/V9DopBQpFyRGshaqItOLPPozDO0ufp71s1nYi0?= =?us-ascii?Q?Z03l8ZtYgsVzlIR2N+JncXPIxGjrvMJy1+kkFHNzS5DUVuEd3Ji5qWpb7HbQ?= =?us-ascii?Q?K1NZ7VSjl6xoxNJsKVpuNJkk97kvgV9g/arAj/iLCy8tJQTe9CZ2ZbNyNHkm?= =?us-ascii?Q?/tsvX3cLO1iMrV9XfIFS0+QrleWLvKrcGQ8X68hbJgSm5WdiWMiNJ7Z81JEL?= =?us-ascii?Q?Uoa8IZR57/Ww2ViYjNrQ5wG+vIaTlf0sWz/GzD17U1Mll1LUxhjWno3c2p4D?= =?us-ascii?Q?cIVslt31wvjXzkmTVKT65a4Vm1NKNfT6Eegf249lxPZgCYDiReVBxsNXGpQ3?= =?us-ascii?Q?JhjojP4/v3MGdRAidXiNgpDmhBEh+btYoQUNi6klr58TLxHRW7JOLnyXuxS3?= =?us-ascii?Q?TcJ88wBouojQtU4kEVt6J9Na3jST/TfLJ/iI3KzH/MD++t47iJKTnDPg6Q?= =?us-ascii?Q?=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5d21c1f-fc81-42a3-6978-08da073e0390 X-MS-Exchange-CrossTenant-AuthSource: AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2022 11:13:35.7071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FN6UGgA/UHyIS73ErJtnCzMN4uveCybpf6iSzXr9Kr6PtyBMMhSl9XzxEikhR9YsmLHhp7qtQYPxN87Me4cVJwTxtNJ0lrdXdxy0VYgjHPk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB1998 X-TUID: IaVFOlOma9mM Am Wed, 16 Mar 2022 09:12:48 +0000 schrieb Wadim Klincov : > On 3/16/22 09:24, Henning Schild wrote: > > Am Mon, 14 Mar 2022 10:55:53 +0000 > > schrieb Wadim Klincov : > > > >> This patch adds the missing import of `WicError`, making any > >> potential errors when building wic images easier to understand. > >> > >> Signed-off-by: Wadim Klincov > >> --- > >> meta/scripts/lib/wic/plugins/isarpluginbase.py | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/meta/scripts/lib/wic/plugins/isarpluginbase.py > >> b/meta/scripts/lib/wic/plugins/isarpluginbase.py index > >> 185e2ea..68af220 100644 --- > >> a/meta/scripts/lib/wic/plugins/isarpluginbase.py +++ > >> b/meta/scripts/lib/wic/plugins/isarpluginbase.py @@ -8,6 +8,8 @@ > >> > >> import os > >> > >> +from wic import WicError > >> + > > > > This is already done in all the plugins we have in tree. The file > > you are touching here is "what we need to fork", and we do not need > > that. Or does the import in the existing plugins also not work? > > > > In case you need that in your custom plugin, just include the import > > into your own plugin. Maybe you do not even need that "base" lib for > > your custom plugin. Since it is ... what we need to fork. Not what > > we might need for our own plugins. > > > > Thanks for your reply! > > Do you mean `isarpluginbase.py` is something I, as a user, should fork > and change to my liking? Right now using `BootimgEFIPlugin` (or a > slightly modified version for better resolution) works great and it > wasn't clear that it's not something which should be used. Ideally nobody should fork anything. Isar had to fork some plugins from OE, to keep those forks small and maintainable the pluginbase code was written to keep the isar-version as close as possible to OE. You hopefully do not have to fork again ... Please contribute your changes to the EFI plugin back here, or ideally into OE directly. In case you are writing your complete own isar-/layer-specific wic plugin, you might not want to use "pluginbase". Since its main goal is to cater for the OE plugins that isar re-uses in a modified way. > The issue on my side happens when `BootimgEFIPlugin` calls > `isar_get_filenames` and the kernel is not available for whatever > reason. In this case `isar_get_filenames` tries to raise `WicError`, > but since it's not imported directly in `isarpluginbase.py` a bitbake > error is thrown instead. It's still clear that the kernel is not > available, it's just not very readable. Yes i think your patch is valid. No matter what you might be doing in terms of forking or writing your own plugins. regards, Henning > > regards, > > Henning > > > >> def isar_populate_boot_cmd(rootfs_dir, hdddir): > >> # copy all files from rootfs/boot into boot partition > >> # no not copy symlinks (ubuntu places them here) because > >> targetfs is fat -- > >> 2.35.1 > >> > >> > > > Wadim >