From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7071266692367646720 X-Received: by 2002:a2e:8918:0:b0:249:b8e3:6daa with SMTP id d24-20020a2e8918000000b00249b8e36daamr13136876lji.482.1648457501783; Mon, 28 Mar 2022 01:51:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:1693:b0:448:3742:2320 with SMTP id bu19-20020a056512169300b0044837422320ls3493650lfb.1.gmail; Mon, 28 Mar 2022 01:51:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlaUBcvizyut0oM1/O+F2uyrAhDAIAlNKrxOqTmk2vpR93PlPgNU7+lLl0K4lNF9XMDhRm X-Received: by 2002:a19:e209:0:b0:44a:51af:b3fd with SMTP id z9-20020a19e209000000b0044a51afb3fdmr18422785lfg.560.1648457500880; Mon, 28 Mar 2022 01:51:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1648457500; cv=pass; d=google.com; s=arc-20160816; b=oOxwgndSRoCAHYjOQ+YihSD/xq31oL46cs767UdncJoviZob6sA20/8bMvjwo6LZjt 8BWBLEuVXmzigA6HL78EJUqFtajmOu7a1UYofxyEM4R5Q2RLYHUDJLYQc8kWBqtMYIyT z0xDjaU1PLPwNhN8FV63obbQLVmN3TtFcCea6doC+zP6dqEK3xkeF3bG+ad5QWW3Lmn7 9/+QqvkdQ896hmQ38/W++whm07xEHW0ifY5iWrNeLe3pL8fI8xht5gAgrGpfIkOcR6E7 yBuXklsG5i1CcOizKLrjxu4iNoOdPfOVZpmswkBZYo8aVTiUiifyGqpGxqGRXHkjkukL 6bWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=3BJaGf8HAQkbElZsI4R36PmtrLMnPZjOTxGcPpwttGY=; b=VGg+wwHkR3xp9zSm05HLK8zZaV0zVScXpU17nPhONMqFEetyu6O8yhlMRPevZj/CXq KYIvkeAvYnnuHcGTGQVBOncv1gvhTfs4BUx5140e+jju79NPD6QhFt/R2Tv/ScmR9GQP mre3uM1K7uyN+PylIM/SKrPwsC8PdcJBNEogVgbraIpASfrzCkfrqK5YzW61xGqj8lpM kltgTgp2GSzv4N+4jLxINVVETH2oa1DMR6yNqxWgBV3bdnyZIHyU60bJS9mbISUGm7Rq rThfhU1JJDb+P6eK8DHww/Qtka4Q8yS3R3LW91ZjpGprMyE++iOTKKJrGcmhkENUA/+7 PbgA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="Q/TrUYO+"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe08::60d as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on060d.outbound.protection.outlook.com. [2a01:111:f400:fe08::60d]) by gmr-mx.google.com with ESMTPS id z19-20020a195e53000000b0044a11f487a1si718991lfi.11.2022.03.28.01.51.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Mar 2022 01:51:40 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe08::60d as permitted sender) client-ip=2a01:111:f400:fe08::60d; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="Q/TrUYO+"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe08::60d as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGyGeYCfq2tygG2GlUHQSJFzP6Qs3YSPd3wLE5nRlnLpgPqsRWMUfDfXfFV0ruGpo/I6gzdcbxbd3/rQUi8iIalgnLdyj+E2MITGEP494Qn8rh/NAlEgd0CivxIvlG7QAA8ETbzUwCZ1Y4bbk/gFPILTXqp3zlbjUXn+1GZSExz/FIKY7mrYAT89IG60UjmsGjJsotAkUlQ+ckZeqxVVXG0Ju0XLNhPtYy03u1RG2caU8Yrmgfo4Yg0vdIkRUBYl/Wcsr7QiT/aLruKAKzhtYU0xrCvHM96POxK71dLkTyiuGrsRcuK7FHIw2hC/rggAZJQZacNKmvkwT+HsfSo+Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3BJaGf8HAQkbElZsI4R36PmtrLMnPZjOTxGcPpwttGY=; b=XYCsH93+IWSZGY0B3Puoc/pnGYU5Mou1Q5WNqwuCQ9ntCxCA9L8GUkS1r7j7aGnBM4Fav2Z9+L5Wm52H4i3gAETs0rFhUdgDWVxqbDpa85kJyV2cE5Dpjo2xTYwr9zFc9cNMpeVqF8ctuHxnBw/Hcyz1jTo0gxWaNgJPihQaYOK4E3IzjSeSH/kTFNDsQ8FVhlMkk5dRH4q0no/eLDCmQZXtNyf3uGrOfpE4rppcagYZO+QIFzgmg91GZ15AJM127TQRIv7lCZ9eSZGp+po1KIg7VwosbqkZ6eZWgJw3Ym4Gsh4A/f+OTPBZ4pEXxlq7vrJGaO8OX3/Y+l8ZzdEDHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3BJaGf8HAQkbElZsI4R36PmtrLMnPZjOTxGcPpwttGY=; b=Q/TrUYO+7Km7aNoJIcv++OBS/2eYeimxjIe/wt2Fd91t1Lclv/5FT1HnPmDwQxlx0kwJZcju8ic1iyXWuC5BL5lLv22OQA/0KHp18XamZk6CSlVS/+rvEyiYYDYVP5l8DQap14N2HWPlNZrk/E7hVbM+KvtVPa4F3oqOnJLtykYQ/7dwayEfeMvJWGrcwsiLy1FX8Hu/+EH0XpVK+Apk5jyv1SNmt0HONOLGbkdQxwdbkFfM184IgxnVx0wUS8lSgtc+fWso3viDsQxaW5gvFuMq2n0/iRryrEqlMXhy5aSMYSaRxKQBBGqxEefQJ5+HisRu8pEJf09XkNeGu/b90A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by DB8PR10MB3643.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:139::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Mon, 28 Mar 2022 08:51:39 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::15e4:d77f:1de6:485f]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::15e4:d77f:1de6:485f%7]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 08:51:39 +0000 Date: Mon, 28 Mar 2022 10:51:33 +0200 From: Henning Schild To: Felix Moessbauer Cc: , , , Subject: Re: [PATCH v3 2/7] Add ISAR version of biosplusefi WIC plugin Message-ID: <20220328105133.5c20634a@md1za8fc.ad001.siemens.net> In-Reply-To: <20220322164525.3950970-3-felix.moessbauer@siemens.com> References: <20220322164525.3950970-1-felix.moessbauer@siemens.com> <20220322164525.3950970-3-felix.moessbauer@siemens.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR02CA0047.namprd02.prod.outlook.com (2603:10b6:207:3d::24) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b302d179-03ba-4d11-3a0e-08da10982c41 X-MS-TrafficTypeDiagnostic: DB8PR10MB3643:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vvig1MR8klQ9uDQNaCCSgHsjaAXSSpyWfCnnSHFz6t2VcZnuX8BqnOuEdmE2Pjc9R+KeY+8D+JmgnvvVPDTXR5gSSk3rGfe/9x+tMJ2aW9T0edZL+sDsoBga5CHTjA6qvX5W/urDvxikViLA+3PZg7cXHwWMRDWD4r2O0TNU1BIwIlDmTkcLnY5jsfT5dc4E2x47uLt1AppxuKMeEG4YRJD0Dph8ArX1RNuifO0sCqUSPPeS/WKpCjPScdygHfY6dAuRTYEpeh4vdZCL+w4WJufb8i+SuxAWT/Edic1VWvgifdQvDai5IPw8vK1RTOua29gElBIWJw4tslcW+fD6Fr3JlE7sf/jVIhW6BAtP/YnVv40zzKOkVG59tQ78l4ObSsJW4HwFsPsAZMYfuft+7f74FKKhwgdt/xgCaefUJXM1vgH+9LKI5tuUpXIJ8lF1OfHs7YG8S1vR1XgUaK7in7g28i2AbC3UpsefjzHTM4ikKQZPwxaZAAPugndgdihs+mahGhmMLDQCoT2RA4yN0V30VDRQHPXDyOzb/UN1PDn5a0zPZiJxMN5c1BHuGlVGfTpP+t/Iv8L7AVKnWPzc7u3m0SqZa0NxWbmwlJ5DP2bC0g2zhtYdfjTHUqjLMcYZ+uigoAza8/NyXWOUBYJNMA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(107886003)(66476007)(66946007)(1076003)(6486002)(4326008)(83380400001)(6862004)(8676002)(508600001)(186003)(86362001)(9686003)(6636002)(316002)(6506007)(6512007)(2906002)(44832011)(54906003)(6666004)(8936002)(5660300002)(38100700002)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?snHqNUZ7bUzH4Ppi8EkvReVTUFmd/tZznIXKHzeWv6Fjg76TPAzAAnOP9XlN?= =?us-ascii?Q?pIuLOehvO07Pf4yczuIqCb8bQopGDdfMc4uEq0maU2M+m2WO5sAUquHiG0GJ?= =?us-ascii?Q?l7JKIJtvDFBqkmYRT6FcQfrmBL9+5PQekvsgOhhi7tDDXIBpkmfdxXxUQOOM?= =?us-ascii?Q?p0QvAKzv989xn4ypIXu45Y7JaSYMwmukkv5Bv9/yVPP0tfEjNVYQBErAzZ0N?= =?us-ascii?Q?N3b1zMHJ262zBYHs0yGZAXWqJ4mJ/WvsWrR4p0LVLQVrh5Qko+jCweKMzN13?= =?us-ascii?Q?sXeZAH5COzaEH3E00cAYhxYfG8ct9cnYIQRmuA3zWbabee/AhQY1NoJ1QbGo?= =?us-ascii?Q?pnL1k8P99vMnV/PNv+HjqV/0nAFR0ZoRjkhYn7EXviFnj7MVOjI8Ca9QkAFc?= =?us-ascii?Q?fpVZWvBLBz+i5Khnwf8xa1p6yzoxf908NQunkCyboVIA6dhq/ucHbwv9QhX9?= =?us-ascii?Q?ifDQD7ihXHfZyFj0gWUtqpchS6cDPPtKZG0YNgC+AoZe6YoKYV2m6dcKuilD?= =?us-ascii?Q?lS/JILyryUiaE9Dff/LxgKVKwPStYwpCxsofrohXHc5HzNW9jLMXXBVWTqYO?= =?us-ascii?Q?VXWKmcj6kQb9BXI061qyOXHMbvgy61kftJkofjPjoPDyF1DmL74/n06abW+n?= =?us-ascii?Q?EPt4CHT0TVj/dm0eZHSo9mhAzp+DgVlu5ll8OsmJkwSaAi4+LMPTvA6D4mVh?= =?us-ascii?Q?Y/gMkfPHDvSeQo79cXY+ljkwqEX5H76uKszqxjzl6zFf7LO+eOPIUF27Xvzj?= =?us-ascii?Q?s9tj/LOc+1vz4akcPxcUmaZMtdEfSKJ8AXuMrCiBmRuXDCLnZJ7JWtuXmEBW?= =?us-ascii?Q?S8nusWk6su6uxpOH22KT5s4X6wRgjOFOHRvHyuimKGII2tsGW6WkB47BcwaH?= =?us-ascii?Q?v05WPwmTbxmZPFbturuQ7fDWOFMzD4z5f0FUx2IX6FrgTMErMCtM9tMddynf?= =?us-ascii?Q?GQ8NkwSvFC2MfAFiTK+nbrrg1HzDtpE5LeohCUdeHAaLoR/+zhYreiWgb9Tc?= =?us-ascii?Q?0VaF4zhP64q6JjERMN8/Ph4kC8YD+0SILIIuaU+JkMWq+fAPRrRnAtvzWg3d?= =?us-ascii?Q?boOI3CIaH94OFhAzaBacbCOIwhSkcGbMMXCVb/R8iTln5ylQn9JZFCWz9VYz?= =?us-ascii?Q?vIb32msnFQvG7mk+1lFEyxwZqf6/ffjuIJx2VVOiDu4BIxDl6nt7AyYRWUlg?= =?us-ascii?Q?Wr2hwwouW5xQLppxHgB7zavwUOy7/p/GJIOh2Prk9x1JWxZFjLb2Ds6JSVP+?= =?us-ascii?Q?yLMAa2E0Hyel8KfMCQp72SiHgEI5ENAq+klzhuF4vSM+JidkDTE7lVEfAgB2?= =?us-ascii?Q?rrxUDFFOQunPlt7OJwVYptgYirdDOyPGgpG3gYh+vVuDETgT4+kYk/OstSTJ?= =?us-ascii?Q?E+793AmYXSNHpW8XEXWQerIggZxP4/47iHhU/5avYh8noAZJg5f6xQ5vHzMt?= =?us-ascii?Q?sO1MfDXACIpLBMmbX7TTrPPhahDcifnkiF3tjsOSx0H2NfBg7b22/zHw3xZj?= =?us-ascii?Q?b8IPMuwVnINKRTSydIH67JwzZWgMqD91QVRmfbNlBJCq+yI/TGoyNQhUuSXf?= =?us-ascii?Q?S9IlANKvancrunT30S+crPexiBPUFbASkWVpCisoxWIhkC65iyoSIDrO3SjB?= =?us-ascii?Q?K/Z8rIXrIRYaR+KJeu8B3FRMB7VPKPVimxHkrt/mC9AdzovCnDpnMMA4z2pP?= =?us-ascii?Q?Iqdp/bpx1AiYCv6QurN24hYyfb0ESQp14lJ4qO/dS/x1pPrZ0CtB11hWIc8X?= =?us-ascii?Q?YYZpCbgW9JBy7+DWabeyTC4JmmjNbbV0ELUEcdiE7JhVMhT9IHVN5PkoO3lq?= X-MS-Exchange-AntiSpam-MessageData-1: pPkB3RtnaZTWmoHdxCF8FyeVoTBZzb6bg5A= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: b302d179-03ba-4d11-3a0e-08da10982c41 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 08:51:39.2235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LjYpk1qm/+AXa8qtCt/sirdxdnGutgPr6oD4zHFi2QFP+AjT4o5/1VIItHf6NRIuGMY6ZOF8N9xkOCTP14VLOwYKj7WlgIEuopZ09pBscnQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3643 X-TUID: rqSz06DSpr1O Am Tue, 22 Mar 2022 17:45:20 +0100 schrieb Felix Moessbauer : > This patch adds support to create a disk image that works with both > EFI and legacy bios. The biosplusefi-isar is based on the original > biosplusefi WIC plugin that internally calls the bootimg-pcbios and > bootimg-efi. By that, code duplication can be avoided. > > The generated image can be booted with EFI or legacy pcbios. > > Signed-off-by: Felix Moessbauer > --- > .../lib/wic/plugins/source/bootimg-biosplusefi-isar.py | 8 > ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git > a/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py > b/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py > index 5bd73906..fb6b7fcc 100644 --- > a/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py +++ > b/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py @@ > -75,10 +75,10 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin): > --ondisk sda --label os_boot --active --align 1024 --use-uuid """ > - name = 'bootimg-biosplusefi' > + name = 'bootimg-biosplusefi-isar' > > - __PCBIOS_MODULE_NAME = "bootimg-pcbios" > - __EFI_MODULE_NAME = "bootimg-efi" > + __PCBIOS_MODULE_NAME = "bootimg-pcbios-isar" > + __EFI_MODULE_NAME = "bootimg-efi-isar" > > __imgEFIObj = None > __imgBiosObj = None > @@ -106,7 +106,7 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin): > loader = SourceFileLoader(cls.__PCBIOS_MODULE_NAME, > modulePath) mod = types.ModuleType(loader.name) > loader.exec_module(mod) > - cls.__imgBiosObj = mod.BootimgPcbiosPlugin() > + cls.__imgBiosObj = mod.BootimgPcbiosIsarPlugin() Mhh, for some reason we did rename the class in that fork but not in the EFI one. Maybe something to get sorted out in this series, or later. Not sure which option would be best ... i guess the consistent rename would be the conservative option, meaning the EFI class would have to go -class BootimgEFIPlugin(SourcePlugin) +class BootimgEFIIsarPlugin(SourcePlugin) Henning > # Import bootimg-efi (class name "BootimgEFIPlugin") > modulePath = > os.path.join(os.path.dirname(os.path.realpath(__file__)),