Re: [PATCH v3 2/7] Add ISAR version of biosplusefi WIC plugin

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 28 Mar 2022 11:11:40 +0200
schrieb "Moessbauer, Felix (T CED SES-DE)"
<felix.moessbauer@siemens.com>:

> > > a/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py
> > > +++
> > > b/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py
> > > @@ -75,10 +75,10 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin):
> > > --ondisk sda --label os_boot --active --align 1024 --use-uuid """
> > > -    name = 'bootimg-biosplusefi'
> > > +    name = 'bootimg-biosplusefi-isar'
> > >
> > > -    __PCBIOS_MODULE_NAME = "bootimg-pcbios"
> > > -    __EFI_MODULE_NAME = "bootimg-efi"
> > > +    __PCBIOS_MODULE_NAME = "bootimg-pcbios-isar"
> > > +    __EFI_MODULE_NAME = "bootimg-efi-isar"
> > >
> > >      __imgEFIObj = None
> > >      __imgBiosObj = None
> > > @@ -106,7 +106,7 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin):
> > >          loader = SourceFileLoader(cls.__PCBIOS_MODULE_NAME,
> > > modulePath) mod = types.ModuleType(loader.name)
> > >          loader.exec_module(mod)
> > > -        cls.__imgBiosObj = mod.BootimgPcbiosPlugin()
> > > +        cls.__imgBiosObj = mod.BootimgPcbiosIsarPlugin()  
> > 
> > Mhh, for some reason we did rename the class in that fork but not
> > in the EFI one.  
> 
> That is indeed not consistent. However, I don't know about the side
> effects when renaming this. Looks like the class name is not part of
> our API as the WIC script just takes the name of the python file
> (e.g. --source bootimg-efi-isar). By that, a rename should be safe.
> 
> > 
> > Maybe something to get sorted out in this series, or later. Not
> > sure which option would be best ... i guess the consistent rename
> > would be the conservative option, meaning the EFI class would have
> > to go  
> 
> I vote for not refactoring this as part of the series.
> It is technically unrelated (we just call the existing plugins) and
> just delays the integration.

Good. We should keep that in mind, and i agree that we should not slow
down any more.

Henning

> Felix
> 
> > 
> > -class BootimgEFIPlugin(SourcePlugin)
> > +class BootimgEFIIsarPlugin(SourcePlugin)
> > 
> > Henning
> >   
> > >          # Import bootimg-efi (class name "BootimgEFIPlugin")
> > >          modulePath =
> > > os.path.join(os.path.dirname(os.path.realpath(__file__)),  
>