From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7071266692367646720 X-Received: by 2002:a2e:bc19:0:b0:249:b29c:7f5e with SMTP id b25-20020a2ebc19000000b00249b29c7f5emr16588746ljf.312.1648459222956; Mon, 28 Mar 2022 02:20:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:1693:b0:448:3742:2320 with SMTP id bu19-20020a056512169300b0044837422320ls3556348lfb.1.gmail; Mon, 28 Mar 2022 02:20:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZnzUBqW/vuGZIBU0YTH7926++hAJ1+hFplM7Xt0nXx7VJ8S3cWKaVQirJZ+T5Po17SC8B X-Received: by 2002:a05:6512:c23:b0:44a:2c00:1a08 with SMTP id z35-20020a0565120c2300b0044a2c001a08mr18788888lfu.468.1648459222015; Mon, 28 Mar 2022 02:20:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1648459222; cv=pass; d=google.com; s=arc-20160816; b=Pusxb0gaVWi9TtJLQJCsYQOB/S3fRpLt2d8NSAHDz8EkC7eJya0QXPyFgWV92gfenw /0bRrD8R81jiF2WIAjkg0y84eXemMw+MqH+C42TfdxbrZzDcld6x6cMB8peYazbJKp/U iAVXT5wM/Q4Xmz1mvOCVHuyPYjPj8dAhOOXkOhanSXVGFoXrCh0ROE9oxQTX68u5g1zT 89R5ssDWGzQgMUxZJ7CmAp0mzvobIEMezjkHTVSEoeEiRFjHBAwLTeT0bN1+Gn+Xt52t SxL4oNJdclgkeqHPJMcOKWRTgRSkDGryn3fUPXEGxhQfQKEvq2eeuig442mN8dKQ2BYX OJWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=mKniaktdNW7QY1MIY2f5vek4bQnX72DpHa9ijmaYq7M=; b=ZXTRas8cvKX+33SRmhTPu5qd0Ts/E7ewM61CILPHEkhT+qTWSnkxB25cxxWrqE0tvm qa/yS9HSlFJlfmjAtIONE/uhyySpA5Szev7PgI1Ef1QE7kFI8SrtPxJuy2GSWlfDWu50 cQWhnUmgJahEiHf1HPnzJLlbQJR0JNf+poworbz1LMuRjIgWMwIuFSxsWHK8dJL55jUm o1dO08oDhwGA6/7qeSiPHHLrbxDQvjXxJb+fehnI4oYG7Pz4XwppkzSY7kjmkqE9mLwO e6OtEtg+H5KF3i7Scopj1MihTr8qpFb4sfZTlcmgUSBQCz6LFEWWmfw44caPGObPA43C GrOw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=fHPPn10B; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::624 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20624.outbound.protection.outlook.com. [2a01:111:f400:7e1a::624]) by gmr-mx.google.com with ESMTPS id q5-20020a2e8745000000b0024801a668d9si613407ljj.6.2022.03.28.02.20.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Mar 2022 02:20:21 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::624 as permitted sender) client-ip=2a01:111:f400:7e1a::624; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=fHPPn10B; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::624 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QXJmPv+D/y+ayaPGsX8s2B/6qZkvQmWyGAgMn9H1cifCirwc29vKRoRpP8FDpTvoQkgrc/o7Fc18vTshgaeoCu5jR7CDazFVMp7iwowJ6y6dJWzWAwAGBgR67pKkZak8dfnLFSNqhbkwb/J2NkvOfXKnoOrdfGglDQLVFGx5MVONZYjguWSlLOPqqQ2onvC+FYSFqdj5ZB+dqg9VRVFcGyuhXrOa8QkxHD7Es3pkOegxP3bLI9L8ipg7LfNfPszSJtReQNiO/0UZq5ZLzVkhMx6ICcChZIuK0Rpoc1YhQ5T/+YgEC1X8rrPFlgmoBH2yctFm5SzomGV09SpxSER+Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mKniaktdNW7QY1MIY2f5vek4bQnX72DpHa9ijmaYq7M=; b=GBfv5fJHlsoNoQwk9YJ89YDLkfhJVK2RV87Nz2yKcpDQoI4qTe/0wFQY4G22nw9eC2Ygi7jjJOKu5u46hvuUSybUROtUI55AGOICW9yZmTl7Wa4KiCVryN99t8fp7bkjcPF8tVQB1aTe52PB7lWuiRnrbKU2KAHPnnDZ72SkA/FSW/7Jv0eY1UperoU9l+/w1CMOPAch9JozGsyxBDprn1sJZnvU18Ki3VmqA3sykywkYOKJyQr4ZuDFcQm815YkZCf5eqc6qsvUCVkOQDd6tHqi+0JZadOANMY1ZJkXPGF4DdULWPIAa4sEsaLQTZTa0p5QeFGrZyLv9n/T2XLsQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mKniaktdNW7QY1MIY2f5vek4bQnX72DpHa9ijmaYq7M=; b=fHPPn10BZ5l3UsIa4gSe4LdEgAGYdEyXPCa/XhNxWNqGn3IRhDAkf316paBqF6qTW/nL3vGOcFLoTo1fanwZjyDh+DM3gF/a4Kxw6Vo4qWyiGUugk2ROHNS5wggTxKBEaNXKpx0LqSFUVrWzjK3JJoQu8490bHDIlSJ2KerZwgjZ2BxsW8HXJ9uQ8i/yIvlhEuua8t+h5LM/7Ib/ABaoCz7i7M+4Yzrxt9/3MtsWWx0lhrR3KXXJIPRhX7VXI7CAGLlrWrcILb3IodWOc/5unvUh6+wqJBJxM6wLI2QubD96Ulk/JbHdZeUCL6afavFaK0qUuCYMcchj9yyWsOAlKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by PA4PR10MB4558.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:10a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.19; Mon, 28 Mar 2022 09:20:20 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::15e4:d77f:1de6:485f]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::15e4:d77f:1de6:485f%7]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 09:20:20 +0000 Date: Mon, 28 Mar 2022 11:20:13 +0200 From: Henning Schild To: "Moessbauer, Felix (T CED SES-DE)" Cc: "isar-users@googlegroups.com" , "amikan@ilbers.de" , "Kiszka, Jan (T CED)" , "Schmidt, Adriaan (T CED SES-DE)" Subject: Re: [PATCH v3 2/7] Add ISAR version of biosplusefi WIC plugin Message-ID: <20220328112013.1eb5baa8@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20220322164525.3950970-1-felix.moessbauer@siemens.com> <20220322164525.3950970-3-felix.moessbauer@siemens.com> <20220328105133.5c20634a@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR0102CA0005.prod.exchangelabs.com (2603:10b6:207:18::18) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d210ec69-856d-47f3-8dcb-08da109c2e31 X-MS-TrafficTypeDiagnostic: PA4PR10MB4558:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XQ2K5qG9QDRxB5eQF0Sv7t8WFLTErPtYPsDOmlTSF5ny3EHhaOeWfNjonBC/D+TbbsH7IWhtGRyyCbMzvZbsCWSEihlqGVpCDDSzh97uVQhYXMevGJpMSf1HVC/jKbIbkbGJmtKOxHTCHjUclLyka5Fp62Shwe6ion78Icbl5QMW2dGU9kAfzW+2p8FZPQp2mAmErmgI3bvq9BLcVG5dvqZc2kwPK6eMnCBejYz+wvFqbYgSZT2X4iGl5qynJINbjhkGYC8iM7b0fB6RTYXtLC7OPm8yXPYX0L3viBNY/CjYJ/h4/BxkreStrETidmLVKiBsdhC+hdxK2MclGlppIwk5CFQkoJs/2/Zfgyd4GmE8+pWFhoPcVwDrsrrGVMPVa7wzyadlDu2zHzlmi7Ev5sP0b8plIbPp4FONK0sUz6UPEaD9eZysYkWgrtjOWq7cRSwi/bWwKEj0T4MTVUrJA7HnDKbiBX8SSWuJOLCE2L4AVxwXbvSNG8d96qqs2CsFBdMaXNjHDT2e4hzVLaiJoEbopJmd5Z40RVh9kUC7kZLwGh5gE/GKkQwmWN+W+ox1Oknf5PNYebksCVZsV54X6qRGSAz+hR6UOiEADWpLb/Q5h1BdnjfeKtEtkhUblteczKTl/EuZhttiRrYZhX9bRg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(44832011)(38100700002)(107886003)(54906003)(8936002)(1076003)(86362001)(6636002)(508600001)(8676002)(6666004)(6486002)(6506007)(186003)(66946007)(66556008)(5660300002)(316002)(4326008)(82960400001)(66476007)(9686003)(6512007)(2906002)(6862004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b8BZw6ihe/OwzZ29NE32sfrxID3klAy+xHiVMVpInfmFWRR6Ljqwev1Lruy+?= =?us-ascii?Q?2R6mny81Fas3kpHdRIEQYYtHksZJRZWjcHcdmE56S/KAThirCmXZeDNrgjAI?= =?us-ascii?Q?DWK3deQBDX1XP3XfGOx80qeb0EYa3z+XklH81zGjqyZQB9Md28buEFhjr1Yk?= =?us-ascii?Q?AtBcFq5jVy66TDh0qJJP+tONaMrPHuplS9zFOXDNTwiEXoKel+vR+Trhk8GQ?= =?us-ascii?Q?Iq9tODvOiav/avdF3BtDAOesDW13pxtf/PRVqcAkwgGAa1ftezsJgBA2zJAt?= =?us-ascii?Q?FGvRGASqaI1D78yaqEQYAHaMYEWRVsYRk8vMZ8dt1xpV6T22KFBTnPpMmZmK?= =?us-ascii?Q?kTFID9F/zN60U2/shMauR7mUMv5LlL1UfbqZD0o+IeNgLQ6+lX0p3KSjPSS8?= =?us-ascii?Q?W3bpxQl52dtpdMviy+kHJRtHSdzAjZqAsQPKbr/geokkeB8xyxcQQxTtNCY2?= =?us-ascii?Q?NsMCBprn/mY0iwaj28yogkfc3PWBr5skxf+O9lPq1gHfuBBlKcUAceeLrIEr?= =?us-ascii?Q?L7XxNiNP6C4KkS4UJTDOgOHtbqg3po4+1Xbs3ILTTWJvaawYxr9bOWpRfYWa?= =?us-ascii?Q?8wERYDII0QcD9MNreSSXkWx/5Mx4MNpLLSmX0kkAogl07QnTIcFSpe4fDkDG?= =?us-ascii?Q?dwubkOrxZj3FrsWPLkWtskATZzXN0x3d1QCkivY1hV0meKcVe5BethYRsRvx?= =?us-ascii?Q?X2rba14QHqV2hBUiae2QwZHhFJhp/aI/uJqBVvNRGasPnKepH1IcgLTgaepE?= =?us-ascii?Q?sslCp754u0EecLrZS6SvJev8ATgdCoxSUWGTr2XEPNENIb0Jd0Vk6LBr5iD2?= =?us-ascii?Q?3+UCX46hcmEHNw0KkHpr8E7wAbO9CBeSKJj+yzxGk2RD0qkP8eNqWMa7XLuP?= =?us-ascii?Q?xZuZNFoVompcgxKunwiV3Kq9GUAgry8Fu4qgpXURuex+m2jfoVRP3KHf6Wkt?= =?us-ascii?Q?3QLI0ukzuHR8CJsdzgUp3lE0t2g+Rhi+kY7aim6htU8jXUygxXx37VM1CAgg?= =?us-ascii?Q?0IMRYFJmN+iH1fDda2U2hgJFwNGKFMf9imjACIW+x94cu3vtOt+P9v/IQkDF?= =?us-ascii?Q?i2/8Kwh47W/ZNFZ47A5mpZ5yxt/Ur/TC+fv32ek38djquljMRLuy/iDCLcWl?= =?us-ascii?Q?1ucGL7a4DzOfHseaxao88Gv8aJp8T26JScOZXVwkfnsx4Dw3VdMmthjhMfdn?= =?us-ascii?Q?u7mk8Tf1gzmqHK7eXoNnWuDN8crXsp5Vq73IkAaJKp40g8PvYlKqgmzpfr29?= =?us-ascii?Q?JXos6wmhre76a+hU+yu7DZHpg0nLoMQ5vtbySCV71+eislAJ0bqYG+Yj0jqf?= =?us-ascii?Q?5DuapyK9hUoe9cyM1SObx9bQZrXkjZy5MU9tzaj72LP4elRcQBAUKkicd96j?= =?us-ascii?Q?n+BcTcMewmAqCr1HtFo2qm4orlFvvQHB9j8RKs8uDedjzZYaQwt+5nnoR3Lt?= =?us-ascii?Q?ZiAW3yJaBkY16o1UyLqMjO3VBEMt3xCIB2qlk13A9v0bPuAgrbXtUSoA2/a7?= =?us-ascii?Q?5SkSde+jT/UdzxB/Vlffnh+qxDG7/jv4ZoPwySMVpd6ItxpBhPyD2crQjTUe?= =?us-ascii?Q?nACLAvlkCOUiJ8H9OddL9akVawrzggfHKSTX/6vzJ7ox5H/pLorjRDHhc93d?= =?us-ascii?Q?VtTPhZzQwcRmj5VLJwNWIFuV8Eg7iqbcLbUm556oYGSzg/qdJewpiVoQCSlz?= =?us-ascii?Q?zyyOIwcfojs8kUE2w5OMqRw00IBOBnksuo6qifrC3R9PtzW87mqzmIhn1Dfs?= =?us-ascii?Q?Lv8OcbGuGWz6+fCGiuMEkhsWzHdk6zAO+zAf+h7kmBcB1JKE0qvc9yypsFC0?= X-MS-Exchange-AntiSpam-MessageData-1: p/zwx97scl72vaxzMnT4/uy/ov4M9x4RjAo= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: d210ec69-856d-47f3-8dcb-08da109c2e31 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 09:20:20.4631 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RVu/o7wsMqIw3TB/Ujb9qBGB/zksE65X4BByJFaqkvr9C1YNmYRKpLGVl5foUp9I8B8xMOyKUauYuZO30AuHbnQWbNSj7SWJ3OEJIv3v9NQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR10MB4558 X-TUID: zEfK3v0HHRYg Am Mon, 28 Mar 2022 11:11:40 +0200 schrieb "Moessbauer, Felix (T CED SES-DE)" : > > > a/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py > > > +++ > > > b/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py > > > @@ -75,10 +75,10 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin): > > > --ondisk sda --label os_boot --active --align 1024 --use-uuid """ > > > - name = 'bootimg-biosplusefi' > > > + name = 'bootimg-biosplusefi-isar' > > > > > > - __PCBIOS_MODULE_NAME = "bootimg-pcbios" > > > - __EFI_MODULE_NAME = "bootimg-efi" > > > + __PCBIOS_MODULE_NAME = "bootimg-pcbios-isar" > > > + __EFI_MODULE_NAME = "bootimg-efi-isar" > > > > > > __imgEFIObj = None > > > __imgBiosObj = None > > > @@ -106,7 +106,7 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin): > > > loader = SourceFileLoader(cls.__PCBIOS_MODULE_NAME, > > > modulePath) mod = types.ModuleType(loader.name) > > > loader.exec_module(mod) > > > - cls.__imgBiosObj = mod.BootimgPcbiosPlugin() > > > + cls.__imgBiosObj = mod.BootimgPcbiosIsarPlugin() > > > > Mhh, for some reason we did rename the class in that fork but not > > in the EFI one. > > That is indeed not consistent. However, I don't know about the side > effects when renaming this. Looks like the class name is not part of > our API as the WIC script just takes the name of the python file > (e.g. --source bootimg-efi-isar). By that, a rename should be safe. > > > > > Maybe something to get sorted out in this series, or later. Not > > sure which option would be best ... i guess the consistent rename > > would be the conservative option, meaning the EFI class would have > > to go > > I vote for not refactoring this as part of the series. > It is technically unrelated (we just call the existing plugins) and > just delays the integration. Good. We should keep that in mind, and i agree that we should not slow down any more. Henning > Felix > > > > > -class BootimgEFIPlugin(SourcePlugin) > > +class BootimgEFIIsarPlugin(SourcePlugin) > > > > Henning > > > > > # Import bootimg-efi (class name "BootimgEFIPlugin") > > > modulePath = > > > os.path.join(os.path.dirname(os.path.realpath(__file__)), >