Re: [PATCH] bootimg-efi-isar: add support for squashfs

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 30 Mar 2022 09:50:01 +0200
schrieb Daniel Machon <dmachon.dev@gmail.com>:

> This patch adds support for squashfs in grub, when using grub loader
> for EFI images. This is needed when the linux- or initrd image is
> located in a squashfs filesystem.

Out of curiosity, did you try systemd boot as well? And in fact did you
confirm it is actually needed with recent isar?

With
https://github.com/ilbers/isar/commit/9d0a7012be2217c77f85d54ba8aac0839bc847fb
we should have all files living in the EFI partition which IMHO is
always FAT32. But maybe you are using "custom_cfg".

> Signed-off-by: Daniel Machon <dama@universal-robots.com>
> ---
>  meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
> b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index
> d971254..78fabb8 100644 ---
> a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++
> b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -355,7
> +355,7 @@ class BootimgEFIPlugin(SourcePlugin): grub_cmd += "terminal
> minicmd test loadenv echo help " grub_cmd += "reboot serial terminfo
> iso9660 loopback tar " grub_cmd += "memdisk ls search_fs_uuid udf
> btrfs xfs lvm "
> -                    grub_cmd += "reiserfs regexp " + grub_modules
> +                    grub_cmd += "reiserfs regexp squash4 " +
> grub_modules exec_cmd(grub_cmd)

While it is usually "not allowed" to touch this file without checking
OE first, this is touching our forked bits and therefore fine.

It would be interesting to see if we could drop that list and say "all"
or "all defaults", but that is another topic.

Henning

>              elif source_params['loader'] == 'systemd-boot':
>                  kernel_dir = os.path.join(rootfs_dir['ROOTFS_DIR'],
> "usr/lib/systemd/boot/efi/")