From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7080797374331748352 X-Received: by 2002:a05:600c:5113:b0:38d:d8f:67e9 with SMTP id o19-20020a05600c511300b0038d0d8f67e9mr3486225wms.107.1648633705626; Wed, 30 Mar 2022 02:48:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:3544:b0:38c:6c15:b2dd with SMTP id i4-20020a05600c354400b0038c6c15b2ddls726696wmq.3.gmail; Wed, 30 Mar 2022 02:48:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzToGRlIhhueATHNe0B7q+BPQrvFxQcRVlATRZgxMn3GZQVpecdsDgUKwL+0kGoivmTFN57 X-Received: by 2002:a05:600c:1c1e:b0:38c:b393:b355 with SMTP id j30-20020a05600c1c1e00b0038cb393b355mr3508018wms.92.1648633704770; Wed, 30 Mar 2022 02:48:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1648633704; cv=pass; d=google.com; s=arc-20160816; b=kEsJ0a0VpZD9rHLueDdrNkoLnvoamOL0h6N+rY4ijmiBR54WbI3PVBS9To0CpDvuQN tOkdhWqjOstY4VMTOW+Ssf+Yaw2lhFjksMFwe0ulo3UXYBzYEcGe23gttYZfZBXpooqt nctjoo4uR/qMbNdgKQdxFxCDyQ8xAkwkBc2j16XQcUDhnovfuGSQ8QGrXV42ccJ5cx2l 0U5V9KRZqBN7quwpA7Jb9oi31/Jf8Tnxt7AqI92EvgZKiqBuJfL/U1ln5kCru3OzvLZr XweaxduLMhxkKleLBjznm3VxCX+8XTWFOxs2uywGKIkyx1Tit91fLtWMuWFQi5HihOU3 99FA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=lH93Sl/2WL5zLuCU2kxPo3B3jZmGQy7sgByP0j8HG1s=; b=Ybab0m/NZSNF3EGKMs6qLlbqNWTSxHiW/PR4AamAerooDdrZq5eMYlQSlqxjS7oMM+ XAvUT+DnMUdxe7LQs0iqTJxxHiLlDRbjc1AJWNGBhMIKmD66uiHtFhXgcGasullUnHqE mdWdt21luM9/ZxnW0seK1Bdm6EfF4PAxsRXmepDY+0kwt4bNTpNXkkpW9UqyM52JZlLa F8kctS/Q1PCVaW5uRMGGXZqI6u64rraHhs1YlJdSwVZQmAiafOPVA03/QUOmO16Pmv8M 9ET6+jS52Eft5YKVYnM7GaB7OdGtZgdBHkRdVAAERnc+mcZ2DDmCLuoAO6nnI9w0d+G3 uIaw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=p2B5VArt; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::622 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20622.outbound.protection.outlook.com. [2a01:111:f400:7e1a::622]) by gmr-mx.google.com with ESMTPS id c6-20020a056000184600b002040a29c341si987989wri.4.2022.03.30.02.48.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2022 02:48:24 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::622 as permitted sender) client-ip=2a01:111:f400:7e1a::622; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=p2B5VArt; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::622 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k92scybJ1xmfMLYkogS50bgvTTv0EiCuU9Rbn1e2ykrOoKmdqvmjHeEU+VIGI0Vj6US+Ii0B2Ien9ZrMU8kA9LIlyOJiFF2fTkksBRaEdgHzkenynejqVFmjcXgT1UKlFOQDK5BSMrzJo9Vqg/nA8vZUOY4uzmMmPUYtNtP25x0Ezby3t/KcN++jH+fv3C+il84H+bO8RKl3+YUPkmUzgMUsRJ1ct/76ChXYiTwa0YbjYWx2gBAFYSeSSgkS8qQHADR3w4drGhbkN6PKQzxbkT2S6kzb0Jc48P+7/9KIVFYrNiXTuwwk6lhhfm6BiVkHY93h9GqqeIzm0hDNPx57Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lH93Sl/2WL5zLuCU2kxPo3B3jZmGQy7sgByP0j8HG1s=; b=D0OrHxSdYPCF8ezZED+fk9W/e/XKINKwMg/5Gxjz19CYmtExRGWHvps/IwNXJUCvFDed1K5XkxeflBJyTJ7IUtXpDuQSH3RVu5deZINAelhNG6SuHk7fIlukRa2YyFEByUL5JE09dgGzG2yQKt7g87RlL6/YIHROCRzQDNfn1nYiCiuvCM7fEI61oZfFHEqGXy3evhVt17PNH17doFj1ODOTE47HAEn9S/LeuG3wQZCZgrbDkAjY31EupmY+SwKlVV9LlpDok5bJ+nYEQDwOI0TTYOw6WrPL+MuoLQ0/4d9OPBrPO7+6z+Sidtdue73NVf5IK0zewjzbfpCuxBfjqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lH93Sl/2WL5zLuCU2kxPo3B3jZmGQy7sgByP0j8HG1s=; b=p2B5VArtjMiXwMMoTm4RRgbQbjNPAgXeUx4V2Vy8pLOK7ot9lQVtyKMct9CVT3NcZbtv8odH4U07IpCuawcpSCsLoRgBsJ1LtwbvtMH1MWXVJXtxxyDg7+KwgOTgrqrc1NIAM/Qybn5BBWkRhPctOR1XiLvjAr6QTS6O0K1yS9lPFGnA+1i4DkLDxdXXPs2iFvL016UYtX45tQTFJ5poR+55JvmM9bomsi/qFOk2LTnvmI57CwiO9LHW5O0hrF1f/9KjfZZcAlQnKwiQrYK+XGAbUPUVmtJOKNhE4tTRfME/BETRS1Dl5DAR4Ml13k+pB/yArhFe+d+zLC5h7fFBnw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by VE1PR10MB3791.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:169::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Wed, 30 Mar 2022 09:48:23 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::31e9:4e5d:6594:a423]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::31e9:4e5d:6594:a423%6]) with mapi id 15.20.5123.020; Wed, 30 Mar 2022 09:48:23 +0000 Date: Wed, 30 Mar 2022 11:48:21 +0200 From: Henning Schild To: Daniel Machon Cc: isar-users@googlegroups.com, Daniel Machon Subject: Re: [PATCH] bootimg-efi-isar: add support for squashfs Message-ID: <20220330114821.07b42600@md1za8fc.ad001.siemens.net> In-Reply-To: <20220330075001.1640596-1-dama@universal-robots.com> References: <20220330075001.1640596-1-dama@universal-robots.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0601CA0044.eurprd06.prod.outlook.com (2603:10a6:203:68::30) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20af87a9-742e-44f4-2a50-08da12326e39 X-MS-TrafficTypeDiagnostic: VE1PR10MB3791:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SSIcHlJuSFLO/OkOJleUVZVT9T24FVO6FNyceEyPn3SqQqc/iVDEsTCWOL61+o8N4fIcSFnUH0w35fAUMPJQ+tGHG7gXMVRBbipjy54c07w3n40sI6MCjWACraayxZ7Df8kTtylaKDYjQDpwoNuH0oFt/nqMrmBowFHO0TZmK0mlTWWRhS+FQHQlkHZ+QpMYrpZN6CTAUOgaPkEtXpA/Zqo99k/EnyLTw3bf4ip/0tVW0+PF06OO8m7OoDY/ne366bVTIwM4oO+/enhroqgxVIH07AP4HzpxH/CQEuSdLrWGrWhIG1VwScXYWjOcsDPubpEo2KyhLK2w30xs3e0Qbij9HMHoCgFSV5/Phi45GmDG5CSBP09Z30IRHV+qp5/o2bxrX8/okutbwy0A5jFsWG5f6+NuDCEi9Zil2WfoiL8fkDmQtLdKRmdHZTcTYrNw+omo6kyIEH/crRM64iFC8JF2AGpOcNSHVh7PjR5q35jJWr/p6355zL4kGyvN4F9L0SB6EmxAKLZ/F408eqOpkQdJ6SpXiiJUx2C7kD91AuxzOoNKKYXMPSlM+k15dhwNuhNyA4cOzteDMwhYRnAisluPcLSjB9HwWGZprsLQwJDBlvkZEfgl55o/4i8EvUerh6Z/N1JmAydIzWqCdJWHpPuOsC2N5GE78gBeVLgj+Ey023u18wbh5N2EHD7iEZyLp9oUlK01vKWwP6QKeoUXy30v4WcB96OQ4merdBbRRPk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(9686003)(6512007)(82960400001)(508600001)(966005)(6486002)(6506007)(66556008)(8676002)(6916009)(186003)(4326008)(86362001)(316002)(66946007)(1076003)(2906002)(66476007)(5660300002)(44832011)(8936002)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vyoUAr2cEWA5kHCCMnQcnHvE+b2KXmBL4h6/SihaVycqduTM/phrl4oP3R8/?= =?us-ascii?Q?aRB5dFAormBcOiLKDaSNgRpk8s9FrU6jXYw5K6yAwpXtRAopbd3LrPXrbuv3?= =?us-ascii?Q?qZWujXEHmVTk9Qu+yU6jkPxCnGS+ML6t8bgtPaer18VoM0qUhG3DoX6Z82Ce?= =?us-ascii?Q?gbZerOuLdYAL6mrhohrZMrXSHZbvXuJ8UrgeU0jaLB5oOMH+NRP+1mtNKK8/?= =?us-ascii?Q?BR9aSjExeuyUHF/yPF5L41OGLJ/kizsmUJXxM0w7HLzD+qM3Eg9Z1kXRifxj?= =?us-ascii?Q?qS9iAPlU1r4IbYO/jNt1+dWUuzXkONe2FZfuV5Ye5ocEeSobs6SJUM63Enf8?= =?us-ascii?Q?HRW0m2SnuSaAW5Xtr9bhEsY72CklGaVa507K4LGP/54hMEu/qh4tDQea3P8a?= =?us-ascii?Q?VxgCBdUtxXIDjUY4tl2ZkI/7Q75U99HqRMOuywql5BaMvc5Sn3EjhG3cnmYU?= =?us-ascii?Q?OmiPkj+NrLJBVMihX4JVnzgNnhMuszy+uLfjyKoeSuuwcU1l8LI6lBeH1kuI?= =?us-ascii?Q?/UgE9TL4ScfrsFbmZePCv81UgOVCVev4ithWgsu5ArPG/Sy6g8IhYfg84cgA?= =?us-ascii?Q?PuKHMgtGm+MnzsQCinP4vTBaN7iWzDZVi+C5iiZlRThSJoW5irtFmHmgFO9o?= =?us-ascii?Q?Ujkq8D/s7KptEqCakZqEy8SeQzbHt1AsMSScs97zUs/JlxfrkQpUx9gQCZEu?= =?us-ascii?Q?y1i3RhVeDk3tdrmth+dluum5ir56L7HxfjpQq/fkKvE1JRSerXSTEdzjJcvd?= =?us-ascii?Q?2c3jqbT/f1aybs6eJLVXhmNgKXKFO40x5Jk0VK58142dUWkMHTwn9wZPG8R9?= =?us-ascii?Q?uBWpMgJFDYoB0wK/rs3WdBnezbWYklNqXfAPYAldI0Is418y+8QYcJROgCt+?= =?us-ascii?Q?9itZozzInTIK0mh4jsrr4Ligs3Q1L0eYrK6tiWhhSZrBYDANhMKQ+aTi2QkP?= =?us-ascii?Q?3loQwHF1JMy4WVtiWGiDS3kgDZgjWYBjRrLSqTRQxoaVLKn7qafEcQbm/ccw?= =?us-ascii?Q?+9akjrHggw8gjdgv8E/ZeNmgPyDbTRwnxgbfhrVJySXbHE9S50W93/CaINlz?= =?us-ascii?Q?UJPGQpc1LKGrhBJsdY/AsttiKq4FlGOA0/oW+oFDbI8pydZWQW5jvyXFt7JU?= =?us-ascii?Q?Rk1Gdwc7u1uAtAwKYR96AcVYwcx+5UtIDf/tpud/+AS58hIOQ+UPRjGQy87G?= =?us-ascii?Q?WwNAXvTrexRVoad8gY1V9eDWzY+Wb555SMJ+37CBvl6mdFB70Y1JlUcAWkJD?= =?us-ascii?Q?3KyLz8RDuBtep36DPIgJxkNXE91ety0g9xWuIrHcRVKJoCoPLfziTZPBI8vg?= =?us-ascii?Q?T/lM7z8bAp0Fd8GMexX6gclkksdQdBPCQEZMSuVLPup49BQDx7js1TU0HDOP?= =?us-ascii?Q?qEy3ds/aFmWuu0zk7xALFaNW9kLFciI7496wFBkRhOybEjSTkGbbPs8XGUPs?= =?us-ascii?Q?EvaGwH/iJM9HHNYPLLzNLvC1ZsXnVTaBome08yxljmuF2HOug2N6+N++HcNw?= =?us-ascii?Q?26VFM/+yvm9r38k70zyTROCRaxUa193ExfbZ3MxjrKgGXzZu8/t6hysF12ul?= =?us-ascii?Q?aVQSYpaNfSokwHKmp3KlLImF4+2IKFbk7F1KIm2mQB5rxalhwhaAFtrn7O1g?= =?us-ascii?Q?/y4rb+gn/96Aqzit6ZuEFxHen9F9eftEwsD2elv0Yw4i19+0lBSfQUfHYV2L?= =?us-ascii?Q?tt+Gjyzct3q5BoaQgZogAQDl4vUkZzc3v9Wx9lDwMyCB5hiUhbnSeUOf6VRF?= =?us-ascii?Q?hpVSBIStETfh2c18A7rq+3VFqGQxUi/rQznf4SsxNBAxQwd+ACciqIOZ10iR?= X-MS-Exchange-AntiSpam-MessageData-1: uX7fo7449p2vNMV+Q31pNG9GRSfR28ao3aE= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20af87a9-742e-44f4-2a50-08da12326e39 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 09:48:23.4813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FFGbcD8VwoPYa+mLj/9R7VbP7YpugYJA3Op2kE7muli8C+BxX3SUGTONqghyi+eruEMY8yYWj+0lOMuvZcdQxBe1aPXKYwBYSW1oJf5rYyU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR10MB3791 X-TUID: upTekM2Gvtbi Am Wed, 30 Mar 2022 09:50:01 +0200 schrieb Daniel Machon : > This patch adds support for squashfs in grub, when using grub loader > for EFI images. This is needed when the linux- or initrd image is > located in a squashfs filesystem. Out of curiosity, did you try systemd boot as well? And in fact did you confirm it is actually needed with recent isar? With https://github.com/ilbers/isar/commit/9d0a7012be2217c77f85d54ba8aac0839bc847fb we should have all files living in the EFI partition which IMHO is always FAT32. But maybe you are using "custom_cfg". > Signed-off-by: Daniel Machon > --- > meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index > d971254..78fabb8 100644 --- > a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -355,7 > +355,7 @@ class BootimgEFIPlugin(SourcePlugin): grub_cmd += "terminal > minicmd test loadenv echo help " grub_cmd += "reboot serial terminfo > iso9660 loopback tar " grub_cmd += "memdisk ls search_fs_uuid udf > btrfs xfs lvm " > - grub_cmd += "reiserfs regexp " + grub_modules > + grub_cmd += "reiserfs regexp squash4 " + > grub_modules exec_cmd(grub_cmd) While it is usually "not allowed" to touch this file without checking OE first, this is touching our forked bits and therefore fine. It would be interesting to see if we could drop that list and say "all" or "all defaults", but that is another topic. Henning > elif source_params['loader'] == 'systemd-boot': > kernel_dir = os.path.join(rootfs_dir['ROOTFS_DIR'], > "usr/lib/systemd/boot/efi/")