From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7080797374331748352 X-Received: by 2002:a05:6512:31cd:b0:44a:9e36:a9d with SMTP id j13-20020a05651231cd00b0044a9e360a9dmr13271977lfe.271.1648797850059; Fri, 01 Apr 2022 00:24:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3f16:b0:449:f5bf:6f6a with SMTP id y22-20020a0565123f1600b00449f5bf6f6als64413lfa.2.gmail; Fri, 01 Apr 2022 00:24:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoR1/OOVl2UZp0F5A/cA5RBDTAHhrTG6TkUUIZlb3HJbDYHB87S2vl/gA2Kb7VQDCFgu7M X-Received: by 2002:a19:5f59:0:b0:44a:2040:522f with SMTP id a25-20020a195f59000000b0044a2040522fmr12467123lfj.590.1648797848900; Fri, 01 Apr 2022 00:24:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648797848; cv=none; d=google.com; s=arc-20160816; b=UnoJnD+tVXNGo2jLVV+Ez4ai1YyY9UirrqcWT17XAJy752CY+vn5HKD9ck8wlSqXjp hEJH+5N47osGWCzC11Tb9TwncQTZhhjKgu5ZJrVb6xFClpuT96MihGgxpPF4YZfZLFEa CTC8QICVh3SWmR0laUho9ASFfq6rjZoLA+YVA6xAe2duHFfgysBpf+s31/Wq4EHgTIyi UnawwuUXCBD0CHzTCV3mkk7Q+riHePjvWd9NNEC0HXEzKOyYB6o77rUbLlTlgDL+6BNS sRFTFZRQ51cJbB8Nc2VvcyHMTuYaNPV25eRQrdb45XNMMeGrwoI2bKBslAZVrjS3fVuJ ErKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=NOHfDCI2Kmj1GqZzWF6gvEzjzDkadUzHu/41/WKWGFM=; b=slR7t8vNluzrLp9ViLjg010IuAE/yQh+wFVzbuhTyKVsHMHQCb/su/mhvtYV/Pzlv6 xmV+ycaOL/IW9Ai+d3A/xwSNAEiRzlXBx4ngULS24in/yu58ZdauaUpelMPK+JRRBS77 5a/JMrldAHZFtd/WfpaAXktR6f10JyWKHCUoJsHzMPzJWjOkP5eynT3UKCg6mjrDwIYx IASs8IBVJbfKe07TTSIJQldz3VcawTenWLif9wJDbk0hivxXel3GiKLZhmrX0THmHx/I chGsvlPBLHlnaNy/VKP3OKF8avu0nXV7qAg7wEzSllJmtRhlbg2Pe95suAO4nNzCq0WC M0og== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XLDJQoVS; spf=pass (google.com: domain of dmachon.dev@gmail.com designates 2a00:1450:4864:20::12f as permitted sender) smtp.mailfrom=dmachon.dev@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com. [2a00:1450:4864:20::12f]) by gmr-mx.google.com with ESMTPS id d24-20020a0565123d1800b0044a28635947si83230lfv.6.2022.04.01.00.24.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 00:24:08 -0700 (PDT) Received-SPF: pass (google.com: domain of dmachon.dev@gmail.com designates 2a00:1450:4864:20::12f as permitted sender) client-ip=2a00:1450:4864:20::12f; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XLDJQoVS; spf=pass (google.com: domain of dmachon.dev@gmail.com designates 2a00:1450:4864:20::12f as permitted sender) smtp.mailfrom=dmachon.dev@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-lf1-x12f.google.com with SMTP id t25so3234491lfg.7 for ; Fri, 01 Apr 2022 00:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NOHfDCI2Kmj1GqZzWF6gvEzjzDkadUzHu/41/WKWGFM=; b=XLDJQoVSzmg8k/UxdvRA9LUkkISohdJAxXmQvMWulTSomFwXZMRmUD2hAXBiDsaEcu vdVicnFlGO4yH3sjsWmO+dGxFb5TbFw284kc2JXII6qqo1WJXMc0LLGhZN83htUzfIsa QXlMMitJrfFQnOCf131/hzGiGuJ///RkPsaX0JjWc15oJG2zlnIdK6B55IclUl2d2GqP G1/E0+NsxqqQMDWK3t3OPL5T7FZtKsrx/6VOJNBfOXHgVmF4fCeSYGfqDlmVGq9UxJkP /hhPCP7XADNaKduGMPRyaVn+e1PH+Ica0hMIB2MY8hq8rTsdGI4Wv5beejP+yZ7FJy1z j29Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NOHfDCI2Kmj1GqZzWF6gvEzjzDkadUzHu/41/WKWGFM=; b=q5cFvplB3Mv6JISXZ+PjaTKU0rA3fRmafTt4QztqNQrcBNuLyxzNjxtvtmzRW3Wi2A pfbzvnkS3skXSjdePHD5knySo0cckwnXGVmwyXHjV61z2QlALh05xu8kViomnzYrphap Lw7oXM7ZYnlTr36AEzJdEXaou9WHfCZ9g7dvQIKKoCwJkT7KaG76ZwwW37L/21eJIcOy SQ6FFqdxJnahJGdL57cM8NAX6fFnfedlwjkIIzPR0hx5khZVAvAPnPrsPqIVoGSBeXtK ZK5QqzyfrBBCe0lBqfT/ES0HZez8Qyewkj0f9KgJhwUTVXj70GYVItqUA48sBXB91H5a z8+A== X-Gm-Message-State: AOAM531lgGDRDAykIX+A50GGm7xSLwKIDy79D1DxK7m6wQ7TSIr32Umz 7t6knOaGUcZakYzTuEFVIQ== X-Received: by 2002:a05:6512:3f92:b0:447:769c:1b2c with SMTP id x18-20020a0565123f9200b00447769c1b2cmr13298673lfa.387.1648797848552; Fri, 01 Apr 2022 00:24:08 -0700 (PDT) Return-Path: Received: from ur-li-s4qm6889.unirobotts.local ([128.77.151.194]) by smtp.gmail.com with ESMTPSA id t12-20020a2e954c000000b0024b00cc7539sm122653ljh.109.2022.04.01.00.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 00:24:07 -0700 (PDT) Date: Fri, 1 Apr 2022 09:24:02 +0200 From: Daniel Machon To: Henning Schild Cc: isar-users@googlegroups.com, Daniel Machon Subject: Re: [PATCH] bootimg-efi-isar: add support for squashfs Message-ID: <20220401072402.GA2792945@ur-li-s4qm6889.unirobotts.local> References: <20220330075001.1640596-1-dama@universal-robots.com> <20220330114821.07b42600@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330114821.07b42600@md1za8fc.ad001.siemens.net> X-TUID: hizm/INququT On Wed, Mar 30, 2022 at 11:48:21AM +0200, Henning Schild wrote: > Am Wed, 30 Mar 2022 09:50:01 +0200 > schrieb Daniel Machon : > > > This patch adds support for squashfs in grub, when using grub loader > > for EFI images. This is needed when the linux- or initrd image is > > located in a squashfs filesystem. > > Out of curiosity, did you try systemd boot as well? And in fact did you > confirm it is actually needed with recent isar? > > With > https://github.com/ilbers/isar/commit/9d0a7012be2217c77f85d54ba8aac0839bc847fb > we should have all files living in the EFI partition which IMHO is > always FAT32. But maybe you are using "custom_cfg". > I think you have a point here. We recently bumped the isar layer, and I might have missed this change. I like the consistency of having the boot files in the EFI partition across all bootloaders. This should indeed make this patch redundant. Thanks for poitning this out! > > Signed-off-by: Daniel Machon > > --- > > meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index > > d971254..78fabb8 100644 --- > > a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ > > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -355,7 > > +355,7 @@ class BootimgEFIPlugin(SourcePlugin): grub_cmd += "terminal > > minicmd test loadenv echo help " grub_cmd += "reboot serial terminfo > > iso9660 loopback tar " grub_cmd += "memdisk ls search_fs_uuid udf > > btrfs xfs lvm " > > - grub_cmd += "reiserfs regexp " + grub_modules > > + grub_cmd += "reiserfs regexp squash4 " + > > grub_modules exec_cmd(grub_cmd) > > While it is usually "not allowed" to touch this file without checking > OE first, this is touching our forked bits and therefore fine. > > It would be interesting to see if we could drop that list and say "all" > or "all defaults", but that is another topic. Agreed. > > Henning > > > elif source_params['loader'] == 'systemd-boot': > > kernel_dir = os.path.join(rootfs_dir['ROOTFS_DIR'], > > "usr/lib/systemd/boot/efi/") >