From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7080797374331748352 X-Received: by 2002:a19:dc02:0:b0:44a:da12:7802 with SMTP id t2-20020a19dc02000000b0044ada127802mr1284151lfg.657.1648798422715; Fri, 01 Apr 2022 00:33:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:880d:0:b0:249:6a0e:ce7 with SMTP id x13-20020a2e880d000000b002496a0e0ce7ls190934ljh.5.gmail; Fri, 01 Apr 2022 00:33:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhPxq8I9Fywy6k2YY+Fp17r5de2kpHxko7JlLal/jHAqHrI21TT+6CjDeU74mejByx8Gav X-Received: by 2002:a2e:9c43:0:b0:24b:469:2bb6 with SMTP id t3-20020a2e9c43000000b0024b04692bb6mr758263ljj.248.1648798421614; Fri, 01 Apr 2022 00:33:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1648798421; cv=pass; d=google.com; s=arc-20160816; b=QUl/6axgTj4kzcQBi/HCSu0ZgGKgk5apfYo6awwtZvy1zD5fGL9ByA7IgafvNBeXav 9DDjOakTC2feIiqwXHfHKRVj5akyU0gl3HQCqukiIfbVED+vE/c20EqlfOZdYMg95SOz 5zUSRivwW/kpyF5SQfFEX8fg6XB8VAx9eYpksp7yk6h7/mN3DIr9oCzvg0Cn9jC49xew cYY8JFD/n8Lyx8NGbp7i0A+fMhDbfmbaAuE7YQrT3aAt1RdTynBlr4S6vtb/UtCp94+t i6JfBV4PnDPQxrCtcKx0TxSvYyPVv2Kdym/RSHyrYcsoxuYwkZOSoOZ8QZEsGpNpBTzf Vb1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=6MooYHIPYDH2nxgFzPPfYu3UqkWparBwCowMEg3qH0U=; b=PQe+cT0v5teXA1CqjySnP4a9JjfbRX8zudNNHfmP2mE2sb6QWxlB4BMSwe29IHDdPk tfYueebWIRn7e2OncmIwpjl2qEiTH5KObupZLyE+ZZ7OtdpQXQ13Y1z2ooaBHknAf+Bp uQeoLKVrmnD6PWbtIkwlnICo5+LPPSUKB78vVq74sHoCmMwWb3fzyBZnGpyGp0ZUQa67 wtttLeeiN2JDWIUPy/K+aHFJjc1l1YbZolPmZGpoPrZeOE9iMMI5qYcuoiXfo6t5r5R4 //pCGgZOd16YVYgBy6VsuxB+h8zcs9gzO+2Dmig5rUyMjaAzcuQZb5jpLTPimUm5BS/9 9EBg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=kSh1CwAy; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7d00::624 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20624.outbound.protection.outlook.com. [2a01:111:f400:7d00::624]) by gmr-mx.google.com with ESMTPS id w22-20020a0565120b1600b0044a9928e3edsi78548lfu.10.2022.04.01.00.33.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Apr 2022 00:33:41 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7d00::624 as permitted sender) client-ip=2a01:111:f400:7d00::624; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=kSh1CwAy; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7d00::624 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HMgQanssFVSIXJTmDLQB4WllUW0DtZYvoL8yHFnb6p//+HEkMrwS1oOgzTozrg70C0GL5tZv934Te6iF0k8W4TT4fwdcoeRs/uR6KXUIjTKxoH+dY8gJVNduJiJ3WuVmblYMBcplzR9YviJCVFAD5WivLKpq1BmInuiE1SdtD/6GIAF+XbvSgEvQA8xHfm4tcPnqPpB4OFPrGZEzgyWac4rjCEkzLTbyTAnSBrXS+k8Edy2NS4GhylL2fiUGUmHvzT5qICo9kBKLCQ6/YJ8M8KDDKg4I6x30UUuMiZyHFdS0MPgdDkKlX9zvdCmgo3uELdvmfxqovh1zzysO7TCpZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6MooYHIPYDH2nxgFzPPfYu3UqkWparBwCowMEg3qH0U=; b=DXSeyDCicTeJq2po4GpwN0APHGvu9I/gyNTkJXN9jzUZJSWA4f61MdLpTbFYmBzlhZwUQq8yFy5pAtgIN754tcVIxkFdZZvEf1BIQ8U+VW7LP3MDYnv/I1smS8T2n7KeyVbfd0tnHC0PFGHS5If8LQ63x5tw47rEtBMnC/n1tfrYWa5Vqt8WIjTVDkkfbFU/AwwX/yUIMUB/fzKzRUZs1G6I7y/NRSNjSiwrNG6ajMmzcWtiqaO+L7RGGafwEvvW8tFZKDQt/iXm85FKj5Nb+uf2d0bvT4aJhJ5BLNxnKf3xXdD5SsK7Aih6V7On1i+A23zEkLbOu6g3y7tEeEWftQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6MooYHIPYDH2nxgFzPPfYu3UqkWparBwCowMEg3qH0U=; b=kSh1CwAyU0Off3S5m6uFxLT7SZK2QO4tsNi2DToYM9wwo2sll3ASl3ZwV9dXUfmrBsGuD3LG9nteEs/JK+P/s8n2E989SXAlY4GnxsFYzuyN8wHFC0SjSr4lST1k3uSHJJGoaBnXb1+lvhPnNRmalYnV1IwQ11/M/HfXHO7Q1C9MIb2kI/LvfwkBOQLuQHPfECGj4R36FjRFG+TQgDfoUR6jI7v3121OmQUA7mDf39AKSaJl/zLB36+uQVNKkD/uamx9eAD/W6xD1mJ0sdjL+yTwDG/G+zl0vDMri0q666GIBqfeyZcX9l+8rQp6fuG4uCu6maNfT+KPV9H2Yeo+QQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by AM8PR10MB4657.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:355::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Fri, 1 Apr 2022 07:33:40 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::31e9:4e5d:6594:a423]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::31e9:4e5d:6594:a423%6]) with mapi id 15.20.5123.021; Fri, 1 Apr 2022 07:33:40 +0000 Date: Fri, 1 Apr 2022 09:33:35 +0200 From: Henning Schild To: Daniel Machon Cc: isar-users@googlegroups.com, Daniel Machon Subject: Re: [PATCH] bootimg-efi-isar: add support for squashfs Message-ID: <20220401093335.34524ed5@md1za8fc.ad001.siemens.net> In-Reply-To: <20220401072402.GA2792945@ur-li-s4qm6889.unirobotts.local> References: <20220330075001.1640596-1-dama@universal-robots.com> <20220330114821.07b42600@md1za8fc.ad001.siemens.net> <20220401072402.GA2792945@ur-li-s4qm6889.unirobotts.local> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR07CA0008.eurprd07.prod.outlook.com (2603:10a6:20b:46c::6) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e45c108-ebef-47a0-ad95-08da13b1f0f7 X-MS-TrafficTypeDiagnostic: AM8PR10MB4657:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /SkJ4Q8GPYIff5cEFb6295BPG2Vd0lgdQhKAhEl4RRoRkQRx5eYTMu57MYIXhr425hJ8S0tTu+i13UYbGYWSBUyKqX16nLEHRbTVB35Dl9O82isgfngJs4fUuiGN3hjjvjwSsarY2GnK5V0gELO3cxyUcSXboyBRWBAUemdIgcdOuLXAmMKoxj3PQXoEK8E9dCfoex4qEc5g50jI1VVfdNcJ1RTjgzAdUZ3PGauT+r4cjcl8k0XxN2E0Vu6DlGePxh0njCAYVbmlennOLMLq72kHg+86YRRZYZ6Rx5SdYrbgTO9Red66jFePw1BjSWV3awmhsdCEXlKbMKrL8gxaEADFOhUwpQ/b/OW1RP6avz5bJu0vXNEqRPFDacXE7t5I1t26wn6oknrkiWIqPEXIYE6fW6dNafpR6H/yTkMYnNezh/JSFM53K+oXR5OlhTkf1kijSXUyGqoscduYDmo0qZw6V9WDsaFgoWUCMncYobkiY0RuElE5mmg1I9VsIO9DkrimNWsMbgoVkGkFed/ka3cJpcN3KSoGMBdC6GM7AiP/ZXl/4oNL18nqxBMJZaQloLybl3iEouBQjspUGp76xYd2HQA0A+UHaYBnNsdybc4N1R2CNuiRsmDW+UNXLmNg3CzVkQ5XDGiwECHtuyLj3sNMBKC24kZ92aior0wE/jXUgIYy3hlF5s9dua7Mit/usbxQlv7myfryJdy6N0qJZEIrTOq+VthdAvjSJCsYR4A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(9686003)(508600001)(6512007)(2906002)(82960400001)(38100700002)(8936002)(86362001)(8676002)(6666004)(66946007)(6486002)(186003)(6916009)(316002)(4326008)(966005)(44832011)(66476007)(6506007)(5660300002)(66556008)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c4x4v+/EzFtACoROyJbNONRuzbkBSuY3Q6wQW9gR1Y4omgl6yIgYNqu6A4PV?= =?us-ascii?Q?Z+F6ehRfDOJm9pwiZ8LLHJw67EsbvZr6VBFg+IVSEYQTdZUBeuhQokrMZSD6?= =?us-ascii?Q?wCmgrP2e/RIwU96p+P9v5Fxvy8XlFPkWskruvv3igx/WuZkQrStEuQSGYEkI?= =?us-ascii?Q?kIoa4RSvuwYUnpSnOyqUtegEYAR1o07xuz6MokgcXaci3ew5sHtJViDVUekJ?= =?us-ascii?Q?iPsyDYWHhqjBvhJs6QhWaF1qCQJ2zlZYjyAAeO3yUeM6DvyxCFq3pgPlygzw?= =?us-ascii?Q?8cYD9fbS5g4H9pHHfPSITAHBmRvtEa2UC1y+RG9RjzarcHMrz6FeKCvf2G5U?= =?us-ascii?Q?rnSjtBIx9Q7sg9mQxCe/C2uXyORWtZgQjnVpoIOzvGUfXQuRlAQ/th+rkWii?= =?us-ascii?Q?5GO43nNKGLfXixyjIJ1eqN4Jnx3TMKAZigZdKhJhrF4agvKDZ+lI83d8Stra?= =?us-ascii?Q?Ukb6+v9G3H00ypgc+ScAVmzXDHOC6CQLJitTIJv+zNUtNbcjTZ5ubtLTVgir?= =?us-ascii?Q?p28HHy7/yOq6XKqVGx21zYHm9XmUWvm12JJkRRkz7nVsW0jBKgC4YmzFz0py?= =?us-ascii?Q?8TYEmgPZcr9zvnfTBgwv1G5OsA2n6qjg1GTYA4RkuHvG6TgoN8fLVVTfkOkh?= =?us-ascii?Q?zq+l/wKrq0LNz6aWAA2UFtEAOrAJXJWz/PBsQCLZZTRHGGffWVmmdBW9lLti?= =?us-ascii?Q?eVhpUbFLPaEeMwJp/aKS/TikENPAH01WaOLC8M2skhUBfjuQb2bC4p7jO9FS?= =?us-ascii?Q?reWbEqIM6K2DFA/6oQVzFk0xwNdfmu8JWtDDAtV/M5AkJWyc+alNowAd/mk7?= =?us-ascii?Q?nGeKfrV3dTqV12iE0CkHz7NdEibU0CNAKw6d4YZTx4LppLbGJHxdEr3FSvF7?= =?us-ascii?Q?Zs4RiStwSapEmKI48/fHTRdPYoAH2qPngUJU/q7p9ekaWQ0CKw98bYCQx64q?= =?us-ascii?Q?tR28nRggP2L65gfiZBcm004dxlxSP6sngzIXQpQL8HYGhL9ZTBlDoyb5tYWl?= =?us-ascii?Q?yPP7wdJE3YTU7zCZb3rib3hTpRF0QXQk0+02z/UfnqRc8LfXPD7tHAKLhteZ?= =?us-ascii?Q?NQ95WzjGHC/svpJoCQ4tM8P85+AK7VrM7EiUfwjD1swNkrSuftDrQS0hf/pg?= =?us-ascii?Q?ERjfzTWWDyXieHHpPkDbUYp15LNGnFF9SyUXewTWLfCp2f3fCbncI2MTvT84?= =?us-ascii?Q?tv080EzShqURRKcFDenAYqew+ZWSZUb/ajFgxgRLAP6iy15x+hrkACL/aPPA?= =?us-ascii?Q?CzI6XRWirtu2N9a1E5weBviTuoLppb6D2Kvw8qRGZUNJiSEVAYBSUrDRDMES?= =?us-ascii?Q?OiKQ//cmaKnREWYorrSF85cjRpfoCfMyWBwT0TCFgVUPiNtK1/1dUr3mbHsj?= =?us-ascii?Q?NKIEDfvDpUuFNnZPUawPtXAo2OgiilFIt7uHDNlMMdJ/cqJTF2tHyMmjIa7m?= =?us-ascii?Q?oHgA4q/l4iVbWWdugoQ5bOJkWrrtY99H33y1oUI/TymC0Bpap6NjwDirblgB?= =?us-ascii?Q?1GjRuWdL14FD6XxyGCtOKoCDXZb08ue1c107bwYJuf1blGQDolfcbooxlpOP?= =?us-ascii?Q?dSt5M2aObNtFnVO2Zy0m2BcdSx63altpQTs97L0Xc92Q5oRuhjxw0XtQP1HX?= =?us-ascii?Q?jTc2taErUelFenCG7BfHqtCz8NT+xKWnJEbreTnpJFpo5rV0c6nKF4tpuQlE?= =?us-ascii?Q?pZdIE3X3ClBnyHmcrLhAkN6dX3QLXnC7nXSrbDE5ypTk4SmUagmQcPGT3Hbc?= =?us-ascii?Q?6A8jjP6unaYH+08dnZy2CynK9Dtt4KTn9fQzaS0d9kIuiiS1hbDq092paCVm?= X-MS-Exchange-AntiSpam-MessageData-1: TXjRPvXmeQvYs4iry8n0B3P/29kodqTHy6Y= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e45c108-ebef-47a0-ad95-08da13b1f0f7 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 07:33:40.0967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: edkbj+NKYBMngdq8jgXCmUypjGFKOQPDWhB/jhGeP2l7QDcw468/RqBrjPPcA0Vu1KGUXlMTl+S1aBPp8+dZreHzkp3D3Kc8IjC67Q4k0vA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB4657 X-TUID: hdeiSCeFhn62 Am Fri, 1 Apr 2022 09:24:02 +0200 schrieb Daniel Machon : > On Wed, Mar 30, 2022 at 11:48:21AM +0200, Henning Schild wrote: > > Am Wed, 30 Mar 2022 09:50:01 +0200 > > schrieb Daniel Machon : > > > > > This patch adds support for squashfs in grub, when using grub > > > loader for EFI images. This is needed when the linux- or initrd > > > image is located in a squashfs filesystem. > > > > Out of curiosity, did you try systemd boot as well? And in fact did > > you confirm it is actually needed with recent isar? > > > > With > > https://github.com/ilbers/isar/commit/9d0a7012be2217c77f85d54ba8aac0839bc847fb > > we should have all files living in the EFI partition which IMHO is > > always FAT32. But maybe you are using "custom_cfg". > > > > I think you have a point here. We recently bumped the isar layer, and > I might have missed this change. I like the consistency of having the > boot files in the EFI partition across all bootloaders. Thanks, i like that too. It comes at the price of not being able to install kernel updates with apt-get any longer, which before worked in some cases but was not consistent. Fixing that at some point is on the agenda, but not very high to be honest. We usually OTA update the whole firmware with i.e. swupdate, so single package updates (including kernel) are not a use-case. Just saying in case you rely on kernel updates with apt-get. All that would be needed is a bunch of scripts to maintain bootloader entries. Should you end up wanting to write those. please get in touch so we can sync on it. regards, Henning > This should indeed make this patch redundant. Thanks for poitning > this out! > > > Signed-off-by: Daniel Machon > > > --- > > > meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git > > > a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index > > > d971254..78fabb8 100644 --- > > > a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ > > > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ > > > -355,7 +355,7 @@ class BootimgEFIPlugin(SourcePlugin): grub_cmd > > > += "terminal minicmd test loadenv echo help " grub_cmd += "reboot > > > serial terminfo iso9660 loopback tar " grub_cmd += "memdisk ls > > > search_fs_uuid udf btrfs xfs lvm " > > > - grub_cmd += "reiserfs regexp " + grub_modules > > > + grub_cmd += "reiserfs regexp squash4 " + > > > grub_modules exec_cmd(grub_cmd) > > > > While it is usually "not allowed" to touch this file without > > checking OE first, this is touching our forked bits and therefore > > fine. > > > > It would be interesting to see if we could drop that list and say > > "all" or "all defaults", but that is another topic. > > Agreed. > > > > > Henning > > > > > elif source_params['loader'] == 'systemd-boot': > > > kernel_dir = > > > os.path.join(rootfs_dir['ROOTFS_DIR'], > > > "usr/lib/systemd/boot/efi/") > >