From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: [PATCH 1/3] ci: cleanup tmp after repro test failed
Date: Fri, 8 Apr 2022 07:31:08 +0200 [thread overview]
Message-ID: <20220408053110.10416-2-ubely@ilbers.de> (raw)
In-Reply-To: <20220408053110.10416-1-ubely@ilbers.de>
If repro test fails for some reason, "tmp" directory is left dirty
and may impact on the following tests that build the same targets.
This can cause errors like "Release signed by unknown key" because
custom distro keyring was left from the previous signed repro test.
Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
testsuite/cibase.py | 3 ---
testsuite/citest.py | 10 ++++++++--
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/testsuite/cibase.py b/testsuite/cibase.py
index 0281be41..4a942ae0 100755
--- a/testsuite/cibase.py
+++ b/testsuite/cibase.py
@@ -45,9 +45,6 @@ class CIBaseTest(CIBuilder):
# Try to build with changed configuration with no cleanup
self.bitbake(targets, **kwargs)
- # Cleanup
- self.delete_from_build_dir('tmp')
-
def perform_ccache_test(self, targets):
build_dir, bb_args = self.prep('Isar ccache build', targets, 0, 0)
diff --git a/testsuite/citest.py b/testsuite/citest.py
index 8f47338c..5d4cd0aa 100755
--- a/testsuite/citest.py
+++ b/testsuite/citest.py
@@ -31,7 +31,10 @@ class ReproTest(CIBaseTest):
]
self.init()
- self.perform_repro_test(targets, signed=True)
+ try:
+ self.perform_repro_test(targets, signed=True)
+ finally:
+ self.delete_from_build_dir('tmp')
def test_repro_unsigned(self):
targets = [
@@ -40,7 +43,10 @@ class ReproTest(CIBaseTest):
]
self.init()
- self.perform_repro_test(targets)
+ try:
+ self.perform_repro_test(targets)
+ finally:
+ self.delete_from_build_dir('tmp')
class CcacheTest(CIBaseTest):
--
2.20.1
next prev parent reply other threads:[~2022-04-08 5:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 5:31 [PATCH 0/3] Fix failed repro test impact on other tests Uladzimir Bely
2022-04-08 5:31 ` Uladzimir Bely [this message]
2022-04-08 5:31 ` [PATCH 2/3] ci: rename tmp in repro tests to access logs Uladzimir Bely
2022-04-08 5:31 ` [PATCH 3/3] deb-dl-dir: grep exact version when caching source package Uladzimir Bely
2022-05-04 7:49 ` [PATCH 0/3] Fix failed repro test impact on other tests Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408053110.10416-2-ubely@ilbers.de \
--to=ubely@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox