Re: [PATCH 0/1] Update bitbake to version 1.50.4

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 19 Apr 2022 16:02:01 +0200
schrieb "Bezdeka, Florian (T CED SES-DE)" <florian.bezdeka@siemens.com>:

> On Tue, 2022-04-19 at 14:51 +0200, Henning Schild wrote:
> > Am Tue, 19 Apr 2022 14:41:14 +0200
> > schrieb "Bezdeka, Florian (T CED SES-DE)"
> > <florian.bezdeka@siemens.com>: 
> > > Hi all,
> > > 
> > > On Fri, 2022-03-25 at 09:31 +0300, Anton Mikanovich wrote:  
> > > > 01.02.2022 14:42, Uladzimir Bely wrote:    
> > > > > Bitbake in Isar didn't get updates for almost 1.5 years. At
> > > > > the same time the version we use have at least one annoying
> > > > > bug, when messages in log files got duplicated if "--verbose"
> > > > > option is used and error happens.
> > > > > 
> > > > > This was fixed in upstream revision 69c622b744d9, few commits
> > > > > before the tag 1.50.4.
> > > > > 
> > > > > Also, there is 1.52 branch exists (latest tag 1.52.1), but it
> > > > > seems to be incompatible with Isar.    
> > > > 
> > > > Update to bitbake 1.50.4 applied to next, thanks.
> > > >     
> > > 
> > > this seems to trigger a build failure when trying to use debian
> > > bookworm as distro, there is no debian-bookworm-backports.list
> > > file.  
> > 
> > I think you might be dealing with an issue in your layers. A layer
> > you might be basing on recently introduced backports for bullseye
> > and does not yet test for bookworm. Isar itself does not do
> > anything about backports and does not carry such list files.  
> 
> Thanks for the idea. 
> 
> I was able to find it. 

Good to hear that.

> But: Should we really fail this way if one of
> the distro apt-sources files can not be found?

We usually develop and test for the good case, so likely or common
mistakes might not get the verbose error messages or warnings they
might deserve.

Feel free to suggest a patch improving the situation. I agree that it
would be better if something told one that a DISTRO_APT_SOURCES or
DISTRO_APT_PREFERENCES file was not found, before one runs into weird
follow-up problems because we lack checks.

regards,
Henning

> > 
> > regards,
> > Henning
> >   
> > > ERROR: ExpansionError during parsing
> > > /work/isar/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb################################################
> > >  
> > > > ETA: 0:00:00 Traceback (most recent call last): File  
> > > "/work/isar/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc",
> > > line 181, in
> > > get_distro_needs_https_support(d=<bb.data_smart.DataSmart object
> > > at  
> > > 0x7fc5bf873908>): def get_distro_needs_https_support(d):
> > > > if get_distro_have_https_source(d):    
> > > return "https-support"
> > > File
> > > "/work/isar/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc",
> > > line 172, in
> > > get_distro_have_https_source(d=<bb.data_smart.DataSmart object at
> > > 0x7fc5bf873908>): def get_distro_have_https_source(d):  
> > > > return any(source[2].startswith("https://") for source in
> > > > generate_distro_sources(d))    
> > > 
> > > File
> > > "/work/isar/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc",
> > > line 172, in <genexpr>(.0=<generator object
> > > generate_distro_sources at 0x7fc5bed36318>): def
> > > get_distro_have_https_source(d):  
> > > > return any(source[2].startswith("https://") for source in
> > > > generate_distro_sources(d))    
> > > 
> > > File
> > > "/work/isar/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc",
> > > line 157, in generate_distro_sources(d=<bb.data_smart.DataSmart
> > > object at 0x7fc5bf873908>): for entry in apt_sources_list:  
> > > > entry_real = bb.parse.resolve_file(entry, d)    
> > > with open(entry_real, "r") as in_fd:
> > > File "/work/isar/bitbake/lib/bb/parse/__init__.py", line 125, in
> > > resolve_file(fn='conf/distro/debian-bookworm-backports.list',
> > > d=<bb.data_smart.DataSmart object at 0x7fc5bf873908>): if not
> > > newfn:  
> > > > raise IOError(errno.ENOENT, "file %s not found in %s" % (fn,
> > > > bbpath))    
> > > fn = newfn
> > > bb.data_smart.ExpansionError: Failure expanding variable
> > > OVERRIDES, expression was
> > > amd64::qemuamd64:debian-bookworm:forcevariable:${@get_distro_needs_https_support(d)}
> > > which triggered exception FileNotFoundError: [Errno 2] file
> > > conf/distro/debian-bookworm-backports.list 
> > > 
> > > 
> > > My understanding for now is, that bb.parse.resolve_file() might
> > > throw an IOError when the file can not be found. That might be
> > > new, but I failed to get something from the bb changelog.
> > > 
> > > Seems we have to revisit all usages of bb.parse.resolve_file().
> > > All of them are actually in the same file...
> > > 
> > > Any thoughts?
> > > 
> > > Regards,
> > > Florian  
> >   
>