From: Henning Schild <henning.schild@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH 0/3] Make CI targets be configured
Date: Wed, 27 Apr 2022 17:59:42 +0200 [thread overview]
Message-ID: <20220427175942.73ea0c28@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20220427123205.30111-1-amikan@ilbers.de>
The test suite already has too many knobs, now including env variables
would be the number one cause of "works for me" ... does not work in
CI-A and even different in CI-B.
I think if i pushed this series to our CI it would simply fail, because
i would not have any of the variables set there ... and no clue how you
did set them on your jenkins.
Tests that are known to not work should probably be skipped in general,
not kfailed because that would just waste time.
If we ever see certain tests not working in certain setups we can see
how we make skipping configurable, but it is imho a very bad idea to
introduce that without a need.
So i would say let us get rid of some of the KFAILs and turn the still
valid ones into SKIPs ... and see about the rest laster.
Henning
Am Wed, 27 Apr 2022 15:32:02 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:
> This patchset removes hardcoded KFAIL protection from targets and
> makes any target be KFAILed or SKIPed based on execution environment.
> ISAR_CI_KFAIL and ISAR_CI_SKIP variables are used to store those
> lists.
>
> Anton Mikanovich (3):
> ci: Implement dynamic KFAIL checking
> ci: Implement dynamic tests skipping
> ci: Correct container test case name
>
> testsuite/cibuilder.py | 56
> ++++++++++++++++++++++++++++-------------- testsuite/citest.py |
> 32 ++++++------------------ 2 files changed, 45 insertions(+), 43
> deletions(-)
>
next prev parent reply other threads:[~2022-04-27 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 12:32 Anton Mikanovich
2022-04-27 12:32 ` [PATCH 1/3] ci: Implement dynamic KFAIL checking Anton Mikanovich
2022-04-27 12:32 ` [PATCH 2/3] ci: Implement dynamic tests skipping Anton Mikanovich
2022-04-27 12:32 ` [PATCH 3/3] ci: Correct container test case name Anton Mikanovich
2022-04-27 15:59 ` Henning Schild [this message]
2022-04-27 17:50 ` [PATCH 0/3] Make CI targets be configured Anton Mikanovich
2022-04-28 7:48 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427175942.73ea0c28@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox