From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: adriaan.schmidt@siemens.com, Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH 1/2] start_vm: update image types checking
Date: Wed, 27 Apr 2022 21:57:25 +0300 [thread overview]
Message-ID: <20220427185726.14022-2-amikan@ilbers.de> (raw)
In-Reply-To: <20220427185726.14022-1-amikan@ilbers.de>
Image types checking in start_vm should be aligned with code updates.
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
scripts/start_vm | 8 ++++----
testsuite/start_vm.py | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/scripts/start_vm b/scripts/start_vm
index c114d86..8876e53 100755
--- a/scripts/start_vm
+++ b/scripts/start_vm
@@ -113,8 +113,8 @@ eval $(bitbake -e mc:qemu$ARCH-$DISTRO:isar-image-base | grep "\(^IMAGE_FSTYPES=
# Take first image type for VM if there are several defined
IMAGE_FSTYPES=$(echo "$IMAGE_FSTYPES" | awk '{print $1}')
case "$IMAGE_FSTYPES" in
- ext4-img)
- readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.ext4.img
+ ext4)
+ readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.ext4
eval $(bitbake -e mc:qemu$ARCH-$DISTRO:isar-image-base | grep "^KERNEL_IMAGE=")
eval $(bitbake -e mc:qemu$ARCH-$DISTRO:isar-image-base | grep "^INITRD_IMAGE=")
@@ -130,8 +130,8 @@ case "$IMAGE_FSTYPES" in
-initrd $QINITRD"
KARGS="console=$MACHINE_SERIAL root=/dev/$QEMU_ROOTFS_DEV rw $QEMU_KARGS"
;;
- wic-img)
- readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.wic.img
+ wic)
+ readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.wic
EXTRA_ARGS="$EXTRA_ARGS -snapshot"
;;
*)
diff --git a/testsuite/start_vm.py b/testsuite/start_vm.py
index 708520f..f761a8b 100755
--- a/testsuite/start_vm.py
+++ b/testsuite/start_vm.py
@@ -31,8 +31,8 @@ def format_qemu_cmdline(arch, build, distro, out, pid, enforce_pcbios=False):
image_type = get_bitbake_var(bb_output, 'IMAGE_FSTYPES').split()[0]
deploy_dir_image = get_bitbake_var(bb_output, 'DEPLOY_DIR_IMAGE')
base = 'ubuntu' if distro in ['focal', 'bionic'] else 'debian'
- if image_type == 'ext4-img':
- rootfs_image = 'isar-image-base-' + base + '-' + distro + '-qemu' + arch + '.ext4.img'
+ if image_type == 'ext4':
+ rootfs_image = 'isar-image-base-' + base + '-' + distro + '-qemu' + arch + '.ext4'
kernel_image = deploy_dir_image + '/' + get_bitbake_var(bb_output, 'KERNEL_IMAGE')
initrd_image = get_bitbake_var(bb_output, 'INITRD_IMAGE')
@@ -47,8 +47,8 @@ def format_qemu_cmdline(arch, build, distro, out, pid, enforce_pcbios=False):
extra_args = ['-kernel', kernel_image, '-initrd', initrd_image]
extra_args.extend(kargs)
- elif image_type == 'wic-img':
- rootfs_image = 'isar-image-base-' + base + '-' + distro + '-qemu' + arch + '.wic.img'
+ elif image_type == 'wic':
+ rootfs_image = 'isar-image-base-' + base + '-' + distro + '-qemu' + arch + '.wic'
extra_args = ['-snapshot']
else:
raise ValueError('Invalid image type: ' + str(image_type))
--
2.17.1
next prev parent reply other threads:[~2022-04-27 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 18:57 [PATCH 0/2] Additions to imagetypes patchset Anton Mikanovich
2022-04-27 18:57 ` Anton Mikanovich [this message]
2022-04-27 18:57 ` [PATCH 2/2] meta: fix wic image generation for qemuamd64-bullseye Anton Mikanovich
2022-04-28 6:04 ` [PATCH 0/2] Additions to imagetypes patchset Schmidt, Adriaan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427185726.14022-2-amikan@ilbers.de \
--to=amikan@ilbers.de \
--cc=adriaan.schmidt@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox