public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Adriaan Schmidt <adriaan.schmidt@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH v4 8/8] start_vm: update image types checking
Date: Thu, 28 Apr 2022 08:06:15 +0200	[thread overview]
Message-ID: <20220428060615.986332-9-adriaan.schmidt@siemens.com> (raw)
In-Reply-To: <20220428060615.986332-1-adriaan.schmidt@siemens.com>

From: Anton Mikanovich <amikan@ilbers.de>

Image types checking in start_vm should be aligned with code updates.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 scripts/start_vm      | 8 ++++----
 testsuite/start_vm.py | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/scripts/start_vm b/scripts/start_vm
index c114d864..8876e538 100755
--- a/scripts/start_vm
+++ b/scripts/start_vm
@@ -113,8 +113,8 @@ eval $(bitbake -e mc:qemu$ARCH-$DISTRO:isar-image-base | grep "\(^IMAGE_FSTYPES=
 # Take first image type for VM if there are several defined
 IMAGE_FSTYPES=$(echo "$IMAGE_FSTYPES" | awk '{print $1}')
 case "$IMAGE_FSTYPES" in
-    ext4-img)
-    readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.ext4.img
+    ext4)
+    readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.ext4
 
     eval $(bitbake -e mc:qemu$ARCH-$DISTRO:isar-image-base | grep "^KERNEL_IMAGE=")
     eval $(bitbake -e mc:qemu$ARCH-$DISTRO:isar-image-base | grep "^INITRD_IMAGE=")
@@ -130,8 +130,8 @@ case "$IMAGE_FSTYPES" in
 	-initrd $QINITRD"
     KARGS="console=$MACHINE_SERIAL root=/dev/$QEMU_ROOTFS_DEV rw $QEMU_KARGS"
     ;;
-    wic-img)
-    readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.wic.img
+    wic)
+    readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.wic
     EXTRA_ARGS="$EXTRA_ARGS -snapshot"
     ;;
     *)
diff --git a/testsuite/start_vm.py b/testsuite/start_vm.py
index 708520f7..f761a8bd 100755
--- a/testsuite/start_vm.py
+++ b/testsuite/start_vm.py
@@ -31,8 +31,8 @@ def format_qemu_cmdline(arch, build, distro, out, pid, enforce_pcbios=False):
     image_type = get_bitbake_var(bb_output, 'IMAGE_FSTYPES').split()[0]
     deploy_dir_image = get_bitbake_var(bb_output, 'DEPLOY_DIR_IMAGE')
     base = 'ubuntu' if distro in ['focal', 'bionic'] else 'debian'
-    if image_type == 'ext4-img':
-        rootfs_image = 'isar-image-base-' + base + '-' + distro + '-qemu' + arch + '.ext4.img'
+    if image_type == 'ext4':
+        rootfs_image = 'isar-image-base-' + base + '-' + distro + '-qemu' + arch + '.ext4'
         kernel_image = deploy_dir_image + '/' + get_bitbake_var(bb_output, 'KERNEL_IMAGE')
         initrd_image = get_bitbake_var(bb_output, 'INITRD_IMAGE')
 
@@ -47,8 +47,8 @@ def format_qemu_cmdline(arch, build, distro, out, pid, enforce_pcbios=False):
 
         extra_args = ['-kernel', kernel_image, '-initrd', initrd_image]
         extra_args.extend(kargs)
-    elif image_type == 'wic-img':
-        rootfs_image = 'isar-image-base-' + base + '-' + distro + '-qemu' + arch + '.wic.img'
+    elif image_type == 'wic':
+        rootfs_image = 'isar-image-base-' + base + '-' + distro + '-qemu' + arch + '.wic'
         extra_args = ['-snapshot']
     else:
         raise ValueError('Invalid image type: ' + str(image_type))
-- 
2.30.2


  parent reply	other threads:[~2022-04-28  6:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  6:06 [PATCH v4 0/8] imagetypes Adriaan Schmidt
2022-04-28  6:06 ` [PATCH v4 1/8] image: remove IMAGE_SUFFIX Adriaan Schmidt
2022-04-28  6:06 ` [PATCH v4 2/8] image: refactor SDK Adriaan Schmidt
2022-04-28  6:06 ` [PATCH v4 3/8] meta: introduce IMAGE_CMD_* Adriaan Schmidt
2022-04-28  6:06 ` [PATCH v4 4/8] imagetypes: restructure files Adriaan Schmidt
2022-04-28  6:06 ` [PATCH v4 5/8] imagetypes: switch meta-isar to the new scheme Adriaan Schmidt
2022-04-28  6:06 ` [PATCH v4 6/8] meta-isar: remove IMAGE_FSTYPES from multiconfig definitions Adriaan Schmidt
2022-04-28  6:06 ` [PATCH v4 7/8] docs: add new imagetypes to user manual Adriaan Schmidt
2022-04-28  6:06 ` Adriaan Schmidt [this message]
2022-05-04  7:51 ` [PATCH v4 0/8] imagetypes Anton Mikanovich
2022-05-04  8:09   ` Bezdeka, Florian
2022-05-04 11:32     ` Jan Kiszka
2022-05-04 12:19       ` Schmidt, Adriaan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428060615.986332-9-adriaan.schmidt@siemens.com \
    --to=adriaan.schmidt@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox