From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7091667705539854336 X-Received: by 2002:a2e:91d8:0:b0:24f:1656:eaa0 with SMTP id u24-20020a2e91d8000000b0024f1656eaa0mr11558899ljg.444.1651157556930; Thu, 28 Apr 2022 07:52:36 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:17a4:b0:24d:5627:cbb7 with SMTP id bn36-20020a05651c17a400b0024d5627cbb7ls46910ljb.0.gmail; Thu, 28 Apr 2022 07:52:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxq4zxgLVpjnctJhLGGN/SMBhKbxLApUqp1UJkt7o9yUHlVHOGUJi1S6Z6YHrOkpQMKB/0K X-Received: by 2002:a2e:904b:0:b0:24f:5af:4f86 with SMTP id n11-20020a2e904b000000b0024f05af4f86mr18195825ljg.511.1651157555764; Thu, 28 Apr 2022 07:52:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651157555; cv=none; d=google.com; s=arc-20160816; b=WMsJo2zV6f70Z4QhAMAsSZ79VgeqkHwJYCkoW6zGNY/vN12+BxY2JPU8D3NFGAPG4P dEAkZpYmJ4F37GS/ikL3OTe8xBI1A4F0XlPccUKI/CCPVBaSkrG1jMu77+3HqMHYfDuU hHZ2L2wpo/mRugOnPbx/Ua9d8xGjOVXJ3J1AaAPxs0VYne+nyKKygcnqayO1gHdlWlTW bFoTsa5qKLZX608OtBfFpurTYJbc7paZA8zkaSMf/PGaaOpSzyoEXo33mzwkF+Gkt0V6 y6Kbgh0wJ0VU7zMhqQ1TR69R2pxKUM4+q9D/iZU4vQhv7NQ4SVBDb6xd4t6h3z7uPkEX 13kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=yqWKGq3jmvUzW6FlhlHZmyGImkI7RAi3FnofAX+qs2c=; b=xOscm92cYtqghcxs8+iocHcBGwDioFwyrFUIAsDKy7sme+TqRk2qrlHy0E08EjsdOF o2wJQPQTWgFIZ0RC6BxClrwJXLC+miml0U4Bt3ppP982Dh/QSSWCfv6x+Nd+j4EpZFPi khLMi7H0PVk/EE2r97YXAuAkodVZuCGkNnGOooiMB45EcyYKEmiotTtHMbsUXi3ik6uV +w44jVooDRcKCOlKgb0G7Rrr1BkdWZuymjCO2UqE4ROiics1TjTP3J3fnT8Vg2QOjxne HZIWIGp6ZsBl/1bvctje1tnSpWU/U68DhJUExeHlx2a3xDDPaBsa6NeE+MvWMNkwjzqZ Mw3A== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=eZOM61Ue; spf=pass (google.com: domain of fm-72506-2022042814523450b3827ba32bb2d806-dpc5be@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-72506-2022042814523450b3827ba32bb2d806-DpC5Be@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net. [185.136.64.226]) by gmr-mx.google.com with ESMTPS id x24-20020a056512131800b0047216d2d1a9si253323lfu.2.2022.04.28.07.52.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Apr 2022 07:52:35 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-2022042814523450b3827ba32bb2d806-dpc5be@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) client-ip=185.136.64.226; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=eZOM61Ue; spf=pass (google.com: domain of fm-72506-2022042814523450b3827ba32bb2d806-dpc5be@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-72506-2022042814523450b3827ba32bb2d806-DpC5Be@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 2022042814523450b3827ba32bb2d806 for ; Thu, 28 Apr 2022 16:52:34 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=yqWKGq3jmvUzW6FlhlHZmyGImkI7RAi3FnofAX+qs2c=; b=eZOM61UepuWrY40SBD2dgnsek+U8a0uYJvbHn80dia9lCxxwxvJtwmS0JiG8wpVrSfJCRl iMgu0H731jCuAI2akph7LyQSqy/qttXG8A+G0W8Cfb2TL0ILZDUXGW/WZL1BNvkMPQYaUQni 2JFm244pwd1OmNkEvYFV/6XLOCRSA=; From: Felix Moessbauer To: isar-users@googlegroups.com Cc: jan.kiszka@siemens.com, adriaan.schmidt@siemens.com, ubely@ilbers.de, Felix Moessbauer Subject: [PATCH(sbuild) 0/1] avoid absolute SCHROOT_* paths to improve caching Date: Thu, 28 Apr 2022 16:52:21 +0200 Message-Id: <20220428145222.1872273-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: Ff9YRYkMw1Pv This patch is an addition to the ubely/sbuild series. It fixes a cachability problem introduced in the sbuild.bblcass. In general, we should be VERY careful when working with paths in BB variables and make sure these are never expanded when assigning to another variable. This is especially important for variables that influence the signature of many tasks, as otherwise sstate caching in a gitlab CI will no longer be possible. For gitlab-ci, the build folder has to be relocatable, as it gets mounted from the host into the build container. Note: This was found with the recently added isar-sstate script: Sample output (before / after fix): **** comparing to eafc8f6a **** basehash changed from 5398d6d1 to cbbae538 List of dependencies for variable SCHROOT_DIR changed from 'set()' to '{'DISTRO_ARCH', 'DISTRO'}' Variable SCHROOT_DIR value changed from '/builds/gitlabrunner/4/build/tmp/deploy/schroot-target/debian-bullseye-amd64' to '${DEPLOY_DIR}/schroot-target/${DISTRO}-${DISTRO_ARCH}' Unfortunately, manually finding these flaws is not easy. The best strategy is to grep through the signature data in the stamps folder and search for absolute paths. But the data is not pure ASCII, so this is just a heuristic. Maybe the isar-sstate script could be extended to automatically find such cases. Best regards, Felix Felix Moessbauer (1): avoid absolute SCHROOT_* paths to improve caching meta/classes/sbuild.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.30.2