From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7093814202197868544 X-Received: by 2002:a17:907:d01:b0:6f4:d873:d7a0 with SMTP id gn1-20020a1709070d0100b006f4d873d7a0mr379995ejc.717.1651667894415; Wed, 04 May 2022 05:38:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:907:7f1a:b0:6f4:7118:d7c7 with SMTP id qf26-20020a1709077f1a00b006f47118d7c7ls952290ejc.1.gmail; Wed, 04 May 2022 05:38:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU9sQTZQiQuTfBqhqD1EFxendjwNN2RjOdjfm97aFxyNB00JFJYepNP7SbzZpCR/hhe+O4 X-Received: by 2002:a17:907:7e93:b0:6f4:3278:9413 with SMTP id qb19-20020a1709077e9300b006f432789413mr16194948ejc.375.1651667893414; Wed, 04 May 2022 05:38:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651667893; cv=none; d=google.com; s=arc-20160816; b=A4upWq6WEBlo3uV76CZyuwg2bpB/VKzakI4sNKhIpL1gz4vagxrFRxbpKkzsyLcran ZNrTgZwyC3fs9dePP2OeHk3DLemAva59NCE+2FnmT5CbNVk9xLq/Hln7VMQ33J4XyxCf /zAuxV40HkLcUSC6Hwb4y1OsrZfqCq70q/fp3BI+WPUcNsyXVQ0E7etOYJrVpPKRMb7x nSj7/fMeIu0I7sdxtJ3R88VK9Bf32ZBDbEJteyD66/I5ti71Xuqj0u50wyEsbdemLoAl TbVw4vLHonDLvgeaKF4VIv57U0JM+wXFGHBGnbcqDmECPQUkbJLlV0zKMyKy3Qaox/Cp YU5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=eHbzgSVa65WaNqqZWc/NGS63fwBoJanh2KxQsAsbNb0=; b=RoNUCqY9EhVG3aMtN3niloAZMq5z/x6DVwCx+imA8yR9JWsPtpomuAKz2P8jZr5OrR 8FjfVOUMfxdCYW23il0k/xEE6Exgj/5wR5NBr3/iRHcCud4jhBQYPrvYYPxWIpNOXPY/ nTBZZ0HpBCESazzGXLYyIVqyIlsxHehWOKRo2XvcnIRPfpTzK9nhK8h3TKRNnnHhaiD3 UZEfXL5z0nuGE2KPf4hXBPTlGriUT/kb9UJD9CkLuRoSQG1C7Qt+ouf6iMZMNROgRSkV 4WVzX6qiyNSpfcda9xTmDj4ZnvsFjoSJLFDdkJjvuvYwJuL+EQfFUbDLw5Aty1XIrtP3 0iMA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=GnppPm+F; spf=pass (google.com: domain of fm-72506-20220504123812245bf153c38ad44f2f-cqarc4@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-72506-20220504123812245bf153c38ad44f2f-CqaRc4@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from mta-64-228.siemens.flowmailer.net (mta-64-228.siemens.flowmailer.net. [185.136.64.228]) by gmr-mx.google.com with ESMTPS id gv43-20020a1709072beb00b006e8421b806dsi1354810ejc.1.2022.05.04.05.38.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 May 2022 05:38:13 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-20220504123812245bf153c38ad44f2f-cqarc4@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) client-ip=185.136.64.228; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=GnppPm+F; spf=pass (google.com: domain of fm-72506-20220504123812245bf153c38ad44f2f-cqarc4@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-72506-20220504123812245bf153c38ad44f2f-CqaRc4@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: by mta-64-228.siemens.flowmailer.net with ESMTPSA id 20220504123812245bf153c38ad44f2f for ; Wed, 04 May 2022 14:38:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=eHbzgSVa65WaNqqZWc/NGS63fwBoJanh2KxQsAsbNb0=; b=GnppPm+FWKHkAsuqPqgysi1tXL+eRyDfWQ7NyHviJpvY1wj7egM3+4xoPm5VpVwDIHmXU8 uVTrWFWCD4ceJ0nytX6JBdxk1kxEtKtQpqpGxC6ceQL2Sk6Q5soQxC3R7HPM4X0ZyEmdaD4x HrFLl3SIdpAQ/ySKvVvJTQvbM3Q18=; From: Felix Moessbauer To: isar-users@googlegroups.com, jan.kiszka@siemens.com Cc: Felix Moessbauer Subject: [PATCH v2 1/1] fix: mount pts into rootfs Date: Wed, 4 May 2022 14:38:02 +0200 Message-Id: <20220504123802.3544809-2-felix.moessbauer@siemens.com> In-Reply-To: <20220504123802.3544809-1-felix.moessbauer@siemens.com> References: <20220504123802.3544809-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: 8x49u67/iINv This fixes a regression introduced in 4e1dacc. Pseudo ttys might be required during package building as well as package installation (e.g. to make expect work). The patch recursively mounts all pts from the host. Signed-off-by: Felix Moessbauer --- meta/classes/buildchroot.bbclass | 3 ++- meta/classes/rootfs.bbclass | 3 ++- meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass index 3d2211b9..527f8ded 100644 --- a/meta/classes/buildchroot.bbclass +++ b/meta/classes/buildchroot.bbclass @@ -43,7 +43,8 @@ buildchroot_do_mounts() { fi mountpoint -q '${BUILDCHROOT_DIR}/dev' || ( mount --bind /dev '${BUILDCHROOT_DIR}/dev' && - mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' ) + mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' && + mount --rbind /dev/pts '${BUILDCHROOT_DIR}/dev/pts' ) mountpoint -q '${BUILDCHROOT_DIR}/proc' || mount -t proc none '${BUILDCHROOT_DIR}/proc' mountpoint -q '${BUILDCHROOT_DIR}/sys' || diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass index 7e9fb0f3..9f3ec0e3 100644 --- a/meta/classes/rootfs.bbclass +++ b/meta/classes/rootfs.bbclass @@ -35,7 +35,8 @@ rootfs_do_mounts() { set -e mountpoint -q '${ROOTFSDIR}/dev' || \ ( mount --bind /dev '${ROOTFSDIR}/dev' && - mount -t tmpfs none '${ROOTFSDIR}/dev/shm' ) + mount -t tmpfs none '${ROOTFSDIR}/dev/shm' && + mount --rbind /dev/pts '${ROOTFSDIR}/dev/pts' ) mountpoint -q '${ROOTFSDIR}/proc' || \ mount -t proc none '${ROOTFSDIR}/proc' mountpoint -q '${ROOTFSDIR}/sys' || \ diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index 145d5e87..ba8ad094 100644 --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -362,6 +362,7 @@ do_bootstrap() { # update APT mount --bind /dev ${ROOTFSDIR}/dev + mount --rbind /dev/pts ${ROOTFSDIR}/dev/pts mount -t tmpfs none "${ROOTFSDIR}/dev/shm" mount -t proc none ${ROOTFSDIR}/proc mount --rbind /sys ${ROOTFSDIR}/sys @@ -383,6 +384,7 @@ do_bootstrap() { -o Debug::pkgProblemResolver=yes umount -l "${ROOTFSDIR}/dev/shm" + umount -l "${ROOTFSDIR}/dev/pts" umount -l "${ROOTFSDIR}/dev" umount -l "${ROOTFSDIR}/proc" umount -l "${ROOTFSDIR}/sys" -- 2.30.2