From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7093814202197868544 X-Received: by 2002:a2e:bf01:0:b0:247:dfe7:62dc with SMTP id c1-20020a2ebf01000000b00247dfe762dcmr12907310ljr.365.1651679625223; Wed, 04 May 2022 08:53:45 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:bf11:0:b0:24a:fdc1:7af4 with SMTP id c17-20020a2ebf11000000b0024afdc17af4ls520537ljr.1.gmail; Wed, 04 May 2022 08:53:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO3iDHbkByOqj51b1IdlNcc7mpIx41b/H/I2PrLYnsoMjdvV6X5OFDNSZpiKHg6+7v7o5O X-Received: by 2002:a2e:7f0b:0:b0:24f:e04:d0c with SMTP id a11-20020a2e7f0b000000b0024f0e040d0cmr13018336ljd.441.1651679624086; Wed, 04 May 2022 08:53:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1651679624; cv=pass; d=google.com; s=arc-20160816; b=mp7+d/yZ3Q669RR7vpr5rSO0plEUq5GEZvkXtTeFAEXzybwYxOxvViwVwDHk4Joz9b xwSEw7ldtwZqkGf+8k+V8JrVSLqgxb1GSyP/tYYik/X7OFRCBKpF/EfQ1prSzvuS9KLD g0vZQQsBTH4gCQmkSktCyjX9VVS0VFiEvgwDehnidanSpcpSctqCDLOjptbOBXbsz+6/ JQXVtlQXwHC+zeZi+v0JDsMF9zMj3AtNijeDGn40kMH5u9F7bgCQDVnTcg35yjKVfmBP OwkiviW3vb43LEdCHSXLklUivoHHSQnD+jKQBEl+2z7RfNvtFMXD8hRpu3NDMK/Lvk2T FDSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=YVdXgysTSF+uP0e9/wenFEA4i1FzzOZ4Nl9wGtZLCDA=; b=aFwc4zrYWW7qKZ2lbibq+p5mNMcyRlMeZwDAB8/SLzgOlaCOQuGXPrevCBl6AzrAOy +nOjKujTkB6Qb/LsCea2oszzmqfbgow9+xLScX+lDrd9aeIbxlFViHSOUbhk4eNO0FDJ 608l+he8e4mrljCQqkog389k9yhj1P+LKIyW0xA27SBvIvIMy3RSW2263Xi3JF/YL0c2 25ZaORMOH0xcg5qLEiQ62j1lWVhF/EJspMq8Ky767RK1WKlwuTqWOgy75hq+OgvOd2O9 ZgP4+2QW2RKAV196Q055UzmfBe1Hb57GCpgtQN0zTIznbMFETMrkQ9/TEEcimb41nhOS sbFw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Zt8eu1vj; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::604 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20604.outbound.protection.outlook.com. [2a01:111:f400:7e1a::604]) by gmr-mx.google.com with ESMTPS id s1-20020a056512314100b00471902f5be2si1221437lfi.3.2022.05.04.08.53.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 May 2022 08:53:43 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::604 as permitted sender) client-ip=2a01:111:f400:7e1a::604; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Zt8eu1vj; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::604 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JvJVK9YrjgRBgmEU5/+mrI54O7r4JsefBJkyCrfYuwd+xnZbKeVyt5Y3QCYiKsOF94wUwt5WBNSsL84O2911yx2R6y6/m55cIhnP1q/acx1x5Zqj4TXSofQvDzG6xSouljgpS5iIrj8S2kerjFImJ4rAKwHdrOG+yBCOYBl60SkgcW7zwvbX8hQ94kRFqC/JPdXhOFsD0pRQ0imeqvZJzA9n6i55jZsQQjiTB3lJys7epvTdfgjJrDML2C3lSNlCnwQN9X0VxRzjVHGNlfhz1SmITUdem471HNg6zJ48jbBrHe4QYI3CAOtE+muQerH62C34+GLyqqpXPcG4H4Dfcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YVdXgysTSF+uP0e9/wenFEA4i1FzzOZ4Nl9wGtZLCDA=; b=PUeQDWndPCpSxHczwIVNR7a2UbOH7eNetM/trUv0RM2auTrOYqmDDE584m5nLEY6+vHdZFp7dYDlLFTK+4nKKiho6WuQS1Hs0gSfShwm1xAq08ciCeYdLVkkgJfIRA2mm3l0o9ElX5plRBWCTLHYqmM26cMdfb8vwMI4WUXoogRYs/7s+egdteJ5PJHj46BWQ7W6RgId1ja+4bg0trkaOaM+h7cPoRydu8xWn3UctkqJKXiPuxLAxckTYDuU+i8vi9gmIgWS2zeDRgHYIsU8TJc2zwkXbp5KDYEBm0MAQMt3PepwaRz8V8/kCqUShfshxc4eo2NL0hNSrOZ7LsnBAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YVdXgysTSF+uP0e9/wenFEA4i1FzzOZ4Nl9wGtZLCDA=; b=Zt8eu1vjPpHvehIhAcgydedZ1DidUSJVjNbvGQf400IYiq0NAzGe/E74Sfj4Om9Ic3RGEJMnPMcPvbyQeOqJFMVOmTRxZ/70+U/AUR1/6+hbIi1q8w0voIJdfRVBHZZs1+L1BoNhOjizAU6HzoQNQevEl8nR2/qnkjy305B8h/L+5kfQnkJxJqUTv37HwunQfmaTYl4RIjUd3j6q07eVrPt7eLq2FYgTX4/8Qx/dIFgGyAzV5FtDmnAYXvag48/MA+/fPOgtl37/0GTF6y+T3/JXp8ws8IgEctUa0kAqTs/CJdv1IVflE3bQrLAtOsvNyPoab/eg/vy+oU4HIjyDpg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AM8PR10MB4259.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1c9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 4 May 2022 15:53:42 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::f4be:8b5d:4314:c2d8]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::f4be:8b5d:4314:c2d8%4]) with mapi id 15.20.5206.025; Wed, 4 May 2022 15:53:42 +0000 Date: Wed, 4 May 2022 17:53:38 +0200 From: Henning Schild To: Felix Moessbauer , jan.kiszka@siemens.com Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2 1/1] fix: mount pts into rootfs Message-ID: <20220504175338.6d37d23a@md1za8fc.ad001.siemens.net> In-Reply-To: <20220504123802.3544809-2-felix.moessbauer@siemens.com> References: <20220504123802.3544809-1-felix.moessbauer@siemens.com> <20220504123802.3544809-2-felix.moessbauer@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0070.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::47) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 438d59a5-60bb-492d-7b0f-08da2de64384 X-MS-TrafficTypeDiagnostic: AM8PR10MB4259:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KReVk1higApnTNZqWhqRgnRvzQ9udmqYtyYRoE9Cc0XFLB/MEvggNPRdzSuQ8OxcWcGSnxfmVGctyoaLugA9qpQTTpioaGedx2u7Lr0PialSXVQbzG24hgHpyBk/faVpn1y+8El7PtQXqlS+zNVF27PFF7JrKXbJnBTJWKPavlZ73m26eTau97am7sa/gnVuQOQVaTVaX9ZsedCJIdiiUrX2NSowUC1oi71snWlqqWwLZny1t9wxQqMAc++s90Gxekn66S5Xa/oYPqptq3TJCU+SF2OtCKCRpA18Ykxvyjr4bbLa2YH5xzUue7LPEkuNjERKTMQsaPSe0hMCFU6lrNJNtq4iLAnYvlkpYSqKvxPD8GIYpS6LstNbsZ7jll4NkTbytXclrTlsg8GscIiG6HFtNHwvPVIzAL3GSrvbyvPUlTN314TV3+aGgAVRVMQxNlcSW2yVj6fP8yXA+wNNIXS2RPfQ2F/Qs/rI9H6Qf3rkD9lrByxuV3ZYelw9EtVNJaGuPf7Ja92PROOSzzJ1bDtdVUupvS+ro3jetHYkeI/nJF8Ehc9j1UG/jHIkhD7pBnURZtgy8ra5yRfRQnNHqDRLES7fg3ekrhWZYh4UBamCGls1d2JHXju5rg4r7EM/iDLS8SIjuxF85OODQauYyA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(4326008)(66476007)(66556008)(66946007)(8676002)(8936002)(44832011)(6506007)(82960400001)(6666004)(6486002)(2906002)(316002)(38100700002)(1076003)(26005)(6636002)(6512007)(83380400001)(9686003)(186003)(86362001)(508600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M6h9wIDixc5J375WgCh8w4Ds2tA+sn6+4EH7w+dMXX2YAaYN1V0H/k3rzHaU?= =?us-ascii?Q?4npyLuezP4hs7c0oZQyag2qEao5akqnt5H1mCb77OKHcyDTQH1Dr+GUt0bPW?= =?us-ascii?Q?ymV5JR3mX5I7s/b2+rP4LaIbUwYkMMlHHE4kmB5ntPj4IUWO7phBkDp1fM9I?= =?us-ascii?Q?UGa0Y9dzE8oop58hWedHMHSi8v3NygF6BdPaDclWDCk8VqhepfUai7f9kpIM?= =?us-ascii?Q?Ma6qAVZVoRaoGvk/QOqZopi4LjW+wikPF/7qenLdSi619HcO/Ca0Pa9tCvXp?= =?us-ascii?Q?3Lp0FoTMUf/I9eCal25YpHXNIaKXIJ6lQ3pYJtktzZbRU8ddvcfeHTvWpTcn?= =?us-ascii?Q?Xx/tgCwKJJ1Q/YYC/RweEGsEeU1ODn6e4XKZ9jidsc6m9bg1wiD3MrbGjNE3?= =?us-ascii?Q?slOTye3mXReVizzVmtOujECRjKhPqKhcckspH5oMkSX3SIvc0RHvsdeRon5E?= =?us-ascii?Q?ggyYmtmaHbAnowKIQdyJWx4LMHJIfqw2A7wwyXY1JnYsO3uBem/zPa3hZMai?= =?us-ascii?Q?JqeGDKNmzYf2X1xTWdfhE/a+LI69D1FU8B1TKrF+s6NoHrXLTJWbV/4f57BK?= =?us-ascii?Q?0KPjd4MnUR/QW4s0OXXgKAVxw0Lie+3DdraOgf5fJtbjFRc6LFxnxOWfVjy3?= =?us-ascii?Q?WLwUmY4v5GK9V8iL6KXyMgmXYVxtgEQEP+ZO6jyV04VxH/qyau8zesvqIj63?= =?us-ascii?Q?FqsIdNg1XTf1SnOc14cETqIHJ/bO/Aa5w9mTihV/1JyLEmRVBpYRgcVb2qVw?= =?us-ascii?Q?1v0lhB2gaY5oO9A4lguqibU0V7NlgnacclCYtzvVt6NTtqXJCfuF+jHlf7ks?= =?us-ascii?Q?K8HAqEJo690E5O/YhA0c4V919Gmn26C5naA+VbQYnQkWze7sRR+jEPYYcx0B?= =?us-ascii?Q?Qq2NL4n+I1ZBQssxM2u/8sR8ET1G4SBE9h/2mCA5gIi/3l30ecIx90wdvVMv?= =?us-ascii?Q?th4KMu/loEUiE9WJpSxFR+5MP3cSZr7hGGOy4xSXx6ZyrrSaqPbA8Q7dvdXw?= =?us-ascii?Q?Wk8zCFx+pLI5/+JCh69iHvb4cAzMdUm+rYF4Wrrv/MERdll7N3cVD5CNP38j?= =?us-ascii?Q?0bR0FDEpoNZp0G9XdTYLm8IrlKZxvcJsRHR4GxNIOE9bc5UszcbGn2Zh/Mix?= =?us-ascii?Q?m7R3zKF8SYhs2VpLMqWXvB81sb07sKZzNZlKcInBAPVTM3MoY/9IYcc5kipi?= =?us-ascii?Q?5Cmd+1YI5ek4HVfVgHkrnxFPkJCn57MFPLSlACQYH0GQCHJ4wB73IS3gPJTz?= =?us-ascii?Q?i/UuSavbYMxei0cetczbpuwbhdWe/qF2iPn/09FlSPN/G9H/Jpc01Zcl5lVx?= =?us-ascii?Q?sC+0kE0+0n45ptmlAoMD3+6XFHuLttnStTccBu7lqEj9Y7EcyEhK8x/rqsVV?= =?us-ascii?Q?Irrrkf+hMyl72ezfeh7wZlJjHkFLckmdfSLN8Fzqz1dbLcdXJqUyHz7Vf5KO?= =?us-ascii?Q?BNC5KufrCyAY2u4oIyoqn3kycArGPrd7s6k+UhawRDCz8osG0MS9Gzetagv1?= =?us-ascii?Q?ZwWw8uqbEQfmVWn8oh+2aWe31yb4Exd4FRN9PX5BVdoPjpMn+PTaRd6T9E1Y?= =?us-ascii?Q?E7jVlozmG/BX82oxRnVvFDg1tJv+dJNTuGozTo3EHE9O7qhlNQGT/4vH86rY?= =?us-ascii?Q?IyLw1y7WseQuiVxND+OAjvTcclKeYhVjSbua1mtAbeAhPSyvwmyezz7BDkJi?= =?us-ascii?Q?4wbDoD7tYP5UDHADzCq/SsVgK2rtqP4cmf4wC7lgWnZ9f4z1SNY4YpEdlkAq?= =?us-ascii?Q?5J5STY6txsJWJCuMoousi7Z1Hf440firZ36zHe7TClrfUYrkgO0P?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 438d59a5-60bb-492d-7b0f-08da2de64384 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 15:53:42.6236 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BvgwAh2SHKWaHP9uP4kgmnoY5TixpiOgeCgy0Tq30MkgbjuPmTyx07QsIW2GEkRYNJa9IDEuhhs0eerT5jR9eYcO2i8rwV8XHTlrs4Tsbjc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB4259 X-TUID: wLr68FbvXwzc Am Wed, 4 May 2022 14:38:02 +0200 schrieb Felix Moessbauer : > This fixes a regression introduced in 4e1dacc. I wonder whether we should not instead look into reverting 4e1dacc and finding a solution for just the sub-mount it was written for. i.e. mount --rbind /dev dev && umount dev/shm && mount -t tmpfs none dev/shm seems to work just fine, leaving dev/pts mounted and also dev/mqueue which was also removed by 4e1dacc or dev/hugepages which i found on another host Who knows what all those sub-mounts are for and what else has been left out. But the commit message ends with the recursion having been removed on purpose. > Pseudo ttys might be required during package building > as well as package installation > (e.g. to make expect work). > > The patch recursively mounts all pts from the host. > > Signed-off-by: Felix Moessbauer > --- > meta/classes/buildchroot.bbclass | 3 ++- > meta/classes/rootfs.bbclass | 3 ++- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 ++ > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/buildchroot.bbclass > b/meta/classes/buildchroot.bbclass index 3d2211b9..527f8ded 100644 > --- a/meta/classes/buildchroot.bbclass > +++ b/meta/classes/buildchroot.bbclass > @@ -43,7 +43,8 @@ buildchroot_do_mounts() { > fi > mountpoint -q '${BUILDCHROOT_DIR}/dev' || > ( mount --bind /dev '${BUILDCHROOT_DIR}/dev' && > - mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' ) > + mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' && > + mount --rbind /dev/pts '${BUILDCHROOT_DIR}/dev/pts' ) if recursion was removed on purpose we should probably mount "-t devpts" and not "--rbind" Henning > mountpoint -q '${BUILDCHROOT_DIR}/proc' || > mount -t proc none '${BUILDCHROOT_DIR}/proc' > mountpoint -q '${BUILDCHROOT_DIR}/sys' || > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 7e9fb0f3..9f3ec0e3 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -35,7 +35,8 @@ rootfs_do_mounts() { > set -e > mountpoint -q '${ROOTFSDIR}/dev' || \ > ( mount --bind /dev '${ROOTFSDIR}/dev' && > - mount -t tmpfs none '${ROOTFSDIR}/dev/shm' ) > + mount -t tmpfs none '${ROOTFSDIR}/dev/shm' && > + mount --rbind /dev/pts '${ROOTFSDIR}/dev/pts' ) > mountpoint -q '${ROOTFSDIR}/proc' || \ > mount -t proc none '${ROOTFSDIR}/proc' > mountpoint -q '${ROOTFSDIR}/sys' || \ > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > 145d5e87..ba8ad094 100644 --- > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -362,6 > +362,7 @@ do_bootstrap() { > # update APT > mount --bind /dev ${ROOTFSDIR}/dev > + mount --rbind /dev/pts ${ROOTFSDIR}/dev/pts > mount -t tmpfs none "${ROOTFSDIR}/dev/shm" > mount -t proc none ${ROOTFSDIR}/proc > mount --rbind /sys ${ROOTFSDIR}/sys > @@ -383,6 +384,7 @@ do_bootstrap() { > -o Debug::pkgProblemResolver=yes > > umount -l "${ROOTFSDIR}/dev/shm" > + umount -l "${ROOTFSDIR}/dev/pts" > umount -l "${ROOTFSDIR}/dev" > umount -l "${ROOTFSDIR}/proc" > umount -l "${ROOTFSDIR}/sys"