From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7095678487044816896 X-Received: by 2002:a5d:42c8:0:b0:20a:d91f:87b5 with SMTP id t8-20020a5d42c8000000b0020ad91f87b5mr13187935wrr.301.1652091395766; Mon, 09 May 2022 03:16:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1f11:b0:394:7a2e:a847 with SMTP id bd17-20020a05600c1f1100b003947a2ea847ls3666698wmb.0.gmail; Mon, 09 May 2022 03:16:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0qbVxyi6Na1ema/HUbWA9ohfi0mDewFvbZXdA4kfXoVYT8xQk5oD9zLJ0yXkGrVaO2S8g X-Received: by 2002:a05:600c:4f53:b0:394:6a35:79ac with SMTP id m19-20020a05600c4f5300b003946a3579acmr20149165wmq.36.1652091394699; Mon, 09 May 2022 03:16:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1652091394; cv=pass; d=google.com; s=arc-20160816; b=ZeXddGnpckZriScRJAEQpj465FHexbdmU6KlyVLqnct4WUrrsKQMPXKaGj1Y2DbDVM g/sIZZpbckrZwE4IJnxMmxdS88hzrotBzo1BKSAwU338gFNDm/8RnYpIOnp/+LZk8u8v XyVz7hxJGa1t9fm/1MUJoaOWmtWHW4jQW2g0lxfsor63lp+hnXZCsfakFVnwDvq+pLdc fRuPHyP5Q+CQIR+dh9shcUKTp2fMpa594kTEVVdcsg2ZyxEDuaVQpP5RwDvyKJlTmjGw Ik7lfJOnO7k/JBkFt43SkBY2Ch6qP67yefgiIf097PZpMRkTJobbzeOb7KOITobeP5Ka 7XKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=SykF9y3JfQciTZ12LDItLf9tIkNUOJl8u6ITLYQcKXA=; b=QiEODYcgcmk8a0+//ZZy44NH9IyKQaFnQUKvYevKTRdQqzRxvtG55qD8s5RKffUY1m 3ckaZyS91miHAy1PkdbU/zCuqsUp1Li0/5pzH/bkWxU1RcU2Fp5TNvAIHXTDN6NcmCaT pJW9BSPKZdCnR0aIFFhUpKZgvY8Em5KYWNaPLappWPn4fqkN550VSnQM4YrLmvKqCSU1 O/PMiiEbwruBjNWVaPr4/F7JnYr0OsdEcYRVx/W2MUzwYZFoXhCmvfbJqFeBFZom7e7l 87Lkqy3oMRlLZqvlMMt4YsSClA9EE8aHG70eumgU02AUNtBfQgeFR1sHzqyAywpf+x7Q NOlQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=FvDu3oeJ; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 2a01:111:f400:fe0c::603 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0603.outbound.protection.outlook.com. [2a01:111:f400:fe0c::603]) by gmr-mx.google.com with ESMTPS id n13-20020adfe34d000000b0020c67de496bsi567464wrj.2.2022.05.09.03.16.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 May 2022 03:16:34 -0700 (PDT) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 2a01:111:f400:fe0c::603 as permitted sender) client-ip=2a01:111:f400:fe0c::603; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=FvDu3oeJ; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 2a01:111:f400:fe0c::603 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GF8cN9mzqYpIecykKRe6VXswHYGsqBjpx8UwIYK0GvQJU9yga0wKenDb0cIX2v2wT6Z9YRiVmEcPUdlc76fBq1OxGwErZ0ZpOXTwnc150y/r0n2d73b1R+cGsgzwvG9c497Qd/w7dOotBXwySNV1IcNKSR3jVxuNtNefGPusvzBoVEVW7hD7gA1fD7gWDEJ5HlW26aEucv/hcRibogGA1UXG5/Z18SKRtpSeHA3E4zFS3ROdz0rSHsqcQ/MDXh780mwe5PsOFmd93S+z+Q6HDbyAArQ3ha9+FB2xQ93CT12301Z9i2jjVgi/eBvHPnabiWGBbFdFxxF8JR9NfLO/RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SykF9y3JfQciTZ12LDItLf9tIkNUOJl8u6ITLYQcKXA=; b=TWn2iACgeYYvFslWQBZz+ZLNhR9yiwWpLKjTeg4bAf441Nf16dFQuWGubSBZalXQwQEEYeafDRgTV+rciBp/J7BElnjavzQWAFKzsaJR5Ix4vCRZhrJCAjPayBu1dVhkrcMWN+ZjPLyR0x/RYkFr7N6SSlsZnOcaN+9uGR13RWCBiULqTyNnMEqFAZQUWnnelD1HkY7FUMwrNS/TN/DZ2RNrsXSobDxx/lIxrEDSTjdotjFXWJjoTzE2iFVs10w9AgPb6PjLqpNB1ob4Fo769DiXMqjNSbxHDxy2WmoTsMTKqXJ9bx0TwdrYpUlDxkVUktofJasu2e4sfrfkWxI2Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.73) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SykF9y3JfQciTZ12LDItLf9tIkNUOJl8u6ITLYQcKXA=; b=FvDu3oeJdmzk3s6Wm7p3Ci6NQxf+qMYr7zuVbRNx4NzHih8SZ1dCdE7vh+YANahUyT6T7IpsrntyiW8QcY6R/K9O34tSvWWrbUyvEWSi3EvVuVWpF3f3nHoCkEc3r2lDJVcelY/Ds6dLykDb2fRi2pufkFUqj/YQv0Ku0wVs94cOckRtgnL8j0a0kC8rOAVE3xH2706jkQKnoXk9o2lNYxyzK4G4WJSHqqiBadJgjqp1aQjfFykV9I23VgZ7eZXtcetneQ2NyM5eE6ja34uqvfLqR0M1OTy4OucIGmKK/EdJMZAGi+5tezGBOCusQsvcGQSOHIGco91/oT4fgdBPRg== Received: from DU2PR04CA0351.eurprd04.prod.outlook.com (2603:10a6:10:2b4::10) by DB7PR10MB1913.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:5:11::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Mon, 9 May 2022 10:16:33 +0000 Received: from DB5EUR01FT061.eop-EUR01.prod.protection.outlook.com (2603:10a6:10:2b4:cafe::30) by DU2PR04CA0351.outlook.office365.com (2603:10a6:10:2b4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Mon, 9 May 2022 10:16:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.73) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.73 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.73; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.73) by DB5EUR01FT061.mail.protection.outlook.com (10.152.5.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Mon, 9 May 2022 10:16:33 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SNA.ad011.siemens.net (194.138.21.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 9 May 2022 12:16:32 +0200 Received: from random.ppmd.siemens.net (139.25.68.25) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 9 May 2022 12:16:32 +0200 From: Adriaan Schmidt To: CC: Adriaan Schmidt Subject: [PATCH v2 3/7] bitbake-diffsigs: break on first dependent task difference Date: Mon, 9 May 2022 12:16:00 +0200 Message-ID: <20220509101604.3249558-4-adriaan.schmidt@siemens.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220509101604.3249558-1-adriaan.schmidt@siemens.com> References: <20220509101604.3249558-1-adriaan.schmidt@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Return-Path: adriaan.schmidt@siemens.com X-Originating-IP: [139.25.68.25] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6cf646a7-7720-4ea7-d9c7-08da31a4fdf1 X-MS-TrafficTypeDiagnostic: DB7PR10MB1913:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DE6b9FzhDitQG7ESAVaJFf0WnTUy5anqjYnxK9rsbIj1JGDtUzHJ7ksz7gEbLkK+iTnr7/7gui9la+VOnyW1j/3L58mtBYDENCiMpD4wwuIiDmf0BarJsRPX4FQ1qRs2yCilXYy1m8aIArekzAdtqW70CXzvbQZnHQKxEkZTjKwpOoo9D+sIyfUJn28IbTSG9sDecEMeBfszu7o1DT2gRx1tgtYS3q8e5pmZd2B4E4KaKu1/BA3Yd9wxDTKUGT9pACSy4Wao1DcW2MkkJLS/Jwnb5HKJiiXYWWow4jlreDQ0TB09VpGMa7gveN+9oDJeDIZeUIa4ysMXhQGYZnJ+p7MHWLO4Nx89t4V4BuBMwWwVrl2kmlCxr68UQvdSYuCWbU+/wg47KJ5N3C1gycaDvhMSeXONZQbqyuIlRaCEulWZD6c6Hv3LuMJbmiRSfMYetkpEjD50sX4IGLLf5cizs31Q7SYPBEpq7lQA33pCG7mNqrFsYSP3l8F3Zd9EEy/gC3sW/Aly4m3v1GwSjz+EPMJU9JlZrsQVE3o7+5Atp+Xf0w5fCp2FVFIEshkJH4BTCLm/6sH8gcWv6m08I7jb/u2hktgCWHLsT3jL89OsQpAC6WD7YUms4lQirM3Pi3hisYx2lkMNvUEZnYDxgdseAPWzpqvCb7Z1LkeTU1LQJPuxcQHcmtsZ6n4i9UUptnAUGqHfJQl/RWi/5S1RofZQFotvArOXqNZgfJCgVjqb/2IJ7owcdPZPevF+yrRDq+dRTGsyI9Zy9cAHx5xKq/toULTzsY+/Can1fZ6+4U5aUGU= X-Forefront-Antispam-Report: CIP:194.138.21.73;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(6666004)(2906002)(966005)(86362001)(8936002)(498600001)(5660300002)(44832011)(81166007)(83380400001)(356005)(26005)(82960400001)(956004)(107886003)(2616005)(36860700001)(40460700003)(47076005)(336012)(186003)(1076003)(16526019)(70586007)(70206006)(6916009)(36756003)(8676002)(4326008)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 10:16:33.0604 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cf646a7-7720-4ea7-d9c7-08da31a4fdf1 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.73];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT061.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR10MB1913 X-TUID: 4ymPKQ14PemB Currently compare_sigfiles() recursively calculates differences on all dependent tasks with changed hashes. This is done in arbitrary order, and only the last of those results is returned while everything else is discarded. This changes that to instead return the first difference and not calculate any more, which significantly speeds up diffs of tasks with many dependencies. backported from upstream: https://git.openembedded.org/bitbake/commit/?id=8ed7722865d2dcfda1697aaf4e12b828934bf527 Signed-off-by: Adriaan Schmidt --- bitbake/lib/bb/siggen.py | 1 + 1 file changed, 1 insertion(+) diff --git a/bitbake/lib/bb/siggen.py b/bitbake/lib/bb/siggen.py index 8b23fd04..767aeb0a 100644 --- a/bitbake/lib/bb/siggen.py +++ b/bitbake/lib/bb/siggen.py @@ -980,6 +980,7 @@ def compare_sigfiles(a, b, recursecb=None, color=False, collapsed=False): # If a dependent hash changed, might as well print the line above and then defer to the changes in # that hash since in all likelyhood, they're the same changes this task also saw. output = [output[-1]] + recout + break a_taint = a_data.get('taint', None) b_taint = b_data.get('taint', None) -- 2.30.2