public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Adriaan Schmidt <adriaan.schmidt@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Subject: [PATCH v2 7/7] testsuite: add cachability analysis to sstate test
Date: Mon, 9 May 2022 12:16:04 +0200	[thread overview]
Message-ID: <20220509101604.3249558-8-adriaan.schmidt@siemens.com> (raw)
In-Reply-To: <20220509101604.3249558-1-adriaan.schmidt@siemens.com>

Call `isar-sstate lint` on the populated sstate cache to ensure
that no undesired absolute paths make it into the sstate signatures.

Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
---
 testsuite/cibase.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/testsuite/cibase.py b/testsuite/cibase.py
index a1494ce6..2ffb8191 100755
--- a/testsuite/cibase.py
+++ b/testsuite/cibase.py
@@ -6,7 +6,7 @@ import re
 import tempfile
 import time
 
-from cibuilder import CIBuilder
+from cibuilder import CIBuilder, isar_root
 from avocado.utils import process
 
 class CIBaseTest(CIBuilder):
@@ -103,6 +103,12 @@ class CIBaseTest(CIBuilder):
         # Populate cache
         self.bitbake(image_target, **kwargs)
 
+        # Check signature files for cachability issues like absolute paths in signatures
+        result = process.run(f'{isar_root}/scripts/isar-sstate lint {self.build_dir}/sstate-cache '
+                             f'--build-dir {self.build_dir} --sources-dir {isar_root}')
+        if result.exit_status > 0:
+            self.fail("Detected cachability issues")
+
         # Save contents of image deploy dir
         expected_files = set(glob.glob(f'{self.build_dir}/tmp/deploy/images/*/*'))
 
-- 
2.30.2


  parent reply	other threads:[~2022-05-09 10:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 10:15 [PATCH v2 0/7] Sstate maintenance script Adriaan Schmidt
2022-05-09 10:15 ` [PATCH v2 1/7] meta-isar: improve cachability Adriaan Schmidt
2022-05-09 10:15 ` [PATCH v2 2/7] bitbake-diffsigs: make finding of changed signatures more robust Adriaan Schmidt
2022-05-09 10:16 ` [PATCH v2 3/7] bitbake-diffsigs: break on first dependent task difference Adriaan Schmidt
2022-05-09 10:16 ` [PATCH v2 4/7] dpkg-base: refactor dependencies of apt_* tasks Adriaan Schmidt
2022-05-09 10:16 ` [PATCH v2 5/7] scripts: add isar-sstate Adriaan Schmidt
2022-05-09 10:16 ` [PATCH v2 6/7] isar-sstate: add tool to check for caching issues Adriaan Schmidt
2022-05-09 10:16 ` Adriaan Schmidt [this message]
2022-05-18 11:02 ` [PATCH v2 0/7] Sstate maintenance script Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509101604.3249558-8-adriaan.schmidt@siemens.com \
    --to=adriaan.schmidt@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox