Re: [PATCH] expand-on-first-boot: Add support for devicemapper

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 19 May 2022 11:51:01 +0000
schrieb "Moessbauer, Felix" <felix.moessbauer@siemens.com>:

> > -----Original Message-----
> > From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
> > Behalf Of Anton Mikanovich
> > Sent: Saturday, May 14, 2022 4:06 PM
> > To: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>; isar-users <isar-
> > users@googlegroups.com>  
> > Cc: Storm, Christian (T CED SES-DE) <christian.storm@siemens.com>
> > Subject: Re: [PATCH] expand-on-first-boot: Add support for
> > devicemapper
> > 
> > 21.04.2022 20:10, Jan Kiszka wrote:  
> > > From: Jan Kiszka <jan.kiszka@siemens.com>
> > >
> > > When the rootfs is inside a devicemapper volume, e.g. dm-verity,
> > > the script so far fails to identify the boot device. This adds at
> > > least basic support for that case (single level, single slave).
> > > Once there is a good example for more complex setups, this could
> > > be taken into account as well.
> > >
> > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>  
> > 
> > Applied to next, thanks.  
> 
> This patch breaks very simple partition layouts like the following:
> 
> $> mount | grep sda  
> /dev/sda2 on / type ext4 (rw,relatime)
> /dev/sda1 on /boot type vfat
> (rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,utf8,errors=remount-ro)
> 
> With this layout, the service fails with the following error:
> Boot device equals root device - no partitioning found
> 
> @Jan: It looks like the check of the device slaves is not sane.
> Could you please have a second look and try to fix it?
> 
> It also makes me wonder why the CI did not find it.

I think expand is not covered in any of our CI configs. We currently
have Tobias working on systemd growfs and repart, and might see more
testing coming with his patches. Hopefully including also a "qemu-img
convert resize" to see it grow and possibly check that it really did.

Henning

> Felix
> 
> > 
> > --
> > You received this message because you are subscribed to the Google
> > Groups "isar-users" group.
> > To unsubscribe from this group and stop receiving emails from it,
> > send an email to isar-users+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.g
> > oogle.com%2Fd%2Fmsgid%2Fisar-users%2Fa016bb05-21c1-e179-68cc-
> > f1d96311e210%2540ilbers.de&amp;data=05%7C01%7Cfelix.moessbauer%40sie
> > mens.com%7Ce400a882e3df426ed81508da35b2d6e4%7C38ae3bcd95794fd4ad
> > dab42e1495d55a%7C1%7C0%7C637881340185739960%7CUnknown%7CTWFpb
> > GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M
> > n0%3D%7C2000%7C%7C%7C&amp;sdata=SKokXmDUdxOGDDRMs4pn4VUu4bv
> > WO5iDgl%2BwBWT2lsI%3D&amp;reserved=0.  
>