From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7101379742667898880 X-Received: by 2002:a5d:4143:0:b0:210:309:ac48 with SMTP id c3-20020a5d4143000000b002100309ac48mr405860wrq.239.1653466137113; Wed, 25 May 2022 01:08:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1f11:b0:394:7a2e:a847 with SMTP id bd17-20020a05600c1f1100b003947a2ea847ls2608906wmb.0.gmail; Wed, 25 May 2022 01:08:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxql2V1Bcbspg4n56gr5wSBrLm7+HZ5mZJzC0KxtF7Q0ZYsVaZqZqtI4KyekNFyBeIy46fk X-Received: by 2002:a1c:acc6:0:b0:38e:b184:7721 with SMTP id v189-20020a1cacc6000000b0038eb1847721mr7000105wme.94.1653466136170; Wed, 25 May 2022 01:08:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1653466136; cv=pass; d=google.com; s=arc-20160816; b=PFeUEcYbngkisfKnxdGwBmlKmd2x1dNRPlMyPDlcOdS16GUt4q+Yjfdz7fEM0TyrNM W5ud8dPJIEia0hldBZvOoPp26u7o4BBb/4O7OSLbr94xiQf9pLAQcggrHEgD+KCQ9goY CcyQSV1KYic6MWKe3eAzVQkkTKeKim7Pz+lDDTax4tBkan6AYu3XCeDGDXWTf+ea3e7m HJGm/CcYrD7Iz5ffdrJK9KEeunxGkOoVe7DqPKddPVlKUROv2ysbYnMeH/w/iL4oHZFB WUNhzBeyyPsV7ntz1D4FzjjjRjhObMukiykDDwSr+gw+7oPv2HKKo1MrsJylTPQ91SAP 9Xag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=lanjN9E7CWGpiCFIZAkz6MDCP59RW2WSXkPP9tc/nVw=; b=dsxbuMgsTqbTYu1B58CbbPfiOlzLh8gN1JrXU4Ns8k6zb5JwOT8eJVrt6bFU0Eopb4 ofwmpsHVk3laQmyUED0h4yHi7qsFAxtoeNSpxTR+J/1aqDPoBzhGrZKAMGvksb1SYE9U kvKBEFj0sVLl7uoJ2X0lr/lELfD7t3+lfGqoA5ou0zpzXI5nsBR9gm8kR7Sy1SiVnpX4 J78SE/Cf8gqPducjC+IhiZUa6N/caWyfsB96gEYeSinjfetPAizBWekNoLlGdCEDXmcW bcSf1Kl90mcYXwtrJqdcNdYCXB38aXIIUv9HnO5SYo1G9O2oGrXhKdn/2xNZlB4hGEU1 YL3Q== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="a/+v/S8Y"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::604 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20604.outbound.protection.outlook.com. [2a01:111:f400:7e1b::604]) by gmr-mx.google.com with ESMTPS id z8-20020adff1c8000000b0020d02df3017si76317wro.6.2022.05.25.01.08.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 May 2022 01:08:56 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::604 as permitted sender) client-ip=2a01:111:f400:7e1b::604; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="a/+v/S8Y"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::604 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dnf78cnToe28BNJ4WTPQWwJt1lNOU/yknjDlWiyhql8hs6Q1Mw+3PDc45rICqvm4rMHNfo0GYI3pkjvG49k3S+Y8ZxwOep8SFmdv87DomXWud25lzrWPbis650KqFDzZ6dDbx+Q7lf7l2Nu+Un/IL69OiO0D/Nv1OCa9c3tkN4bJIUq+KCb3eUlrjqDhKhsRA5WsKLqosg4KubJS33/zQ3bjBqyiD/lXSJQ4CB8Z0alCvEQWLuWKAeb0r1gSF/7e1Viw3WqumqOOlSannrkVBDhOWrvXDkSyz9iLdUG6SCN0Obrc9UceHF5NhR2pj5IkolQq0QrDwivv1FZ7C3BX1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lanjN9E7CWGpiCFIZAkz6MDCP59RW2WSXkPP9tc/nVw=; b=CuhS8DkqYoIv6sWG6lgHeyOPj/J+58waru4owBLzZ3oEXaj4CYUnKSXCxUwhGz8NrZflMx5yiYMhAhva6OAXHbCb9NK2zCo1UmVGfKt0R4KNjV6NhDcJwhD+6NcSzXfP573U3dmhgESfHIM+7ohK6TSQJUkmIC5H1anT3Bg1iXtEpLsuCkeczR4fJSsbR0HvC45E5aNOqSL25hYxgJjTZCC/HUVLn4ACbeJwlCTRMt7FuWJ5RcBoS/BpynECq0KOTt06q0yRsqpg/Xkn6yZIZwy7DAqalzvJRZVVVmWgs4FXuj1sodNQhDPuIjNkO3MHNeNojPELa3YLVyIVRgZHcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lanjN9E7CWGpiCFIZAkz6MDCP59RW2WSXkPP9tc/nVw=; b=a/+v/S8YQVbj2RiKYLr4N7yLWW+Bk2yms9zAkjUAFPdG7TxeEk8a2mxV7jaXKe9ELy6Ri8SoWPMQax0Cx+i10NQqR3A5ajsWIMgf48g4cnw/8qfrSAlyXvQkOKn83PIflKZMRIOAVPN39xN3HAu+2U58Y0x3mriwDEThXgqRlmsyeRnXQDiUg6HQUKh3aWDTRYzlxIPgaxqO9oa9js2lKcJzLxe4agEYPjSTclpEwlWawxgVlQTVl401cjRZjvlDFcaEuXcsC0Vb7DJHo0jhBbADlvii5W2IR2I4vQVKTZIu4JT7dwlClmL+/BTvAhnoUdMAbokX/QJoyJiVvlC9Xg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DB6PR10MB1670.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:6:37::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Wed, 25 May 2022 08:08:54 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::a949:4d67:8108:3599]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::a949:4d67:8108:3599%6]) with mapi id 15.20.5293.013; Wed, 25 May 2022 08:08:54 +0000 Date: Wed, 25 May 2022 10:08:51 +0200 From: Henning Schild To: Jan Kiszka Cc: isar-users , "Moessbauer, Felix (T CED SES-DE)" Subject: Re: [PATCH] expand-on-first-boot: Resolve errors in helper script Message-ID: <20220525100851.73c5d4e7@md1za8fc.ad001.siemens.net> In-Reply-To: <644a0a94-5128-556f-ee7b-c644c46a8db5@siemens.com> References: <644a0a94-5128-556f-ee7b-c644c46a8db5@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR04CA0039.eurprd04.prod.outlook.com (2603:10a6:20b:f0::16) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 66f61937-2880-4d2d-7955-08da3e25cfba X-MS-TrafficTypeDiagnostic: DB6PR10MB1670:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rEja9upLxpySZ7nwDGWknyucVc4ef9hXAx3NNAPn6jZTO6oEEgwN+buhGhT6HowMzdAAtUfcQxEKh+4zzecTzacscXIw1doDuyaktMGyEQB8eahVnJT+DmhMCne1V6GAYsyKc62CyE9qlCPIh8FMAFLosOefGxwV0tlHj1S3XI5HX4bzEDDatGRs9dWkn5wnks3BBhGEoSgjyfpkHMWZ5Vuor1ycgodOqNvCIp8sGVY8PxXWZR/aiMDFQwxp/1iPEDrQih+5yIOThH3QKRQ8SD0wHfIZKMZ4rNA6g3HQIHG6rjOYhasHf1/bQqPv3Z0QJ6gJ5LvsvsvmqLv+syOFsYt1bxnMPVbVClrG39kihniiedEhzpRIQjxvstirRDn8VQDVpHBkpXslZA30RGMfFjKd2+RsY1/RkXcFMzdpIMwkzJSYwvkjxUOy48mp6ykhlHNno73yNQmSkwoj+7XQlcP50MMqdb5sk+oMqIQYFAJL+D0KADlt5qhwHLd9op65FuxFbdWntsv9C35K+Mkg4DI2nmNwY0V/slUCyHnm4Au/f5PYdSUHtRqe6ilm4ky5umaJ6ybnifcX/LiifF4FeLA4A3lckL2eL37g6Tc//G43fjctBoSJHn1PGazmUuSrz13wBYzPB0r3XCIOBfH74A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(9686003)(6506007)(8936002)(6666004)(6636002)(44832011)(6512007)(54906003)(316002)(508600001)(82960400001)(5660300002)(66556008)(1076003)(186003)(66476007)(4326008)(38100700002)(8676002)(2906002)(86362001)(6486002)(83380400001)(6862004)(107886003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ARK7C3L5U5JM8bD98pSZQRDuVk7NBc+qJbkaEPyYUZopf1fI8SoBZWhU6smj?= =?us-ascii?Q?ezqMvB/tXob95k+cWRzKXRhKX8iGkfnEqYc+LQMZP9b+/mdXo3vbnNerG66B?= =?us-ascii?Q?xhu1VLlmg1Xv0WVJEYhX/dv/g27/GjVBH5HFQb91lfRMVZB/j3IBqQN/bSVk?= =?us-ascii?Q?XuSQsKNDWXjWu3RYyrxnVASNTAUB3EmcNABrYCB15hdYxvqHKfFXssAGvZ0U?= =?us-ascii?Q?HdYkPKi5X9SDFtRg7U2xaXG7l3U/HgxiQjBNeHrwayGx9P7j++ab2ds9K+we?= =?us-ascii?Q?q6QvOkgPrtf+ny6VPC85aFTbCBbcNORxAx1N9A/2cQM1K0fapvQHL8l3jjgO?= =?us-ascii?Q?W0Kz/jY+xGj1UInxetF/tUNQBMCe3ICoAOso3KZLyRY0KlITgpdyjtHxRCQb?= =?us-ascii?Q?t+zsixqveQRVIGX4dVqjN3HB1S1AwRFsHxZjRx/zzI1a4nhx6aAzqVaXTQRv?= =?us-ascii?Q?UB59IIhxIQ1TC8X1n2OdzFrBHBW5KkNpm5GKLkM2PNGA8MDRGcfukjcPED3C?= =?us-ascii?Q?7NBeHPJE5VTSFEuANvsXl0EQu1uZEeB+lOxv8AyA3J59yRi2PbnTk/yYLK0M?= =?us-ascii?Q?Rl8ZF1xLL2SCUvDtYZozYv26P1nCglOLbwPjmhh9VRtLn9lsSfuuwMgw0KpF?= =?us-ascii?Q?ZzfVhrico+U/RrVGhZePTKAgYQesEQomM/vPxJizJgGNZpB76zZHEI5wKIOp?= =?us-ascii?Q?bZ/kR6MfoSFL6P71P5phsuxVm/GmczEu0A/MtiMEeTXj/e7kz3yWZ6JhGQKX?= =?us-ascii?Q?FB653p92+dEs6CjMB0Cfx1umVI3EF+Z1NUN87YT4X+k3I0ufLdclz0iPL/HS?= =?us-ascii?Q?TwVor6tq0Ryzm2Ovx1scauBxr0w1eHezYZA4M3eSmzDH1TcG3Kst3AGX/2wZ?= =?us-ascii?Q?aP+EqY/YFiXbYSOuf7+8fuPSFuK5G0zzqJDH+qceBto+x+oezDPWyfahMw5m?= =?us-ascii?Q?S99YHlddglWmQLn+mmFXQU2KoVfOD5jwv+tjiuvM1XVm0cwG2uRoSGFuNqju?= =?us-ascii?Q?hwlfqMrkon3xho7kHZUfTYG4RZ3oIkI00sZVFWkiRNoJ/VdpinsPISY7dP1k?= =?us-ascii?Q?nj84CXLq+/th0iKZbzTAyQ6F9tkCa3rxM91QpyKxjXoYywq+K8eY1sfFhf6v?= =?us-ascii?Q?rXDKOXKekRDWJBq9rIcULovi/gA4cPknLF9UA76JQQTnapcrgrjMhEhmKsGg?= =?us-ascii?Q?3A/n2aBeSOuwHpt4v0aCvH8rbFLoJLzmYG7J8odEEWP8Gi+V8Qqr6WV8GaZn?= =?us-ascii?Q?PGaZC0Ug9gGcsySOr0mjJ7OpMb4U4msJdLHmbtbvkIBBROgspU3qMU4fLglE?= =?us-ascii?Q?lZ9ggnd7sWfIH4s6rQSmkQntfwdkQfAjpPT4XmtnbVmNjP2yZ8Ev5zMfGz1q?= =?us-ascii?Q?0Cxb0+k22Z+bS7w9+dj8UD4uEt3MeMPiLM8R2gwXJxtcbNWjIeRHSEUxq1AC?= =?us-ascii?Q?zSeN1fdsQ1mcLFsoVWmO02UP6X1robqfsBX3sUrTtv9vGJBK5pVeI22vekWS?= =?us-ascii?Q?TdNdM52xdDf5WQCqIJoo0w4Cx8zMykor/E3EUwQFIDAid1tI3hKzKAdH6QsM?= =?us-ascii?Q?TXjMQpgF8i7O3in+C6JD9AV/rT16Ot+j2U3/0wg+8GVNBlzpIoGvjRhAla4h?= =?us-ascii?Q?LVPTuSPASCHlxF4GLG4cHLvjAJ0mmQ9M9c/MHQcFsgFU/4TDPEzfr4XouAFP?= =?us-ascii?Q?qatl7sM6XxlD3I76pSHWer8HkrGCH3ryaucG7fWFiDlYSfRv/6ghqyrIio4x?= =?us-ascii?Q?E3uRRRQ1DJchTfYyTgX+kByiASZfoHCf/feglzG/8Bnj0GjSmqhYIKSbowpN?= X-MS-Exchange-AntiSpam-MessageData-1: Am/Fue4DB/iyi+ojkoIw/zbavxdOF6sSFKI= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66f61937-2880-4d2d-7955-08da3e25cfba X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:08:54.7569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FGv/1NTK9cnkrTA9PiaXftdFirxlhxWqGXjm7HQLSIW6AZaNrYVL/sIJxkvubc1sEO5y983ZKJcAyel+M2M0EZYijtolep/kLCmPaXoR0XE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR10MB1670 X-TUID: F9ZM1P9hTE5d Am Tue, 24 May 2022 21:00:03 +0200 schrieb Jan Kiszka : > From: Jan Kiszka > > Missing quotes broke the -n test, and as we are at it, also resolve > the shellcheck warnings. > > Fixes: 15214487e19e ("expand-on-first-boot: Add support for > devicemapper") Reported-by: Felix Moessbauer > Signed-off-by: Jan Kiszka > --- > .../expand-on-first-boot/files/expand-last-partition.sh | 4 > ++-- 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > index bb371e9f..8a8b7c98 100755 --- > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > +++ > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > @@ -11,8 +11,8 @@ set -e ROOT_DEV="$(findmnt / -o source -n)" > ROOT_DEV_NAME=${ROOT_DEV##*/} -ROOT_DEV_SLAVE=$(ls -d > /sys/block/${ROOT_DEV_NAME}/slaves/* 2>/dev/null | head -1) -if [ -n > ${ROOT_DEV_SLAVE} ]; then +ROOT_DEV_SLAVE=$(find > /sys/block/"${ROOT_DEV_NAME}"/slaves/* 2>/dev/null | head -1) maybe find /sys/block/${ROOT_DEV_NAME}/slaves/ -mindepth 1 -print -quit -mindepth 1 to loose the * -print -quit to loose the pipe head 1 Henning > +if [ > -n "${ROOT_DEV_SLAVE}" ]; then ROOT_DEV=/dev/${ROOT_DEV_SLAVE##*/} > fi >