From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7101651034648346624 X-Received: by 2002:a5d:4886:0:b0:20d:527:f98b with SMTP id g6-20020a5d4886000000b0020d0527f98bmr4180884wrq.70.1654181247188; Thu, 02 Jun 2022 07:47:27 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:144a:b0:20f:f1e7:c71c with SMTP id v10-20020a056000144a00b0020ff1e7c71cls9893336wrx.0.gmail; Thu, 02 Jun 2022 07:47:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrh6wzMaTmuTqGWKcpilJ/hHXsmDsq+U/flmWAF3UzRjcxVCcUNXFbANpwCg9Ix1U17YuX X-Received: by 2002:a05:6000:156c:b0:210:4a6a:16bb with SMTP id 12-20020a056000156c00b002104a6a16bbmr4091777wrz.245.1654181246182; Thu, 02 Jun 2022 07:47:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1654181246; cv=pass; d=google.com; s=arc-20160816; b=b2ihbDe9ffs1y8Rgs4rxF/TC4Dq/CX3INjS36C+H+i9pHfS+YlTQ8NgS0TVk4Yi3H1 k4iig3F9cfYkcfP/+I1JYBYJ3Mau9nOFWZn9+2rwpoj9whf0gCC7WmWc+phL+p/xsU09 zjJj+/GbXLYMTo1HVe1XgQVm6lMmBdgCgkvlU6OQ4DidkYtb8m0VQn5w2ZCVS7wQjfb/ k8lz1DKTH51x4DJ0tZQBKvQpDe35rU/AD/iO+Dw3F0C1yYQ/oL5/C+U8jK7sb9MRzsL4 NV2t13f1D/vAYqfBN47/JKsVPpTTIUbrD1VLiDMLwpJo7e6f1mPN0Dwk4uX4hq7yXuQ7 Mr5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=elpf0dcdlPvkNjKjavP3qtkmQGse2RqFKzKQYgOdkSA=; b=F2eWfoMIKRV3m0rIdH9VPSa2QQ3ibkXZY2500uFyilwIEZRA/Xq9xlt/cdR2R3gjUc N8irio8HxPR2Y0wP6tiCYR60HWgyBud6RlVvzvumFM3qvopnJNgVsLc5rNKplER4a7T1 Pjw8GdJyUpYl03UnQoUnpklc8lfQIJaKNf4DBuhgBXRZcUN6ZEGiARiRufqjtXG5Sqpc YfP0nz0wYj6dAxs3+kzS+z9dH/XETHgL6QbkNRbZAfErsq1CDdZtEQqi92qMne2aR1Vv RCVLh5KzwM5ZGwR19P4UPHrJ7frrJa+E2gXgefv2O5rccyaVX1+q4WyXbc/DPxCzIESe Fiug== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="lmMkH6/6"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe02::61c as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061c.outbound.protection.outlook.com. [2a01:111:f400:fe02::61c]) by gmr-mx.google.com with ESMTPS id s13-20020a5d424d000000b002102a7531cesi208431wrr.2.2022.06.02.07.47.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jun 2022 07:47:26 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe02::61c as permitted sender) client-ip=2a01:111:f400:fe02::61c; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="lmMkH6/6"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe02::61c as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eSbv1gRXXoXUKqBdHmLVT7ylaG8vpdJdrsH1DAkHY+ewg5/BkNLtLkT+IT1CGf46r5jc6XJbcZNHydzt9hbISwUkA+wa6N/OVa7Kl20pPkFi2IyWvkiWwm8VD38iA9s0y6veRFYXjccQU8jdMlFa8etRznvg3TlrvKLBK48TeNH2KNG5wOI3Sdr2nN1KOK1s6RsZncJhMVo3kETuIEdSgCBPs7BqUL4ss2R2aa2gbNZsaw0za5scjHGIOB7Z0cTYHP/Cmudi1H5mc4iJfklhLwu38H2QiFA4Wqd0v5O48bj0EtwYGvI8OKbJvQ63+7GnutxFgFcSukEfyfoL7y6zUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=elpf0dcdlPvkNjKjavP3qtkmQGse2RqFKzKQYgOdkSA=; b=bqtyc6mBmV1Cd/FJ5UqI2dgJkFJx7DqxB/wOYgJ6+8D+ycwNSB3HiSDQNacTlYTLHQNFdoBPfnIQIASY+wLY8sac0G5FDoeYSwUunQ1h23rNL+AyRzRcgBFB+yWm0fZnaevNBjmMQ2UZQbHhZWYICgc+M7o9qjFM9EKnMUZuVAkCpOwQunmlNPdPYBmfpPGAgaPN1VUGDGDZFRajsks0Ymcu//qJlV5iG10XhxnbmvM1luCh0/9YtumeMKq97kzQ9x12LMvwJfPaa6wTF6kBmYF3WcSTimQmzNJNGQWq5HPDgazNztzqmL7r5lpnDIadgOUNE35dEwFQGRREdLi9eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=elpf0dcdlPvkNjKjavP3qtkmQGse2RqFKzKQYgOdkSA=; b=lmMkH6/6BmykPYe6s2Kx1q/IQGfaxjrl+/1SKJ6NP/sP/US6uo4MZB6v+IHqAx+qEYFw6/y+boGRPZu0CzzU+RcT22l8sGTxVM84HwDy4l2C+EEU4MEw34hBYdZ8hs2tRwU/g0u5OAn41JdBBrYLTafz+CfakGW407EafrYkyGDkUlE/OhEZw6XN9aHgm09Dc5zBqR2YzwwNQ/tO3eOtdRUES1YhSbt8sRyplrdzTUasl+cvP17N/QzwYDOBhPsGo3iIpQaOGgIo53P+NVXC8rVwPYUFSkx5oCWyxM2rpjhHO5x2w4iPlLkaluWs4veSvMwDPFJGnHYFx6/si6qYrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DB6PR1001MB1189.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:62::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.16; Thu, 2 Jun 2022 14:47:25 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::a949:4d67:8108:3599]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::a949:4d67:8108:3599%6]) with mapi id 15.20.5314.013; Thu, 2 Jun 2022 14:47:24 +0000 Date: Thu, 2 Jun 2022 16:47:22 +0200 From: Henning Schild To: Tobias Schmidl Cc: , Joe MacDonald Subject: Re: [PATCH v2 1/1] expand-on-first-boot: Switch from resize2fs to systemd-growfs Message-ID: <20220602164722.71d771d9@md1za8fc.ad001.siemens.net> In-Reply-To: <20220530113737.612324-2-tobiasschmidl@siemens.com> References: <20220530113737.612324-1-tobiasschmidl@siemens.com> <20220530113737.612324-2-tobiasschmidl@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0063.eurprd04.prod.outlook.com (2603:10a6:20b:48b::9) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ef36d9e-4609-4cd3-cc61-08da44a6ce9a X-MS-TrafficTypeDiagnostic: DB6PR1001MB1189:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cw6HOiELZOqinVWxySzGmT1CyaKnzkNw4A5XgyGqU5ANFDuziD9dvOHqNwacBxHoEanFord/JSfkmCv3++8nysLf+2pXE6eJRRWHETTVC+G2THgZyJ/FX7xgZa9UDtmTkjIy2lA5rWk9lD0AYtGHA2yFHTAF5CUbh2E/ZVe2p38H6nT93YkR1dgid5kbw7uq3dSIpBi3XiWPgH7CMZ0/9aDjRHxkTbhYUnKMRETkjncX8PCwzkiw1fJD8VbJl+r84gp5ahuhpiQLuePMnlDKnoGwMiowqBntcRd1SW8fATGYKhj5QDKE5OXWMQHjs3doLn+4x2ruw7nBW4gbupn9VV2PnD08VdKs+V+5bm6yrP0J1ZjJpartRXKVD0JZxkXALBNgOmC6vndSeZeZNmLqgQvOXtSjot+nOoBg2k86kDAj8qc/1NeIxIytJ9CNHPGqWuiXCz6r3tKjNc+rQKTubXb2W0fSdVkB/9tjFbAdPn9j3kDt4Z1GfmHip/uS0WIzk75lksOLim7zcjjz4Pj2/bPr/q4Y8xCKBjm0EXEaqz1ZsXZs8xRcFPvVOyvy58ekOaayPSADJA3YVjdMFiGcS9j7EyynsHS8xIRKJNdWqiHtfM9xFCnMxMLX28q2ilrtadnlQCeOoay/l5Rah7hkoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6862004)(6636002)(6486002)(86362001)(8936002)(66946007)(26005)(6512007)(9686003)(8676002)(2906002)(82960400001)(38100700002)(83380400001)(186003)(5660300002)(508600001)(44832011)(107886003)(1076003)(66556008)(66476007)(316002)(6506007)(4326008)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s1kI+tTzrPu+TmMLJfbFk8nLVBUieV2tovRXWedXTp87+39JNUdasNBe4MFB?= =?us-ascii?Q?Ds2qVE58xl/NKAIZtMIcLd9OxxZUxF1F1GlS7gdx3cdCJRzGuD0pjITMTznO?= =?us-ascii?Q?+tBh8tN9kfXHf8Uqn0r2gynV/twRY6jqhADV52sKITB4ElQw7vx+Hs77t6Ye?= =?us-ascii?Q?Bhg6BlGqrAAA2Sidaw3NAfqQTHMgiP9s5fCqymiEEhYHOgWY9btm92wxQZ+x?= =?us-ascii?Q?ov/mVet9+ESouNdtMAmmLIftq4+KMbGO+swrXOJSGB9SBK7KcxdIf8QGQMhE?= =?us-ascii?Q?tdDMU9C6O4exZX5ef5IYIB9QuzhaW98F5eHIW7sdtdyVCXIpE3wxOd8aIZ/K?= =?us-ascii?Q?nwroZY1TsgK3gHYYhn1NWBaTfhv2wp+bvY5vTDcjqsVuifxIkNezVfuVl7U2?= =?us-ascii?Q?UO72jxsri0V1+SiO3CIIvymctrahftQVLhSlumHdE3UDdIP1tfEa2AO2fCnq?= =?us-ascii?Q?xG05L9OfMe9UpoSsKJqIbAYj9LaP1Y2sbuF7QkescQROBAgnsb3gMe6R5p8V?= =?us-ascii?Q?c1t+ZusDDNcZOgoZ8Van9Lsqapc/toNzYfLKFIuqg6nxFnJ4/5YMtSvkiezd?= =?us-ascii?Q?wJR0MTUbpEZmekLkYMMRpDli/fnmBWL9vYdxKZEAdVnH8UJxwlXCXxbXljx5?= =?us-ascii?Q?RMf+cCOy27wvJbsQ8en6zye+BrcqqeX/AlV6HG5BepOAguRMzEuXnu9bv4TP?= =?us-ascii?Q?Lo6BNM6EepDuy8SI7CEjOQ1OD07cERT0Pmmm4+T9zMfKMmLrjbc57Z4hfg4O?= =?us-ascii?Q?Z8PXSMJ6T0mcr+dPCC81qD1LxAxVbkKjPOZMs6HN1Z19tshU+rGIKhPHGTsy?= =?us-ascii?Q?FcG6w52HDRXJtVdIU/cTrqYUSHErBRKJdW2+6pzkBlz+BfopJyFizPJt8nGQ?= =?us-ascii?Q?505byOM76T+ZrNC6EXxoziVYnoAgmKvuw4T1YsiozwEWfkFNEMoBb+jFx+HG?= =?us-ascii?Q?lOA/TTbH0HbtSpftzagMv+Q5PbOK2Z7qtbzqCFmtHdN45wnOAAwP3q62Ze48?= =?us-ascii?Q?FYefLKG/8OCfha/MJvacnSZiuKEC9aHT4ZwvdTo96c615A2BbTN373WtjKvl?= =?us-ascii?Q?xzfaSBGXRBr5F4MXiQ0ifZzXZ4dUCmkzbEcZGGZWbjTZkdYuA4Zs4IdIAlaB?= =?us-ascii?Q?yADFZQASrhG/FkiW2qvA3r96pI0lQdbjy3HD4nzQK9v67xPiMdsXmJefymh+?= =?us-ascii?Q?gVpA/6ERonFLrhuzb4EuZSb6g4uunmw12PK16UA4U2xj3Ji2Y90hqM6qFIFO?= =?us-ascii?Q?CV7wMUa/cJ/93PKFB0+wYxXuen6aDS0hYsBmqB83avCDb5WX1Mq0CIlNAHv0?= =?us-ascii?Q?TDR09svcEjtxxCdFcFSXjkL33X9wFQgF/COsIpufSNJLaF+sf3oo34WKCLzG?= =?us-ascii?Q?Nl+6vwFrUrc93HWROZvHGUMoc/1/D/SgJQku6dsJj2h1huGW7GyatSq35qMG?= =?us-ascii?Q?LL0ZeTZtmXMXDQ8CkWWjcujs6CQCUUjekG6GaemEtcF1LyHUYUIzxaqUa6Uu?= =?us-ascii?Q?NuSC/pjl/h+q5wRnzJuwa0enKDghW20L1GqemOLUVrAqxBD8IuHEziBAAtSN?= =?us-ascii?Q?/zDMr4YVSolcE2Ib3jtFSJHLOacOtrrRi3HlpVNezMsGcNuMWyhVSVEwrTrq?= =?us-ascii?Q?9mKdKrhLQHIdd5lwMXvCewKScU3m1yQx0lyCG2S/FwsxVuw8CEj8mDFgiq6S?= =?us-ascii?Q?P8Cz83MDc+4UztzX8XkakqNeGvfhl60zztMgf3UYlcl/lffN78o+uAhgqEDB?= =?us-ascii?Q?Oxb6paCQtV+gOPLH6vrJOlxTxBKCkI+36Fx9yK8ELWWlSEfCD90i?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ef36d9e-4609-4cd3-cc61-08da44a6ce9a X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 14:47:24.8951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iohZVn2qO1MttteWY9Q/oL1N2dAfi1cTQL0xH3TFtg5jTREPlJD43qKDUF5OWB3uJgA23a7uAVjDEPtgcmHui8XvZassii3P6ymMir3YR/U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR1001MB1189 X-TUID: j+aDQIGHhEUp Am Mon, 30 May 2022 13:37:37 +0200 schrieb Tobias Schmidl : > We want to be more versatile in our approach of resizing the last > partition. Therefore we switch from resize2fs to systemd-growfs. > > This allows for ext4, btrfs, xfs, and dm-crypt partitions to be > resized. > > Since systemd-growfs landed in v236, this obsoletes > expand-on-first-boot on stretch (v232). > > Signed-off-by: Tobias Schmidl > --- > .../expand-on-first-boot/expand-on-first-boot_1.1.bb | 5 +++-- > .../files/expand-last-partition.sh | 10 > ++++++++-- 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git > a/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb > b/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb > index 1703a64..09ff234 100644 --- > a/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb > +++ > b/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb > @@ -1,15 +1,16 @@ # Resize last partition to full medium size on fist > boot # # This software is a part of ISAR. -# Copyright (c) Siemens > AG, 2018 +# Copyright (c) Siemens AG, 2018-2022 > # > # SPDX-License-Identifier: MIT > > inherit dpkg-raw > > DESCRIPTION = "This service grows the last partition to the full > medium during first boot" +MAINTAINER = "isar-users > " > -DEBIAN_DEPENDS = "systemd, sed, grep, coreutils, mount, e2fsprogs, Maybe e2fsprogs can be dropped now? If not ... maybe we need to add something here to really enable btrfs? Henning > fdisk, util-linux" +DEBIAN_DEPENDS = "systemd (>=236), sed, grep, > coreutils, mount, e2fsprogs, fdisk, util-linux" > SRC_URI = " \ > file://expand-on-first-boot.service \ > diff --git > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > index bb371e9..37e94ca 100755 --- > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > +++ > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > @@ -3,7 +3,7 @@ # Resize last partition to full medium size # # This > software is a part of ISAR. -# Copyright (c) Siemens AG, 2018 > +# Copyright (c) Siemens AG, 2018-2022 > # > # SPDX-License-Identifier: MIT > > @@ -45,4 +45,10 @@ partx -u "${LAST_PART}" > # when using systemd mount units. > export EXT2FS_NO_MTAB_OK=1 > > -resize2fs "${LAST_PART}" > +MOUNT_POINT=$(findmnt "${LAST_PART}" -o target -n) > +if [ -z "$MOUNT_POINT" ]; then > + echo "Cannot find mount point for ${LAST_PART}" > + exit 1 > +fi > +mount "${MOUNT_POINT}" || true > +/lib/systemd/systemd-growfs "${MOUNT_POINT}"