From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7101651034648346624 X-Received: by 2002:a05:6000:1682:b0:20e:6de0:a566 with SMTP id y2-20020a056000168200b0020e6de0a566mr4893470wrd.91.1654199779236; Thu, 02 Jun 2022 12:56:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:4f0e:b0:396:fee5:f6f1 with SMTP id l14-20020a05600c4f0e00b00396fee5f6f1ls97021wmq.1.gmail; Thu, 02 Jun 2022 12:56:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAiplJEYQ1RjXK7ktkZ20IB4jiwYPWycDSKwhZ7r2tfHz2A8Iyadf410JmmXKN5dXldoTJ X-Received: by 2002:a05:600c:28cb:b0:397:6493:379f with SMTP id h11-20020a05600c28cb00b003976493379fmr5597215wmd.6.1654199778256; Thu, 02 Jun 2022 12:56:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1654199778; cv=pass; d=google.com; s=arc-20160816; b=MMoOLWDEwBjq/FFCj/J1H3M8vrl75pZWGBD0frWFrk52ReFIKjFGR18NmD2pzN6gTv Cer6pSxhUAQBhYZl2pG7kZLmbThCVckDNAEod4i2tp1bi+jKtHjXhH7QYw7hEXxNbUQ+ U/rRnc2V4GNxkllUah0wUpuQYwkkMVk4ikSKnWA1LDqxjdSfcT1TybYuS2uzl13zn7aY nCe9Tr3LMmsg9+sVDl+0FX3ItR7MrCT8EKEab0xDYFgUQ5jnJ0UO3b+jyd8Tkgqbry8t v9bFW1r5PVJoqoFbAhUvtXAntPuXBswUBuqQA+I9s/QaQwS9HQFIg32ZpsiQGahrQM8F 9cbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=Kkc8r7trRIlO+bEbPE6fHmctLU3Q4nH7GgesvUyVcfk=; b=iFIcR8XHCg5Jf1qK2oIRlilOrhhgWN4nwK7XCRRKkThmvJ0ryqsEstrqew6CgWWwZy Zm5/iyQLh8LyQhhNpKizzFwiVw+GZgnW4TP/W8MaloGgXRGp4BTQAy1pgXji8nonGitX +RbgqusAiPjNCdcwrI0Vb4Z4tF9kgHuDLjtQbyLZ4IBCgU5xx1/TrNfZsXDHgvHesHzU rZ6UOu+1TNtcSMneIzjF2hmnzaPvYQlEyowbW14fpy8io23DQ7/bm+Blr4hi7xLtKFOr i+1YUf3CinUBLhNvqIC4EHmnjTuZyIxgN9JJpjk+1esr6e/hqd+vcpkq70xCWc0+v9rl ro7g== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=dbBdvHkw; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe09::623 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on0623.outbound.protection.outlook.com. [2a01:111:f400:fe09::623]) by gmr-mx.google.com with ESMTPS id p7-20020a1c5447000000b0039c234694d0si275559wmi.1.2022.06.02.12.56.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jun 2022 12:56:18 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe09::623 as permitted sender) client-ip=2a01:111:f400:fe09::623; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=dbBdvHkw; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe09::623 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j5yIQZTRs1bdvwd664+yLg+KJxtRFt7Lw2mt0Pnlg1hsVpj1IppV4LXnJiZ5KkqhU7MPP2jDOJR/+roUal6DkVWbhKdRVLCfeJpWDfllJ6gdaR2CpzcZXeYsRRtVESKe+4XoEYqn7rnXKR7t991BGbzqrwTbIxsNoajQrY7eCfzV4HfEeJhchIHc7PkTwqrQt369tSBtFI0PyRXKnvC8a99T1jGHEApvch6hP+nuIABrhQ9BStE4hXwvOA7CEVysThCyHynriOyh0iBliUVU8dHte+tw9VMsHSTnRIefDVKJk0BcoD537lxyQ7/aOunAiNJIHrfmgoRoQe83blzBMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kkc8r7trRIlO+bEbPE6fHmctLU3Q4nH7GgesvUyVcfk=; b=QudAn7StdEXYFYHD5XsYJ4qAWIpVn9Put5k4Ue6YFEfqVD5PegMWy2Q4s1RYuJSJuLVsr2uOaLlokeRXmNC/BcdYmxAujahAcN0I5M2hucwRw2NWcUP/gTuM/rWLd5mHLxFkTePbcGyeieHkjnqlo8T+oC7fhn0GybsgYWM+uLNYLoI0ZdbPRn8wDFWb/vIJYl0hxvApiB2/WZWjBIaZQBez9dCYMGb7pIYhdgP3uQshr3ei691RwHXYnaik8wqvmm6hM4wjVM9jRK1NQvEouR8sZnbEl1fwiPYGD6P+Q2041XvpLp7mmXQlu4vAsp4Hf3G90rX2U0qxRwgi4g1qsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kkc8r7trRIlO+bEbPE6fHmctLU3Q4nH7GgesvUyVcfk=; b=dbBdvHkwt/YDlt8RfuPztq6q0rmtBbk342Do4UwL1TMbM3J581d75EyI+hslKe6VHryRZs4xLvkEhR+YzEggqE38otgt3+wDtm897cSq1O9yHiADweNPDf6/fU3Ac85/kykA5SwwXsVphGsuFJma6t9nCx1639XbdIWXuGmHfhhz72zNc+TViziWutpCHXdRIrKdlccsuyOQ4zapHNsL5Blpwr+TRRTjIFmRcQScdDvk5O58671u0eixuAsnjKjNb1tC9Yws4SaBJr70PsWxKJ9tuW9R1lM9mJr1E9L2hp/LCsQTfBihJgCvcTMNGlj9OPMD5j28QS0oWf6yIxdJpw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AM0PR10MB2465.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Thu, 2 Jun 2022 19:56:17 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::a949:4d67:8108:3599]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::a949:4d67:8108:3599%6]) with mapi id 15.20.5314.013; Thu, 2 Jun 2022 19:56:16 +0000 Date: Thu, 2 Jun 2022 21:56:13 +0200 From: Henning Schild To: Tobias Schmidl Cc: , Joe MacDonald Subject: Re: [PATCH v3 1/1] expand-on-first-boot: Switch from resize2fs to systemd-growfs Message-ID: <20220602215613.7ff436cd@md1za8fc.ad001.siemens.net> In-Reply-To: <20220602194600.748443-2-tobiasschmidl@siemens.com> References: <20220602194600.748443-1-tobiasschmidl@siemens.com> <20220602194600.748443-2-tobiasschmidl@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0502CA0009.eurprd05.prod.outlook.com (2603:10a6:203:91::19) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4c5552b-7a4f-4c92-dd06-08da44d1f487 X-MS-TrafficTypeDiagnostic: AM0PR10MB2465:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SNFfs5Sz446WxKEfJKHAWLooElVauLWKYV6QRel1/coBNZav6gUnLspsEGhz1ylIetzrWlaX2kLXCTD+1XyJ4xebrZ9pygwVCucxd+ykgznt7ddo4gI6mUueu8ob4/9/fNJ4tc8Yv4mlu0drTivfN1+2WfaG9PJpHv4yTscr8wf7BBawGE24a4Kv8wYHLGvr1Jfbn7PlRxORPvj3VttVf99bxNRjfXOdiq9uwG/1XEhJWufPvwfNyhiY+0Bn9VDLBX+3wMIPqvMmlI13fDRo6Fb7PlnLnbF+d6SIXuupQdlxlbVPOoBjddbiXz8MtlE+YM1z0mmaHsp8kUsRYUes6YeGjODgXhO/JoiHF6K3ZX1z5ZDjT4uA0DtPkWBtBt8Mmr8MEe+7cxIhcwo7GFc4gbIKFMZpDKH7XBH1ku2YPGSPziTS3GGZXwwkQvNrKmuOlSktWG8gzgcC+M6P5QK0T9/jDx/EvQNEEsblB1b9Xhpn3qwZX7qCiZfntqIkXjMSlpx3IrRg4Gd6hFBY7CO3I7FtbNlSuB9GTq66+2JTzC+OXXACKnTJX0CRDX06bTOszZ+0PXoM6NNn8mLN+1RNNkartvFCqNj/2hPvno/w4BbNSvxVzLNCLKPDCpfpgAvRZoznoc4XwCV3fRKBzutxIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(5660300002)(66946007)(6862004)(66476007)(66556008)(4326008)(44832011)(508600001)(6636002)(316002)(54906003)(86362001)(6506007)(9686003)(6666004)(6512007)(38100700002)(82960400001)(186003)(8676002)(1076003)(107886003)(83380400001)(2906002)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y6NEhjdhq5AhLKt4jraXswhX8NWc+cWP4kTYTIdxoUFqg8cMSCCDdTkorJ0Z?= =?us-ascii?Q?VgCL7UPuCEo6UxYHUBYwwgrNJgF8zUn6pA1Urn26r/1e71wzWJbn4MFZ15WG?= =?us-ascii?Q?7un2L/MPatBGEUOGc/+mY5VpQqnEQs045/+tMVjen7cbr1suTgMK9magtFnS?= =?us-ascii?Q?sz8xVWsv/zoaNCKKb30XipHolnwbw7VrgdeI8x5yZ/E5RSOyJu7B1ib1Z/qI?= =?us-ascii?Q?IckGDTVArpE+Uu2mGc20Zfojn0bl24VXvj3SyPkarfkhqIDd980+OYRFYCQv?= =?us-ascii?Q?/6axB8wuHKaVvRkzp6S7YJV+o6PJX4qmQHXDysoyTJz4oJ1C9ZNlwo0mEn2d?= =?us-ascii?Q?jVdbs0ToflwR7ATJcCnP3F/mHJ2R04MiJC4OZbl16mlNM55hOvTSVcZuZd+w?= =?us-ascii?Q?yR4eVBT+qNqwI1H3Dz8oTPG7pYV1INKlPMpMbFhTdr8z+VwWYlIab61Yihs0?= =?us-ascii?Q?rXP/xvnO57JY+FovYJTul9Ek64djpN4WgbCQwdDet+80O1JUquxKmmD4VluQ?= =?us-ascii?Q?bRXx+E9uRQfn8PgmWr9QfZfxpkbTCrswl1+BVSzwxZ5fuC95ZuyuTvLdG7G5?= =?us-ascii?Q?4jZ3VbAl72innbmlGYGC3R50GkfOpC8p0tVp1cMgmlg+6NnO+Cd1ttj9F39I?= =?us-ascii?Q?ETqtXSGCZKfz9Yq6xOVuUqJdhh+YIh6ZEob8scvhi238/DF54FxgH2ETlvyj?= =?us-ascii?Q?t8pqpCN20pS+KbN+SwcErqOyBiyNMmNWT0IbQonWh4zIyy2+uq11jg3FBzhp?= =?us-ascii?Q?Dw7Q9ux90+Q5NDywe81P0S7dEyXsDzJj7rnW88mZSYWNbBhw0nmOvB1M/hLM?= =?us-ascii?Q?qXv/NDpwIWdhcG76suHr2jtc6CkZhM1YEHfvR9oBN2fzwFGib7WlDziNHxYe?= =?us-ascii?Q?mE/RWjVTuY4xO1j+9brdGgGZ13mIRlQh/T1R+S8P6YRW2mTqNLrGnUvoREAw?= =?us-ascii?Q?jyzCGPOvWF8Cnn6GjNYpSXVcTVA9cp2i/V9+bzV4m4GAA6zYEFG4rtiow9fk?= =?us-ascii?Q?5eTebviC82jRlM6v6FcFayomsEOa3uJwSrbACQtaH6aOcljrtmfG1twAoPM6?= =?us-ascii?Q?yeztzNB0dpr+FottxwvgGyOo8aMMQyeIfl9awGmnxaSQ8mp+q41RGY+oJQQB?= =?us-ascii?Q?wvoIiXzQnWJ+Nclhe3k4OeGtJnsOn05LWs3ymKcaPEzgjgt6yLpvRuDfsAr1?= =?us-ascii?Q?5kUR8WMOBvmRvMNHcnzWRG60QCMcOBjD6w+ymq7fmait5XsEh1mF8aeEV1jE?= =?us-ascii?Q?mln6lyxVTez4XNyYUUwvnItzhqVx8dDQ70an+unqDJtyPNk0B9EnPs0qN9Wb?= =?us-ascii?Q?5zumC9pvxh6eFIqQQtX7kevep1+3u7zvsrBoRz5hPpcafJ7C0gZSpOgSPIpv?= =?us-ascii?Q?rpC4/ej32SiOKGGyG+GT3pZ62cqqr5DtYckRpuQoCaoTabrPgWPKMbpN6MOL?= =?us-ascii?Q?IlfIAkilmvxODxkNUiHoT4vQBltfZ/Z07dRxcEPljA4NEtIij7AE8rFV8mFp?= =?us-ascii?Q?1xBresLKwFBFvRW2y2xi54IpS/GP8X2G5yBJNZmHd3bg68nVEb7PzDbcbbeB?= =?us-ascii?Q?/r0lFFw6mNXhdUEHHTsxDZr1+hsoig8tFilCxUKxg65KGz+yOsGCuHvdMtWT?= =?us-ascii?Q?k0OAvfkRvpvmMp13EDw2LzXNnJi9IfHtFzIFmm9mbg3b3NpHhpcDkj/JbcyJ?= =?us-ascii?Q?WaHAqK1geqYu1XuuVgkMa1NHXQvB4g7Pz2EX82jWWmoE/vPDILmakDqf2IBh?= =?us-ascii?Q?A6wmC/II9zfHX9kiYdptIuiRz/gdwZWbZCPWKRjOPAkRq3T3B7x9tJ00B3WY?= X-MS-Exchange-AntiSpam-MessageData-1: Qt4f8Tzld23i6M59lN1qpVVfiXWa/6r2eK0= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4c5552b-7a4f-4c92-dd06-08da44d1f487 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 19:56:16.9150 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mwYWMXzPiJKtzfKmA/ud81QfH+BivG3Ue4NHxJ3KyBmlgppvkJYtKseOa4F8eOUOoCo0E/5k3vcUZlOt/2YBAAfjlQb1O1awvV7lIXfxrPg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2465 X-TUID: gq+opBEwCkRd Am Thu, 2 Jun 2022 21:46:00 +0200 schrieb Tobias Schmidl : > We want to be more versatile in our approach of resizing the last > partition. Therefore we switch from resize2fs to systemd-growfs. > > This allows for ext4, btrfs, xfs, and dm-crypt partitions to be > resized. LGTM! We are missing resize test cases, we always have been. I assume you did test all the filesystems listed here somehow manually. At some point in the future we might really want those resize test cases with several wks files to make sure it works and works for all the filesystems we do care about. Probably extX and btrfs to start with. Thanks! Henning > Since systemd-growfs landed in v236, this obsoletes > expand-on-first-boot on stretch (v232). > > Signed-off-by: Tobias Schmidl > --- > ...n-first-boot_1.1.bb => expand-on-first-boot_1.2.bb} | 5 +++-- > .../files/expand-last-partition.sh | 10 > ++++++++-- 2 files changed, 11 insertions(+), 4 deletions(-) > rename > meta/recipes-support/expand-on-first-boot/{expand-on-first-boot_1.1.bb > => expand-on-first-boot_1.2.bb} (78%) > > diff --git > a/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb > b/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.2.bb > similarity index 78% rename from > meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb > rename to > meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.2.bb > index 1703a64..48d30d3 100644 --- > a/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb > +++ > b/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.2.bb > @@ -1,15 +1,16 @@ # Resize last partition to full medium size on fist > boot # # This software is a part of ISAR. -# Copyright (c) Siemens > AG, 2018 +# Copyright (c) Siemens AG, 2018-2022 # > # SPDX-License-Identifier: MIT > > inherit dpkg-raw > > DESCRIPTION = "This service grows the last partition to the full > medium during first boot" +MAINTAINER = "isar-users > " > -DEBIAN_DEPENDS = "systemd, sed, grep, coreutils, mount, e2fsprogs, > fdisk, util-linux" +DEBIAN_DEPENDS = "systemd (>=236), sed, grep, > coreutils, mount, fdisk, util-linux" > SRC_URI = " \ > file://expand-on-first-boot.service \ > diff --git > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > index bb371e9..37e94ca 100755 --- > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > +++ > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > @@ -3,7 +3,7 @@ # Resize last partition to full medium size # # This > software is a part of ISAR. -# Copyright (c) Siemens AG, 2018 > +# Copyright (c) Siemens AG, 2018-2022 > # > # SPDX-License-Identifier: MIT > > @@ -45,4 +45,10 @@ partx -u "${LAST_PART}" > # when using systemd mount units. > export EXT2FS_NO_MTAB_OK=1 > > -resize2fs "${LAST_PART}" > +MOUNT_POINT=$(findmnt "${LAST_PART}" -o target -n) > +if [ -z "$MOUNT_POINT" ]; then > + echo "Cannot find mount point for ${LAST_PART}" > + exit 1 > +fi > +mount "${MOUNT_POINT}" || true > +/lib/systemd/systemd-growfs "${MOUNT_POINT}"