From: Tobias Schmidl <tobiasschmidl@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Joe MacDonald <joe.macdonald@siemens.com>,
Tobias Schmidl <tobiasschmidl@siemens.com>
Subject: [PATCH v5 1/1] expand-on-first-boot: Switch from resize2fs to systemd-growfs
Date: Thu, 30 Jun 2022 15:55:31 +0200 [thread overview]
Message-ID: <20220630135531.717696-2-tobiasschmidl@siemens.com> (raw)
In-Reply-To: <20220630135531.717696-1-tobiasschmidl@siemens.com>
We want to be more versatile in our approach of resizing the last
partition. Therefore we switch from resize2fs to systemd-growfs.
This allows for ext4, btrfs, xfs, and dm-crypt partitions to be resized.
Since systemd-growfs landed in v236, this obsoletes expand-on-first-boot
on stretch (v232).
Signed-off-by: Tobias Schmidl <tobiasschmidl@siemens.com>
---
...oot_1.1.bb => expand-on-first-boot_1.2.bb} | 5 +++--
.../files/expand-last-partition.sh | 19 +++++++++++++++++--
2 files changed, 20 insertions(+), 4 deletions(-)
rename meta/recipes-support/expand-on-first-boot/{expand-on-first-boot_1.1.bb => expand-on-first-boot_1.2.bb} (78%)
diff --git a/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb b/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.2.bb
similarity index 78%
rename from meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb
rename to meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.2.bb
index 1703a64..48d30d3 100644
--- a/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.1.bb
+++ b/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.2.bb
@@ -1,15 +1,16 @@
# Resize last partition to full medium size on fist boot
#
# This software is a part of ISAR.
-# Copyright (c) Siemens AG, 2018
+# Copyright (c) Siemens AG, 2018-2022
#
# SPDX-License-Identifier: MIT
inherit dpkg-raw
DESCRIPTION = "This service grows the last partition to the full medium during first boot"
+MAINTAINER = "isar-users <isar-users@googlegroups.com>"
-DEBIAN_DEPENDS = "systemd, sed, grep, coreutils, mount, e2fsprogs, fdisk, util-linux"
+DEBIAN_DEPENDS = "systemd (>=236), sed, grep, coreutils, mount, fdisk, util-linux"
SRC_URI = " \
file://expand-on-first-boot.service \
diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
index c0edde7..31f1ae3 100755
--- a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
+++ b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
@@ -3,7 +3,7 @@
# Resize last partition to full medium size
#
# This software is a part of ISAR.
-# Copyright (c) Siemens AG, 2018
+# Copyright (c) Siemens AG, 2018-2022
#
# SPDX-License-Identifier: MIT
@@ -45,4 +45,19 @@ partx -u "${LAST_PART}"
# when using systemd mount units.
export EXT2FS_NO_MTAB_OK=1
-resize2fs "${LAST_PART}"
+if grep -q x-systemd.growfs /etc/fstab; then
+ echo "Found x-systemd.growfs option in /etc/fstab, won't call it explicitly." >&2
+ exit 0
+fi
+
+# mount $LAST_PART out of tree, so we won't conflict with other mounts
+MOUNT_POINT=$(mktemp -d -p /mnt "$(basename "$0").XXXXXXXXXX")
+if [ ! -d "${MOUNT_POINT}" ]; then
+ echo "Cannot create temporary mount point ${MOUNT_POINT}." >&2
+ exit 1
+fi
+
+mount "${LAST_PART}" "${MOUNT_POINT}"
+/lib/systemd/systemd-growfs "${MOUNT_POINT}"
+umount "${MOUNT_POINT}"
+rmdir "${MOUNT_POINT}"
--
2.36.1
next prev parent reply other threads:[~2022-06-30 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 13:55 [PATCH v5 0/1] " Tobias Schmidl
2022-06-30 13:55 ` Tobias Schmidl [this message]
2022-06-30 15:03 ` [PATCH v5 1/1] " Henning Schild
2022-06-30 16:41 ` Joe MacDonald
2022-07-01 7:33 ` Henning Schild
2022-07-06 17:58 ` Joe MacDonald
2022-06-30 15:05 ` [PATCH v5 0/1] " Henning Schild
2022-06-30 16:36 ` Joe MacDonald
2022-07-01 7:43 ` Henning Schild
2022-07-20 12:38 ` Schmidl, Tobias
2022-09-28 10:07 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630135531.717696-2-tobiasschmidl@siemens.com \
--to=tobiasschmidl@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=joe.macdonald@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox