Warning: bookworm support broken due to systemd packet split

Warning: bookworm support broken due to systemd packet split

[Bezdeka, Florian]

Hi all,

when trying to update one of my internal targets from Debian bullseye
to bookworm I was surprised that the build was failing with the
following wic failure:

| Traceback (most recent call last):
|   File "/work/isar/scripts/wic", line 547, in <module>
|     sys.exit(main(sys.argv[1:]))
|   File "/work/isar/scripts/wic", line 542, in main
|     return hlp.invoke_subcommand(args, parser, hlp.wic_help_usage, subcommands)
|   File "/work/isar/scripts/lib/wic/help.py", line 83, in invoke_subcommand
|     subcmd[0](args, usage)
|   File "/work/isar/scripts/wic", line 222, in wic_create_subcommand
|     engine.wic_create(wks_file, rootfs_dir, bootimg_dir, kernel_dir,
|   File "/work/isar/scripts/lib/wic/engine.py", line 190, in wic_create
|     plugin.do_create()
|   File "/work/isar/scripts/lib/wic/plugins/imager/direct.py", line 98, in do_create
|     self.create()
|   File "/work/isar/scripts/lib/wic/plugins/imager/direct.py", line 182, in create
|     self._image.prepare(self)
|   File "/work/isar/scripts/lib/wic/plugins/imager/direct.py", line 360, in prepare
|     part.prepare(imager, imager.workdir, imager.oe_builddir,
|   File "/work/isar/scripts/lib/wic/partition.py", line 183, in prepare
|     plugin.do_prepare_partition(self, srcparams_dict, creator,
|   File "/work/isar/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py", line 419, in do_prepare_partition
|     for mod in [x for x in os.listdir(kernel_dir) if x.startswith("systemd-")]:
| FileNotFoundError: [Errno 2] No such file or directory: '/build/tmp/work/debian-bookworm-amd64/talker-qemuamd64/1.0-r0/rootfs/usr/lib/systemd/boot/efi/'


It turns out that the systemd package is now split into different
packages, so the systemd-boot stuff that we use in the ISAR wic plugin
was moved into the systemd-boot-efi packet. With that we now have
additional dependencies. The systemd-boot stuff is no longer installed
"automatically".Debian changelog: 

systemd (251.2-3) unstable; urgency=medium

  systemd-boot has been split into a separate package.
  This new systemd-boot package will not be installed automatically on
  upgrades. If you are using systemd-boot, please install this new
  package manually.

  The default boot loader in Debian is grub2. If you have not set up
  systemd-boot manually, no action is required on your side.

 -- Michael Biebl <biebl@debian.org>  Wed, 08 Jun 2022 21:49:47 +0200


Why does the ISAR CI system not report that? We should really make sure
that Debian testing / bookworm is tested properly.

How to fix that? Similar to the SYSLINUX_BOOTLOADER_INSTALL stuff but
with IMAGE_PREINSTALL instead of IMAGER_INSTALL? It's a combination of
distribution (package name) and machine configuration (WKS file
selection).

Best regards,
Florian

Re: Warning: bookworm support broken due to systemd packet split

[Baurzhan Ismagulov]

On Wed, Jul 06, 2022 at 08:54:11AM +0000, Bezdeka, Florian wrote:
> Why does the ISAR CI system not report that? We should really make sure
> that Debian testing / bookworm is tested properly.

Thanks for the report, we'll check but as always, patches are welcome.

With kind regards,
Baurzhan

Re: Warning: bookworm support broken due to systemd packet split

[Henning Schild]

Am Wed, 6 Jul 2022 10:54:11 +0200
schrieb "Bezdeka, Florian (T CED SES-DE)" <florian.bezdeka@siemens.com>:

> Hi all,
> 
> when trying to update one of my internal targets from Debian bullseye
> to bookworm I was surprised that the build was failing with the
> following wic failure:
> 
> | Traceback (most recent call last):
> |   File "/work/isar/scripts/wic", line 547, in <module>
> |     sys.exit(main(sys.argv[1:]))
> |   File "/work/isar/scripts/wic", line 542, in main
> |     return hlp.invoke_subcommand(args, parser, hlp.wic_help_usage,
> subcommands) |   File "/work/isar/scripts/lib/wic/help.py", line 83,
> in invoke_subcommand |     subcmd[0](args, usage)
> |   File "/work/isar/scripts/wic", line 222, in wic_create_subcommand
> |     engine.wic_create(wks_file, rootfs_dir, bootimg_dir, kernel_dir,
> |   File "/work/isar/scripts/lib/wic/engine.py", line 190, in
> wic_create |     plugin.do_create()
> |   File "/work/isar/scripts/lib/wic/plugins/imager/direct.py", line
> 98, in do_create |     self.create()
> |   File "/work/isar/scripts/lib/wic/plugins/imager/direct.py", line
> 182, in create |     self._image.prepare(self)
> |   File "/work/isar/scripts/lib/wic/plugins/imager/direct.py", line
> 360, in prepare |     part.prepare(imager, imager.workdir,
> imager.oe_builddir, |   File
> "/work/isar/scripts/lib/wic/partition.py", line 183, in prepare |
> plugin.do_prepare_partition(self, srcparams_dict, creator, |   File
> "/work/isar/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py",
> line 419, in do_prepare_partition |     for mod in [x for x in
> os.listdir(kernel_dir) if x.startswith("systemd-")]: |
> FileNotFoundError: [Errno 2] No such file or directory:
> '/build/tmp/work/debian-bookworm-amd64/talker-qemuamd64/1.0-r0/rootfs/usr/lib/systemd/boot/efi/'
> 
> 
> It turns out that the systemd package is now split into different
> packages, so the systemd-boot stuff that we use in the ISAR wic plugin
> was moved into the systemd-boot-efi packet. With that we now have
> additional dependencies. The systemd-boot stuff is no longer installed
> "automatically".Debian changelog: 
> 
> systemd (251.2-3) unstable; urgency=medium
> 
>   systemd-boot has been split into a separate package.
>   This new systemd-boot package will not be installed automatically on
>   upgrades. If you are using systemd-boot, please install this new
>   package manually.
> 
>   The default boot loader in Debian is grub2. If you have not set up
>   systemd-boot manually, no action is required on your side.
> 
>  -- Michael Biebl <biebl@debian.org>  Wed, 08 Jun 2022 21:49:47 +0200
> 
> 
> Why does the ISAR CI system not report that? We should really make
> sure that Debian testing / bookworm is tested properly.

Depending on which WKS you choose you might have to install certain
things in buildchroot or even in the image. In the case of systemd we
have nothing prepared because we just assume that people will likely
use systemd and the binary will be in the rootfs.

At least the wic error message it pretty easy to understand.

Bootloader variants are tested somehow spread over the many distros but
not for each distro. If we had more CI power yes we could test all
combinations. When people contribute new plugins or wks files we ask
them to change at least one distro so we have basic coverage in CI.

> How to fix that? Similar to the SYSLINUX_BOOTLOADER_INSTALL stuff but
> with IMAGE_PREINSTALL instead of IMAGER_INSTALL? It's a combination of
> distribution (package name) and machine configuration (WKS file
> selection).

We could think about a SYSTEMD_BOOT_BOOTLOADER_PREINSTALL where we even
have "systemd" itself listed or say something like "systemd < 251 ||
systemd-boot"

Thanks for the heads up.
Henning

> Best regards,
> Florian
> 
>