From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7117657722680508416 X-Received: by 2002:a2e:b602:0:b0:25b:b233:8cb with SMTP id r2-20020a2eb602000000b0025bb23308cbmr25846839ljn.425.1657209439216; Thu, 07 Jul 2022 08:57:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:b8a:b0:448:3742:2320 with SMTP id b10-20020a0565120b8a00b0044837422320ls70212lfv.1.gmail; Thu, 07 Jul 2022 08:57:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tXOLjcA7ypUAj6Oejvd9vuQHUx5tBCRIC6cabMjoo+lFYsuHQOXIc3/ggClubrPV7TVJoS X-Received: by 2002:a05:6512:3b21:b0:47f:665a:bf50 with SMTP id f33-20020a0565123b2100b0047f665abf50mr31093022lfv.673.1657209438183; Thu, 07 Jul 2022 08:57:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657209438; cv=pass; d=google.com; s=arc-20160816; b=tQqaWe853ryPhgcYSyIGC1j/YX+4YRjNAJY3W/ot3LRB0auL9raXjFPRrmAQhJ8Hjq Li9unC8A8hkmSI7vnX7IPU+th0tBS1oo3i1RJLYggkgwIPsIi5syqnB142YjR0PAmzDc A8OZuKTK4QZ8+VaU8NLhW1Os1EEAyDvqGWpCOafFs8Ho9izGt41Px9pBI8ZCubHEa79d OV++bj+fvJPZbSOTENxeAPiydFGqnXiaCP86LCdhPPG963UNpDLKBy4sT9JoEWpIUdoS riGfhh17UYpbIPd2zl1ccp+Ttz8ZL/MmpiT0GBLpPP8COSUBvt1o4e12BjcCrlX6CsAF IJeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=giNszHklEMrq7wJb41h8QegunjfWH5ZRAm/sixBE4gg=; b=i+CuP5Ukm7dMNokMizpSp1uxRLc+0MzDCzXetG4zx07C0+NU4ZWeEe+KL+s/uYa/G2 3ij6sJYJT5JS9ZMf/aRfRsVJFki6FUCNfsSxuhfzSSttS1xrC29RUimdF9qaZF4l+ydG wLYyEipah0iS3n+5ULEDV9lcieHZON4s7cpZ24ZuzAIvKt3ZVFw/7aSVINi3TLhtA1A3 XP+sMQINGVM+HpZNgq4PwPLdhYk8BoVY8R/76tdH0aAUmQtAvBK+S+b5qtQGuO2MwJNI rqXU0SnyMJ/gGy4sLYX7DfhCpQ6pvubpg4ENHy7G8xSwm3mgG3z09XhCzszOUkOIharO qUYQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=vUhBYPG3; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.13.45 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130045.outbound.protection.outlook.com. [40.107.13.45]) by gmr-mx.google.com with ESMTPS id u17-20020a197911000000b0047fae47ce32si1514394lfc.9.2022.07.07.08.57.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jul 2022 08:57:18 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.13.45 as permitted sender) client-ip=40.107.13.45; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=vUhBYPG3; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.13.45 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UqOr6bGf1jVRJKJHyhrMxjigOpqI+5yqKxaYs+CVcuS1xT7FtUjTOP7hFE94TuetjnMqkdtDzBVMh3WYBiX2JqdxzVzgNpv6v09CXMvFpjg7TI3b19dx0eTsAkxlLAlMFA8s1rpwENFwJC222PRzqxJhlEclP9Hez1iVue3oCyoK2fTYycyNkc/SsO+UuJEZFWbIxEQRRFwAkntWqyVyzJXP4QkjjWbKnKen5JUwOeGilCQZl9LJp5Fyg1ONBiILdqx22/rDmdO/h5KR2hQ0a3XxuaCnOdPSbM4bbLD7Jkhbf08Txs/n7u/ECMFjj+L25LdjUXW9U0b+GowgffqHkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=giNszHklEMrq7wJb41h8QegunjfWH5ZRAm/sixBE4gg=; b=XaJapVMnaCdql+bK0aW+bTATJtYy788aUsYSlwy3m+CPDInm9MesnNptn/Z56Fodouda8fBKckWNZ+hI/tkPmFPsNf8hwV0pzfp05nGKB7j8z0/nOa3z7iUJCc4YxrF07Zhh3w7yEtjsMgQedUd9lJhpruw2Egc+tcxhqA5+r+yfkgDNr2z/98bA79Cvla+txvcHphpTi/sueYlcYGtbsvjiRJxNUdlFmC2wXh24UpAFzJhPANj69ncMPwgqSLMyqB/Mm/1C5StsA+EQ6aOvI1JZckpVrskZbx2yeOJx2x4tMRrA86plP0f/2ZHWDqiVae+xFWCWcyKTKrEGxw3xoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=giNszHklEMrq7wJb41h8QegunjfWH5ZRAm/sixBE4gg=; b=vUhBYPG34JbNBuT9FQDkzvUnTOaLVOiBGZBcmte+eFCpnzWKcjMKViWcv7wLtwDzAb/fImrvYtBwHnGM6ZeSCe43CR9D4fyCRJ0ZeJ5npIOKRnym28TTEWNj9mXAp3I1fXdqGSTVhVZeCy9FV86m830POj+wOKiYh6OveligeH7U6CcOnQ8uNZ2PVsjDXKhvzFv5suxIKM84x42oSAUC2+bwLujAMdtGbBLopi5A4mxBSSv6d46uLNDIAmajn4oCOQGhAG+bbqeKAkL4i3kGQmwERsq8WuckhImXDhI0rBgrCtq8JNiMaYYxM2m/Og7iEXglcscpXoojd2RlR7IviA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AM6PR10MB2998.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:ea::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Thu, 7 Jul 2022 15:57:15 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::b925:3d3d:8f5f:c4d9]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::b925:3d3d:8f5f:c4d9%9]) with mapi id 15.20.5395.021; Thu, 7 Jul 2022 15:57:15 +0000 Date: Thu, 7 Jul 2022 17:57:12 +0200 From: Henning Schild To: Felix Moessbauer Cc: isar-users@googlegroups.com, jan.kiszka@siemens.com Subject: Re: [PATCH 2/2] Add support for build dependencies in linux-module Message-ID: <20220707175712.3497e838@md1za8fc.ad001.siemens.net> In-Reply-To: <20220707154634.3860434-2-felix.moessbauer@siemens.com> References: <20220707154634.3860434-1-felix.moessbauer@siemens.com> <20220707154634.3860434-2-felix.moessbauer@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::16) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1e027b2-2e26-49fb-108a-08da60315d03 X-MS-TrafficTypeDiagnostic: AM6PR10MB2998:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9+ow0+UFco+BkV7mfdPiYJl0PtLs7YL4RIQku5FBiqSZ459+NdabdeiA73RuvNdzRCcZomJVyGnexQOXzAIE7m7Y0vc9VClwI2fVC0qGE7ZLWfK3dWEfBDTow7wcZlmpKfpBBB1VhliCD3XNBO/DzGfNAvvhzADH4RtTTceIen6zf5DxZEMhkIQq+crnL+v8Nngjzl18ooKoXoX9yKxR25MC+KoxxY8h3STzKlGRnrPyvcUgJuuUo2YqXkvBm7XqXeedMo5SkdRwZ4+iooYyqL/+ovpuyeleiqirhJMgN9yebTyXllIMu6SBWe/7kgeYIHr+SVxqKj9hPuf/Ox541LSAbbipPvgQrtVBoM8nOxI0ilcb8RlpKRW6j99yxreUGMr5b70M8QSaQ5GudUOCN+eS5jFeKsZAQ+9pz3PpsiItOgy2PsRqRcWd3BTqtivRh/sEztvmj9gwTK6fwKfFtTnxW+JgvB6vXwoKZy4QN/dBSeZ0+CIYZ1giexmF5aiowPGSwRB1bc1jsbKyaHm9VAdhHAVFMXOuPdYjjizPh04NNVJFKlqaNRyqX+Ek1AZEeBsv7cF7rzb3IR1mvKvpSNggdvmOBY5lwbygiFGE+6E7HTnW6uwRYcSNvDh/RTWQQtPsxCOE1CwIyGWCWyha9+jipyN4Moi2WKidl/VgS3IWP/LvK/ri8JzmrF1J+2Md806fwP5Y+YkDsq+7JaQwr39XGVT9kJ6enXhqvOktsv05aBP3SvA0TH9Vnpde7eTAuTIScEdv9OG+EI+/D/Oh6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(346002)(39860400002)(396003)(136003)(6506007)(6636002)(9686003)(6512007)(26005)(1076003)(316002)(86362001)(107886003)(38100700002)(4326008)(6666004)(41300700001)(6486002)(478600001)(6862004)(44832011)(83380400001)(5660300002)(2906002)(8936002)(66946007)(186003)(8676002)(66476007)(66556008)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CAf0kS5GTjyGrN58+aKxPJ2oCqXq7fmzHju40wzsZM35dZH+8dSY7NwzNlr4?= =?us-ascii?Q?W8SBhgnkPmZy5ukcDSvl41NLzJCgG/hrlPjZW8flaqk8EYkbuoU2QnJy6D6e?= =?us-ascii?Q?hlRsl49nAeox4YLuKlTX6hwPQN4M503FBjToZSQ9dMbhZwYn6+TkrAgX3/Br?= =?us-ascii?Q?J11tqSJGVGUtZLlUbagyYYv43btEnUQ+clXBoj2LjMfCjusMfWJtS3GMh2Tk?= =?us-ascii?Q?doR/6+ISI/8ZoR7vFb47kspCNnyPmASVGiW5dspxzg2Ajc57/z7YefQQnycJ?= =?us-ascii?Q?I2a9OXBNTPbFLnG5+vyOXVafbt0ogvaRW0Su2VM0tLMI5tJmj+Oo9kElF4Tw?= =?us-ascii?Q?/R6KidA8/RglRUvgf+LMHp8oBeOMeXnlHX4HPUALPR++oHldMTWHQ9UbHSoW?= =?us-ascii?Q?neT7350wyZTMmshZHn/idOFbBN1pkfWsDKycGe4v3wlcL1jataxjeqr2ebBn?= =?us-ascii?Q?1qR69Gdr6TyRyzOs+uvdnhKUcppBMIiozn4x6D2RWZ5gnOZDlJC7x+J64oHU?= =?us-ascii?Q?KfoDa88vmzv7NjxGXa/5wuNJANS9FNRzZ9dayCLanbqMOj5iIXz4BmRbGsM3?= =?us-ascii?Q?sgJR0gKwuJ0ruiIsN9MuS6gR10iR9ulfcSwwHzKtEKE41eGxPiYJdZgWrxEq?= =?us-ascii?Q?rzXylN2hdVAKuJooH8KObO6h++VkqO8fmvRRjAtHbj4I1NNZ4LJUoYKUDQrG?= =?us-ascii?Q?LJtAl/NfrRRvRboFnmKrj/oItsS3sMCj8qJLNwdO7Qjl602tC9pvA3+wXxCv?= =?us-ascii?Q?dvTeSDsoGAClzpiW2Ey0dwWMDstC8VindYEXbejT1FVz6SIlnx/5Du0GrF0E?= =?us-ascii?Q?+nTG3vo9GDEAriAJDvQKj0u1ES1F8QvJG7rLpRIM18Hye2CTLRXfpe4cOIdo?= =?us-ascii?Q?L49sW0UWwAi9iX3VvNN2DelqDP8RXdPtQWNfZsFFj6puyj+m+CK2BL6f6PEj?= =?us-ascii?Q?By/jVk8rWbZQjIfxflslIndT1PsQa7kPbcHz1ltUv8Kug0fN4XaXFqOjnvVf?= =?us-ascii?Q?cwSG3NkZlI05Vsg4w5qjIRP3A4eAmBJVSZJ0LAj0ukK2Y169I3XOiwrYBuMv?= =?us-ascii?Q?UrE2OZUD9odErg9VPpH9qtM52umZNVE6gmUSSC/hW2DPF672I5ufQfIweUCc?= =?us-ascii?Q?+rzSuupksQ7PkvjT7jbjMVAxXdlD+Cpa3Rq3FjPCxXJucgrKbigGaVOPddTq?= =?us-ascii?Q?f45RRQ6t9y6zaQgEB8BosSzZSS4ik9VGJQBjk6ZJYa4C1f/7nZcmnHik912H?= =?us-ascii?Q?7bB9fFrbYqZAlP+mje9zop1M21/29QNcQINcpNASpM2KYFbBb4G/TaqFIZkt?= =?us-ascii?Q?F+/26cPo3Lt6eV+6RuMSA61Ukz7LpTdCjCXVh4GKBC8+UvTBS/MC2yO3/bSL?= =?us-ascii?Q?Z7TVwzoeqznW0dgMMTvjgdN3GMmxQqjUv0q8UD7IJvelajPfkj/LcD/uzpcK?= =?us-ascii?Q?iN7FXl0eLmgCG+Fu34PbNJQKW61hDSA24GY1qY6nyPFviN6KdJuW+S11vADK?= =?us-ascii?Q?MXPzX5NlxgYSDF4FwZYfhV0lAaqJUNQc9YaED6fDDytI9Fbsfsuopc79h15R?= =?us-ascii?Q?JW6NKBqrJ8jPNr3WkgZChe438mDF4PwP8Yecl5koxvfbBny96HA7s3vVV/Ix?= =?us-ascii?Q?RA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1e027b2-2e26-49fb-108a-08da60315d03 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 15:57:15.8210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zvUC8JN7fWHgIgqGITC+CvZNA4LT9sTYNwTC4NrFrpcAThE1uS3JGH93OjGFwFh0bNusLRM7IGofAXhkpzSwTCd/nR1EjIdfV552DIdPmic= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB2998 X-TUID: l2Q3UsiOpHAk Am Thu, 7 Jul 2022 17:46:34 +0200 schrieb Felix Moessbauer : > This patch adds support to add additional build dependencies > when building a linux-module by using DEBIAN_BUILD_DEPENDS. > > Signed-off-by: Felix Moessbauer > --- > meta/recipes-kernel/linux-module/files/debian/control.tmpl | 2 +- > meta/recipes-kernel/linux-module/module.inc | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git > a/meta/recipes-kernel/linux-module/files/debian/control.tmpl > b/meta/recipes-kernel/linux-module/files/debian/control.tmpl index > d3f4dfe9..67b08244 100644 --- > a/meta/recipes-kernel/linux-module/files/debian/control.tmpl +++ > b/meta/recipes-kernel/linux-module/files/debian/control.tmpl @@ -2,7 > +2,7 @@ Source: ${PN} Section: kernel Priority: optional > Standards-Version: 3.9.6 > -Build-Depends: ${KERNEL_HEADERS_PKG} > +Build-Depends: ${DEBIAN_BUILD_DEPENDS} > Maintainer: ISAR project > > Package: ${PN} > diff --git a/meta/recipes-kernel/linux-module/module.inc > b/meta/recipes-kernel/linux-module/module.inc index > 97eff294..a5c4336a 100644 --- > a/meta/recipes-kernel/linux-module/module.inc +++ > b/meta/recipes-kernel/linux-module/module.inc @@ -16,6 +16,7 @@ PN .= > "-${KERNEL_NAME}" KERNEL_IMAGE_PKG ??= "linux-image-${KERNEL_NAME}" > KERNEL_HEADERS_PKG ??= "linux-headers-${KERNEL_NAME}" > DEPENDS += "${KERNEL_HEADERS_PKG}" > +DEBIAN_BUILD_DEPENDS = "${KERNEL_HEADERS_PKG}" > > SRC_URI += "file://debian/" > > @@ -26,7 +27,7 @@ inherit dpkg > TEMPLATE_FILES = "debian/control.tmpl \ > debian/changelog.tmpl \ > debian/rules.tmpl" > -TEMPLATE_VARS += "KERNEL_NAME KERNEL_TYPE KERNEL_IMAGE_PKG > KERNEL_HEADERS_PKG PN" +TEMPLATE_VARS += "KERNEL_NAME KERNEL_TYPE > KERNEL_IMAGE_PKG KERNEL_HEADERS_PKG DEBIAN_BUILD_DEPENDS PN" In general such lists are way easier to maintain and look at diffs as multiline. i.e. TEMPLATE_VARS += "\ FOO\ BAR\ BLA\ " You want to not just add the new but likely also drop the old right? Henning > do_prepare_build[dirs] += "${S}" > do_prepare_build() {