From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7117959015048413184 X-Received: by 2002:a7b:c4d9:0:b0:3a2:d92a:9936 with SMTP id g25-20020a7bc4d9000000b003a2d92a9936mr307924wmk.70.1657292725136; Fri, 08 Jul 2022 08:05:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:34c6:b0:3a0:4f27:977f with SMTP id d6-20020a05600c34c600b003a04f27977fls13309669wmq.2.gmail; Fri, 08 Jul 2022 08:05:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uWHZQ21TCZmBLH8ar/t8GIaoG/I19Xe/WJuF3Vb+LW94t8j5F2Jy2kk4oOwAIovd4mxZ8u X-Received: by 2002:a7b:c4d3:0:b0:3a2:aef9:2415 with SMTP id g19-20020a7bc4d3000000b003a2aef92415mr301251wmk.72.1657292724102; Fri, 08 Jul 2022 08:05:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657292724; cv=pass; d=google.com; s=arc-20160816; b=gGhPfG+EoemY4JnwugGKIKZHvAu1xrRKXvpVBJ3xboBrAwtntS8W1+sNgbouNDRATw GC15kgJGQQulbv9Ji8CO33eOTeGYDeuSqPAKq2s5C72zGAm0hHbfLlfBl7bLtYKVR3hS Nixmu6bJ5/qwSVdLnsqEXV/mDOKjD5LIMblOubhCYG+53+nd68UkmoMqq9RB3PWCY8Fe DXAtiGXDNgviGBLCRP0wQbvUUv3/xSqZDZyXYlktSu1VdBC24fodJH2V1Or6LcZABBo1 Jg4zRC/li6TU5vZlkYl/bpEeGwTgBugmF7QxwJmg2arUD7YwAsYDgET+J0RYJobe9DXO iePA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=kuXxx5QbLge7vt4JdauuzQedDshvKhzjhs6zgPBqvCc=; b=UmpCZFBLiQ+aPhMwsOEIi4gsUDatYPDylCw7LfUJYGBJQwo9Psh6d1EAzMkWsilSj/ xo514y80b9Tg1rta9bcbA+Ltv4AH67zVb44zI2aj+3QiVuGIVycdm8K2VeNG5XUrL0Fp ufrbF065wK2ahWs1MHCa3BpK4fDJ9TFjV46utqyit7tUIHvOR7acsL1k6jn9jec4F+13 k77h+l4Hd4Jyz+yGrOQ+HuqzvHD556Efa/zTkGXuHMdHp9X6VSuqFmHUp4d9vwDeKZpo UCCY+2bry64cQtUMxq1WgH/0Mvq6ybU9yjYl+5SYAbKSk4QigJwGk3XcHPUwtcveWJxF KCqg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=nbt32GJP; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.2.72 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20072.outbound.protection.outlook.com. [40.107.2.72]) by gmr-mx.google.com with ESMTPS id b7-20020a05600c4e0700b0039c6559434bsi84053wmq.1.2022.07.08.08.05.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jul 2022 08:05:24 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.2.72 as permitted sender) client-ip=40.107.2.72; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=nbt32GJP; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.2.72 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S94g157esF8Jj1iv1vrMBoheGKOmKI4SS4Yy5DUFRXCmGBqLCYfaeDWL/wcwMtl8YH4CCh7+MuacTaB9zNa85g0M5gNhqmdvVzfYDS0oiBNaEqVnP6GB0pprwx7WZX3YEvPcfNvxRw2/S3wCWOvMPzhLLA2asX5BU2RYhHg5uaiODaLnA9hWNBOb0/9bBzUiWkVARoIW3uQ4KT+Vu+6bPFUNTuf9Lhp0nRKyfB+DRTOyZBAj8/kSxVs+9mcM0j2TXnSHdY7NTf+xx/0ybaRZ/GjWBxP08C9N00shokjTKAP2DIBXU/PZjNIwdbjMpiKDhRM5Eriy59BL2qKvSkwgAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kuXxx5QbLge7vt4JdauuzQedDshvKhzjhs6zgPBqvCc=; b=T1VFSort4OBp0+arss7YnMD//ulWPSNcmSveHfy0DqlEDBtVyGg1dicRWyQdGQDctMiL6ilmC3rWUqrmnR5YLLfrn/O3XPuChTikz+T2E6xMwis5za7R3YvHI5yM7Reky28lErGrrDul1/RVP+owMWtPR8FvBh579Cy5C8Rxs02PmVuvUl1qACh1JwrfXsaBAqCi6zGLjpq0hmyjK1YtFfCo1Dwbkkgvem+iVwQtn6HhhF4bS/DOhiGRS49jIAb6L2/wNspb6yhrB248EqzCw4S0e6F53EtNoQRhwnLPTCIgxxsXXforJOfrSLPDmhnW4msqEJnVlLYCmHlChwa8kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kuXxx5QbLge7vt4JdauuzQedDshvKhzjhs6zgPBqvCc=; b=nbt32GJPzmp/mPfRsB/GALi1bAdlTbAuyootiV27N7uL0nMLws8i37Ew2l8CXQldWeidqsV+REUaXv/XARmJPDtiW890l6CD7c9ly2XlWU1VM+z+VZPucI9Fov3ByuPLyaubE7U4Z8hC5PCtMBEJeGMKLuZE6PmF+MXcHhq0woqJnf6Werc/cQbwPYbzYq5KT5c8Oy/GzFarSyhYT8qoQLFDSmESMOjhQnt/Pv4TpsyOM8C0MeGbN0kXkoLXPFZH4fIq9L7Q9Q3qdvZe4BUcSeVWZoTN22FPxtuOIr+k8GEMehK76gHyFvTO2XoFVEHxFwnLHSMRy+h6Y3s4+PDLEQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AM7PR10MB3173.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:10a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 15:05:22 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::253b:4d66:1a99:f6e0]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::253b:4d66:1a99:f6e0%7]) with mapi id 15.20.5417.020; Fri, 8 Jul 2022 15:05:22 +0000 Date: Fri, 8 Jul 2022 17:05:16 +0200 From: Henning Schild To: Tobias Schmidl Cc: , Florian Bezdeka , Jan Kiszka , Felix =?UTF-8?B?TcO2w59iYXVlcg==?= Subject: Re: [PATCH] expand-on-first-boot: Check size before resizing Message-ID: <20220708170516.527dfd5f@md1za8fc.ad001.siemens.net> In-Reply-To: <20220708111520.662382-1-tobiasschmidl@siemens.com> References: <20220708111520.662382-1-tobiasschmidl@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR03CA0261.namprd03.prod.outlook.com (2603:10b6:610:e5::26) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e47e88c7-e16e-4501-b7ff-08da60f347d1 X-MS-TrafficTypeDiagnostic: AM7PR10MB3173:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qr1I4cegQBDXgsAoRuS0mK+EPPqmOVFNCkKQDZZ+2rgU0Q6uuyD4RxMhDk/8k1Whrw8OGA57bstvUt/CJDh+AFfXVCua1w0W0Ac/j0IJuClvxbNuavZiDXMjKRlz+TQ+TMGGo9q3cxejxg/Ep2+SEIFkpcHQoSIZyCW0L3Ue+LxZO9J7rzyTupxN0ZGjwwMPm4tR5aiDq+SXPgnNWiDDP+lVpZk6n3SEUpPZCX3T4qvsGWdkiPKSlmt++5dIYEA5CHUiNVDxv7aQRoWpg3xUerGQsuXgvPlKzKGJw67F/imCJnTOW0OvaJxED0McgyONEvRUu5ECx4+6YtLaF/bF0vDrbe+CaVHK6BJ/b5+ratqrCTAdyghgXd/FsMh4LMHEdZ11rKWDB0wCqLX28T+Vcv+3zrcp1eo20k4Xa9cBbcUNdKIS4bZGvjm8rj3Y0VcwNllFvtMgHzzXqZkssOlnuAqtz5flS4HxpkMAmKs/QoqzBIJd4DS+9t8UUEBdsKkjSu7f/fv37Tp/74W7XvRTupqjtNc1YwM4jpm/YUUN6Dk4b7UE4UxCVSjdjrLX8hKaLXqU/7g5i/RglO8dkaPrzeS5t/+wQ/lE+x2V1kwUTGz7CaoWp+uzZ36jcZ11z4nHqLTrQbRTtSOw4A3AcrH2DakJGj3snxxa/fShUN5dPN/IPoz9ITc0iOgzORdDUeRaedaDFlw7N8NOtOLrJwjIlMDL94GKmY1setpX21/mx6tE9S4HkNrW4c6V+X0mHz2A X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(66946007)(66556008)(66476007)(316002)(1076003)(6862004)(26005)(6512007)(8936002)(8676002)(6486002)(9686003)(107886003)(4326008)(5660300002)(478600001)(82960400001)(38100700002)(6506007)(86362001)(6636002)(2906002)(6666004)(83380400001)(54906003)(186003)(44832011)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M86LfqmsmPJzN/F9xnWuFDwN7GUMMW6DculvWBqy6EtpzzgFojo5TWkIhhvR?= =?us-ascii?Q?caqcNvQG8p/mq6AAVrIbd2ZkTDcf2bdfFWAjlTgsHIYwQB5vp5GTn6MQbkz8?= =?us-ascii?Q?y8YhpknIvLAglAsMJWm/Ew7CslKyMcVkSl6vUgefjXMD5y8xFftsYgAR/6GU?= =?us-ascii?Q?t6/rS69syptkXn0hEfBW6IsRYDPOnPxlLXolBJyw53fUpyNzV9GQ1SNkLFU6?= =?us-ascii?Q?v6xdHCJr7/9l+5cZv0nkSzKhyxRsB/2CE46xWMk+WJhEke3iRg8wuOmCTji3?= =?us-ascii?Q?W//Bi4FCX/UR3+BIxlzfOMh4DXFlybypxIiPE3kqgQXfhf2TQtaXUY9BO/I8?= =?us-ascii?Q?koDayMiWS5FnFGKY6OkzsXALzDftzjfYVyXQDC3Ns5NjrMrNEPVfm9wjLTt0?= =?us-ascii?Q?aOodWKfxjTOveVzm002VuMu+y1HyVXJxOjXA8+jBXcMbgoncG2ZWj2043/y8?= =?us-ascii?Q?5fQWP2su43pWkViFfiVMx+yLEfXbPqbHSJq26HMQl/c1yz09aHNY8bcKKSn7?= =?us-ascii?Q?QQ4fVzQ5Q0cmL1pl/v5rjTbw/XJun00IN3va86f7xITzyJLO5nIeW4ysLtsw?= =?us-ascii?Q?Q4oTGMbZRq71U9J9sXZt05rOhGBqL4B9iVqpEAz/Jf1+2/pLFDhNrpotUjdQ?= =?us-ascii?Q?vg7dUczkDmNbnRQekkMmjRoBv/RoUxoSKU6ZTODvQLW0y00duBtaAYUCdnax?= =?us-ascii?Q?NgmUq285bTjLUXoDUeKigRcorFwagbGj5cJi7nuogxicSM6V9T74S3IHwwkW?= =?us-ascii?Q?euPBbjgzPb9Xq6uQVGmGfA7fNzGAntguGT/N1IL38TMgCKQgNsMzLwBkp4ux?= =?us-ascii?Q?1o9K6UcYpSHLt5WZK/SKb9EUC8rat56Y4r73c2JLFYa6eOr6ylUsTQDwlL9s?= =?us-ascii?Q?/K/On4fme7DbrcN5Qpg4lL7gpoCsacCqzcOqmxCFXfHyj9jCnFbttdi+gEn8?= =?us-ascii?Q?frZbnc3ILgdhtGaPRpM8uQ1xgDaS0pld6Rwgy5YSaG5euVUqqmHzVV8gOUbG?= =?us-ascii?Q?6Xc9/0RKAg681wjJbotkxBMJCTCYgd0GbgrF0YXHZd82QmcFC8w3LDYjDR6F?= =?us-ascii?Q?rYmMO0DGCyJlF9FfUATKEmDbpeWfYmNrUuphLrcM7u3Myz2yo9OqwhMWv0D/?= =?us-ascii?Q?K2TTq2Go8crVQKXYuS+LadHLaKgse1usfY8VWqXGPEOMoZFBmwOJhR/EufBu?= =?us-ascii?Q?+owdd+j3HdDMKNSg92AK15JjIPcYWSwAscGLkv9jly6r8pouN6F5r4Ir6jNO?= =?us-ascii?Q?hOcn58aVsnhSVbs6xO0xS0rVRxQQ8cKaoLD3LNkbZanJkMFB29exP7j2Y/6D?= =?us-ascii?Q?XQWpEInRixFB/Nldf2qpM4WZZMry8N9YSz0p5xj5/Ddl5NIxsB6hBBA7DbOB?= =?us-ascii?Q?bSl2yjzZMzTAfJSrvomtXgVVJQK2GT5wDOcG7OxoZvanPKngjAfM1K4K8vm0?= =?us-ascii?Q?um7n2f1tSkD8SJEoxwg7jPqgI94t+GuiipE9O3fCO0yfo0J/ZFj8cPKBqYwk?= =?us-ascii?Q?NR6EpL3kyQjGXMVhbcvOzsChh1FQKQZnMFo7W3itmWncb83caeFLE9LgYW6r?= =?us-ascii?Q?VTSjWkurf2Z0EJqaUl32cgXZjzj5TJUynblt2pIXpoG1iRSuGOU1+1CcjF4H?= =?us-ascii?Q?ZA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: e47e88c7-e16e-4501-b7ff-08da60f347d1 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 15:05:22.6154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eL92Gpu3QbTFtXPQPccZ/qC/mOSRYBlqAY1AlEpndbGsWCy2JoRIfAw3BPGtbmRK5CsndrbUbbQxK5U4Y3b0GnCBm6IwGIWcsSl1G1D1kFo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3173 X-TUID: MoeZ7UsifNEC Am Fri, 8 Jul 2022 13:15:21 +0200 schrieb Tobias Schmidl : > If the disk is too small, resizing might have detrimental effects. > Because of aligning issues, it could happen the the final partition is > _smaller_ than desired, which might lead to an unusable last > partition. > > Signed-off-by: Tobias Schmidl > --- > .../files/expand-last-partition.sh | 17 > +++++++++++++++++ 1 file changed, 17 insertions(+) > > diff --git > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > index c0edde7..3b944be 100755 --- > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > +++ > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > @@ -22,6 +22,23 @@ if [ "${ROOT_DEV}" = "${BOOT_DEV}" ]; then exit 1 > fi +# this value is in blocks. Normally a block has 512 bytes. > +BUFFER_SIZE=32768 > +BOOT_DEV_NAME=${BOOT_DEV##*/} > +DISK_SIZE="$(cat /sys/class/block/"${BOOT_DEV_NAME}"/size)" > +ALL_PARTS_SIZE=0 > +for PARTITION in /sys/class/block/"${BOOT_DEV_NAME}"[1-9]*; do > + PART_SIZE=$(cat "${PARTITION}"/size) > + ALL_PARTS_SIZE=$((ALL_PARTS_SIZE + PART_SIZE)) > +done > +echo "Disk ${BOOT_DEV}: ${DISK_SIZE}, all partitions combined: This is too verbose, one echo before we step out is enough. > ${ALL_PARTS_SIZE}" >&2 + > +MINIMAL_SIZE=$((ALL_PARTS_SIZE + BUFFER_SIZE)) > +if [ "$DISK_SIZE" -lt "$MINIMAL_SIZE" ]; then > + echo "Disk is not big enough, won't resize. Current size: > $DISK_SIZE, minimal size for resizing: $MINIMAL_SIZE" >&2 "Disk is practically already full, doing nothing." All the numbers are maybe for someone who runs bash -x ... which they can always do. All that runs in a context where human readable output is not useful, just a summary message on how it all ended ... > + exit 0 > +fi > + > LAST_PART="$(sfdisk -d "${BOOT_DEV}" 2>/dev/null | tail -1 | cut -d > ' ' -f 1)" > # Transform the partition table as follows: