From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7117959015048413184 X-Received: by 2002:adf:e112:0:b0:21d:7195:3a8d with SMTP id t18-20020adfe112000000b0021d71953a8dmr16441999wrz.371.1657529546198; Mon, 11 Jul 2022 01:52:26 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:1849:b0:21d:9b2c:2273 with SMTP id c9-20020a056000184900b0021d9b2c2273ls5449248wri.1.gmail; Mon, 11 Jul 2022 01:52:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u6jzZpEv3Czhm6TtOJsGrT5jk4m9hwe3m2cucg1EiUuSTaX8AS0sUCTKkg7FJvuJ/rCvfy X-Received: by 2002:adf:f043:0:b0:21d:6a90:f3e6 with SMTP id t3-20020adff043000000b0021d6a90f3e6mr15879597wro.277.1657529545254; Mon, 11 Jul 2022 01:52:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657529545; cv=pass; d=google.com; s=arc-20160816; b=Ama5NXtum92cvD39iu2oXQlDYSgVoAiQC0np9mTNrGNCmb869cdH6TJKsVfrfJPmd+ 3ZACh9CFcMWPtoH3RX+/RhqVHZsGsF+t8UBQwNe+oizdJKIs2gU+bVQm63/lWXqF6o+9 +M8BWok6Xzj8upYnCkct7O3nBXPWFjymqGCVI1sSzd/fvwdid3+4SL4ACRrXANRbUkHl d+yBMlYTleznW7FkHPG4NTRiuGDw22bmeFfFTmQ8tnhZKIAhCtTHvYyx4k14zrKnCHsm Vpy/4Z7Gp8E8eyc5nZxLnc+RA3DL3UMLzHzr3f6cFpDlmfM5XhbAaBL+w/RmaJvPge46 1mUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=XbkfOjyGpCX8TWqqQ1PBogbx9y1NVnC9sIV7OKUjR0E=; b=UMo6qMOvU/SEoM1QI37EgYnH6vW7gxY2W8FU8TvbCTHD+t3RTdssPNeFUYXvlhmM/3 jj7VNUyo/iZbaVq/2kGq3ajnAeytrjX6dTALtfaMACQRSE1bZ37Ac3xDJYjdLHeGd8t0 Gw1tqG8p7PI56eTRuh1o0l/ie4bxbu28jEDq1cuUpwF9xWfrDQt3R3W5TOCXCrqVcqiR BshdowrCbMsw19S2G6/GDqEuagQ02V1Tfat38xECBoE4xdEkC40VO5h2nyl6NNXftsz9 +Ia9tT5L8iVv6Q8UDN696LcBoEa45YMhQNO7hyG9fqKtD6/nVhdhw2AV5ZZxTX3AAc0j yHFA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=E4hc2HQU; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.104.65 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2065.outbound.protection.outlook.com. [40.107.104.65]) by gmr-mx.google.com with ESMTPS id f4-20020a1c6a04000000b003a2e979b6cbsi30574wmc.2.2022.07.11.01.52.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2022 01:52:25 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.104.65 as permitted sender) client-ip=40.107.104.65; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=E4hc2HQU; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.104.65 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HtqdVlkv4MAlOPOuycMLdpONjXIqkeNKQn8UBNuGij2M8+xmLXSyqgDhw0YdHSB9jjMLFn2Llddh3PBln5QobpjpPwpkCvaLurV27qV5ThOc63APi9LMFfdXbho5/qAl28uEF6RFlTjW2x3E/ZH/dW2elj9jwucBuQjkkaIvBucGw5w2KWB19bmrz4JWim57fIi9iEe8TyMTDVB6HvI/Mm9Rww8zWwABUGue3PK4NdZZH81wJh1OyuPuFdyPPTe4b28Oqif623czOLjlJsdD8pXF1dkzbhlwx3NFRpQZYUw41kA1HEz5npUMpRuByWpoOPrwMKzWW3fHvmjxbVt9Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XbkfOjyGpCX8TWqqQ1PBogbx9y1NVnC9sIV7OKUjR0E=; b=bgPp1lryIGz+8iEbZjoblTyM6X0VcWHbxAXL33h85tgFNy3JBEX0IYf6YSC+LeKUgiSwxIwwL2knW/jrUNXyC1m5l764QEzYGIP0QfHbdKV8iEG69kTGASymXj0ouhcG6xb/W70l86GYhFcqe8nZC7tPG6XQdKDHmsQ8he28ZvsksrAUtNLFsXyhqaM89FGpFsPZ4X9SOjJs5R5bgpdgZ74A1LcfVVKeOHBnk3nOOQGo7z1dCqpWitZxDahV4bVziq/V/yABnThwIe/VRKW2k5PphQ8FewoTbMIAmubDvz7SWemGul8NlOacc0xSglEFvsBkEYMCzCM8oRuR/VFBag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XbkfOjyGpCX8TWqqQ1PBogbx9y1NVnC9sIV7OKUjR0E=; b=E4hc2HQUeqKcmx5mI63Q5CoUDN3XgKTakNQ6TPv3Zq9hrEkhfr7TSy5GD13q6WZvgnJBcd8n+MNZOm5nUEkal+jWBB9kWh9qUa+K+uP1ETqY7wz/z0pGWmlAkoUqUJiiCiSjJA52aw/tWlAStYVTkUQKCBSIuCN14uUZEzK5wxSLlw/ELC0nhxLhipd8mfSsXIsiDOcz1b5MCD6bVU+Ab2E08UgijM9PtW6SbYcnL8wmf7EfOi46irdPvM8vD9KGudYQZGLLl5H3MuzaYl0WyKLW34suFFmbFHv65/O2fkdpa739HmwRvzwwio0BzayQwbTNvcYApHMfD3D3RxMntA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AS4PR10MB6277.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:58c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Mon, 11 Jul 2022 08:52:24 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::253b:4d66:1a99:f6e0]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::253b:4d66:1a99:f6e0%9]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 08:52:24 +0000 Date: Mon, 11 Jul 2022 10:52:22 +0200 From: Henning Schild To: Tobias Schmidl Cc: , Florian Bezdeka , Jan Kiszka , Felix =?UTF-8?B?TcO2w59iYXVlcg==?= Subject: Re: [PATCH v2 1/1] expand-on-first-boot: Check size before resizing Message-ID: <20220711105222.4b52cbc8@md1za8fc.ad001.siemens.net> In-Reply-To: <20220711081602.81904-2-tobiasschmidl@siemens.com> References: <20220711081602.81904-1-tobiasschmidl@siemens.com> <20220711081602.81904-2-tobiasschmidl@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::7) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 826a1f28-5dce-48c6-ac60-08da631aac56 X-MS-TrafficTypeDiagnostic: AS4PR10MB6277:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G3Rxyrm7rAtdITPub2FOBWJMj0+5POA7XxYWc/Z8XOW4eNIKeyGgiKexlev9jj3phZ4aorHr+SNHRHXmxAH1rK+GrVx19JL5EJXZpX3NHvtVgq3t9HNN61hSvyEMmLCFQ9MFGJZNHIAfQjkTdciefCRR0cSJzErRxvnVMfwDxvFspkQM830B+HCk9uk9JJozuI7jSDUslnYb3i8QEe8JmWNq4mlDhl+QbTm8Cazitpu4RIDEsVd7fAuinoL4CUaaYPP/yA0I/A/4S7X4ARAoX1Ial6GazVWnQBgOlviNK/c/kS4siRsDyJbHWMEcgr77/7o+hdyxxSmiHjajA3fxt8V8dtq++jjF0VnPkH5NKFHfDQO/7FYI0vXV+Uy5ZgOPK4IRUoKrl+N2oIkBLvFhEgmDehR1mvt5WaUxh9vllqAUPKeTqr/G6CgsbFnkhBbf8UA3TWqss9Xv2rwIvFoKg0p/l5OaPqsIzoUnd5U+V6y8nFvHQvpuiw1I1Tv6DiQIy4jY5dEiimg6go30ativGO+KsCRIpTAhrRXaYK63jZOsJXLov0rm2jxNx8fhs2xz+rlb7O/MEXmd4AqQt6E4vcl44ickNzwnJ58JYs5F0bztFpPZX+5hChK/+IIk1kuzTRCFnNt5SnDTUViTlCrf8zEENuP81Jnk6bAbymlgrC4FDOeC8wY/uWN4jX2erMIyOKjvKZITu0qeDmlWxEaeyefvr0AmzGOv/McsCUlPAYf8YWCulgYHrc6gvE665vzJGnE5ftrWXsxT1VimzXDKzw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(396003)(366004)(39860400002)(26005)(6512007)(6636002)(2906002)(41300700001)(316002)(9686003)(6486002)(6862004)(5660300002)(44832011)(86362001)(4326008)(8936002)(8676002)(6506007)(186003)(54906003)(107886003)(1076003)(83380400001)(38100700002)(66556008)(66946007)(478600001)(66476007)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?onBdI3FJC8ZgQl6mAl7OMSHSNESF1iUh9oCDm4Zz6rNfS6VRxHmgjJh5poma?= =?us-ascii?Q?XOSaQiehOu5pioBXetT0YwMy3jtHvTFiUpg/Kgl1yX/JQDgxg2fB7MF/2Tpd?= =?us-ascii?Q?9IuBdrkm3epMKDeSp/FUgyeWejntaoREsR9Vg//IefDdjHo3d1WvPthSDhu0?= =?us-ascii?Q?zjjTiUHUiXOHfdtvGwThtl5uw2NyelQA9S6Ph3kUihRnm3MYuZYrwlIAdFSE?= =?us-ascii?Q?5vf2yHLTSUYdSHDeR4OWc72n8vYqVHapWrxHDPuEVT+bS26Vf1uSaXpuNrsF?= =?us-ascii?Q?EL3pawrRRKlMjOxVPk0UUULIrCQ/JJ7zJBpdl8T0P0DseIgQ//k/ulyn5D7m?= =?us-ascii?Q?nYy4FCLNF/OI5OqaysKcunR/SnWv10LQHxt+XrQMOQAXvsPIjTBa7hf/8vMV?= =?us-ascii?Q?9knmnr/5pw9rBA+TPIsemRCfJY1bE/yu4/4WFZCyg8+blhPEBDF5+0VgRlDH?= =?us-ascii?Q?mD4lh96DIq79F9ivWaa9xGPkIbEN/VGIb6cNLyhgwf6uL6f+IZdouesI+HEv?= =?us-ascii?Q?rNfb5HRPbINAGqDL4ir/L6lz7BbU71oxxdaXyrFjTk2KX9aRzJubhVuD7uQA?= =?us-ascii?Q?QxO3bReulcUPhsJ8JERuPESSp1e6Ny1zKvY3vEgEP1i9neUCQhI4EGfqtSHv?= =?us-ascii?Q?TlmavelBSYhJ4lhex4dTmeW5m2FX00LPjZzIc4J9JmZuJ3+sj8e0Iycfnqmk?= =?us-ascii?Q?Y6V8a9zgI87ab5qe9kPhZt0gGJq05qRvQu2Y0+nx69InYWXeZYOamdz8gRmZ?= =?us-ascii?Q?F7PDeXEoAdf9F3cQwnknAh+AEVBeCCXPhvWEciDOAsJfDjVVMyl/i/lh6Vvg?= =?us-ascii?Q?eo+2Ur2qtdLBI43r3pGgsOs99YADXVTsxlq5jkPSh9ik9kZgAOQWLBgFN7Ir?= =?us-ascii?Q?IzHjb09bFjoZgqsWkCQOkw/ZwqDwr38cvBahO5/AtYjO02ogyq8kRTfba9M4?= =?us-ascii?Q?A2H8VAcUfL0APLpfnhOzgdBzKA1HG8bjN2WkkDBvHWveo4bcObh0AQ8WKkND?= =?us-ascii?Q?HCPqJPuR4DiJb5Be4LJYbOmmybPbYK5g4E1L0/+j4JBCsLWJeClb9oozL1O9?= =?us-ascii?Q?WkQfhlLt8CeiRPOR0FFhyjLh9EBkDvFQDJKjOrXqDwcMPqqtzSBI1tWrAI7o?= =?us-ascii?Q?aebiZPhxfgLHoXeiSqFns/4cBhR31QN9CSxhzyFyY6vAPK5i4mW8lQWZ0gtQ?= =?us-ascii?Q?UuIDhdXw+4X9WVgnLU3CFkLF1HhxhdlZP3gCV5AZI9KxTT/mNsAqOlU0ie/B?= =?us-ascii?Q?2DTlXoj+ZkM8jVQA0MFWmaZ75xfT5/hTa6Qr55jehXePNg0lPaMWBr9SpP7U?= =?us-ascii?Q?zLiiTyDYBI2BRexn3VyJ0qwYIAwaYRCRLIFPzhXHeuinMYS+zK+96DDSso2R?= =?us-ascii?Q?M1FOWeaufdxsUULyQj9QxIa2DOX+EfHZk3+719lSVNjC1hTZwBpaZ/fvLg6I?= =?us-ascii?Q?Rsn3TqojVC9m2xSBXKgWmVmOoyJnNfA0PK3XSLmktaoLhRXXZqbO05WZ/Zn8?= =?us-ascii?Q?041qrYP+FQFVsicp/egWhuCIVIaR1Beg0Fe5PlVNgeilXL/ynvWcjQBen6yy?= =?us-ascii?Q?9plCAek4BxCjV6ZhzSAohHHSY7o/D6Ja/hzl7XPbDEIS6TnXRUk5tOve6DL1?= =?us-ascii?Q?mQ=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 826a1f28-5dce-48c6-ac60-08da631aac56 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 08:52:23.9569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2A9CSqJgoFaX7CTccDj54zkVynvnhj3m5SXe7/gH8p0Qpnd50gbYuykRhzpQ3RFlS8bdAbT3FmY3k6xAwr1DX8u2+JrtK/xB2dBQq9adn30= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB6277 X-TUID: MwJvKs1yKDov LGTM, i also like the idea of asking whether it is worth growing instead of asking the more complicated question whether we would potentially shrink trying to grow. Henning Am Mon, 11 Jul 2022 10:16:02 +0200 schrieb Tobias Schmidl : > If the disk is too small, resizing might have detrimental effects. > Because of aligning issues, it could happen the the final partition is > _smaller_ than desired, which might lead to an unusable last > partition. > > Signed-off-by: Tobias Schmidl > --- > .../files/expand-last-partition.sh | 16 > ++++++++++++++++ 1 file changed, 16 insertions(+) > > diff --git > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > index c0edde7..0aa1063 100755 --- > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > +++ > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > @@ -22,6 +22,22 @@ if [ "${ROOT_DEV}" = "${BOOT_DEV}" ]; then exit 1 > fi +# this value is in blocks. Normally a block has 512 bytes. > +BUFFER_SIZE=32768 > +BOOT_DEV_NAME=${BOOT_DEV##*/} > +DISK_SIZE="$(cat /sys/class/block/"${BOOT_DEV_NAME}"/size)" > +ALL_PARTS_SIZE=0 > +for PARTITION in /sys/class/block/"${BOOT_DEV_NAME}"[1-9]*; do > + PART_SIZE=$(cat "${PARTITION}"/size) > + ALL_PARTS_SIZE=$((ALL_PARTS_SIZE + PART_SIZE)) > +done > + > +MINIMAL_SIZE=$((ALL_PARTS_SIZE + BUFFER_SIZE)) > +if [ "$DISK_SIZE" -lt "$MINIMAL_SIZE" ]; then > + echo "Disk is practically already full, doing nothing." >&2 > + exit 0 > +fi > + > LAST_PART="$(sfdisk -d "${BOOT_DEV}" 2>/dev/null | tail -1 | cut -d > ' ' -f 1)" > # Transform the partition table as follows: