From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7118849486659518464 X-Received: by 2002:a05:6512:118a:b0:47f:93c4:fcb2 with SMTP id g10-20020a056512118a00b0047f93c4fcb2mr12668899lfr.39.1657555965825; Mon, 11 Jul 2022 09:12:45 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:2102:b0:25d:5f70:6f64 with SMTP id a2-20020a05651c210200b0025d5f706f64ls49748ljq.1.gmail; Mon, 11 Jul 2022 09:12:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ti7kHu1v1MaNMOJxNSQtUpwVK6uPo1TeLuhz9bp6DHdPykvSBMgtMLe6G6iK2aORcg7cDP X-Received: by 2002:a2e:a484:0:b0:25a:8c94:3763 with SMTP id h4-20020a2ea484000000b0025a8c943763mr10169487lji.64.1657555964675; Mon, 11 Jul 2022 09:12:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657555964; cv=pass; d=google.com; s=arc-20160816; b=bBeVAEJExJgOgh+sVFyFN6OYFNorKRxulsItW552eq5fcaK3z9vQSe5/GXXXWm+LrE ewhRSllpYZPFr2T2gfnKIMI3vUcfCWAihEkQsLfXOk5XjniyDKzspqSXfeKVeN/OGDU5 0wNYnJD5JM02Ncz/MgCMv4FJkFRasmCrIGYDEpFYrXtY6hPlCJdGzRhptj0p03p9jRLr +WsDoEUcTUvqWFl7/pRzprSOx0+jgPuVZGqx/LBBGfilLWz9h8Yv+OuHaQWLj3Hzrhno KOaTfNNZefuVfK6LoRlnxT7zhtTS6jW9Tn1wWGOL8/kko3Edk48EP9I31gBpe3qBJm7O m5zg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=0L7sq+oNb4BYP3ApyWHdWzNA9OVn8OKENKm9jumdEpQ=; b=lNG6hAadA+OkOhe6u8eos1fYCywAme9ZvSd7AYVVObf4JLU3qYxXKoxAWUPhu6Y8Mi X98GifFjayQtPj5dnKtLyFPNxGJQxHMDdMRtDRBg6jWuStMUHaTCv1F1GQHBn7Ri2cjZ KZJkSw91MN2att/Bt0q4Q+xoU26xtcyrYV86NTxB0fIaKtJNK5UVjieHPNyc/KUnXT32 NsNYuxur+5wQQcIweIjFnLjvXXUV1zxtb48dZk9EUl1uROvfDpA4qawzxZ8HFEbSHC1j 1JfRDFW92tngmuo8ga8oaoXfakCsylTdJloanqbIWuK4iMfrRyvI6ZbR40Vnl50hbJt1 1dNA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=QGxX9wcD; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.79 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2079.outbound.protection.outlook.com. [40.107.20.79]) by gmr-mx.google.com with ESMTPS id z14-20020a05651c11ce00b0025d50b414afsi200838ljo.4.2022.07.11.09.12.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2022 09:12:44 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.79 as permitted sender) client-ip=40.107.20.79; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=QGxX9wcD; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.79 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KvXLZJLeBSnbj/RrLJDivR88AQvl3DC66y0/nK2ye/qV6U4E5MfhAvljcKYCZ3qcElyk4mn1k6WnntnpnUG6n51Xd5j8fF3Q3iaG9W2YisqtxGd8H+0p6LU1WXbxuMm3J0usXCw9tbEX4D4IxkpT5WD9KYQfJ5MzneMwr4xB+ScHxxVQJlUCaRCDx6VnOLXDB18Oeqz8llk2O2IICD52/T+kgd7vC5sXtkoCo3y9xS79Zag4QpFhgQphU9jZMBifKsm1sINu4/xwikD7BuYVaJ1rq+LZz5vftjJZIMIV6gPtARzvpGwAfTB2K+MsB16BIilaeEI9HxWwO4JWjJ86HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0L7sq+oNb4BYP3ApyWHdWzNA9OVn8OKENKm9jumdEpQ=; b=cRkXV7U6/uee4IKgroeSKUiRZHiQDOACc0e2F7JQUw4d1dORVEkJ9xPy5ZYtJ8ujH7a4TyFzY3gBMgO4uhByyHwaXBfVBVorFyhPAqgjYcR2LG7AmTpDtzQ1xvSo7iX9+TV9QJVzANC7ltLmc/wpmVuhxG20dAhAQo1sIrNk26Rspun1SbPp80gY62rSnVegwd4PjLp9GxO/skVN0skB1BvUjaQ873w3DLOPhbBQlGwVcez3Nc/i9sIFcBvf9H42Dnq44rgdhdO/z49knOq/tYNGUC8iIYhFCDHkVorOfE1eNi17Rqa5oPxlFzV15rGlIQhemA1Xjiwe1sCCwR0MPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0L7sq+oNb4BYP3ApyWHdWzNA9OVn8OKENKm9jumdEpQ=; b=QGxX9wcDV8n3CVQ9cm2cKyK0ZsMQvBBdqoHbp64+WvS3xzwS/9xDgL1besLl4+josGADoO+0FF5u3xG6oxPEpZ6NG1JJlHZ8/P06g0QW8AuQlYv7ejxGrZ74BuPUzb/pD65RVPzU4CBQfK9nPt1nTvj5/M2ol33bjLy+jUVotw39EYNm9qGGKmo0tiE1jffua/dWGp7uCIIVeJTwtYPk3eUPAM6teTLSRq4FRNmFBouqLjcENoAxe9NckhLN2oD9LubW/6Vp0JL9qBIsjsG6fsSPzi9bioDy8qF5/+PUKud3tMUARdKt7n3FJ6nT2U4AfgeWIegOYcSpJEZ93EatbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AS4PR10MB6207.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:58b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 16:12:43 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::253b:4d66:1a99:f6e0]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::253b:4d66:1a99:f6e0%9]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 16:12:43 +0000 Date: Mon, 11 Jul 2022 18:12:12 +0200 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH] wic: bootimg-efi-isar: Add support for loading device tree files Message-ID: <20220711181212.79e7341f@md1za8fc.ad001.siemens.net> In-Reply-To: <360ce666-6b17-d0ce-08fe-f195cdebe675@siemens.com> References: <20220711151214.271e944a@md1za8fc.ad001.siemens.net> <360ce666-6b17-d0ce-08fe-f195cdebe675@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR07CA0044.eurprd07.prod.outlook.com (2603:10a6:20b:459::17) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09307889-d71b-4864-b772-08da63582f64 X-MS-TrafficTypeDiagnostic: AS4PR10MB6207:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gOsJ8o9N63Ry59tLLrN19Q4U0G3UMgbBe7pWtryH2VWJo7BU2okRGGMS1+qR3f2ToxbJevHofWWilYKEnbFjoHHZzzm2hqcj/8HcMCMy6gycsw77w7mcFLl+UB/rYYTY7wBP4PLF8ZHlQj928QIdqnekfCBFVvjd1L3sb4awIKOZ0fobTTBAl5r4i2TRQ5EeCG0S6cGRNbmAJ4p34k0DowF2FZh8bOL41tgHYDMBvMhzuKWtIEkBJIK1fVpPrVlcBGijE0jQgSWE4YUtLB2Z0aas/JQBGZScowe9Yv7/vXKWcsR43OsnuhIpXcGHFW5fo3mb16uIi65dWuEztnvoGj0r3oUhYKKGPXmCVX6vJr8I58GBUnq2Jjz6vYg1F131ybktfHznoKrr1sJrtb/a0Pyr6s+Dhyt948M4vS8gpW0zYV4JaNJLpz2RZLpbn6IwWI5PJt98Ggzd0DQo1h3HeVQwKpdp32jFybHh1tVDUdIX8KMMaMkHQy9YdrrcNr+QpjlmPT5PwTk6cPX3twKj2S0pqjME+ObdDeXzDcBu6YXuEXhopoFzeRzxrZqF1tiGOR+lo5Zx3ygG7V3NG93Y3O2bCk+rJalzi01aUt9Q5MZneOCBuU9Fk2dZLRFlyXdoOouiUzEmIvSYStWnfa3+vljtcpHvUaLPSKxlkeXx+qk9Sgg22dtCJQlVxqY5RSezvAD9DpxD2SX3tjG7KgO/DV3QtV9yKTaCdP6EPyQ3Fmp0bzUMvcaF7CRoQHWyEP6n X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(8676002)(186003)(66946007)(66556008)(66476007)(1076003)(4326008)(6666004)(41300700001)(316002)(6512007)(86362001)(478600001)(6486002)(26005)(82960400001)(6636002)(9686003)(53546011)(83380400001)(6506007)(2906002)(44832011)(38100700002)(6862004)(5660300002)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZscHXyhGP6qEXpFEMVDYEQSqmU9Frew/0H/FXROU8BuE3xvqfxU6jBY/c4DS?= =?us-ascii?Q?EjDfXjApTT/qfII/LK6L1CW+NWtJy5YwzcElWJtqoyBSEKelyVVR5dhKhniC?= =?us-ascii?Q?4ivGXd/p5CZA6sBvxz7KvFR6Ma7MIYdYXLiQlK2ROLvkmopKXqGhl1w7HH2v?= =?us-ascii?Q?ZGuyVRPvs/eyBUJRqNZ4XEU6KvyBa/ULxxdPqmNrtJ9TnTxBCYMb3WJH5nlI?= =?us-ascii?Q?zCFlU3g5Qt2Ja1xahvZxfav3vhLAjLc7WZFjtUxa7OoMI8k62niYCtFN5dH1?= =?us-ascii?Q?M+HJR4koi18mpu/ip8SwrtJqyO5dKJqwfSQOfYsD5uyXyf+2JmDdZ+/DCSW5?= =?us-ascii?Q?ibWqXBSB3b3g4HBm/zLKAOr86is1s3x45kqzvFvzo+iT4AuJiKqYVzeYYB3v?= =?us-ascii?Q?6QIPd+L3wq1lZujfpNNe2iXX+io86ug0RHw14oGnyf50gRTHyjBWXbK2V79O?= =?us-ascii?Q?Ro095Uabtr3i+w8bcoeddhMNub8ylFpkWQHAD5AvZwW1IzlOUr535gsbZixk?= =?us-ascii?Q?S/WUd02chdhBCWcuq+Fj4J7WoCdeWBAD3hruV37UthatCn74Yy5dsrq9cXT7?= =?us-ascii?Q?J3HiwxbC+gB4QKMH80ZptgIv0ECYMSoWGHbh9cGxGvsBXfEoen7oOCijIk1z?= =?us-ascii?Q?ePCKy/BJTJU2hZTDNJiZymPVJl9vCEn27tB90ScYRvFvCTvLfwYH4okrnZwE?= =?us-ascii?Q?xTEH2uhFsKkdfhm/Q7gV/ojz9sAvUs9O9RHkdGRP/TtJqLae6lr6dSzf/zG7?= =?us-ascii?Q?dXn/aKy7PCZoN76sXnhhibpeoXwjqh/5bELD+eaHwW+ZfJeeQAee6kkrhRho?= =?us-ascii?Q?RqoIfdec2q1VkoNHIl4+Bwu64Zl2yFhTk99VUf4YMscBB8r5XEvwzcCSytYG?= =?us-ascii?Q?7o4J+wJBYKXS7y8pJPsuevbjc4lPlIKrGE9+X+rYOKdaLyoDfW9LtYH6eLV+?= =?us-ascii?Q?MRNVahmsnx6j/XaGihAVsh58cjWhYQIuo3tFxnQzEIT+snoun15NlEU1mryP?= =?us-ascii?Q?fVv4Ir0pE3hVzmbpB/BG0xg1ZgjumXp7UsZWFIPVoehK9Ti6k2h5ks3m7qet?= =?us-ascii?Q?EKSQO0bVmvGDkdWLkCUcNjFxUYYZghEtWmHJuNKwaNTiUCaZ9q4uyRDzZjMM?= =?us-ascii?Q?dGSZw2raZZRvd8vmN16uTfg5LIlWPxRhIjHLUE2Jc6fpI7R9ylZBszuZrbjo?= =?us-ascii?Q?25g0cFP0aJUpt7RzRczRZggELypmEken0SsbRJF1xY/UQzEOV9zrdg6kmbHf?= =?us-ascii?Q?SY/xpC/GrRfx3RQCfi6Jn5owOf5zV0uMjz67KNJmMasH+2a+Z7w61gAiZHTr?= =?us-ascii?Q?lnjCyjPNuInlX1FUH/QRsm0VAjhlAKRRfb03ftJnLQlO63DBBWoD/6q5vvcI?= =?us-ascii?Q?dVjDdCDKebg6CByl9KqWICJdW+olmVpfayBAOewbISHvSTP0M/3mGWNdWWp6?= =?us-ascii?Q?jTwNHJpAjS6IT0N4Klkgcfrjbx83vC5UUKwEJ4gFIJAiEaM1WKR3vn465KHU?= =?us-ascii?Q?bTX7hsR0xSvbA63pmlsDIAzyxMYcshzqaGOVC6ttO5zrYuzadyCpzROQ1o8x?= =?us-ascii?Q?DV+0QpA4nYbFVaVqd1iKvVXfycD0VodTm0iehGq7esFbHxSSG5c5amTFKAE7?= =?us-ascii?Q?Hw=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09307889-d71b-4864-b772-08da63582f64 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 16:12:43.1623 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TNkaqeU1ypVKQ63oRaXXNxLDEhAzKsROicrTzF5JHwNnwq7Amg/ea8wIVdBr0Z9GFy7dDEE6w0G/T1+HrPNXKVsAqIKoEYkOPMbZLhCc5u8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB6207 X-TUID: ZLc5K9AJDk+4 Am Mon, 11 Jul 2022 17:14:09 +0200 schrieb Jan Kiszka : > On 11.07.22 15:12, Henning Schild wrote: > > Am Sun, 10 Jul 2022 22:51:44 +0200 > > schrieb Jan Kiszka : > > > >> From: Jan Kiszka > >> > >> For device tree using systems, add support to set a custom devices > >> tree during UEFI boot. This requires to copy the DTB file to the > >> boot partition and to add the respective loader entries to the > >> configuration files. > >> > >> Both grub and systemd-boot support only loading a specific device > >> tree. Therefore refuse to work if DTB_FILES contains more than one > >> entry. > >> > >> This has been tested with grub from bullseye and systemd from > >> bullseye-backport. The latter is needed as only systemd 250 gained > >> the required feature. > >> > >> Out of scope are overlays (only supported by systemd-boot) as well > >> as unified kernel images (practically broken on non-x86 with > >> current toolchains). > >> > >> Signed-off-by: Jan Kiszka > >> --- > >> meta/classes/imagetypes_wic.bbclass | 2 +- > >> .../wic/plugins/source/bootimg-efi-isar.py | 39 > >> +++++++++++++------ 2 files changed, 29 insertions(+), 12 > >> deletions(-) > >> > >> diff --git a/meta/classes/imagetypes_wic.bbclass > >> b/meta/classes/imagetypes_wic.bbclass index 61a74d4a..3a577f71 > >> 100644 --- a/meta/classes/imagetypes_wic.bbclass > >> +++ b/meta/classes/imagetypes_wic.bbclass > >> @@ -106,7 +106,7 @@ WICVARS += "\ > >> ROOTFS_SIZE STAGING_DATADIR STAGING_DIR STAGING_LIBDIR > >> TARGET_SYS TRANSLATED_TARGET_ARCH" > >> # Isar specific vars used in our plugins > >> -WICVARS += "DISTRO DISTRO_ARCH" > >> +WICVARS += "DISTRO DISTRO_ARCH DTB_FILES" > >> > >> python do_rootfs_wicenv () { > >> wicvars = d.getVar('WICVARS', True) > >> diff --git > >> a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > >> b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index > >> a24e04f3..aff51e81 100644 --- > >> a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ > >> b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > > > This file is a fork from OE with very minimal non-functional > > changes to make it into Isar. I am afraid that feature will have to > > make it via OE. > > Right, from > > bootimg-efi-isar.py | 65 > +++++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, > 59 insertions(+), 6 deletions(-) > > to > > bootimg-efi-isar.py | 104 > +++++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, > 87 insertions(+), 17 deletions(-) If you look carefully you will see that what you propose is the only new feature. And most of the other code is a "trivial" grub template ... which one could shrink, but it is not worth it. In other places i invested a lot to make it hopefully easy to maintain, not to make it look small. What you suggest is a pretty big change, which is going to be pretty hard to maintain. If we really need to go down that road ... we need testing for that. > The problem is that OE core has no DTB_FILES, and seems like not even > a concept of injecting DTBs via the bootloader, thus passing them to > wic. Then prepare an "additional boot files" patch for OE. ... but wait. It already has "custom_cfg". There is "initrd" which can specify multiple files to copy, so i guess all you need is to write it down differently. Carry the generated config+yourdiff as custom_cfg and set initrd=foo to initrd=foo;my.dtb to get that file copied, done without a patch. Henning > Jan >