[PATCH 0/1] Use path in TMPDIR for schroot's overlay

[PATCH 0/1] Use path in TMPDIR for schroot's overlay

[Uladzimir Bely]

The patch makes external mount for `/var/lib/schroot/union/overlay`
unnecessary when running in docker. So, Gitlab CI doesn't require
changes in `/etc/gitlab-runner/config.toml` to provide external
path anymore.

Also, in corresponding external mount in kas-container also becomes
redundant.

The problem was initially raised in isar-groups mailing list as
https://groups.google.com/g/isar-users/c/xelLq3MTc_I

Uladzimir Bely (1):
  Use path in TMPDIR for schroot's overlay

 meta/classes/sbuild.bbclass | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.20.1

[PATCH 1/1] Use path in TMPDIR for schroot's overlay

[Uladzimir Bely]

By default, overlay path for schroot is /var/lib/schroot/union/overlay
that leads to the conflict with docker build.

Docker itself also uses overlayfs for the layers and we come to
situation with 'overlayfs over overlayfs' that is not supported
by the driver.

This solution places overlay path under the build/tmp so gitlab-runner
configuration changes or using external volumes in docker are not
required anymore.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta/classes/sbuild.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/sbuild.bbclass b/meta/classes/sbuild.bbclass
index f9bfaaf6..405fb963 100644
--- a/meta/classes/sbuild.bbclass
+++ b/meta/classes/sbuild.bbclass
@@ -31,6 +31,7 @@ SCHROOT_CONF_FILE ?= "${SCHROOT_CONF}/chroot.d/${SBUILD_CHROOT}"
 SBUILD_CONFIG="${WORKDIR}/sbuild.conf"
 
 schroot_create_configs() {
+    mkdir -p "${TMPDIR}/schroot-overlay"
     sudo -s <<'EOSUDO'
         set -e
 
@@ -46,6 +47,7 @@ root-groups=root,sbuild
 source-root-users=${SCHROOT_USER}
 source-root-groups=root,sbuild
 union-type=overlay
+union-overlay-directory=${TMPDIR}/schroot-overlay
 preserve-environment=true
 EOF
 
-- 
2.20.1

Re: [PATCH 1/1] Use path in TMPDIR for schroot's overlay

[Michael Adler]

Hi Uladzimir,

I have tested your patch and it appears to be working (verified using one of our K8s based CI runners).

Kind Regards,
  Michael

-- 
Michael Adler

Siemens AG
T CED SES-DE
Otto-Hahn-Ring 6
81739 M�nchen, Deutschland

Siemens Aktiengesellschaft: Vorsitzender des Aufsichtsrats: Jim Hagemann Snabe; Vorstand: Roland Busch, Vorsitzender; Klaus Helmrich, Cedrik Neike, Matthias Rebellius, Ralf P. Thomas, Judith Wiese; Sitz der Gesellschaft: Berlin und M�nchen, Deutschland; Registergericht: Berlin-Charlottenburg, HRB 12300, M�nchen, HRB 6684; WEEE-Reg.-Nr. DE 23691322

Re: [PATCH 0/1] Use path in TMPDIR for schroot's overlay

[Anton Mikanovich]

12.07.2022 14:14, Uladzimir Bely wrote:
> The patch makes external mount for `/var/lib/schroot/union/overlay`
> unnecessary when running in docker. So, Gitlab CI doesn't require
> changes in `/etc/gitlab-runner/config.toml` to provide external
> path anymore.
>
> Also, in corresponding external mount in kas-container also becomes
> redundant.
>
> The problem was initially raised in isar-groups mailing list as
> https://groups.google.com/g/isar-users/c/xelLq3MTc_I
>
> Uladzimir Bely (1):
>    Use path in TMPDIR for schroot's overlay
>
>   meta/classes/sbuild.bbclass | 2 ++
>   1 file changed, 2 insertions(+)
>
Applied to next, thanks.