From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7121963773926047744 X-Received: by 2002:a67:f94b:0:b0:357:321a:bb00 with SMTP id u11-20020a67f94b000000b00357321abb00mr10368322vsq.14.1658214339034; Tue, 19 Jul 2022 00:05:39 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a67:c50f:0:b0:357:5666:c73e with SMTP id e15-20020a67c50f000000b003575666c73els50046vsk.0.-pod-prod-gmail; Tue, 19 Jul 2022 00:05:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tAz9RvqO4/bRJyKYcnycUNivwkKw947jn60i/ehCkI6LIAmCaiuJezrF4GZMi2EiiUOl/H X-Received: by 2002:a67:d389:0:b0:357:4c4a:b7a4 with SMTP id b9-20020a67d389000000b003574c4ab7a4mr10708901vsj.33.1658214338512; Tue, 19 Jul 2022 00:05:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1658214338; cv=pass; d=google.com; s=arc-20160816; b=Pabk7BFqnUryxY62huxcY5W2aWw9VgqiDNEcUEs0gOsB4KD/T+yLf4RNrAIpI1LNuG rUsSu/Z+3x1jnTxw/AkR5QsC4TvYxKkiH6NTHbVcEWKiyolXQ6bOrtdas4q+RdxSM56x KmQmHlOB32gS6xt+0x/iRAzk9CA9T6TJHLqgf18UXqyUxI5Q2YLP4F1TXDoUk86fkxpO KLL+jPOrTsUvyVxkKv/z49osZtcwI2QkhhO3saw7CO3EeNj71Uz9fi7Lao/nPtL7qc5e XljRJci0uUHYY6Im9HoM47MbSXWBw7OgMUs3ysOZt/qd9rgioVFkyYNDFIzTYPlAUQwI mhXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=PvA2JXKnsMEtxmvETsp39F9BoHu98T/9wxWuzvkaoXE=; b=g4LO9+gvsC7p2YhjuPyrBYsxABuKhm9l4bfPcJNrXYJDLL2jz53NNzLgc3kT5io6+W RHaJFhP8/0wWDAeTmL+XYxgh/d2pUG49bPeOzKwhrmptdoPksh1QJ/Ji/UAoXacaU4pq S05wTgIHdGTosFzcx17LZ/AzoBdDWtreu2lni9PCiEzWNhB5F6fI2rI8IekFVKk+OBoc IzPPTM9b140YtoQ0tVKs7OUPX1ZEVbuN/G/NBPiq98K7u9Dior7xUIrssQLPsjabWJ1D eEYqkDEUxdtDyfp5uRx763ekeeU0rqe81OEtcoaiQ6uQ04AU5dDjB2fcu25x3sE86Um5 wC6Q== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=vCtwY0Uf; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.53 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70053.outbound.protection.outlook.com. [40.107.7.53]) by gmr-mx.google.com with ESMTPS id a20-20020ab03c94000000b00383fb969820si350396uax.2.2022.07.19.00.05.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2022 00:05:38 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.53 as permitted sender) client-ip=40.107.7.53; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=vCtwY0Uf; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.53 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xr1AgG3Vmn5FeguoA7XfddlTfH66jjfobypxkCc5brl9JELZuh1XmXboPkaCt49nnnto8atF42tFLsgLy6B0el5xCufwvjZHpTqDfDVEBe5r3SzrkPGdKfXlnqRI398aFbCoyQoOGUdFl+46FzRrZ+LlXhj894gRMfBkTATtdMAG3ih0iBME3ob5WwLsA6sHPhqLZPmq0/5vekN4N2La9dBOqcTEHFT3QHH8kd+LVDUnpUE/ENswCJ6KM4i9QobaCRVAOeoPURVitxl3g7DHLca4rO8cuVFhOqZqcIPV0oEy1QoVBFa6GortOlcD7Zz2YDZn9YHqJiDkui6ICRpoDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PvA2JXKnsMEtxmvETsp39F9BoHu98T/9wxWuzvkaoXE=; b=jG3uQmw623h0SmVGRncOBKf6lfH2uXV6pD/TcEv3M0XotubnO16TWkAX0tJALDC+EMPpaJG8BGygek6v55sYY49s/yanm1Qkgpm1kqUrMBMubh720/Gv95QAtPKiLJDiBYo65NdI/Q57z/fD8iY0OJAWxKPaNYe9V+ZJ5kVyUwL0FMgiam9r2+xgdNb4xsquSJ60xBg4mZRexLyOw9nYFA76zCURA0+tEpRvg5Pk8YS/yJ/bW3NrPhe7nyuxMrMquohMcIqUIHBX6KEGZpvkhXLsIoct8eagnmTBknUORAnTSxcdXq/rH4xJZzsRyUG2pw832g9rjHyqRdbBLXDtQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PvA2JXKnsMEtxmvETsp39F9BoHu98T/9wxWuzvkaoXE=; b=vCtwY0Uf4oTHV3w/UhucjSZlxDMkT5IbcSDqkx8GCZkCHK9epkuRO94H3zcM6N9hXKgWg3TWPFERDeK/b98BNExXtHi+xAJvZT5NUYK7SStZ7MmJZr0cYc+JFjlifIWuouv0G7C9Qx7OrKpleTLUbR6XvN0URiNyrYUXBxTbM+eWr1RxY1Aa8ady3gOkLeNKCDx/02OwYfI3dUAoI/zHqwp2HOxIIol5qlfte1tmSa7HIfYjWQW4RmrTfh2jZa/al7k9+QEeR9VaTSR7yiJ+S73VV2xoFFhYGRdUTxHR2UC9gN2cg758JQTn3AAZRMfIwuIxJghHUChpIMNPNYDMKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DU0PR10MB5774.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:313::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 07:05:32 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::6df3:5703:14de:7cc9]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::6df3:5703:14de:7cc9%9]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 07:05:32 +0000 Date: Tue, 19 Jul 2022 09:05:27 +0200 From: Henning Schild To: Adriaan Schmidt Cc: Subject: Re: [PATCH 1/3] fix(isar-sstate): catch errors in signature comparison Message-ID: <20220719090527.0979e298@md1za8fc.ad001.siemens.net> In-Reply-To: <20220719061628.192078-2-adriaan.schmidt@siemens.com> References: <20220719061628.192078-1-adriaan.schmidt@siemens.com> <20220719061628.192078-2-adriaan.schmidt@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::10) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54c41cdd-7bf9-42f8-3e79-08da695511c5 X-MS-TrafficTypeDiagnostic: DU0PR10MB5774:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KEURzDY97KaMzE1xUnxgriPfPImSxZn2McoUndNP1FproZedS1F87bmBY2gFtbOcwxXmUAjgY+9PTHWRNyKvXF6yuk7qIq4YULzaBDHO58bz65D5jOSS41zMyhw/cTvq14Ob97txlDQPJ65ERBxLy9t5+kTw3va7Ei5jqkQCClEKz+Zw7bJOT/Ai54xKbk00w3Sfh24rCSX/WPVtq+QaUbtJY0UTPxIINAIDlGBrtepx2NxJauaZ8lxVJoWbMj9IPdUegl15LqO35u8wNiGZ5shY0+LSItyaqOQhxJTnnu2hsr3Z5jrA1Ix7A/2wRrKFFq1OBmKi7tUggs0LvS6PFg7ITSDUP5yuEGM2IthozyM0hQGkvCIVd5l4q7jgDvXqvwF0J91FoYgmMSHUNoAeeJE0ZBc1UuS7Ge5LXluGT5NvatyT7Nj7dmaxjOR8hlLh4FwUGZ0sdUsRGzGnamuNxJdBoGH36vBLCFoWoYY/Qck9z22un+Y799+6jgg7GsMPfjyPgHK0y2g+RFajl7US+Auro7FeLaZZj8y4m5r+5jnV1uGkGgj9okEcASTwwkVC4cBwqpmeYE8PCj9P18ZWESCFoCOV8sAuioxs6d4jLC+KHvmVGKzgG1n3/DUiNLz1NGIyLZ43VHdWdm5WvJOUPZsalHxSoccBh5a0dGth/k7DQ12wCrur2Q0C+ilmvVSXw2hpn24wu3ZHJYcrmP0/havwBoYssUQRkfQLSlzdigu4It/rn+t04NiM2A/oqG/h X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(396003)(136003)(346002)(39860400002)(316002)(44832011)(478600001)(5660300002)(6636002)(2906002)(6486002)(86362001)(4326008)(9686003)(1076003)(186003)(82960400001)(66556008)(66946007)(66476007)(38100700002)(6506007)(8676002)(6666004)(6862004)(83380400001)(8936002)(41300700001)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TCamsoC9PWebJVCkhySTfLuywbHw9b8rwPtz5Tb7Mo7g6ZQBR3DoD7cMP2zA?= =?us-ascii?Q?OkSHFN6n3NXWAY4SkOwfpfzAZQ+BSdvWFZ4wd/x6MUKlNK7N7m1DdOJl5PE2?= =?us-ascii?Q?9USGCxz/sbGjW0nQhM6yaPP2gyZ1aWYyxDdHpmxpbMfw2V8zCUeqGTQptw+F?= =?us-ascii?Q?0Vf/rMpH2ATU4J7Dk131NVs7DaNlgeTy0twf0C8riuyPtO9GMKvnp2saHgka?= =?us-ascii?Q?5L7xjmUtmzA6tdaURt+/XcbkfP4IGnuOzex7xlXtO1pz1qfExAfY4rwozZFI?= =?us-ascii?Q?dced1ARhU3YH1SrR3T+3NLSP/0+Pn0LGTtcmxr/ApfnurC59wOBrXYMDQq/f?= =?us-ascii?Q?U3RRchfmw86xWnoso0Uiow7HUr7NQOwXcOX1SbARyp5JYKLCjWdMoJArKYmQ?= =?us-ascii?Q?E+wkU/qsnvuQX+TWtiEu423k1nbbrZSwGQzvBni4n5/I5rAaw6dXgjeeyD3L?= =?us-ascii?Q?0mt3qTNM/V2fbhZ8GiADDFzWcwYJT3p+a7BojMbeAb45nGAFKS2Jueh220BI?= =?us-ascii?Q?Qkt/W7B49GN6tR8DLQpHY9O+O9OQQZmaum774p5iHNjuyVjNjkd6ybXWDka9?= =?us-ascii?Q?EWbReGG2IU7VJVFuAVX5dnUllVXZj96n+mbDa4RNZYBQ3K1nghWQgD4zhiZR?= =?us-ascii?Q?fCwbNDCAwszCo4DKY9ynSMn5N8HuooO+InorddfgMQZik0o+kcap90xrqByZ?= =?us-ascii?Q?I/7xXZkCJfLXeXaEl2+5/5wJ6/Y0QoLbbQrnB02YjfeS+FQ5hKWrCcyGTg+h?= =?us-ascii?Q?TViqpyUoBkpNXW/5iq/UueYWAMTd7jnfIA91DRiUQHGDEdw8opu8bP5bC37+?= =?us-ascii?Q?qg6H6u3r7m5jUGKDxFGagUtM8rBVMetG0nWsRJo/4d7POAcvGAw3E6vi1rSh?= =?us-ascii?Q?sJ+3bJ3e0J5SnvTKIzhi+5VQ/PryHcXyu3hq7T81Zotg6Qa4r7xCmaYPethw?= =?us-ascii?Q?lwX/5upwPliQZ6ufCXg9cOdrsPC5r9lhrKZmS2gtn5cEJ5RVBAE/vH0L09G1?= =?us-ascii?Q?nJjREPaX8BRg2/WFPzcgd2x8iLMQw3VLjNxcaC0G7rd14Eq8NB70X1eAZjLp?= =?us-ascii?Q?N3wQRbsQeCGoGncMZRl+LLT0L0Rgw8DEz+BCmHGBEEuMaXIRnyTeb8Q3kyGw?= =?us-ascii?Q?bBsLn1dbozy9IhfOYRHYcby4+pct3i+hmeQca2GlEYJUHhJCeK8ly/nb2uy4?= =?us-ascii?Q?dquGiiCmdiWvjLx9ZyjlJcuPsQWYzVau2v3aBwp5PrFyP/1U9mK65olGofxg?= =?us-ascii?Q?io/OK373q7UMC06x/7zJuQf1kxnRDKTEoqDjyEr6vjT9uk41FNVXyrgYZ0Xf?= =?us-ascii?Q?KmJ6C1RWX2QnxCebXucD2WY8vzYqlzrGRtERkppEzQ8ysxG+D0Jas8JRDX3Z?= =?us-ascii?Q?592Z1s1VUorPdxdCZcUVjc3MRcP28bmF++dAOUz15izN4BzFsgggC7Pdh+0i?= =?us-ascii?Q?qGQ9fLrEyXT6Fp69sOMES3pmOlhikwEYx1vqJBwlOr/C5QsqaZyuQMprMWDB?= =?us-ascii?Q?v9QNNi2suiX3G/kFgkKOyzZBnZuvp89Wo08g8AkOuZ3Z1vyjFxa/1mj9wFF4?= =?us-ascii?Q?8U+Abt8GyeInCOCRE+VCXLY3aaheVHtZMPIoUzdJgXC10uirxW2Od29ABWpS?= =?us-ascii?Q?XhzW0qZwQyHFL9xxbYY6Rs/jmfrgDmKgW2tSHqts/7PMY54/6t5l5BSKfZVi?= =?us-ascii?Q?+b7OdA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54c41cdd-7bf9-42f8-3e79-08da695511c5 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 07:05:32.2152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fYT+8I5JdZVVyB4hCIIovdMiO7RlUnavqIWepOKT5mh7Cd+lxG3mxf0YchJ4kSa3mBMLWJ8mjJfh26UsuBQnb1zzYArnw4RdwtdNLNaQAlM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB5774 X-TUID: 46oCI9C+WlC1 Am Tue, 19 Jul 2022 08:16:26 +0200 schrieb Adriaan Schmidt : > Those errors happen when the sstate cache contains both pre and post > bitbake-2.0 signatures, which have a different format (pickle vs. > compressed json). > > Signed-off-by: Adriaan Schmidt > --- > scripts/isar-sstate | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/scripts/isar-sstate b/scripts/isar-sstate > index 8ea85edc..9f5c17b0 100755 > --- a/scripts/isar-sstate > +++ b/scripts/isar-sstate > @@ -781,7 +781,10 @@ def sstate_analyze(source, target, **kwargs): > > local_file = source.download(s.path) > remote_file = target.download(t.path) > - out = compare_sigfiles(remote_file, local_file, > recursecb, color=True) > + try: > + out = compare_sigfiles(remote_file, local_file, > recursecb, color=True) > + except: > + out = ["Failed to compare signatures."] Maybe there is a python exception for just that, or an error code from which we can take strerr so we do not invent our own. Henning > source.release(local_file) > target.release(remote_file) > # shorten hashes from 64 to 8 characters for better > readability