From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7129878012169814016 X-Received: by 2002:a5d:648b:0:b0:222:cb51:a57 with SMTP id o11-20020a5d648b000000b00222cb510a57mr6491060wri.287.1660054086485; Tue, 09 Aug 2022 07:08:06 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:238:b0:21d:a0b5:24ab with SMTP id l24-20020a056000023800b0021da0b524abls5206127wrz.1.-pod-prod-gmail; Tue, 09 Aug 2022 07:08:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR77eErwbuDO0100TtULVASlRKgQhIVRzw2KlenXelGKXW+wQMsGLz2EeA2uwH4qjYegpFVB X-Received: by 2002:adf:ebd2:0:b0:222:cd3f:cf9 with SMTP id v18-20020adfebd2000000b00222cd3f0cf9mr6275937wrn.598.1660054085058; Tue, 09 Aug 2022 07:08:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660054085; cv=none; d=google.com; s=arc-20160816; b=TkJuQp5P0LwTZHCB3R+ZVGyv68b38XwCMQirIGJbVnbkpYwGyDsasASdryuRDrZxny FO22A9UHbFuwZktFyv6NTTdKcpN2aByUoCmtQ9/m5VKxOdCn6GgC2tTq3EdeevMmwSrf Jnx8KZKIH/8hNYKlo1jTZLRf5ypyqaH9I18dW/6KxF4a8z7Pvv+8kI+57WHCDpx18JPC mW5S2fkhFQHD9f8J24cenzE7UkOzzGljTl+xGFefd/WUnJexrs762csrqS+FcKrXSZSR FEFEMstXGlwo4YC6aBHTZrk5ECJkNSSMjUUXbmpw13XpTPfspy26EQfadhVXh7znmVkl GW1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=kY12w9AXx9l7HNcZq5H6NkNphB9mu/60vrVj/vIr58k=; b=fem0ShjgYcDankbN/D3tzbOznsij3WNyaza8/7PjMkUXkLzN8n0R62XyI8ogg+mOPx l5UotxtZTM6PRnKWAXp+fSjK5oK26HVvXjdZsu9CcvaGJcaDkwI+5SoYUVx2+IgeUAZ9 OzIM8Fi2FocKP0ofkgZrhAy1bdHt+x6EbxSQhZufGUuPGdwMr1oXNRLHkfAt9WFkvvbf O2uhSXFklQk5AE7IF/PCtJhAHK4+MONDnLU0cCE6srZpUbHN0KKiI6waqe9rKZv9WoAW nrFacH3Y5GiNCeGscla+5hJ92WPKY1djtq1UVJcaNvvorFiamhvrkAh37u69gkn42uiq Xe0Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=SI2xJAXn; spf=pass (google.com: domain of fm-72506-20220809140804a5a4b315ca69abc98c-pdrkhh@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-72506-20220809140804a5a4b315ca69abc98c-PDrKhH@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net. [185.136.65.225]) by gmr-mx.google.com with ESMTPS id f184-20020a1c38c1000000b003a5a534292csi6030wma.3.2022.08.09.07.08.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Aug 2022 07:08:05 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-20220809140804a5a4b315ca69abc98c-pdrkhh@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) client-ip=185.136.65.225; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=SI2xJAXn; spf=pass (google.com: domain of fm-72506-20220809140804a5a4b315ca69abc98c-pdrkhh@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-72506-20220809140804a5a4b315ca69abc98c-PDrKhH@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 20220809140804a5a4b315ca69abc98c for ; Tue, 09 Aug 2022 16:08:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm2; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=kY12w9AXx9l7HNcZq5H6NkNphB9mu/60vrVj/vIr58k=; b=SI2xJAXnKt33pM79624xaJCmaO1Cz7kkHr9W/amjRa/HTFi89sVbbIvMqP11/SBGS1nQ83 WxL3NJcKLzHGtsfGnjw5tECZnLL26vw/0+xb5QOcuDt1n3TYo5DCK17l0tLYIbS+d5hAG49W 471xP5zBvwtx2PXpBBuxPq80NawuU=; From: Felix Moessbauer To: isar-users@googlegroups.com Cc: adriaan.schmidt@siemens.com, Felix Moessbauer Subject: [PATCH 1/2] isar-sstate lint: strip variable value Date: Tue, 9 Aug 2022 16:07:55 +0200 Message-Id: <20220809140756.1164520-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: SKBHuwtW2hM+ By stripping any leading whitespaces, the script now also detects cachability problems in variables that are just appended to. Signed-off-by: Felix Moessbauer --- scripts/isar-sstate | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/isar-sstate b/scripts/isar-sstate index 3a1945e7..5972144d 100755 --- a/scripts/isar-sstate +++ b/scripts/isar-sstate @@ -824,9 +824,12 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, **kwargs): sigdata['taskwhitelist'] and name in sigdata['taskwhitelist'] or \ name in ADDITIONAL_IGNORED_VARNAMES: continue - if not val or not val[0] == '/': + if not val: + continue + # remove leading whitespaces possibly added by appending + val = val.lstrip() + if not val[0] == '/': continue - task = sigdata['task'] if val.startswith(build_dir): pn_issues.append(f'\033[0;31m-> path in build-dir: {name} = "{val}"\033[0m') hits_builddir += 1 -- 2.30.2