From: Henning Schild <henning.schild@siemens.com>
To: Tobias Schmidl <tobiasschmidl@siemens.com>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH 1/1] expand-on-first-boot: Use proper first-boot semantics
Date: Thu, 11 Aug 2022 20:55:09 +0200 [thread overview]
Message-ID: <20220811205509.2004e2ea@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20220810192645.170393-2-tobiasschmidl@siemens.com>
If this does not work on buster and maybe ubuntu versions we might
carry, we can not merge this.
We will have to find a way to use the old way for buster and the new
way for versions that actually do work.
Or what does "does not work with buster" actually mean? Will the
overall systemd status turn red and the resize fail, or will it be a
problem we can consider minor?
Henning
Am Wed, 10 Aug 2022 21:26:45 +0200
schrieb Tobias Schmidl <tobiasschmidl@siemens.com>:
> We can now rely on systemd's ConditionFirstBoot to determine whether
> we should run or not.
>
> Signed-off-by: Tobias Schmidl <tobiasschmidl@siemens.com>
> ---
> .../expand-on-first-boot/files/expand-on-first-boot.service | 6
> +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> index fda5001..7c686c8 100644 ---
> a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> +++
> b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> @@ -8,13 +8,13 @@ Description=Expand last partition
> DefaultDependencies=no Conflicts=shutdown.target
> After=systemd-remount-fs.service -Before=local-fs-pre.target
> shutdown.target -ConditionPathIsReadWrite=/etc
> +Before=local-fs-pre.target shutdown.target
> first-boot-complete.target +Wants=first-boot-complete.target
> +ConditionFirstBoot=true
> [Service]
> Type=oneshot
> ExecStart=/usr/share/expand-on-first-boot/expand-last-partition.sh
> -ExecStartPost=-/bin/systemctl disable expand-on-first-boot.service
>
> [Install]
> WantedBy=sysinit.target
next prev parent reply other threads:[~2022-08-11 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 19:26 [PATCH 0/1] " Tobias Schmidl
2022-08-10 19:26 ` [PATCH 1/1] " Tobias Schmidl
2022-08-11 18:55 ` Henning Schild [this message]
2022-08-11 19:07 ` Schmidl, Tobias
2022-08-11 19:47 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811205509.2004e2ea@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=tobiasschmidl@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox