From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7130898771096895488 X-Received: by 2002:a17:906:c781:b0:726:c967:8d1b with SMTP id cw1-20020a170906c78100b00726c9678d1bmr2014041ejb.54.1660291751623; Fri, 12 Aug 2022 01:09:11 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:26cc:b0:43d:b3c4:cd21 with SMTP id x12-20020a05640226cc00b0043db3c4cd21ls897854edd.2.-pod-prod-gmail; Fri, 12 Aug 2022 01:09:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR7ACzfrRi/8cS3yRQJECBrt6JL55ZvDr8C0IqjUsIEbgeWvuWcvQ/QhbnCipiX+1O7U+e9i X-Received: by 2002:aa7:da4b:0:b0:43d:cc2e:c097 with SMTP id w11-20020aa7da4b000000b0043dcc2ec097mr2588468eds.188.1660291750236; Fri, 12 Aug 2022 01:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660291750; cv=none; d=google.com; s=arc-20160816; b=ooxCBJTmjmwbwXtqi1kxJn+QXOIDi0JmpIjIjwjvGISut65RO+J8bkmN1BUOM6UIqa 3xa9Afp+Zw/IOKzJ4REFHXif/Oa0l2wvQbw+wtcvpqa99X/CRSaXExnID8q6B12iZlvx eZUATR6nlofL79EKWhaS1OMRjAzCGrDH+aQDjivO4o/6/6NWVIwZx4ar9xHt4cgE+ZRf 4zZBDBy9BWkubDOZU4Vy/gXrHJRL6RTY/cWuH/pnoIFQnrvYCIttgXU/WLF4aOhyJNiE rmwTDhlDmo/8xA1938I8xMhfgWwii1rzyTvGysvtd4dVuCpSfoCPRwx2zlX2mjXmRzk4 mLZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=kY12w9AXx9l7HNcZq5H6NkNphB9mu/60vrVj/vIr58k=; b=jOGVQAxCaqD10kR4sJG/d6ORy8e8+dEv3uUhqY7EvWnf3yhKPZwO61KpwJZFpkxTgV SpxTjox+UydmvdIx72Q6J6/ApvgkIuDoWbyrumg+ABIeCfUYLfwTzmaiHm4rQpjEVkvF OIl2TagBbb/2YH8XlsSasRfSKB5zYF4OG09IQgGVznjfqtsCR6CIgc++U8QIL8YDwKFe UCkm3NUd6tmcD39Mg2N1C1ZQAIyJwympoGigxCq2kKCMUkZZ5AjKrD1lFcB5AtvezpPL c/NcR3PTvWvLWhK2POJXo1Q/IjXwWX5Q/sDqYCQ5dI8DDBxuGn3yJcLp0QHw+iDTWPF1 AISQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=X5nrBqD3; spf=pass (google.com: domain of fm-72506-20220812080909d06cea012be329dc2b-plpca5@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-72506-20220812080909d06cea012be329dc2b-plPCA5@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from mta-64-227.siemens.flowmailer.net (mta-64-227.siemens.flowmailer.net. [185.136.64.227]) by gmr-mx.google.com with ESMTPS id bo20-20020a0564020b3400b0043c90c086d5si63894edb.3.2022.08.12.01.09.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Aug 2022 01:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-20220812080909d06cea012be329dc2b-plpca5@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) client-ip=185.136.64.227; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=X5nrBqD3; spf=pass (google.com: domain of fm-72506-20220812080909d06cea012be329dc2b-plpca5@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-72506-20220812080909d06cea012be329dc2b-plPCA5@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: by mta-64-227.siemens.flowmailer.net with ESMTPSA id 20220812080909d06cea012be329dc2b for ; Fri, 12 Aug 2022 10:09:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm2; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=kY12w9AXx9l7HNcZq5H6NkNphB9mu/60vrVj/vIr58k=; b=X5nrBqD3DNNhBr3gpSefHX2/HWkLc8lUjvlB3tUaRKMN2qKdAf4IBHU8hGuSKPY0RaUt5H 9idlJDYbXcUTfNvWtle8vxmyRUqyettDRobDXzwP83+Q/FXIsDwBkz6BefTWKaFNQeQQP4jB ROQbSn22X7KYTijlDpfAvf/Vs+ZgE=; From: Felix Moessbauer To: isar-users@googlegroups.com Cc: amikan@ilbers.de, adriaan.schmidt@siemens.com, Felix Moessbauer Subject: [PATCH v2 1/2] isar-sstate lint: strip variable value Date: Fri, 12 Aug 2022 10:08:59 +0200 Message-Id: <20220812080900.1601235-2-felix.moessbauer@siemens.com> In-Reply-To: <20220812080900.1601235-1-felix.moessbauer@siemens.com> References: <20220812080900.1601235-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: 6MaFjs1oqEjE By stripping any leading whitespaces, the script now also detects cachability problems in variables that are just appended to. Signed-off-by: Felix Moessbauer --- scripts/isar-sstate | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/isar-sstate b/scripts/isar-sstate index 3a1945e7..5972144d 100755 --- a/scripts/isar-sstate +++ b/scripts/isar-sstate @@ -824,9 +824,12 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, **kwargs): sigdata['taskwhitelist'] and name in sigdata['taskwhitelist'] or \ name in ADDITIONAL_IGNORED_VARNAMES: continue - if not val or not val[0] == '/': + if not val: + continue + # remove leading whitespaces possibly added by appending + val = val.lstrip() + if not val[0] == '/': continue - task = sigdata['task'] if val.startswith(build_dir): pn_issues.append(f'\033[0;31m-> path in build-dir: {name} = "{val}"\033[0m') hits_builddir += 1 -- 2.30.2