public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Pingfang Liao <Pingfang.Liao@siemens.com>,
	Florian Bezdeka <florian.bezdeka@siemens.com>
Subject: Re: [PATCH 1/2] linux-module: honor modules Makefile
Date: Fri, 26 Aug 2022 20:52:36 +0200	[thread overview]
Message-ID: <20220826205236.075b048e@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20220826175122.20254-1-henning.schild@siemens.com>

I just gave this one to CI to digest. My guess is that it will fail to
build meta-isar/recipes-kernel/example-module because its Makefile is
really just too simplistic.

So that file might need to be updated to become more realistic.

Henning

Am Fri, 26 Aug 2022 19:51:21 +0200
schrieb Henning Schild <henning.schild@siemens.com>:

> External modules might have their own appends and target definitions
> in their Makefile. All we need to give them is the target name and
> KDIR, not dive into KDIR right away.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/recipes-kernel/linux-module/files/debian/rules.tmpl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl
> b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl index
> d3bd7dc30f21..0d16186b5ff3 100755 ---
> a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl +++
> b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl @@ -48,13
> +48,13 @@ KDIR := $(shell dpkg -L $(KERNEL_DEP) | grep
> "/lib/modules/.*/build") endif 
>  override_dh_auto_clean:
> -	$(MAKE) -C $(KDIR) M=$(PWD) clean
> +	$(MAKE) KDIR=$(KDIR) clean
>  
>  override_dh_auto_build:
> -	$(MAKE) -C $(KDIR) M=$(PWD) modules
> +	$(MAKE) KDIR=$(KDIR) modules
>  
>  override_dh_auto_install:
> -	$(MAKE) -C $(KDIR) M=$(PWD)
> INSTALL_MOD_PATH=$(PWD)/debian/${PN} modules_install
> +	$(MAKE) KDIR=$(KDIR) INSTALL_MOD_PATH=$(PWD)/debian/${PN}
> modules_install 
>  %:
>  	CFLAGS= LDFLAGS= dh $@ --parallel


  parent reply	other threads:[~2022-08-26 18:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 17:51 Henning Schild
2022-08-26 17:51 ` [PATCH 2/2] linux-module: call the install target of external modules Henning Schild
2022-08-26 17:53 ` [PATCH 1/2] linux-module: honor modules Makefile Henning Schild
2022-08-26 18:52 ` Henning Schild [this message]
2022-08-27  8:56   ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220826205236.075b048e@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=Pingfang.Liao@siemens.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox