From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7136244065582972928 X-Received: by 2002:a81:d87:0:b0:340:aeac:9e09 with SMTP id 129-20020a810d87000000b00340aeac9e09mr2741805ywn.74.1661590620157; Sat, 27 Aug 2022 01:57:00 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a25:b38a:0:b0:696:4c31:6ddf with SMTP id m10-20020a25b38a000000b006964c316ddfls923527ybj.9.-pod-prod-gmail; Sat, 27 Aug 2022 01:56:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR5/xm/If3UH5g6iga3HUaH6XYlfrCIQ9KTDOgueTBMhWETfkTN3xJHuWkbwTbU7MnqRn5dR X-Received: by 2002:a25:9904:0:b0:686:75a1:6353 with SMTP id z4-20020a259904000000b0068675a16353mr2784449ybn.233.1661590619524; Sat, 27 Aug 2022 01:56:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1661590619; cv=pass; d=google.com; s=arc-20160816; b=S3Sh9Owau5P7q9BHXDhdZTE9rl7OFi7btBofANggY8tIJ1RrAeTsNd0aNJY/dfjwdw XwQ9T24+Zm1rQfjE5oGkMV9pUrQy3eu8z553SV4lj3WackoVNR2/XhMt+542xsHBtHZz +TAgES5mgHqNTUasb+esLhxDxvVgO4+Uhuwl6zpj6ZghCzYQ8BJE5m+rXO6w4e7HFdHv 7IM9qP8m/e04HWftRwPSDP3KgwBVInRQsP2R7MoQR9zieJRnjDRAFGzgwx0hH2UMoBok +IZnU/FR6JO/+LrmwnPKvd6MtO4h/i9uPVeu9DUiOSp54J6RolYbTu+2QXJCjPkP3MPj j9sA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=crbxFwzusJgcBW7OX3K5qM3o+ObqavD6EwqBkTwlIGM=; b=XS3HMKJZRkaTN7DMpRrLQQrMJzvvkpm3vBBeSSSLcF2JCVJFYBN0SZF15f2uN64jCH NaYLHLcsuFEq0oiNuUhhTYGN2JWH63iyUlmQtixF5f31uoWabOuFvyK35NlRPRfzCwCH X2wgxaFuNY1l4+4+5Ct11wqtPFDFKfRPKac0Ojp5FfHDe/wwn91ZdlJYZncbJMHheV07 Ml8BmrQaWExZpdpn8KgztfAE/jI0873gG5/ZHxKr1SmJSi4yNQr/qSdtr/vCBm+j2DUv vmXHCNo4rYSeiquwyODlqMU67qcPqK5E/y0EXpJ7hDtGu4g9zoJszh0N5iTy+++M3U8I Cmpg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=oQl4m7NX; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.105.51 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2051.outbound.protection.outlook.com. [40.107.105.51]) by gmr-mx.google.com with ESMTPS id bg16-20020a05690c031000b00330253b8e8asi120619ywb.0.2022.08.27.01.56.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Aug 2022 01:56:59 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.105.51 as permitted sender) client-ip=40.107.105.51; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=oQl4m7NX; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.105.51 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DeFrGhE0uByVVgsF+K5oeyQbdds3i8AL5yzRYaW5SIpQyPKQ41F+U9g35+zOsAERTgH35e4mtFE7d+fDMELCn4D9TW9PSkDp7o/Gtdk2QVSlRLHwBiXmlodd3vKYWlMRT6JEskZLihNw+9SjKAvEMtyluH6yIZObDZIHn5FM6kRefJ/ASRda+SBBjMPks+hvaaa2z76ryEWg0QqkTBengk8SNCxp3S/GlfVYQY0Q6wp0HKzg0PVY9O/q0OvS+U3q5AlvIPHDtO5qySC31fkC57iPzePExNARIHrkvHPK/82R1o8pH/wwGMXUAcOrMxShGAsIMnrYvfyyfi3jwd92AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=crbxFwzusJgcBW7OX3K5qM3o+ObqavD6EwqBkTwlIGM=; b=AcqDXm7QKH44blVZKrgqzghM2D1ijTScM5KJBtaPanlcxU+uuceWUiaxT8Bd+9ZqHzRtbdVt/TxjDneNNKWCqPZAm2z8AFJ3qxxZxYQs1Hy8Rb0bDhJoRLvEWuddo/cKj3QRqWYcvEr3HculFzwoJf6EVFsjrgKRACS8AHfn950BJLNfGlErVckNu+uOU8Y7XsvpGW8YYN6CibN7xvW/Dr4Kxle4jZb/DNgdNOiVotiNLgxgv/dZPmMoYhvru8hPDtGuaSp5UdB+F1OXY9ZaMNvPeJR8Vzj5+szAGKFWKxQVibHLwVW1kQCXiKaSR+n7Fv8JiPt3mcDyb8lMXi5TFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=crbxFwzusJgcBW7OX3K5qM3o+ObqavD6EwqBkTwlIGM=; b=oQl4m7NXIIBC/xkn0dvTflJhhLRv8JeJDAAEiAlNA346CY8Ny8GprRhoJ5sDKPytPIGV3Vt+zguiD42LLLHswFODlWsYXvi2yIYN3R6tkcDy9nheUxSCOAP+Vn7R/EolpfITBu6/ITdvV9Dn6oCLCVCscvCHY+E7/jdiN4VZO5XC3n4QGf77u5iWrUZLOxvfSyK6P2Vb+rHGUHQolLfMGMtcTDPYwu+jyJrhnXpISfUycJMfDeBRUwJ4chW++kSn4ndeoC5fP/6iRGQZcUN4lj6z9VN0zw01sYtC6ZCuCSBb8M8vyTMPV5DmOJfSH9KTlDQyNs9gDrzvCtkXQoy9Og== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DBAPR10MB4188.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:1ce::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Sat, 27 Aug 2022 08:56:56 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::75ee:d5d2:6b1d:150b]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::75ee:d5d2:6b1d:150b%4]) with mapi id 15.20.5566.015; Sat, 27 Aug 2022 08:56:56 +0000 Date: Sat, 27 Aug 2022 10:56:51 +0200 From: Henning Schild To: Cc: Pingfang Liao , Florian Bezdeka Subject: Re: [PATCH 1/2] linux-module: honor modules Makefile Message-ID: <20220827105651.052161a2@md1za8fc.ad001.siemens.net> In-Reply-To: <20220826205236.075b048e@md1za8fc.ad001.siemens.net> References: <20220826175122.20254-1-henning.schild@siemens.com> <20220826205236.075b048e@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::13) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 70ea5300-c83b-44aa-b304-08da880a17e2 X-MS-TrafficTypeDiagnostic: DBAPR10MB4188:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /4vWeCc5Bu2XV5wHkVpunG/ZOnVo3i+f48bg5QWnnx5jKUbg/7LF1fNL9pXjy1yo1LwtVjECJqsPeUtdgWoUSk8Vu9S38bF1kp3KvB4ud52QQOOnfAdY9Izxd6FIt9YdNKhywKm5HVVyHTxmdbSPRAR6TTbUykH/GSmoHmV1pP5VuSwGeH9se+P3+N082jxK3mK0u2f4UYAGoc5BEZix20FsrN0C0Xi9AGyi2SVaDNMnBfIfpP4hi3MWXolbckeWGxHnICQUh+zO1aeK2xiaHHqvOb4KR5AQyorb27lt0gjR5y7ezzZO/OZzQWBaKU7DlE24QKi8zSPc/0oHNQv7mS59iaqRfkT3PZ50hXVrpexvzxSRpY7zeqp4Y0DIU4fLQHk7VDeftF1sQhEUUoRUmXMZlpW+LMlWGD4cFOMd6PMcoOBAFa3w0sa5k18MZoIOALgi5t13bHhQg1yQIurfw/EeE1q6PySnTJxAyK4lsH1XVM7KsZfSK/XfykIX93V40fdDXvWD8cBb+OXRpzNt7xRioVSW0EmeyxgIzFDmq8SWgM6OUHugrcZOc13YdJuziB8ehL1qfL9R2+SUXJ9SiqOBHfFJCmlM6py9OO3j/8IFMuKZ4tIuKIWvS54sDaWHT0/IH7ctraHRAOaDoRTR0M/PSNqUU9ddAzpjTPqtpCgOTfaWkLKPawvSlLxLJFr1PV3Kst1bD/i+TPEic46dtQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(8936002)(86362001)(5660300002)(44832011)(66946007)(66476007)(66556008)(54906003)(316002)(4326008)(8676002)(2906002)(6916009)(38100700002)(82960400001)(83380400001)(186003)(1076003)(107886003)(6666004)(6486002)(6512007)(41300700001)(9686003)(6506007)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SSkPpG4gN0q98PV24WlpfwBdN/q6Tkyj/jAptzxkFBc6DGwh5kfW/ek3un3V?= =?us-ascii?Q?AvXaAwF4fHsXJ9TVZQ5r422pjbUQxsuQESvSjEolLVcPi1rGhpthDNkJj7r+?= =?us-ascii?Q?HDWHUnr9stkFZumbNf0riXeiNpcMt/K4SnTFgERSUwlEO5NokViqUuX9EhuY?= =?us-ascii?Q?ClpHnKXbBBTS/ZW5UryY7ayRcBXyZaG+IL3iETtnXW44bCewHpP6ZjHZS3ki?= =?us-ascii?Q?XbLKpXXOUBn+qYIo5MMC4f5Zd/7sqbkMa9xuP2HX/uyzlTO8a5JY8lTw+HO2?= =?us-ascii?Q?db511njCTeRhroXlLinqJ6q2zi97pKv7dYthBMPR8wZJe+0D7bcG3qx4i+RN?= =?us-ascii?Q?H/O/32vwVh+Z/VW4eHopQOLiOSKwFM/pVno5ebWgChF1nVMSWECoPK1DlRGh?= =?us-ascii?Q?6mc4mNHrdXiwhvgs/WMSLFcg9deOM2kwW89y9pOiYGvSfnNINaYcwMiYHbol?= =?us-ascii?Q?l0bynEt+hfZ/Lsc1+thrZfgDmo9ZLOOz4lt/68KtVDZLKIv2nRawSMZYWJ6M?= =?us-ascii?Q?ugZENQy/WFveeqLZofDOtaaUpnhlAMWwmxaZBjoqMiITOXSSG9aPJTDqJAyy?= =?us-ascii?Q?YC/X9LYWdpq/9LsEfne+JL9RBexFOzh+ZfIqmpkcMs93FwztB+FVYOpP47fo?= =?us-ascii?Q?bFM3OA0TFmqblsIq+MEshxTT4k2UacRdFcte9ICaErdt8XTAQ1pL5VZxY2zH?= =?us-ascii?Q?wDEzlcCtVTO1WCqfJD0Rl2F8jZFV06iYN2yAUMoiLjRx8xi6sA06GYcPtoNZ?= =?us-ascii?Q?MRt2llOSpfRUfm3K7bOgtQtY/J1Z0pc0r78OXSyHgBKcZTifFcXdwZlj5aBa?= =?us-ascii?Q?aUItuhuLAbLf0HHAVLBNWVUGQ2VIvXYuJAe3G5dC29nQ/eAXFvojaXQEPOni?= =?us-ascii?Q?D1UVBmBjRJTrg3CPMfZGq/VoXFIw2x/1mglnq2JrV9Gt+tV6Y7ahDvAWTUFs?= =?us-ascii?Q?0Mw6ojW51+WUPBhl+/JjV8EywQXjEn6ZbtJ/0FNBiDhyIKPxMht+bHfPJhBd?= =?us-ascii?Q?ch2Ip26ybVKCog91AJWVYpwOaJ8QAtNxNbajZ/f5LktE0ao7NVAsMkRxKSUP?= =?us-ascii?Q?pKaQaKZNhWSGt0zdYVS4jrP3tmlXoqmCZlbN3zOeqM0czWWh+9WWOjLBxd+n?= =?us-ascii?Q?CyWr5uln6NqIenjsCH2gSpLwmgIhlkOQIEQReFMccSR6ML1EKe1kLnSETRAE?= =?us-ascii?Q?nNj+dz9TMAo9PynQCSmi6hIvkcM2bGV5WU5K1tH2qdLJsxu9LIdhYH+2Yc2x?= =?us-ascii?Q?8d/FtvI/4ANjDwuVS2OAQQTxh71bDXr3goRsHmvAp8OIGGtHaVZoGQ1jBViA?= =?us-ascii?Q?0TmxAB1GvgrtogL1gtJbkVnnSbi8NKeHK0qBdKHFrt3o0pi2DEi42udU3HDq?= =?us-ascii?Q?m/Jk9zEau+6Rphv4nnuVxVZQqCWRCzWJpPbzx9dIWAFeNjw16C1Kgi5526Iu?= =?us-ascii?Q?qxaUf3X9xAZVJWF7G7XwWKVPBWU82icV6vxEy58DDqqZEWJzM7s9qakBF06y?= =?us-ascii?Q?oI8HLUV09rxFzNS/09jUFDoW6ajK6wFb+ayzo6KfuDw/XUVboGZ3tboLvOTN?= =?us-ascii?Q?tvCp2ZoNJhFbErWkmJXoqUN2ayPQQK9XwnfP241vECn1danPQ/jnUT8FZOYY?= =?us-ascii?Q?PGUgHOL1ria04j0oecYplxZKi8h+CbASXMoO+SabxCDicCaELqMtb2hIX5pl?= =?us-ascii?Q?wqbJjg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70ea5300-c83b-44aa-b304-08da880a17e2 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 08:56:55.9848 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dlyL3FBSpPsNOOWUUzcgeOXgQ6udGsvJzSN+h/X8dbaV6I6LNpHVynF32Sxi3wmWdjyj/mysa+Xzm8RFTXwKtoU0MEmvqCQfFMSKlkeWp7I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR10MB4188 X-TUID: QD4LkoDmgrU6 Am Fri, 26 Aug 2022 20:52:36 +0200 schrieb Henning Schild : > I just gave this one to CI to digest. My guess is that it will fail to > build meta-isar/recipes-kernel/example-module because its Makefile is > really just too simplistic. Indeed /usr/bin/make KDIR=/lib/modules/5.10.0-17-amd64/build clean make[2]: Entering directory '/<>' make[2]: *** No rule to make target 'clean'. Stop. make[2]: Leaving directory '/<>' make[1]: *** [debian/rules:51: override_dh_auto_clean] Error 2 make[1]: Leaving directory '/<>' make: *** [debian/rules:61: clean] Error 2 In the end i ran things manually. CI at Ilbers did not finish over night, not even one of two pipelines. And CI at Siemens has sstate issues. We should _really_ have only one that is public and powerful. > So that file might need to be updated to become more realistic. Will send a v2 with a patch to fix that Makefile of example-module. Henning > Henning > > Am Fri, 26 Aug 2022 19:51:21 +0200 > schrieb Henning Schild : > > > External modules might have their own appends and target definitions > > in their Makefile. All we need to give them is the target name and > > KDIR, not dive into KDIR right away. > > > > Signed-off-by: Henning Schild > > --- > > meta/recipes-kernel/linux-module/files/debian/rules.tmpl | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git > > a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl > > b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl index > > d3bd7dc30f21..0d16186b5ff3 100755 --- > > a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl +++ > > b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl @@ > > -48,13 +48,13 @@ KDIR := $(shell dpkg -L $(KERNEL_DEP) | grep > > "/lib/modules/.*/build") endif override_dh_auto_clean: > > - $(MAKE) -C $(KDIR) M=$(PWD) clean > > + $(MAKE) KDIR=$(KDIR) clean > > > > override_dh_auto_build: > > - $(MAKE) -C $(KDIR) M=$(PWD) modules > > + $(MAKE) KDIR=$(KDIR) modules > > > > override_dh_auto_install: > > - $(MAKE) -C $(KDIR) M=$(PWD) > > INSTALL_MOD_PATH=$(PWD)/debian/${PN} modules_install > > + $(MAKE) KDIR=$(KDIR) INSTALL_MOD_PATH=$(PWD)/debian/${PN} > > modules_install > > %: > > CFLAGS= LDFLAGS= dh $@ --parallel >