From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7130878582899867648 X-Received: by 2002:adf:f841:0:b0:225:8b4f:9a5c with SMTP id d1-20020adff841000000b002258b4f9a5cmr9153291wrq.667.1661872016772; Tue, 30 Aug 2022 08:06:56 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:4848:0:b0:225:58db:7886 with SMTP id n8-20020a5d4848000000b0022558db7886ls6963885wrs.1.-pod-prod-gmail; Tue, 30 Aug 2022 08:06:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR412uuAqMLq+FZ8pk40VM14OmaSpeTqxJ+zwc261iaFfe1DUMLh9g/+8+kJXRxgBiGgRm9s X-Received: by 2002:adf:dcce:0:b0:226:d8dd:1de4 with SMTP id x14-20020adfdcce000000b00226d8dd1de4mr6851734wrm.271.1661872015533; Tue, 30 Aug 2022 08:06:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1661872015; cv=pass; d=google.com; s=arc-20160816; b=bXbRbK3cbkHIpiVA1TizPv4F/vbX3BfwoWGxdbc8VczGhGt2s8dyrkc4I0Siv0CWBA r8oTdrnx5eagUOTI8O0dyXTxacuQpEgMZyPY20LpWQ7myE3GNZ8BMlnVzV31yi4JxEdw 8D9Xtl/o7mWfsSl45i6DDxF9xAvpe8c1alXcZh0Qr+aI4ACEA+T+ncGiiyvDzBSRNCMP KAI1Sot8tpPy965HspfTHk5YriRp3+zw/RaqL4LXVUdmIOuUeShal13yji5yizKdVbF1 Ft35736yC+ipEqnLC/VJj0KKM3rMOzMMSE9cpYeyDyEcnBjU0CgSUajl2YGEbf9kX//g JW9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=QXEqIY38p0VwF7Km/aQcn4lLo5TqxrzQYeiHIPbregk=; b=0ZvMumivgUAdw7cQoelwBkTWdVScTIx/W9eRFMp/0ewKeyeJH8Aq/Y0DSzxZpcJnof BRdBxV3IkO802eDF2zqmcntkqxIii/hiaPDMemniDCKj9dn86zcdOTG3rWOyLGrlfAlN Bv2E7DPjPym78vgLM94o7ciLAV0pSQAjC81jaiN1CLoJbRB3m7Q4gSBeUcoj+4K6H6NQ /l5Uq/licggANBS8BWTuzdeE1tH98I20sKSdxxoNHGyEW5yG7R0D1rsubT02xXBLTi1k flc4G6JN7/+D+UR4zowh1SLsBvyYTMIF9Af1q20bBFvvg/jKll5T/5Wn6+150laqXTdp lV3Q== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=jPGwU9aa; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.54 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140054.outbound.protection.outlook.com. [40.107.14.54]) by gmr-mx.google.com with ESMTPS id az17-20020adfe191000000b002255a22a598si470913wrb.6.2022.08.30.08.06.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Aug 2022 08:06:55 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.54 as permitted sender) client-ip=40.107.14.54; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=jPGwU9aa; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.54 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=THwH5cvWKa2kH526rZcjefREAkNY6mP+sxQV27XcV3Qrj0jxXO/+CJNSZotU/cRSvxxR+s91Mra0nnTQ7ulohpHQ26nBcN+JHhhObn8iv3iMxglOpk7zo6PpUyFksXJdMTVnla0P/YzQ7oNc4PrGdVg7Dz7SOgmui0bd9/LO7XVxtrf0QB8b2pA9Dpf8p4eILD3OtJaot5CiAFLzNLBUsnb+tBrUmNTyZyGr22P+wtxwuPL37zvEwfq3dKgg1HJJOPF9LT13psWxFJ2qyfD1HWX6h1VLVFHt7QtWSSmI1TVey+6h6dBwdWzfpVn012X26W9fCCwkn1tGAjyCnhMMew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QXEqIY38p0VwF7Km/aQcn4lLo5TqxrzQYeiHIPbregk=; b=mJBLOwfL2iLJmW5NqrdxCHLUQfVrxM9DRpV9EDsmq+DIgrihvN91CPZ6eoQVWEAc2KXx3HNdG4iTsNtL6jPAK0rT88mN+CvtURv6eOr3wliBt8MB95k5pWywJIdijtVUf3gLQfioDvQ1cTSY3qkP33XdOYSSRBPCgapmPWYms9E1L2wIdM3hcWHGQfP1aCoe5MpOpk27mtZLKzppyIys1UNVeDwoR6kOSHz4j/y4dIt3aIeFfJ8d30JFanMtltRWESXKtyCArurX60OZVrzLn9baat48B3KtIQNRCSaAp65G+Bnvej6cPDdwiALGQElhycXzhvVZQ45pNHRG/FM0SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QXEqIY38p0VwF7Km/aQcn4lLo5TqxrzQYeiHIPbregk=; b=jPGwU9aamryw0UXnatEtTDGBcHvm2tt14cTfovuwjvOuemYy297kScePxx2I5cW/pL2OQu9l5u1FWD45mIC6qRFw08bJDRF0FACfLNpbCY0LBgw4nYXpNG2n4332l+0LCxbrbOkESAN0JOMM8RAPqJJgD0B6BxYE6zZHO9SP5+oKcFFSSWTlP8q1vwbjpIa3GGIHGeouZFaynsQLzFgvflEzh/ioFncud62tYC8mdHQp8pmUzfeZF0cw0imt86UyHZaEzTg7Y20y8H05R9UDQLOmUHhSLKR/71DxNl8LDOrCwlTV0sP74MM2yLb2066qHjwdrF5J78SZqtTE4IKuug== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DB9PR10MB4972.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:2c9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 30 Aug 2022 15:06:54 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::75ee:d5d2:6b1d:150b]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::75ee:d5d2:6b1d:150b%3]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 15:06:53 +0000 Date: Tue, 30 Aug 2022 17:06:45 +0200 From: Henning Schild To: "Moessbauer, Felix (T CED SES-DE)" Cc: "amikan@ilbers.de" , "Kiszka, Jan (T CED)" , "isar-users@googlegroups.com" Subject: Re: [PATCH 1/3] wic: locate systemd-boot efi files in buildchroot Message-ID: <20220830170645.359f349c@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20220812065040.1580962-1-felix.moessbauer@siemens.com> <20220812065040.1580962-2-felix.moessbauer@siemens.com> <20220822134750.44a99564@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CH2PR08CA0025.namprd08.prod.outlook.com (2603:10b6:610:5a::35) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63db1cf8-1ccf-4b54-a34c-08da8a9945fb X-MS-TrafficTypeDiagnostic: DB9PR10MB4972:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CyuGr9CHZw/NHXFis63qSV+q+8GNwtTOWB0o4T/w49gdYSnUH19p55UozMyCzWj7tAg9bva3ZCU9RHnPQjjWxWnetFDe9k8XvLc8H3hmmT6BfqyD5GfLRvNpw6LDMfxTCj9bY4NT/4OKuX3X0KjalxBnw1J6jIVVeijpqk/KiLYx1Fkbu1HXo+sD034S+KOwPtBNMV6lpwbs/FAJKDV2oQjOop8PHAtkcvFz0P+rW4bPHYMcxl+6Mryyl0yznUazJB84aCDr7PA9Bcg8MxhftaFzUsqpb3cvTXEFz9Yta1NBJTVI+040X666TmQPS55+HJv4aJsnRWn5krwyEauNYvn102YYPxfVgqFDjd3USYvIsS5nRjdZrk1Eg+LtGwq4h4DMR9havNmU0iGDn1vv5WArHNa6I9pzE9oAEXNDvFf6PeGSIlZqcvBKfgku5i7eJVF598V75UG7aLcaNGQqFOhgqnSR9HUvgU9qedAdYV4p8tnvHJrLpx6IxxkQ5AnKthuXEjFmzAbFaudHuMHBxz3a0aLrj/L0xT8u/5vDzo+bKGx0lqRTFSKFsac9WrvX0AiNOnRV5VWqLjoafjR+ikbpoqWdSJGqK2sD/Y2cQc3/IxI05T8LnLqBr/7fu5ttgulqZ3OfO156v6huvcFsNh76BbonznzuvQ/bBAETl0v+no5ZHwGZXk0kkfw0nkHUg6iRaSZTE4XLyygml+nTNNIj1r3nwMT1EeJyz/hD+qW9YgIWzorNWlIndmE8j5m0ZUf0K3ZC8UNBuG1+XwWVSQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(366004)(396003)(39860400002)(376002)(86362001)(8676002)(82960400001)(4326008)(66556008)(316002)(66946007)(54906003)(6636002)(66476007)(1076003)(83380400001)(6862004)(186003)(38100700002)(6506007)(478600001)(26005)(6486002)(9686003)(53546011)(41300700001)(6512007)(6666004)(966005)(8936002)(5660300002)(2906002)(44832011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjA3WVQxNGZwTnFEb3NWblNhcHpWU2J6QWh4am5ySG03K09OYnltdWFDVXls?= =?utf-8?B?TnhPeEdKTnZZVlFPb25SQVhEUmNyVklhajdKYlJlZUk2NHJyRWZ6dklxa0RC?= =?utf-8?B?UklVSFlrV2tiT05RVFJpR3JQcUZVR3ZEdk5YSUduRkQ4aXJlRndDZSs4Z3RK?= =?utf-8?B?WXZWRFp6YjFIZTV1alYyQ3N3b0hvRFE2TVlJSW4xWE1hK3VOZWZ5Z2YwUlZT?= =?utf-8?B?WEVScGtwOFJ2YlpPdlk3c1FwWHB5YU5iMWgrdE5iYXdsMkxyakd2ZG5tTVJu?= =?utf-8?B?UGFieERNY1E5VlZlN1JPN3RVTk8vTXN1NHFsbHlUMUdxaWovbHM3K0l4UTdF?= =?utf-8?B?NTVjY2lKMndQM0JqOTNYM0NHeTRHTHJWNHlYTnZYVFQ5bm1kaitvaDlYNjha?= =?utf-8?B?S2FUUU85YktCcUFPMmN5N1RvMUJqaURvSTczQVNrRWozUnplY00vWk9qanVE?= =?utf-8?B?Ti9ZT1ZldDd2QWJVZnJ2a0JHSGxRdkxyVWFkQm1TeDJiS0RhYS9Rbjhhd2E4?= =?utf-8?B?QXdXUnB5NzQxUllsOWtUL01GVythVjN1TnpBNFBOUjlGYlBveEFKRnNqbFAr?= =?utf-8?B?a0YzcGd4bjQ2clN6eFlmZXFaN0gwclg1MjUvK2NzTkdtWW8rUlFvUmU1WjZY?= =?utf-8?B?blBJZ1puWHRMYS9lN0Zyb0o3QkJSbGxmNUh6ZWVlUlJ2UlQ3OWhlWTc0aUlx?= =?utf-8?B?SFdjZnRUMTMwSnpMOVdoQmNwcFFEckxGTmdpTWU0TnFCRXJwYUE2ZUF6aWpB?= =?utf-8?B?ZzV2TEZPNzZvcUN0WlpTU2lsRklkVmJjRDllY2NYdkM1d2V2Tit5UmcreFVO?= =?utf-8?B?Q0dra0FrRU1aaHJoSno3Q3JpUUZUWENtRFN0cjQ3ZHU5N2E5cE1yYkYrL1VH?= =?utf-8?B?ZGw1dUVkQ0V0aFNvaUtSaVM1NGk2d3N1bzNDOHMxbHZ1cnltZ0FlUFVPT1A3?= =?utf-8?B?NTUzOHJyTHJDSTJGY2JHcGR6Zm1RT2s2N2d4YzRGdDR4UTJXdnhPazFDS2c5?= =?utf-8?B?TUczb3BzOVRhMTEvSWlHYVdYUEJ6Qmc1TU01em1BNFJUOGhlN2lraXEycWwv?= =?utf-8?B?UWdHY1FJOS9TRmxsbFMvdFo4bzRTRjFMSGpqN2NmWnR4ZmMvczJyMFV2SWow?= =?utf-8?B?aWZFTGF0VWxIakdqL3J0WSt1UUdOMjR0ZGFRKzFjQ2tWbVVYM0RwZnVta2d6?= =?utf-8?B?YW1qTGQzL0p1SVgzdHYyODVoaXBoZ2JTSEY3UGNwcVhqdnVCSzhUV2hwQjI5?= =?utf-8?B?c3lRZ0NublNJMHFGaHJQYm1SNC9wa3RnWkh1Q21JaFVlakl4RzU2eVR2Yjd2?= =?utf-8?B?VzcrQ1h6NTdGYzhSVlRrMmhNL2huUXpETi91aFM0K1d1M2ZHSWJCamhyMVV4?= =?utf-8?B?NTZXUGhUNDZNdXU2SFFwalJKNXdiZlJnc3FYVFFZb08ybXBZSTFkak5ocmU3?= =?utf-8?B?NWM3QUhiQWxlNFJPQ3h1Y0lrOG8zOHNQK0pFT0gzUk9iVVBwYjhnNGJJaDZ3?= =?utf-8?B?ekZFYWFyZE84T1NXM09QNkl2OXJqc1BJWWJEeGpmQm8wTmZrRWVMa3BsMXZ1?= =?utf-8?B?QWsxei9lZmtRa3ZGeGNDMmxqWEsza0R2RVoxdkdkd0puc3VWUGthUGtXcHNx?= =?utf-8?B?SC9FdzdOY1ZGb2JNc2ozS3kzUmNQL1BXbzJHZFJYN1JlRFlPYkdkcVlZNnBU?= =?utf-8?B?UW9qL2pjZlRSRjBENEUwY2c5WjRJN3hROHlSeEJlL2xsQnBsNzhRR21aMjhG?= =?utf-8?B?SlhObE9pQVpCZTlrYmtmMXBaMXNCWHoyTW1VUGt4QzhzZm9KenA5UUdWMWlS?= =?utf-8?B?d3NlbnBiK2cySWNDRnJpWm1iTnR3QjBZaHNYaEJOOVI2UWJVZUFpbXEwbXVu?= =?utf-8?B?Mi9CM2ZiRXROM1BlNkxLNkFjTkNnSnpzZlRCTXdCNmZwZXdtU3RZSkd6dVJR?= =?utf-8?B?NGZqNEhjRjBwenJESVNLZVlDV2xqaktPU2dyQmxVTU0zMGtFNER6eXluTEpF?= =?utf-8?B?NXVGcEVtWnBTTWxLM3U1RG14OTY4eEZqc1Y0UUpXZHh4R2tjcFJJRXVna3Mr?= =?utf-8?B?Q1ZPMkdPNWlIdDd6WkV0dUxSWTVwVDR6WnhwSFV6MU9oS1hxSjAwMFNSazdq?= =?utf-8?B?VDcrWVJzTVJPci80RTF1U1lib1IrS0sxaTB1TmdqU1c5MUx1b0FCekpRaWZs?= =?utf-8?B?bUE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63db1cf8-1ccf-4b54-a34c-08da8a9945fb X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 15:06:53.8076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7hUYaqTl1uob7/iEMuC7Y6Y2GwYydUZJUJMv1E7ou6Y8Fxpb85voCW3T3Sgzu6Xvyjk73KT4D1jeHUn/w8sl6bw+4qjNpcB3At/oWjsWFwM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB4972 X-TUID: bhd33ZXzTARS Am Tue, 30 Aug 2022 10:23:35 +0200 schrieb "Moessbauer, Felix (T CED SES-DE)" : > > -----Original Message----- > > From: Schild, Henning (T CED SES-DE) > > Sent: Monday, August 22, 2022 1:48 PM > > To: Moessbauer, Felix (T CED SES-DE) > > Cc: isar-users@googlegroups.com; amikan@ilbers.de; Kiszka, Jan (T > > CED) > > Subject: Re: [PATCH 1/3] wic: locate systemd-boot efi files in > > buildchroot > >=20 > > Am Fri, 12 Aug 2022 08:50:37 +0200 > > schrieb Felix Moessbauer : > > =20 > > > This patch locates the systemd-boot efi files in the buildchroot > > > and not the target chroot. > > > By that, no imager-specifc dependencies have to be installed in > > > the target rootfs. > > > > > > Signed-off-by: Felix Moessbauer > > > --- > > > meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 6 > > > +++--- 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git > > > a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index > > > a24e04f3..7a65a98d 100644 --- > > > a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ > > > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ > > > -415,9 +415,9 @@ class BootimgEFIPlugin(SourcePlugin): grub_cmd > > > +=3D "reiserfs regexp " + grub_modules exec_cmd(grub_cmd) elif > > > source_params['loader'] =3D=3D 'systemd-boot': > > > - kernel_dir =3D > > > os.path.join(rootfs_dir['ROOTFS_DIR'], > > > "usr/lib/systemd/boot/efi/") > > > - for mod in [x for x in os.listdir(kernel_dir) if > > > x.startswith("systemd-")]: > > > - cp_cmd =3D "cp %s/%s %s/EFI/BOOT/%s" % > > > (kernel_dir, mod, hdddir, mod[8:]) > > > + imager_efi_dir =3D "/usr/lib/systemd/boot/efi/" > > > + for mod in [x for x in > > > os.listdir(imager_efi_dir) if x.startswith("systemd-")]: > > > + cp_cmd =3D "cp %s/%s %s/EFI/BOOT/%s" % > > > (imager_efi_dir, mod, hdddir, mod[8:]) exec_cmd(cp_cmd, True) =20 > >=20 > > Reject! Touching a forked file will need that fix upstream first. > >=20 > > Or (more likely) need to play with some variables to make that > > upstream code work. Check the diff between the fork and the > > original, and the commit history! The code looks a bit weird, the > > idea is to only insert a few lines here and there to hopefully be > > able to keep up with upstream more easily and avoid merge > > conflicts. =20 >=20 > Before changing this, I checked the commit history of each line > around that =F0=9F=98=89 >=20 > While your approach makes merging easier, changing things as you did > before might break at runtime as variables are misused. To give an > example, have a look at [1]. There, you overwrite kernel_dir which is > not a local variable (re-used in [2]) and which then points to a > folder where no kernel is in. Valid finding that will bite someone who wants to use that startup.nsh feature. Maybe set the variable back to what it was or overload it with a local scoped one. > Getting our customization into OE will also be hard as there the > imager works differently. I think we will not be able to get certain things there, otherwise i would never have forked. I managed to revert a lot of the forking done by others, but some things remain and do not look like we could make a valid point for upstream. > I really prefer to let the code reflect the semantics instead of > trying to make the fork as minimal as possible. But I'm interested in > others opinions as well. Maybe Anton and Jan can comment. The problem is that authors do not know which bits are copied/forked and how to deal with those. And maintainers often overlook that stuff as well. Maybe because i did that work and have an allergy against copies that get out of sync, while others are more relaxed on that. At the moment i see no need to touch any of this again. How well it will work is left to be seen when those upstream plugins see major change and we have to merge. I guess what would also be useful would be some sort of CI check where we make sure that any forked file is at least as new as its source. Either with a bit of git or with test -nt/-ot and git restore-mtime Henning > Felix >=20 > [1] > https://github.com/ilbers/isar/blob/master/meta/scripts/lib/wic/plugins/s= ource/bootimg-efi-isar.py#L439 > [2] > https://github.com/ilbers/isar/blob/master/meta/scripts/lib/wic/plugins/s= ource/bootimg-efi-isar.py#L449 >=20 > >=20 > > What you are proposing here is very much against that principle. > >=20 > > Henning > > =20 > > > else: > > > raise WicError("unrecognized bootimg-efi-isar > > > loader: %s" % =20 >=20