From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7136477983660834816 X-Received: by 2002:a05:6512:2391:b0:494:7f90:ac04 with SMTP id c17-20020a056512239100b004947f90ac04mr3977553lfv.521.1662052660699; Thu, 01 Sep 2022 10:17:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:57c9:0:b0:492:f1b2:ac20 with SMTP id k9-20020ac257c9000000b00492f1b2ac20ls1953854lfo.1.-pod-prod-gmail; Thu, 01 Sep 2022 10:17:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR40N7vc2+PfPxLNltSTSvyFE+RQ/6ofbEt1grlRByRI/3li/+mAkZRgKLPTDmSIAOyQrB2a X-Received: by 2002:a05:6512:a90:b0:494:726c:360e with SMTP id m16-20020a0565120a9000b00494726c360emr5317950lfu.221.1662052659394; Thu, 01 Sep 2022 10:17:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1662052659; cv=pass; d=google.com; s=arc-20160816; b=U2UWUVNn2BHRlWPCThdRz8G38GZDu47o7Sjg98RldS7x13dp8sh08QrGApdWLpFB3R 5KlnoznBoKELtpV3asP/yDyu4Rpp6DQlXX+yfTpbRPV+kMOP4tx/d1bRHMcb7Nk+3Wbh FtwDmbMz3NWiVdY9tKj8Y/V8unYy9jiXIjxThpFEoE+JXyKWOBOtLvt4RugHQfXBFgvL w8tgXvzFG/QYGfwLchiv5BXokwa11JMdiEcoiyNGmVYdLX9/HWAVApCwRDwuCoaVpHJS MQHNg/zc72fuFvTN/nVoQjKAid8gNiYjZn7wtisI1AtKcUpelEOZTxqIBdQ9LXehL2lH 0RUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=zfDTQDZj9J/mafbqfkxpZ+TvAu/bQqanD+sT9NiOFjE=; b=CORNbw5vU1skLGI5VR/nSHeTVjE3KbAZQJxrqMYsT8p31SwemJGvbAJTYfQeYwmrkV wP51W9YDcEel3jlFQgEfY+PHefsdY9umbpaSBwgg45AiQgF5h2BRQzNh3J1saFiUGbny AC0U7y/i2ClHPcgi/WGm1sOis8wiRsOO8tFnO7op/kDx4kH/1IAecy9Tc74IvRPBfZYs 1aqlg0EOqAditRcJ/qZUrrzn03V9IXUEQhxC1EDZNi9CoGYm43mNl230HHe7RG+yQVIl JorQ5PxPXJSO7AfYhuUrJEboxCL0X/fuNsuV1eRaflyrsaUxg1RxyaZhdfvHic1PpVJA yQxg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=abKtFcmK; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.79 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140079.outbound.protection.outlook.com. [40.107.14.79]) by gmr-mx.google.com with ESMTPS id c16-20020ac25f70000000b0049465aa3228si258483lfc.11.2022.09.01.10.17.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Sep 2022 10:17:39 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.79 as permitted sender) client-ip=40.107.14.79; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=abKtFcmK; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.79 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k1+hDl1w3mKn8Wy278bMXJiC4jhaiVhNzI73qNAU4Brlz1NN1jiAcZTDOtqUOKR4uyUN1PR+7oCCnlR84JTT6sdYVikI85g0yhvB8tLcfUgUCOB3Jdg+FDfbfH062vyri7MldTBOUyWB4ZNjO1seFtVsySV86Njc0IX5MIwX6rfQgZba09pM/Tlil/6bP52xbpsYGHY795D+EXFi7m9E0zMLEaGxZftlORn7hm/pmKjdgrq4X8iLHHXOVbvDhfrSjVRn5IvNv+xRNAYeXbyqLtIC8Hl8dIuMIdK1hBic8eQOdg0O2GduZOK3NBrLD7KN/Mlly+FvKzu1XepfnUBebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zfDTQDZj9J/mafbqfkxpZ+TvAu/bQqanD+sT9NiOFjE=; b=hjH1QdxvodnmUiXUsCu4anUMf4VpZ+lk4+8J+sgIli0WWY16Ek31toCRuBXsFyi1ArxnCwnqrEwPTlzFyAQra1Y++OPguGkZqsO7Kb4/8LhjZg2YPUT+2LPGNTz9jvzGkXXntmKdHZLjRSdnyP6V7bChZcqnh3DIptnAfAkvxgTZP0ckcoLJmiJkd1YjnHX5c176hjTx0dE5JOz2mIqbxP2TWxavoC9dMT1V6D8DTV4Mio1vn1pcRm+qsa8XZfYMOkucIbpj9wtbNYxfrK4tE1Nhm2n7BCBbEpn6vad54JqgwyEuUCvssnooclGUSWXNoBGLZ/r8UZalVIqVrPgepQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zfDTQDZj9J/mafbqfkxpZ+TvAu/bQqanD+sT9NiOFjE=; b=abKtFcmKgRRv9n30/0mw4fKZBnIXexRIBj1Ja8+BjA/y5pQfZIYgzdU4cOE87u7zL6PePv7lde94Aj2+0/Ci6mHxzoKWl8Y6xGm3HrVL0VrhjEWsioKKs68epvkud/wK+C7ed9oiY0bjVtQ44WcKHGS3q35iUdVYaV6zDRReJUB3UDfp7arXwvmK7jzdxM2BD1Nrpe12qGa5fa8pVauQ3POCEs5+n0bAogItZIhcsS9ASUPKhGKtU4kT9R2fZs/F8ZzcIZ3REse4bZq+UoRKqTPnhF6w7uNKS+/YLT+sDTnZ+D7R03jxmK9KqQGOaa3VdWTlBgB/i8nLrM9O/X2AjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by PAXPR10MB5350.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:285::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 17:17:37 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::75ee:d5d2:6b1d:150b]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::75ee:d5d2:6b1d:150b%4]) with mapi id 15.20.5588.011; Thu, 1 Sep 2022 17:17:37 +0000 Date: Thu, 1 Sep 2022 19:17:34 +0200 From: Henning Schild To: Jan Kiszka Cc: , Pingfang Liao , Florian Bezdeka Subject: Re: [PATCH v2 2/3] linux-module: honor modules Makefile Message-ID: <20220901191734.2f22f8a0@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20220827085905.6116-1-henning.schild@siemens.com> <20220827085905.6116-2-henning.schild@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::13) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 316e3765-a384-4981-5344-08da8c3dde26 X-MS-TrafficTypeDiagnostic: PAXPR10MB5350:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZhMKhahrnrIuuxLATyzxzYiaGwtf8+fs4huaJC8IFUevaF5aD+c/TvYpGcPgeqm3i/VnRR0SNPTSMi+GNyWuztB5KVthPj3dm2GenedfOtryM9Zga2bX/VIunOlVXBnt+zmwCYlAHbu+h/BwE3EehU+J+bBzjmchKd5TyTMa+K5DKmf54h077c0ZwKBTW4bEjoF0nxvkYnOCORf3KU8iyzYxg9WBCjK/Ty16RTlIFG8ohfKYui+SI1lT1vC6ZAs3LqwuSuf0QfBZ/+P4eSgjsPYkiGtwMtv5zAlqSB2dXbj8++XN28IRi3NCXjc9zm2KDmznb5qHhLPO/2mc5dM5FcZwZWMgkx80uoyltH3qne7hmVHLmZIWFWadA6ti4iPMk2iYHBLGWJH95cWQSS9qdXjgGd1qfpb5hGh+Y8U7AE7TIUejDmmb8ZQn/8QiR4lgX012qJpNyO2+0Gf//pDxQmNQdXEh/s3bAqXwPc4IDNVtl0BVr373vqoIEJ3xcPbL/JzXilH+E8WFEm2BJMGlcE4KNFBGnUULyBSngJ2daPCCffyVmDFdebA16XkMPgBOqmfwMQl71z2uNjcH1ijN2xaPiP4m/iIHxjiv+n5qpsAF232T8eoydwqJZGI4+0l3ldODM9vLyAzjXYoW3IFsUa2Unqv0gXtcgS03CYZ7W7pRW9smyhUsccvJ+FMeuV76X8LZznwf+FRYUYI6g2Otzg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(107886003)(6486002)(186003)(1076003)(478600001)(41300700001)(53546011)(9686003)(26005)(6506007)(6666004)(6512007)(86362001)(38100700002)(83380400001)(82960400001)(2906002)(8936002)(44832011)(6862004)(5660300002)(316002)(54906003)(6636002)(66476007)(4326008)(66556008)(8676002)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?za/+nRJsCmIVRWQucApR7bk1U/w3R/Cpkw6bLBWb1LRmlUlHQ8644Eyd3DfD?= =?us-ascii?Q?ADpUIO9otexW7GYDgkIyZJB4B5btddIOJ2od5FOQ19lsau3vEjJIfKWsBarE?= =?us-ascii?Q?nRzuABRbxiNF+ud6FMbo9TifCcNu0bv0HUXE6P8vHkYbNI6Jr4kLNfcBuKq/?= =?us-ascii?Q?CDbSYzeteBPnzWMhiP64k69BQXcobfumgYVKnxzaWLQAV0gLMLOgFUuLfpaW?= =?us-ascii?Q?pbETrzoZTOzv+V1vffNxs2JBoAzZDkSIhfDiYGNUljQitRTiGlUL/riGlcd0?= =?us-ascii?Q?CtEBiTH/PTA6EwKXNJdA2dgtZYn/mNEXjmjXXNYHnZQaWDmwIbYR9KLZYfm5?= =?us-ascii?Q?L/ElfDOW5Mjd3gf4nZtSIEhOMjFUwHHka8R7hUK0jCRaO0eXZPmwxptW8Tjm?= =?us-ascii?Q?6dAOtcKfB14BpM+zC6xDJuUZVOGN/lc79JrBWy86qHjwRJtxNCkmctm21lC6?= =?us-ascii?Q?8rhg7RMvbQkMEzHVRiDowPPngZX3nwrygB68aCrfqtxlJ2h64hxuyq4bJb71?= =?us-ascii?Q?dWwgVUy5qRajCjjGDZPCIlapN5Nz99QvP/H/8gUoj1+nJo9olJMPMRMGJZYI?= =?us-ascii?Q?IU62yHMNbbbT5eOLcGWyyXstNuEsM6DfS8eBFKazZBZrdkYoB1IMHmanTcaS?= =?us-ascii?Q?tunySrjME6aRjPS8gbBYjGCua0qB0GsqKsDiw2AQ3P8nDzfwJUDhZFfuWBNd?= =?us-ascii?Q?VLlM3qHcXJHgEPUuCtiSwF48EMKHOTNZrzazbcUFD/Qk+oeOIZi2VXqbXgs8?= =?us-ascii?Q?kgXmRKuItbTy9cEJ6BcWVAqU/KOurGyds+lpp0vIB2Vr0YWv7gx7IuI58lyd?= =?us-ascii?Q?VWEWdliablbNoSGO71gHUuJgGQGVnf7yfsKDerTIshhycJRNDxu3hvG0H8gY?= =?us-ascii?Q?LWcULIPoNt2Uzuco0VCx3ejYZovC38/dSFyZWepTDtPOZrE5A4G3lOLCFAkI?= =?us-ascii?Q?JfCQmduB2vuY70WNqkCwwKCR5VXkJ7l49TkSk/JvMlZf2NDEC5Dao4VZyIOp?= =?us-ascii?Q?FPLpOqM4AjTKXoIHSQIumftbC/NYgLxpTIvBXlG3JgUWGNNtq2KefWP5OKuS?= =?us-ascii?Q?Z5Ao/ApOJU2UUA2NnM/D/6hivtaKtQV4qsm4pf29C+yunBsRUfeMPG1aEy8i?= =?us-ascii?Q?PnCsu2r/5zgmIO2YK5LDngW0PNSx9XFYFSc3whQ+r55sq6VM6hqhED7hbbLm?= =?us-ascii?Q?UpKOxBuD83QWmhgYITjjpdtFcYbzFL9JWrNgw+U4Kf/3y5EaG9xBkz5XQsLY?= =?us-ascii?Q?BZu1sx614YLbt4hOYQTvAZeTqJ+yZMAzL2KmFX/BlvEofAKDtsPL5IsByi9P?= =?us-ascii?Q?4lfoqvZ+b9mgeQxRBmo+N6uH9X9VWmMUmgBViA80HlBFth/JzZg1eliHw/eR?= =?us-ascii?Q?wAMWHdny89eLPZ3uKqNsQvpBCA9lML0WA5TSV30HltfbIMf5+7s+5CTSlhBQ?= =?us-ascii?Q?EEv5E75VHdTPV+/p7qBDPMhFeEUEnMF+sq3e0eRqOD11zKLVFHvE+kCj5yE+?= =?us-ascii?Q?ZTkelUdTv+0p3liAyZiSSVjX/X0RtLK5SLBfPKiPzUEI7IgiTbaxvPZHTX9U?= =?us-ascii?Q?3gCcXic9GUJ0inzfzmkMOmMTcag0cHAyIuJZX7dyyZJk7IToZJvfNylc3hGM?= =?us-ascii?Q?Qg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 316e3765-a384-4981-5344-08da8c3dde26 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 17:17:37.5868 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UUsoNO2ryKEAM61MyNf0wYfeATzGC2/xZ3FGTYrEctyXjpO/F84N+oEuZCmHZtD6c/zp30xsEzaG0lgOUbv6q0gF5bLHPmVlx3yVUN64z8g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB5350 X-TUID: bz++Ddo9UP7t Am Thu, 1 Sep 2022 18:08:08 +0200 schrieb Jan Kiszka : > On 27.08.22 10:59, Henning Schild wrote: > > External modules might have their own appends and target > > definitions in their Makefile. All we need to give them is the > > target name and KDIR, not dive into KDIR right away. > > My observation with external modules makefile having their own rules > is that they generally also have their own KDIR variables. There is no > standard way of telling those pick up the kernel from a standard place > and install it at the standard location. > > > > > Signed-off-by: Henning Schild > > --- > > meta/recipes-kernel/linux-module/files/debian/rules.tmpl | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git > > a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl > > b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl index > > d3bd7dc30f21..0d16186b5ff3 100755 --- > > a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl +++ > > b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl @@ > > -48,13 +48,13 @@ KDIR := $(shell dpkg -L $(KERNEL_DEP) | grep > > "/lib/modules/.*/build") endif override_dh_auto_clean: > > - $(MAKE) -C $(KDIR) M=$(PWD) clean > > + $(MAKE) KDIR=$(KDIR) clean > > > > override_dh_auto_build: > > - $(MAKE) -C $(KDIR) M=$(PWD) modules > > + $(MAKE) KDIR=$(KDIR) modules > > > > override_dh_auto_install: > > - $(MAKE) -C $(KDIR) M=$(PWD) > > INSTALL_MOD_PATH=$(PWD)/debian/${PN} modules_install > > + $(MAKE) KDIR=$(KDIR) INSTALL_MOD_PATH=$(PWD)/debian/${PN} > > modules_install > > %: > > CFLAGS= LDFLAGS= dh $@ --parallel > > This breaks existing users with makefile that are unusable or do not > have own rules. I would refrain from that breakage. > > If you have a more complex case than what we support, you can simply > provide your own rules and can then even account for the other > specialties that usually come with such module makefiles. > > Same arguing applies to patch 3. I am not sure i would agree that the example Makefile is indeed valid, since it does not allow self sustained building with a simple "make modules_install". But yes for modules with such Makefiles this would be a breaking change. Will go and carry the special rules entries downstream, while i still think Isar should take that and rather make those weirdos carry their own rules ... accepting a breakage. But i have no clue how "weird" vs "common" it would be to have such a super-minimal Makefile. And my case is probably also not "common" enough to ague for too long. Henning > Jan >