public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
Cc: isar-users@googlegroups.com
Subject: Re: [patch 1/1] linux module postinst generalisation
Date: Mon, 19 Sep 2022 09:31:04 +0200	[thread overview]
Message-ID: <20220919093104.41eb5568@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <CAJGKYO6TFM7mjmYEHJ8qxJfRmakq4Om-DmNJKBmz2paF4uYs+A@mail.gmail.com>

Hey Roberto,

that patch should be inline so it can be reviewed and later applied. You
did send it as attachment. So now people have a harder time reviewing
it and replying to certain lines of it, and anyone who wanted to apply
it would maybe not be able to use "git am" as they are used to.

Am Fri, 16 Sep 2022 14:44:47 +0200
schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:

> Hi all,
> 
>  linux module postinst generalisation is needed because sometimes
> (corner cases) ls /lib/modules includes not valid items that make
> depmod fails in total. In this way, it fails specifically only and no
> damage is done.

I think that patch kind of makes sense. But maybe you can go into more
detail how such a "broken" entry can be there in the first place.
Normally one would expect an isar-built image to have exactly one
kernel and one "working" module directory for that.
Maybe you should rather find the package that drops invalid directories
and repair that. Or maybe it is not "invalid" after all and our "ls"
matching is too simple.
And an interator over multiple directories would maybe also fail once
it finds the one "broken" directory.

regards,
Henning

> 
> Cheers, R-
> 


  reply	other threads:[~2022-09-19  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AM0PR10MB2020627F69E1644392B6677CAA489@AM0PR10MB2020.EURPRD10.PROD.OUTLOOK.COM>
2022-09-16 12:42 ` [patch 1/1] image tools extention not install suggested deb Roberto A. Foglietta
2022-09-16 12:44 ` [patch 1/1] linux module postinst generalisation Roberto A. Foglietta
2022-09-19  7:31   ` Henning Schild [this message]
2022-09-19  9:08     ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220919093104.41eb5568@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox