From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7142858516907163648 X-Received: by 2002:a05:6870:961d:b0:12b:45b6:3476 with SMTP id d29-20020a056870961d00b0012b45b63476mr1579905oaq.193.1663670949817; Tue, 20 Sep 2022 03:49:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6870:7382:b0:127:831c:2a23 with SMTP id z2-20020a056870738200b00127831c2a23ls3716935oam.9.-pod-prod-gmail; Tue, 20 Sep 2022 03:49:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Rpk4JiWXFsO05g1UTrAEGjj67DKAztZhWxYXDNJ6GnF/OCysQ3gSVNEJ0YnjujU+ecdoD X-Received: by 2002:a05:6870:3448:b0:12b:1a11:e868 with SMTP id i8-20020a056870344800b0012b1a11e868mr1689523oah.198.1663670949216; Tue, 20 Sep 2022 03:49:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1663670949; cv=pass; d=google.com; s=arc-20160816; b=Qy9f4PcCOMBAhxP/zznv0Vgpxx8zWAxtANYFl9ysNd0UH+9t3+NTfMQznXT/fAqghh k02mFeE818WEzqZ/uAcRA8Ve7LRxVIO6rxMxQl8gMX/++S+0EwwU49rsQM5IIeaVfZHC yvS02Q6G09ygSOKTo0ZiXZF+rBnIjLn+3M5FTtGaeK6PdjTIabW/mrgVODKdN8l+DV9P qMBeY2ysl2A39i2rVvX1BgxtH4yqtE7ymbNf0oNooMD4W5znJfrLIwvW51qN46Cl5ZMW MUAwcQMNAjS2nx6Psr0yd/zYoh7Ht0wfeaYyPsdmxqo61DGUaThyMdFm8vmJjjtHNGyi R/XA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=fuv+NG8pSnQbhJnEKGeBL+DLKJ+0VPUZR7RnHsKKuFA=; b=enrVaa/heMVoKqvk/4mbSWg/CsG74Or5ihafC/eiJEGx1HODU4sai3Nv1fgYdztDxp LSAky4uc/GhXB7JvbCkDm5FBmvJHQgdiNpn9dfH4rn4cp3AuGGH8Xf4K6y2heqanUA4C TCaVW3ucDEfXPvI4uma4Qha5/cD8raBOm8ii9+aS0R/NcsVZRimXSQ6XNSZIisXjC55z CaZnHgsSVlPtQFyi2TL7KdgBMymle4J+UYA2ot8qddLERhrhuFWBqjyZegroi0T1X/rP O8PHnKQV7tBQOn1tBdDV17KJL4SOb9Lz97ajdbYvMZ/SDbgl0nPX+EBfUFkzzH5JA5ZR bb7A== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=NHFtwi43; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.54 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2054.outbound.protection.outlook.com. [40.107.22.54]) by gmr-mx.google.com with ESMTPS id u17-20020a0568301f5100b006540f7a45b8si73322oth.3.2022.09.20.03.49.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Sep 2022 03:49:09 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.54 as permitted sender) client-ip=40.107.22.54; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=NHFtwi43; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.54 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jeXUaEiV6K0pAOH4RpfnMk2rxzqf4J3Li3syAhK5q1YSp6LvuVeccHGteueZZbeXH6EJG5b98Qt1mADFJ5VsVLilvMBCD2hdUBvuA/L0vpNZPb8/v89w60cg9egCFJ/sB4+Hq0eZSkWdXVXv1UobLLoEVcpgwycfRC/ZaJFYAfSiXSeE9+Ze/b0cfttAO7gfq0fhNtnf1iijru+8tvKzAxyo8colUGJkmlADgwpzWpyBbUTEwFSbfe4qWSKo10YyxP9Rr0wXubAN/ygppNtduPABCpgMl6jE9ugR4WjACA3xExRFJjvOD5L6nbSvsgXsqNafP4jLcj6YiLI3M3RiHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fuv+NG8pSnQbhJnEKGeBL+DLKJ+0VPUZR7RnHsKKuFA=; b=F0QahWIATfBvTbjcRu+Vu/P4RAljIq3ucdia9koDUZyPv7qUFGB61KKviNqmgcWA/153uQbbuKM5RJosBi+n8e8tWYORL7XlVmPxY6IelJNKhmMKLZ41UZ/A0cor52mEQ5WsbsMcA42CQXX52ShBbfIoEWGWMs6V8dFeFKtL1conTSBJz3kL1jO27hjt8jYGIvdDnkMFx6Rzfiw4DJRtmj4H7gTgk/6YIjtaRu+bfQjurVRnCsh0PtNA3YIEpnn7nl2wLEnz6qCNCBBfhJplvKle22wZaUTBiMJkdWNfm6h+fRXAokLLBy7XOyZ1n7xMW3Pa3GekVghyIhPDJUbULw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuv+NG8pSnQbhJnEKGeBL+DLKJ+0VPUZR7RnHsKKuFA=; b=NHFtwi43ttKlA8JDCexwUimpwQqTE5Wz/dYGZ3QFFgEvQ1TFuKOBLGfsixEggTVJ09t4SB+R2Kxryo/KeUeKQrPUxzfIozBZsM6ifHZW6qroxfdVpYGcpxLNTGo+poQm3RUV0YDifENoXOBgJgMFZpwBOsrksH8AeCMSE5uZHJ45JtjoVRXnjbr7XWr3TKi8h0uaqTzl2uj1VIIDm3Pl9G2ptcUyhcARjPMuO7wCA3IzqesgAE9bwR/EHGKdOTQyb/2R4Og7Gv4HuGE+wglqsk54Krr3P1Pb9IUdWI53xky0w61SEndJqav7Yox+42hpm35Zb8vKzvAMd/FQBmwMoQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by PAVPR10MB7235.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:31a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 10:49:06 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1%5]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 10:49:06 +0000 Date: Tue, 20 Sep 2022 12:49:04 +0200 From: Henning Schild To: Felix Moessbauer Cc: isar-users@googlegroups.com, adriaan.schmidt@siemens.com, jan.kiszka@siemens.com, ibr@ilbers.de, amikan@ilbers.de Subject: Re: [PATCH v5 3/5] add option to control deploy of raw wic partitions Message-ID: <20220920124904.50e5aa71@md1za8fc.ad001.siemens.net> In-Reply-To: <20220920095543.70da83ab@md1za8fc.ad001.siemens.net> References: <20220919112035.830233-1-felix.moessbauer@siemens.com> <20220919112035.830233-4-felix.moessbauer@siemens.com> <20220920095543.70da83ab@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::14) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|PAVPR10MB7235:EE_ X-MS-Office365-Filtering-Correlation-Id: 9267b8e9-d4f9-49c1-0315-08da9af5bd73 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BGbiCotptwPy8v6sRj+vzdGjGzpOZgTed4SkFSgr5+YYLI83NQqOFlvQB/rdiQ4xbvkv7aVUAQKMzERONogo8+nSzZYtqTyKb6OxrbnFxxfgvXnVmR9gV5JK6YCbWsJy5K3cEKgjBIp1m/22oPRYUyUskFVld4KJl4IVX/qa6EYDhmIDANNlt2+0xLZ8Knn0XS1bZRLafaCLvqsySLdHv6eOQa+bhIeCKMLA/WNwVMNcBksnh/FP4OwnDbMFdD3sRGT4RCT3tKM8iX+GnxtZgjd/4BBeFheNiQwWTUsdJsOJ8rTeFsb8de2rUd0PorRvyFxQdy/FxJNtbPotGUR31BQWHYQUClHIKSJtjLGanLKZPaiP+enDWMdjSYoFOCn/lQ+uLXKYnRDLlN+lsDUNCNOb//QP99WOAWILe1E6Wx/QAF61whmVbGkWtKQ0VKnI0lz5QjgjYqpKbz4k5uTiuXKwFY7eNJVavBQSfTzLRCF8ZdGgvPR8tI+j1LQ341m6fhy1QpPZtIzb+02pEHb/oli8kUlEOnT/k+/Q0ar2uHnt5W344FOdL64KWU1koXNTF+mCfjyEv/EXpfw8XgUStUX9BGVWD9d80V/yr/NUHqZNNueSOLtbSQFvKD5IBe08AUlTTm0ZAf7+2OwEldYCZ0n8JPssGm7HkIBBWXip8/KEXUna+M8tonqWa7pn6SVSI9xXADxeSrTKUuIckF+msTqGUVvUx6BZrVlMDav2E0GF6I5BcD+CbloxsIes+ugFd383scFPXieUtC8PwKUSFRM1LAJm8c/W1dofBfkfU/w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(451199015)(1076003)(6636002)(5660300002)(186003)(66899012)(316002)(44832011)(6512007)(86362001)(6862004)(8936002)(38100700002)(26005)(9686003)(6486002)(6506007)(4326008)(2906002)(966005)(82960400001)(478600001)(83380400001)(66556008)(8676002)(66476007)(66946007)(41300700001)(403724002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y80HyFk/VeMdznGYAuTENQkVdQh65MsMTDvc+0kJMJj8Jz7+vHec4NpXpSBU?= =?us-ascii?Q?fNAnEjg07G/pPofOT6zhtDO768F98x12UlPtFL2xB0F7ugvL/pz4hbqvPLi5?= =?us-ascii?Q?VB3NhS7a55Brjao58WH6AP+gL+3O+0LqZnGik/VZKcYR6565McRMOECiSrKI?= =?us-ascii?Q?m96YXM1tqEJ8LszCdVPoQBl9udWy4RIz1eZuajBANgh+vGd3PhA/d5IPbPHB?= =?us-ascii?Q?pzb6UjhykLegVjXWz1AqkLB4zETkDoutjRE/eucFPzOSFzXD2nfun+J/SwdV?= =?us-ascii?Q?21SdvKyuMVqGbZuz86hBsn9YZQOkMc1Ym9QCiTFkTM5yTln9o6gOmO0RMrjD?= =?us-ascii?Q?gcenOJBs4qYoVm3l/g0tvWDgDTbYao5LCx+/+ZV/Ny5Q0ingm4A35C4iblRO?= =?us-ascii?Q?+oIdIM5zUeTP+55y47y46BSlwuxBM6znQphiQhriYxGGg2oOXh98/xmeJegL?= =?us-ascii?Q?2mIuY/McKrFJBPp5L/s9ohynmHys2Lk3bF84jGYpqjz1hLFxE89uHDHn3IwP?= =?us-ascii?Q?fb8wCKm7ahx6oSDqkwfnmu8fTRp8ClSALoRLfBKGgrqvuLHR4oyo4OmueyFg?= =?us-ascii?Q?UDkg5JZGzN+qbS0t2KPMUY5pwziDUOnzobXKzbli2fyEFy7NUl65eRzekWQK?= =?us-ascii?Q?rBcaR0V5wuUenYM85tRd4Vo7slEnsrTBEEzrFpVYdlhlK6tB0pi7dLI6rqT0?= =?us-ascii?Q?9Cvg8rqYYOdEegunsBDGitMV/JuE2bUy9iJ4dkQzQbTUNQrc2oLlZOvMoXeH?= =?us-ascii?Q?2JIBA9YldVjb5OzGwSH0FGqVW1pw4Yi8meHIaUaUtH6XSC3YZX4bgT9BLQIK?= =?us-ascii?Q?mvYs3ijtnV5gWffvfyytyoz7UBNNZDhO0hKiVMy8QaGESSKlPt+93QRIY9TW?= =?us-ascii?Q?Lf/YjJ4/2X0+MBRAZwgr6TYDuOlePHcNYySgT/G4sXJhhFgcJRHck/AVKMuQ?= =?us-ascii?Q?D9zAoP/weENz2TnH7Qxcd7uZCiEq/vhhQ6RJHhmF7gnLLPWHZHGm51DO40Pn?= =?us-ascii?Q?RlS5ee4ITvJ+dBPPw8F4cF3Afr/GbNyYzazxuM6cuWTQLp1XTU3OKRaUmA+n?= =?us-ascii?Q?wMxN4wyKGif/bF29T7uuz70W1Mo+uMZWETTBcFexT7ro9lRW7HjuMRiOCFc2?= =?us-ascii?Q?038Hvd1RbBmfVxgIMPHpekboJMVFqETVYHoSBB3i2hRW5anqypvMPQDIqpEQ?= =?us-ascii?Q?ip3hpTE9vi50DjapeBdVBeDAy2jKRORsBXRdoLyd3uVo4gl5ToUF6V0cHVaG?= =?us-ascii?Q?DSpocyHEXSpE4QexHV4CJCtQfR9z+ISTcmgEBPcw1gYbpwjtmoLLdN+wfWMb?= =?us-ascii?Q?e9ZvZMxnhHCAIGZpFiWmwt+/k8S8NZ1+LBrtKQTZfLz4XzJF27Z6pQfghIci?= =?us-ascii?Q?Gzz1Ucq6nRLe07gwAYek4mDgC0tO1DT2ajhy/IsxImmgQAJ6Y6qbaQI6jK0n?= =?us-ascii?Q?bp4lJ9zaICd9HfP7ORdvZZ739SfL17TExTYLRxVh88Hu1bLF2Zgi6gIfNUiW?= =?us-ascii?Q?TMW5PTdTcMy9zCfBByac6Q2LtjsREujG/LLiqgG3PkJyZTNX4lORy9ivARJ9?= =?us-ascii?Q?NGclmyVRUUe28U2/Kvsoy1Mbz6E6ION15MeiWagCu7YLPF0cHg+izAXqv9TO?= =?us-ascii?Q?vA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9267b8e9-d4f9-49c1-0315-08da9af5bd73 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 10:49:06.3380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: odOQvX4Q7hEUIs3i+67e6jGG2LxxMnjbuRRMql+dihv/FG+/ieJ7kAGHhqVwUIJf85c4dn+CRzHds8NJVXTj+1BDcM+weSiDTypD3nt04iU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR10MB7235 X-TUID: ynSYX2anlCjn Am Tue, 20 Sep 2022 09:55:43 +0200 schrieb Henning Schild : > Am Mon, 19 Sep 2022 13:20:33 +0200 > schrieb Felix Moessbauer : > > > This patch adds the WIC_DEPLOY_PARTITIONS option to control > > if the raw partition files are deployed by wic. > > > > We also set the default to not deploy to be closer to OE and to > > optimize for the average case. > > In addition, this significantly reduces the disk size required to > > run the CI. > > > > An API changelog entry is added. > > I think the deployment of the partitions was an accident and never > intended. Cause might be > > https://github.com/ilbers/isar/commit/edc10d9361e79f36c8ea5488b1dab4c468213a8d I think this patch should simply be reverted, which would bring us in line with OE. Where also only the ".direct" is taken into deploydir. While wic does have internal compressor support, people seem to rely on the external one. So i suggest you simply revert this one. Keep reading for a changelog suggestion. > which wanted to deal only with compressed images when wic itself is > used for compression. > > We should maybe just sharpen that to not include partitions, instead > of inventing a new interface to remove them again. > > Henning > > > Signed-off-by: Felix Moessbauer > > --- > > RECIPE-API-CHANGELOG.md | 6 ++++++ > > meta-isar/conf/local.conf.sample | 3 +++ > > meta/classes/imagetypes_wic.bbclass | 5 +++++ > > 3 files changed, 14 insertions(+) > > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > > index 621d110e..0c34d9be 100644 > > --- a/RECIPE-API-CHANGELOG.md > > +++ b/RECIPE-API-CHANGELOG.md > > @@ -419,3 +419,9 @@ packages and will be lost after a given build > > session finishes. > > Any package build requirements for the rootfs should be satisfied > > in the Debian way via package dependencies. > > + > > +### Individual WIC partitions are no longer automatically deployed We used to copy all temporary WIC files, like the partitions, into the deploy directory. That was intended actually only for compressed wic images where wic itself would do the compression. It was never intended to also deploy those partitions, so that will also not be done anymore. For compressed wic images IMAGE_FSTYPES should simply be extended with a compressed wic format, like "wic.xz". Henning > > + > > +The individual wic partitions (e.g. *.wic.p1) are no longer > > automatically +copied into the `DEPLOY_DIR_IMAGE`. > > +To explicitly deploy these files (e.g. for swupdate), set > > `WIC_DEPLOY_PARTITIONS = "1"`. diff --git > > a/meta-isar/conf/local.conf.sample > > b/meta-isar/conf/local.conf.sample index ce7b58ee..57d06202 100644 > > --- a/meta-isar/conf/local.conf.sample +++ > > b/meta-isar/conf/local.conf.sample @@ -246,6 +246,9 @@ > > USER_isar[flags] += "clear-text-password" # Uncomment the below > > line to debug WIC. # WIC_CREATE_EXTRA_ARGS += "-D" > > > > +# Uncomment this to also deploy each wic partition as separate file > > (e.g. for swupdate) +#WIC_DEPLOY_PARTITIONS = "1" > > + > > # Uncomment this to use ccache for custom packages > > #USE_CCACHE = "1" > > # Uncomment and set own top level ccache directory to share between > > builds diff --git a/meta/classes/imagetypes_wic.bbclass > > b/meta/classes/imagetypes_wic.bbclass index 61a74d4a..ba8aa15c > > 100644 --- a/meta/classes/imagetypes_wic.bbclass > > +++ b/meta/classes/imagetypes_wic.bbclass > > @@ -98,6 +98,7 @@ RECIPE_SYSROOT_NATIVE ?= "/" > > BUILDCHROOT_DIR = "${BUILDCHROOT_TARGET_DIR}" > > > > WIC_CREATE_EXTRA_ARGS ?= "" > > +WIC_DEPLOY_PARTITIONS ?= "0" > > > > # taken from OE, do not touch directly > > WICVARS += "\ > > @@ -205,6 +206,10 @@ generate_wic_image() { > > > > sudo chown -R $(stat -c "%U" ${LAYERDIR_core}) ${LAYERDIR_core} > > ${LAYERDIR_isar} ${SCRIPTSDIR} || true sudo chown -R $(id -u):$(id > > -g) ${BUILDCHROOT_DIR}/${WICTMP} > > + # only keep partitions if requested (ending with .p) > > + if [ "${WIC_DEPLOY_PARTITIONS}" -eq "0" ]; then > > + find ${BUILDCHROOT_DIR}/${WICTMP} -type f -regextype sed > > -regex ".*\.direct.*\.p[0-9]\{1,\}" -delete > > + fi > > find ${BUILDCHROOT_DIR}/${WICTMP} -type f -name "*.direct*" | > > while read f; do suffix=$(basename $f | sed > > 's/\(.*\)\(\.direct\)\(.*\)/\3/') mv -f ${f} > > "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.wic${suffix}" >