public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH 1/1] bugfix: isar-exclude-docs delete man folders but some packages expect that folders
Date: Fri, 23 Sep 2022 14:01:56 +0200	[thread overview]
Message-ID: <20220923140156.517e5e77@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <CAJGKYO6CCt4de7SAuJ+ymEdC2LRoAwgJWGzDWHwdkHNimd1dEg@mail.gmail.com>

Am Thu, 22 Sep 2022 23:31:27 +0200
schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:

> Il giorno gio 22 set 2022 alle ore 22:36 Roberto A. Foglietta <
> roberto.foglietta@gmail.com> ha scritto:
> >
> > Hi all,
> >
> > bugfix: isar-exclude-docs delete man folders but some packages
> > expect  
> that folders.
> > solution: adopts the same approach used for the doc folder.
> >
> >  
> https://github.com/robang74/isar/commit/c656e6df63aa76701e34d7ee3f99c81e96312b9d
> 
> bugfix: isar-exclude-docs delete man folders but some packages expect
> that folders, p2
> Instead of using "-type f", it is better to use "! -type d" in order
> to remove also the links
> 
> find /usr/share/man/ ! -type d -exec rm -rf {} \;
> 
> https://github.com/robang74/isar/commit/7af338b06c142eb7a60a881aaf5a9870e375c1c2

I double checked a ubuntu container and was expecting that jdk package
to not install there. But it worked.
Turns out the dpkg path-exclude in fact leaves directories in place.
Which means your patch is correct and fixes a problem where the
path-exclude and the rm do not lead to the same result ... not even
thinking about jdk.

Can you please send the patch with git send-email so it can be reviewed
and merged? I think i would make it two patches ... and that switches
to "find -type f exec rm", and a second one that switches to "! -type
d" ... but both finds not just one.

regards,
Henning

> Bests, R-
> 


  reply	other threads:[~2022-09-23 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 20:36 Roberto A. Foglietta
2022-09-22 21:31 ` Roberto A. Foglietta
2022-09-23 12:01   ` Henning Schild [this message]
2022-09-23 14:18     ` Roberto A. Foglietta
2022-09-23 14:39       ` Henning Schild
2022-09-23  8:06 ` Moessbauer, Felix
2022-09-23  9:31   ` Roberto A. Foglietta
2022-09-23 11:18     ` Henning Schild
2022-09-23  8:57 ` Henning Schild
2022-09-23  9:25   ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923140156.517e5e77@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox