From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7108629846932062208 X-Received: by 2002:a17:907:1c12:b0:783:a808:1a55 with SMTP id nc18-20020a1709071c1200b00783a8081a55mr1635314ejc.698.1664178408471; Mon, 26 Sep 2022 00:46:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:268a:b0:43d:b3c4:cd21 with SMTP id w10-20020a056402268a00b0043db3c4cd21ls628662edd.2.-pod-prod-gmail; Mon, 26 Sep 2022 00:46:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM72lvyjZuYXWko9QgVbM+r7OlBzy/boyShbrkVf6MtYBfOz5Y0HaBTbHLqBzM7TgTfCStcN X-Received: by 2002:aa7:d556:0:b0:451:f7e6:5121 with SMTP id u22-20020aa7d556000000b00451f7e65121mr21295722edr.188.1664178407300; Mon, 26 Sep 2022 00:46:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664178407; cv=pass; d=google.com; s=arc-20160816; b=nrsuJJ2Lsnw8pFWzOU75TTzWZlRfjDCdFb4gDVHlj9DmahKoYsA5w+MVcFO5udn7VP wPRigeQ8wyhMiCpOE6f6bkG/hxHFWIjPefE6+Xc3IMo3ZSJN3Pw23AsoXodbA68az+46 ZenHDnbGG5iAkDLCP9CP5955GVVoy3CBM8GyJtyu6mQl+V8iYtODgTUMideXBEjoCPxh +O1yq94QjGnqBMc++6olBXJmtLV8WWAWVI2Xre/Bq3b7F3vDgUB6Rl97kuvaOGfLYdRE mhyBL3hz2jw0kdRWgYnEr5+s9EoohlyEPt0ATtGg0L51S7s8xpRn7nc12zyXz5QhcvYG iaEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=Bq6OQBfcjvgHnlbjMuNIAXw1fJ7UgOS0s555i6G1wqw=; b=xkqdYp6P9mSNf0h+0fwWl6AJPP6fdgIDz3jEydEocwYwtmrgngItB3/Lf3eRAMo72M 7jekYvjmC8LG+NY0DPsIWmsEQigjl/pwHuvBYRoFxa/WdxTePbJ6y3s1Cm0xHj90W+HY sXYD4rlC1Cer5RG150PteaFBq9gO0eYqIi5h4eM7TJ6Bz+TuPqmWineYjd6Ds7Wqlw0m Fl18nT2l2aXUlp51Ns3dTrGktIGnr15qZgtwsD6w98KTobSNJzi9FoMzovaDArzx+3ii 4oIepYl8y2kMU8UBffiZNY70mRZchVu+uG06uElVpSCOvYOZEzA3GP3uwG15gXVpi/Rs 8RdQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=BcmLTRji; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.89 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2089.outbound.protection.outlook.com. [40.107.20.89]) by gmr-mx.google.com with ESMTPS id jx23-20020a170907761700b0077e2b420e6esi716058ejc.0.2022.09.26.00.46.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Sep 2022 00:46:47 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.89 as permitted sender) client-ip=40.107.20.89; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=BcmLTRji; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.89 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IOKQPGc6iYArxujeJV/BhxrPbcLfhWuktD6KTEBRFI0K24fZbtAXfDzWA+2AxYGsBQQRNC6nwRK2yzMs3gmZW8c5VwF4iVf3z4xaxU1dbRRVab3v+ONnRPreueLYQEGxb/EIKDXhXWjm0QXfG9hmxAOgl0sSYWG1EC3fwDRIwHZ8ZpnQxZYMPx+cnZA3tHllBwdDwpr9wL5G1CzRpM6XyPmPxWOa7a2mJclGhK0O3b+n2EsBysb4BygXuutmJYo62thiCc2qWyc3I4bbNyixvD/uuZOr2Wtjh0JbHlhCXcwSTPb8Yp5eIwfaEKhCoLeLvRqlPG5BiTZYShyEa47gzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bq6OQBfcjvgHnlbjMuNIAXw1fJ7UgOS0s555i6G1wqw=; b=FvLK6i3jirB1f9I8E8GNmp4P9hlTGGTX+lDP48kjK9+NSih0rE6RJNq62lIesMr6EMJ/YH9BhY7N87eQ4aOSRrRs8Qfq00YQwqCinOfkz978WdNUIreKQzMfmQoE5P/FSTAEH7kCt2KLiN/TJdOd0znP8dcjq+M95lgLtT2Bk6d2m6rul0JVtSRQNEdlB/lFG6FmEl8vweAHtGE1jwyq1ikX1L4xeO6bSUVdYdy1oScbAQ/sh6f9ul0jQ4wtopfiA8Z5dQ5OPOlQlJpySEpil1iSKcMOqb/B/uq+/cL5TYFTA1Gks9pcmJgvr0m2AUjs6OiZPj4my/pB5mQCrfx/DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bq6OQBfcjvgHnlbjMuNIAXw1fJ7UgOS0s555i6G1wqw=; b=BcmLTRji+HgAtpJKwhuEB/0Si2MMFC881uxboqYfskrOArv/mGENDeW0Mig1M78cgDPHnmOhkBcpZsTcjtXg0gO/nRONWXAZYCYA/yNHd+d2L4EGcbaokWPQXqsn7cd9agWOXtDd9ozHXT/0+PSGFGiSVveW5mT3hX6L1hhr+Ap/4olsddzKWWmWNcEYjBQWdH+QbRAiIKjpJL9EbaZnJZBZjd2ae+lIaIKx/MOzOlc/4Yirvb1OvRT3uUMivkPetM55TTY2oy4RnM00Hi1phjp3JS+zGJg0cvHg6pEyD3nOfM4WnUO6UXQxDeTvYccou53eNtHexCTk7xxlN9+2Jw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AS2PR10MB6870.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5f6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 07:46:44 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1%7]) with mapi id 15.20.5654.024; Mon, 26 Sep 2022 07:46:44 +0000 Date: Mon, 26 Sep 2022 09:46:37 +0200 From: Henning Schild To: felix.moessbauer@siemens.com, Vijaikumar_Kanagarajan@mentor.com, jan.kiszka@siemens.com Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2 2/2] wic: Update to the latest revision Message-ID: <20220926094138.36c36a30@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20220613075401.2059119-1-Vijaikumar_Kanagarajan@mentor.com> <20220613075401.2059119-3-Vijaikumar_Kanagarajan@mentor.com> <20220613110206.0fa05e12@md1za8fc.ad001.siemens.net> <476c6e8a8687499a85fced0e07299815@mentor.com> <8babb01d7eae44e0b9faecad59cdc1d4@mentor.com> <6157334379c44f8b938983d5c4dfd8b1@mentor.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR18CA0006.namprd18.prod.outlook.com (2603:10b6:610:4f::16) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|AS2PR10MB6870:EE_ X-MS-Office365-Filtering-Correlation-Id: e115a815-7b02-4296-80bd-08da9f9341f9 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: piI2dBsB/cwlhvxeauhj7qH5YV2SmcNbbtgrYT9/PqM5ecU2ZY+MvkGkhmv8mixPji6upNjxw2y61+CxJpOq5VPez1qOHtRmXZ2XFH6wb1OQrTlWcElNWc/SqLh5Vy7QVhc+h00F4saSp2tQ8WjMKfgEVJTbS0HO2Ty8sjYX49YJYkz3ny8W5y3mf2+OzXA/1McwEL37EDXOD7vhK2Bqvf8WXD3BKBlwZXJcisFG3ZnX/VFPMX+hH31ke8rlIcNLW4JngelryFesgDXwBIZqk+clRRWuhQBSaCfPiD6lc+oQhNIHeC0ogsqJQ2CDTZjt/Wu48dulgVynnrvOhOPpxNIHAI/2jhC72L7PbmccF9WtrmQThDfZWW7Xqolcs3euofXThf0xw4KSGE1ptT7ZPwHWeL0WBSS+/ZpiBr4LK8t4s4IP9JRzfX2LBhxrlqgrGsdCQq74uhn2GL2QsS13PoOMJgwLuM++ayiYouDv93DU/YLF1UG077iMrX5CGUW6VVn7o9UAjcUwSy18PfalZQxOMXjYweB0XAdXyx03GcW80+uTtFXiufTel1d1c7PpTamQHJTdh5voG0i6mAbDFt9Z0+JEcVXHfAGV3gDy8VN0x+ZvkFWIt1hkSmxaz4Ws7Qan3x1k0upCvTgxWD1VzCWLu0C14zQ6/wbZilHsgJqtJkkn455q2ZhuIeYe0V8Rtq0R1p/bGwQcPFxKVjC4tOT29B1Khbgs43OHh6UKIt0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(366004)(136003)(39860400002)(451199015)(66556008)(66946007)(4326008)(8676002)(83380400001)(66476007)(45080400002)(316002)(44832011)(6636002)(30864003)(5660300002)(15650500001)(6486002)(2906002)(41300700001)(8936002)(86362001)(38100700002)(6512007)(6506007)(53546011)(9686003)(1076003)(186003)(966005)(6666004)(82960400001)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ezi9fYbdmkHT1UDHiQ+ZHRh/iyS711Yj3QvCH6Wed7batVcDQZvtExXrEYVa?= =?us-ascii?Q?s5Rol62tl/d1R+1Tc6nkhYVWRdk9b2THSc4GAni7W0X09zQBPZhRuOzjeRwV?= =?us-ascii?Q?vz6rnkTW+16718snnxS8g6yYiMPSbLrP9CvAw6J5dVynvcmSWqQQBnpj5qUo?= =?us-ascii?Q?dzBy5XgXy5NaTegUImUGsfymYReiGD9Wb9kTCzbv+geIsdMD0b69oiLU+/SV?= =?us-ascii?Q?1zVUTXwT82VD8foCCiOlgb2Y4giRgoLhENfTRchCEeVAX41vkrGOMNitfavb?= =?us-ascii?Q?UZeDTwJAdyr3calZKDwElAS5n070Go9L1trurg9TFbWpwEDeFFXeSC2+rj58?= =?us-ascii?Q?s10jnN+OYGv4o44qa7HFZzfCC7vugGxJaMo6K83l4rsGyde4Xgcc072wJnSd?= =?us-ascii?Q?fgsPnBUCWqW2oao4+oc0XjUg4y403N8iNbJw0PKkL4G+YGnX24ZvIX/9lg2P?= =?us-ascii?Q?v3hCFf6VhWOanQBjvsr8Pyya5OXOBMghW/fWugo/XjVuRNnBok1QpI9djZJe?= =?us-ascii?Q?8Q92gnjKDNG9IK97SZvDIjTRJZ0c7B67XeRZvUr8GoRCqV1AtuydPr3GJ3b6?= =?us-ascii?Q?kouWeiiE3ZzdYFKWur8vo1HqWerOo5rBCh7yFEMR2uCg9u8cWAuIzYKlwWCP?= =?us-ascii?Q?ljPez++o38WvD990P93rHW2kxSAQlIkqg13URiknYNrDum7E+OG1Q1V/og1g?= =?us-ascii?Q?eogS50C00LZA9Ny2CGYEwvKBqSteQe2pDwv7CaBO1jDHIb0BhuDSBCZKpP1z?= =?us-ascii?Q?7LWPWmDCX5mwVHH5TP/Xj/MCsjk99nkuJn90swxOsN0Uq5prZrwkpr4z9QcZ?= =?us-ascii?Q?5gu3uaygEHI3apTqwtJr/wP337bBU7kjFV1At7fJosI+wuXmsDvQ/WBd9wmO?= =?us-ascii?Q?G+pP73uijZUVdagGp2ToG06FvvmYBo0vuOKdVW0nnVkyQd5GA3Cp9j6aSeYQ?= =?us-ascii?Q?csubahGVj+F7pmDwcCvxW3D277wGDIYDMgYGepmqujljmxibyFSMbknPS7Ai?= =?us-ascii?Q?qLpmIz6lH6S2QlaC/HT3CfFKm/PzSZaeFyir4BHCInin8DbXbysHSjtoe5hw?= =?us-ascii?Q?7alu2Mwh1Wn9cSO8J5UzxsulBOptRaKmRz2WgTkGH/bmDpCDxSjDXyEEXFIQ?= =?us-ascii?Q?s73FnUdAwPNEVy/GSz+bHqCsi0unnnMl/UqlHm8FYuqKaS2LHKD9SEvbE2pp?= =?us-ascii?Q?PHZLylKHW/64U0/2m76YighH6uQaPJFSiYubO6/WuKIv7Ah0oSLxNlwM3sdS?= =?us-ascii?Q?gsLukX5DNE1FMIwBYf6o2bw1FFO30Q1nYy7smhcO5hX2e+lsbfWKkmc4FelO?= =?us-ascii?Q?/I2/DdlCqxtLZsFzQdtdpQtnldlZnAynJndYUbzwNhAUCDhJZjs5a/vioxuH?= =?us-ascii?Q?JIX8vw9WYzWLdlDqRL0NSpZHsfyFyxq0+mV3kfcdVda4obBSBx7SrLEipoKb?= =?us-ascii?Q?m8tozGk/0Jpg3qXcxmOo22iOfMURPUjgBVNfcmKtLRFSRhqB+JxI3jaP7/ew?= =?us-ascii?Q?bBbTQulRWAcgBbr/1niY2gIngXjgqRYk2v1Qt15bA5H4JL5zu38KqJruMXrH?= =?us-ascii?Q?GQ6XZA3QFq8cI3Lv7GfvoHIOL0t0pGPPC0qm27nZbuT2/+USPdpd2Ev+zp3E?= =?us-ascii?Q?eXiza9xZd/Jl1YAgMQbGe+cEGAAdaji8U2WdDM9mIv1n7DnAOdH1MU6PL/wd?= =?us-ascii?Q?XvK2Tg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: e115a815-7b02-4296-80bd-08da9f9341f9 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 07:46:44.4412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yjDMk1RqiAcKYwY/ZN36QMN1FarPvA2uHAtjAndSRPxCJL/9cQKwNl27tqy9oEJe8LwPVSoHN4L7eZ68XtgPbfa/aUM/5z+pSsp8f8YsX6c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB6870 X-TUID: thFM7aDWClHs Am Mon, 26 Sep 2022 07:57:41 +0200 schrieb "Moessbauer, Felix (T CED SES-DE)" : > > -----Original Message----- > > From: Kanagarajan, Vijaikumar > > Sent: Monday, September 26, 2022 12:53 PM > > To: Moessbauer, Felix (T CED SES-DE) > > ; Schild, Henning (T CED SES-DE) > > Cc: Kiszka, Jan (T CED) > > ; isar- users@googlegroups.com > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > -----Original Message----- > > > From: Moessbauer, Felix (T CED SES-DE) > > > Sent: 26 September 2022 07:11 > > > To: Kanagarajan, Vijaikumar ; > > > Schild, Henning (T CED SES-DE) > > > Cc: Kiszka, Jan (T CED) ; isar- > > > users@googlegroups.com > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > Hi Vijai & Henning, > > > > > > Are there any news on this? > > > I just discovered that still many (if not all) of our images are > > > affected by this bug. > > > > Hi Felix, > > > > Unfortunately not. If we already have the latest wic, > > --no-fstab-update[1] might help.(untested). > > We already have a wic version with this option, but it doesn't look > right to add it to the root partition. Instead this option can be > used for partitions that should not show up in the fstab at all. We do want the one from WIC. It is only coming since we patched WIC to support /. > Indeed, the fstab entry has to be set by WIC to set settings like > UUID and filesystem. But this requires that we either remove the > entry set by ISAR in image_configure_fstab, or we remove the entry > after generating the rootfs, but before WIC. I think we should try and remove the entry from that template. It should not be required. If we decide to solve the problem somewhere in/with WIC, we should do that upstream in OE. They have the same "we now have two" problem, where wic adds on top of a template instead of replacing the original. Henning > Opinions? @Kiszka, Jan (T CED) > > Felix > > > > > Thanks, > > Vijai Kumar K > > > > > > > > While it is not serios, having error messages in the journal is > > > still pretty bad: systemd-fstab-generator[1491]: Failed to create > > > unit file /run/systemd/generator/-.mount, as it already exists. > > > Duplicate entry in /etc/fstab? > > > > > > Felix > > > > > > > -----Original Message----- > > > > From: isar-users@googlegroups.com > > > > On Behalf Of Kanagarajan, Vijaikumar > > > > Sent: Friday, June 17, 2022 1:46 PM > > > > To: isar-users@googlegroups.com > > > > Cc: Kiszka, Jan (T CED) ; Schild, > > > > Henning (T CED SES- > > > > DE) > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Kanagarajan, Vijaikumar > > > > > Sent: 13 June 2022 14:48 > > > > > To: 'Henning Schild' > > > > > Cc: isar-users@googlegroups.com; jan.kiszka@siemens.com > > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Henning Schild > > > > > > Sent: 13 June 2022 14:32 > > > > > > To: Kanagarajan, Vijaikumar > > > > > > Cc: > > > > > > isar-users@googlegroups.com; jan.kiszka@siemens.com > > > > > > Subject: Re: [PATCH v2 2/2] wic: Update to the latest > > > > > > revision > > > > > > > > > > > > Am Mon, 13 Jun 2022 13:24:01 +0530 schrieb Vijai Kumar K > > > > > > : > > > > > > > > > > > > > Update to the latest wic from OE-core. > > > > > > > > > > > > > > OE-core Revision: 06ed2aa93fc25a681e3a00ee120d9395b04845da > > > > > > > > > > > > > > Signed-off-by: Vijai Kumar K > > > > > > > > > > --- > > > > > > > RECIPE-API-CHANGELOG.md | 19 > > > > > > > +++++++++++++++++++ scripts/lib/wic/help.py > > > > > > > | 6 ++++++ scripts/lib/wic/ksparser.py | > > > > > > > 1 + scripts/lib/wic/partition.py | 1 + > > > > > > > scripts/lib/wic/plugins/imager/direct.py | 5 +++-- > > > > > > > 5 files changed, 30 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API- > > > CHANGELOG.md > > > > > > index > > > > > > > 2998824..436b204 100644 > > > > > > > --- a/RECIPE-API-CHANGELOG.md > > > > > > > +++ b/RECIPE-API-CHANGELOG.md > > > > > > > @@ -406,3 +406,22 @@ groups are now created after all > > > > > > > packages are installed. > > > > > > > Changes in next > > > > > > > --------------- > > > > > > > + > > > > > > > +### Wic adds / mountpoint to fstab > > > > > > > + > > > > > > > +In the older version of wic, any mount point named / is > > > > > > > +skipped from > > > > > > > adding +into the fstab entry. > > > > > > > + > > > > > > > +With the latest wic, this is not the case. / mount > > > > > > > point, if +any, is > > > > > > > added +to /etc/fstab for automount. > > > > > > > + > > > > > > > +Any wks file which assumed that / would be skipped from > > > > > > > +/etc/fstab > > > > > > > should +now be corrected. Otherwise, it might result in > > > > > > > multiple / entries in /etc/fstab. +One by the > > > > > > > image_configure_fstab function from image class and one by > > > > > > > wic. + > > > > > > > +Below is an example wks entry that might cause an issue. > > > > > > > +Replace "part /" with "part" to avoid adding duplicate > > > > > > > entry for /. > > > > > > > > > > > > I am not sure multiple entries would be an issue, i think > > > > > > the last one will simply always win. It is good to have a > > > > > > note about that change, but i doubt people really have to > > > > > > do anything. And if anything has to be done, isar should > > > > > > drop the first one centrally. > > > > > > > > > > > > The fstab entry for root is purely for adding some weird > > > > > > mount options, usually root is not mounted with fstab but > > > > > > with cmdline and initrd. And not having / in fstab just > > > > > > makes that rootfs more generic ... it can become part of > > > > > > nfs and next guy takes it as btrfs while next guy > > > > > takes it as ext4. > > > > > > > > > > > > Note is good, advise is not > > > > > > > > > > Noted. Will change the text accordingly in V3. > > > > > > > > Ok we cannot drop / mountpoint name(though optional). We would > > > > be > > > lose > > > > the ability to find out UUID of root using rootdev api. > > > > This is used by some plugins. So the better way would be to use > > > > the --no-fstab- update. Seems like we can set them per > > > > partition now. > > > > > > > > Thanks, > > > > Vijai Kumar K > > > > > > > > > > > > > > Thanks, > > > > > Vijai Kumar K > > > > > > > > > > > > > > > > > Henning > > > > > > > > > > > > > + > > > > > > > +``` > > > > > > > +part / --source rootfs --ondisk sda --fstype ext4 --label > > > > > > > +platform > > > > > > > --align 1024 --use-uuid +``` > > > > > > > diff --git a/scripts/lib/wic/help.py > > > > > > > b/scripts/lib/wic/help.py index > > > > > > > 4ff7470..73e3380 100644 > > > > > > > --- a/scripts/lib/wic/help.py > > > > > > > +++ b/scripts/lib/wic/help.py > > > > > > > @@ -940,6 +940,12 @@ DESCRIPTION > > > > > > > quotes. If not specified, the > > > > > > > default string is "defaults". > > > > > > > > > > > > > > + --fspassno: Specifies the order in which > > > > > > > filesystem > > > > > > > + checks > > > > > > > are done > > > > > > > + at boot time by fsck. See fs_passno > > > > > > > + parameter > > > > > > > of > > > > > > > + fstab(5). This parameter will be > > > > > > > copied > > > > > > > + into > > > > > > > the > > > > > > > + /etc/fstab file of the installed > > > > > > > system. If not > > > > > > > + specified the default value of "0" > > > > > > > will be used. + > > > > > > > --label label: Specifies the label to give to > > > > > > > the filesystem to be made on the partition. If the given > > > > > > > label is already in use by > > > > > > > another filesystem, diff --git > > > > > > > a/scripts/lib/wic/ksparser.py > > > > > > > b/scripts/lib/wic/ksparser.py index 0df9eb0..a49b7b9 > > > > > > > 100644 --- a/scripts/lib/wic/ksparser.py +++ > > > > > > > b/scripts/lib/wic/ksparser.py @@ -155,6 +155,7 @@ class > > > > > > > KickStart(): part.add_argument('--change-directory') > > > > > > > part.add_argument("--extra-space", > > > > > > > type=sizetype("M")) part.add_argument('--fsoptions', > > > > > > > dest='fsopts') > > > > > > > + part.add_argument('--fspassno', dest='fspassno') > > > > > > > part.add_argument('--fstype', default='vfat', > > > > > > > choices=('ext2', 'ext3', > > > > > > > 'ext4', 'btrfs', 'squashfs', 'vfat', > > > > > > > 'msdos', 'erofs', diff --git > > > > > > > a/scripts/lib/wic/partition.py > > > > > > > b/scripts/lib/wic/partition.py index 09e491d..e50871b > > > > > > > 100644 --- a/scripts/lib/wic/partition.py +++ > > > > > > > b/scripts/lib/wic/partition.py @@ -33,6 +33,7 @@ class > > > > > > > Partition(): self.include_path = args.include_path > > > > > > > self.change_directory = args.change_directory > > > > > > > self.fsopts = args.fsopts > > > > > > > + self.fspassno = args.fspassno > > > > > > > self.fstype = args.fstype > > > > > > > self.label = args.label > > > > > > > self.use_label = args.use_label diff --git > > > > > > > a/scripts/lib/wic/plugins/imager/direct.py > > > > > > > b/scripts/lib/wic/plugins/imager/direct.py index > > > > > > > 4d0b836..c44159b > > > > > > > 100644 --- a/scripts/lib/wic/plugins/imager/direct.py > > > > > > > +++ b/scripts/lib/wic/plugins/imager/direct.py > > > > > > > @@ -117,7 +117,7 @@ class DirectPlugin(ImagerPlugin): > > > > > > > updated = False > > > > > > > for part in self.parts: > > > > > > > if not part.realnum or not part.mountpoint \ > > > > > > > - or part.mountpoint == "/" or not > > > > > > > part.mountpoint.startswith('/'): > > > > > > > + or not part.mountpoint.startswith('/'): > > > > > > > continue > > > > > > > > > > > > > > if part.use_uuid: > > > > > > > @@ -138,8 +138,9 @@ class DirectPlugin(ImagerPlugin): > > > > > > > device_name = "/dev/%s%s%d" % (part.disk, > > > > > > > prefix, > > > > > > > part.realnum) > > > > > > > opts = part.fsopts if part.fsopts else > > > > > > > "defaults" > > > > > > > + passno = part.fspassno if part.fspassno else > > > > > > > "0" line = "\t".join([device_name, part.mountpoint, > > > > > > > part.fstype, > > > > > > > - opts, "0", "0"]) + "\n" > > > > > > > + opts, "0", passno]) + "\n" > > > > > > > > > > > > > > fstab_lines.append(line) > > > > > > > updated = True > > > > > > > > -- > > > > You received this message because you are subscribed to the > > > > Google Groups "isar-users" group. > > > > To unsubscribe from this group and stop receiving emails from > > > > it, send an email to isar-users+unsubscribe@googlegroups.com. > > > > To view this discussion on the web visit > > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgrou > > > > > > > ps.g > > > > oogle.com%2Fd%2Fmsgid%2Fisar- > > > > > > > users%2F8babb01d7eae44e0b9faecad59cdc1d4%2540mentor.com&dat > > > a= > > > > > > > 05%7C01%7Cfelix.moessbauer%40siemens.com%7C237b0db9bb724580ca540 > > > 8 > > > > > > > > > da5024a3ad%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C6379104 > > > > > > > 15537105828%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ > > > Ijo > > > > > > > iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sda > > > ta > > > > > > > =%2F%2F1Fxy%2B%2BEgDI4RfUEZ38qy1Q82esArdBuRftDuE1t6s%3D&re > > > se > > > > rved=0.