From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7108629846932062208 X-Received: by 2002:a05:6512:1287:b0:49e:f94f:eb72 with SMTP id u7-20020a056512128700b0049ef94feb72mr9485419lfs.376.1664195658522; Mon, 26 Sep 2022 05:34:18 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:94c7:0:b0:261:ccd8:c60 with SMTP id r7-20020a2e94c7000000b00261ccd80c60ls3543419ljh.10.-pod-prod-gmail; Mon, 26 Sep 2022 05:34:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7pY/+5tss3XGxA9trTOeyXqohFjSOv63Moos22so2CxvieR1i0HhpHjy3c8M7VmvmfA+es X-Received: by 2002:a05:651c:1257:b0:26c:4e3b:6d98 with SMTP id h23-20020a05651c125700b0026c4e3b6d98mr7409173ljh.492.1664195656976; Mon, 26 Sep 2022 05:34:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664195656; cv=pass; d=google.com; s=arc-20160816; b=BYY+qHvRJjshrBGVnTvPtvXPKld4EuUBlR3xG1RSFXglVpbtbc528QWWfH7E+ZzRrs zPKXSSXZGrHcrxR6WnQMYDd9H5xqWN6ALmTLNiyt5pGER9skYhx+A1UNoPRY02D2jMRO tj01zddUXNbbnDvn1xKw8OQd7Szdn7FSKZFaSyzKC269XI/kX/EsDbnVuROBs9fCp9+U Jc/Mwqk9mF6Vqc0rRpCs/fZlXjbdyNCcyTVtxmFsVPFwfZf0LaCuW/waMW2HH3eApPnQ EyzsGgnUDDurkzX0YD9Fg3izzW298rnvoCYb/ItsHh9seuYia8JkvE4PfO00bLhPC2hM 1NRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=2/b22lXrLuuRbG0wewGATzS/apc56tZWmExofvatqh4=; b=tccBwflm888LLeDD4oeVOdUUEXfFqgQWs3c1cK3BZeaS6e54vsu4T2rmNV5Oef+cyi ntXhdRsWBM3jpar3losLGTi2lFHczQwxMXyO1r5oJu+KZLgj+BNa+VfoXxV5q+ZXhE2b mLHcl6Gks3TJ4kuLoc7SpFvIYIPBe8ab8BWcL8Ho52U9gIcLS3TDukc/eFEwR0QPRip4 VunmfgHBJhoQn/NfsNtaG5rOwDOZBuuoJhUgo0IpxOYMUv4NmQXctc5lm5XUrKyobedM Uqk5uoZ89sD10tTVEduUSUirZO0RrcXE9+LpRU/Rv8mDaoU3V9CEC8U0+JC1OSRvf3M+ cAqQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="unFyf/ov"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.54 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80054.outbound.protection.outlook.com. [40.107.8.54]) by gmr-mx.google.com with ESMTPS id g5-20020a056512118500b0048b224551b6si595475lfr.12.2022.09.26.05.34.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Sep 2022 05:34:16 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.54 as permitted sender) client-ip=40.107.8.54; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="unFyf/ov"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.54 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TVF5O8AYtIqcX+2Fv5MZkdKRhgoY464f2Dgc/hEY2TeEDi8TuKiZWvWUAacfmPHqEIBHap6PkSYME9q0ZGuh8g8QhlcRMPxhl1V7IsWNir15n5rm5I9gOuul+cKUhw/AeZda+Q6DfRzmdGXiUYaIUlEepEPbbDd8n7jlKVepVtNmsXEjln1crsp3PeGUdR1ZCmr/Lycx3avaGrSHwgIerlPnfklu9rhrmDnOdS6SVWQ4TfbxG0/4gsxDC0fUoFaE5nEnoJdSqwnLZrclMmYGMkzieks/RU7Gl1ZoSfv56Jh9QHhWKYuP4TOOalBPXWRqQzdA9GRoN9f+2tMfaLg9fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2/b22lXrLuuRbG0wewGATzS/apc56tZWmExofvatqh4=; b=QoOJhyhPwsl3O7EqmU2SmG7cTWsKDasaqeAZSetdSh2ZD7Z3yjEkF3MeG2vMDTcwzF/4EwZr3E8tDfisgzEM5yyHZpPTXJki7MJX+AOyTkzFKyu21luNgp0rOJGd49+PukJrr6zUeg5a+03cpwjQbk+zU6qXo+15b7RL4iW7pk51v9FtqdKjha/3m1MYXBiiu8WGmvVzjhU8HyMdUNMKFGWjCkop41s2UR9i0YCHUG268pGY9of7kajHa1HsIhS97/mD+VcCLx7fdEJCFM0KQrRZpUTJPJ3jEpIVzsjbH0kcMk4jP1npIVikSCpApYzuMQE2EZUTcYANryy6WPAPaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2/b22lXrLuuRbG0wewGATzS/apc56tZWmExofvatqh4=; b=unFyf/ov1eDEt9sWfyAwfEV95nqCGb2QYJRzBboc+TZuwz3gZ270ak+uKMjrJD6AO17OsFl5LgUzNp7sNQPtNDez6QmW/X7kCAOO9IWHmBCaaunW8txpwwwhkRJTWuqiko8MclN3IpRfUbw0p7vbs4kLTGt+ypn/gDgAG3PjWD7nyHhPO6c0M5INEEXdYldE84Ji+dfCnj8aTXmo+GNKdTrgo7rZfsrirL0WDPDQM5wp1nxTJUpa3i6xXDHcHnpSqrqFnjH9+1ZX6S0mWCrEFGjzwUcIiVjNfX4LNBFzXa9hwy8kGJGuNTANOUA3MNG2zJnioVtMM4pRraxsQX9qlQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AM9PR10MB4056.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1f5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 12:34:15 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1%7]) with mapi id 15.20.5654.024; Mon, 26 Sep 2022 12:34:14 +0000 Date: Mon, 26 Sep 2022 14:34:07 +0200 From: Henning Schild To: "Kanagarajan, Vijaikumar" Cc: "felix.moessbauer@siemens.com" , "jan.kiszka@siemens.com" , "isar-users@googlegroups.com" Subject: Re: [PATCH v2 2/2] wic: Update to the latest revision Message-ID: <20220926143407.66e1586c@md1za8fc.ad001.siemens.net> In-Reply-To: <7d23828243444e90afd49e7bb23717dc@mentor.com> References: <20220613075401.2059119-1-Vijaikumar_Kanagarajan@mentor.com> <20220613075401.2059119-3-Vijaikumar_Kanagarajan@mentor.com> <20220613110206.0fa05e12@md1za8fc.ad001.siemens.net> <476c6e8a8687499a85fced0e07299815@mentor.com> <8babb01d7eae44e0b9faecad59cdc1d4@mentor.com> <6157334379c44f8b938983d5c4dfd8b1@mentor.com> <20220926094138.36c36a30@md1za8fc.ad001.siemens.net> <7d23828243444e90afd49e7bb23717dc@mentor.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR12CA0018.namprd12.prod.outlook.com (2603:10b6:610:57::28) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|AM9PR10MB4056:EE_ X-MS-Office365-Filtering-Correlation-Id: f5ecef3e-3f1b-4900-5a1c-08da9fbb6c01 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hiE0xgibAKGDF4IljUHTHGdbNdVfwStvd+FKzAfWbTOn3rDI085wd4Sm6YkkPfkxQj3cZ0QCy60cMuZdsQamN70zcDPupTsHaJ2e12kVyJIijjRM2d1UpLgxq5oM7TKRLhAseT8ZvunHbJU1Z8HLMDM82DccNs9oX9IASgOW74qegjhLMhjAUcefbznjpAMMpt1jzi51gBqraujLQM8XZAYi9k+SmoPtXwto9YOuQzf9V/bakLWwIEnmcKQICTIvWdjVWI5FEIr2ZpEJIdL2GEsga8R4O6xkq3Cf6duWlyF3F3Tg2ORMbYQ97eKxbIFkiaE9X9EDpKfQLp/RG/vbAR2rJev/TS+Mq8/Dqm4KdhBFc0QCNF2EWIltDNDBr1c+eBg7nzTwUUC2rJRJYyaDZYpJ1tzFeIfr7N9HPOFeKWiM4I+edEnunhfR1WbVR61iTA2k9Jqw6K++/OaTuLTb4+OXui+Dfmcw8Ibkeh3zCRhjW2hTVNjr05+FfGVTDsN9DXw55ZQi6Vh1dVIuptGHjs9OOnPM8jtDSHrYFh6ISQrrqBIjZlSVM3EiX7klAHdR/7JFO5Ei4AfOiWEPJkiPg7+9bf4ynzwvFInbtzEYgyzKbGvY8F/hOGwb/QyWzLQDtUm3TyulQaAvW8fiPdgsOxR5wFnoORvHFy8aCSHXBY8HtDBZbtiEsxwD+/w7mu5QufGLfK0MPoQpI81mqftZm7UHoJfI5dUojAZNpxB36sg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(451199015)(6916009)(54906003)(86362001)(1076003)(5660300002)(82960400001)(38100700002)(83380400001)(186003)(6506007)(6512007)(6666004)(9686003)(26005)(41300700001)(966005)(6486002)(478600001)(4326008)(44832011)(66946007)(45080400002)(30864003)(66476007)(316002)(66556008)(8676002)(8936002)(15650500001)(2906002)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?izbnj005aEwg8PKm93l9WSXQ0uZVQZwaevr9zB2XEZou3IH1RW2l/oNi1Syh?= =?us-ascii?Q?QuTcZmi0b4l6ABIxn5AVsiAn/GhJplYY9+9/EWol2wHcTHqwFeFQlIsCg2iU?= =?us-ascii?Q?sx+aSJhPdF+SGpJLvlYTeET+C6Y3qsOIHZgz4w4DVqVPzYQc4CoD8Lf9oRlX?= =?us-ascii?Q?r49MBmIjsLB4Qv03mEbMwhwLmufB5LGPIfkZCR4p5JOiLgSBPQEd+xzOXBPd?= =?us-ascii?Q?cIi4do+88fFzTeG/b8s254QA1Ml89VWypwzr5zfRnscpk0yYZYdctgwg2eSM?= =?us-ascii?Q?eVJnCIMRywPHajhHcSEe2/gktOOFplBQ16mVuxS9pETcsRnvZE7O7sK2+9BV?= =?us-ascii?Q?aeydeca+SvRbNCYLq6J1wdFOC8/23kiix8wqVk/FmfaVA6QfIUGTOiHvG/Cu?= =?us-ascii?Q?JvtHYOiTO6LAlCM1aB/DbDYae12kbsdlsPwff2+IQAsP2b/iMBOznfL1h66y?= =?us-ascii?Q?HDUSwxInwCzLlXPA7vJi7VnFr2GDzAqH0x211SgNoj3uz6hwJVJLLgzy9zIR?= =?us-ascii?Q?NQB1zLr510V7cDfU4qIBaGdMPZ3YZ5ocGCkzfpXAHS4QTm2xtDXvklMAgtKp?= =?us-ascii?Q?mQ+1BwLSeQTurq73t0NqB3YZB3SdJNDrKPPZ53cE463GiKmhMM9jqUGBlgDU?= =?us-ascii?Q?ppdPrdJisfLWRyMuv10gdy+6CD7qPjKkAulZy45L8SIbEyLnADjgvVNGsf9u?= =?us-ascii?Q?RT4IsGpJpP95WDpHcvdbagGugsvSeVLi84QI9Np4/eZe6Zzt/UZdSI6OuZBu?= =?us-ascii?Q?HSK0k4zHQLd636key4IHl/P4WILeUWi6mKq3AxmoAYT/1cqdZG2Qb8owpSdf?= =?us-ascii?Q?iq77L57V6M61sGsf8OKknTvnJiWTwyvaURO7krgau5b7RYdbcA0XPwBNzFTo?= =?us-ascii?Q?n1GtDZA4OScE3BtZB7axcso1yLD/nN5xYvAiQJmgRaNlX2wC3NnKABk15SP6?= =?us-ascii?Q?eWAOr3QrxTdnGEXXKsOpytIK3v1+EBju5f0afF/5nLu1psxgoYC9txh91XFw?= =?us-ascii?Q?sSPMJJnOKf3lIlEhxzItsgXk2rnsEgX9j0qN1PCVVM2lq6ZfNhpwpfkOGY4X?= =?us-ascii?Q?uCCTboblAC2CU0rvhcra/t7l4b7goHTgEeDDeaY59DfI6VorbktYr3HZ03ab?= =?us-ascii?Q?g5rM7zyYfKMQ62txvKk2Aj+Ci2bwMHgelmccEWeQ2At1kGWJNqTtLHHS2gog?= =?us-ascii?Q?llkU6fLfqMj676T5XSqQ89vqRkQlidGk3BSmrAS3zkiwhBpRMiqPqV4iWWr4?= =?us-ascii?Q?AJMICe1AYVHEOpWFo7hxsXA6nupYSihyRQATfa8aE2tNys2JBunTDiKX97tQ?= =?us-ascii?Q?MrKDKaC0awJVFGetWB4aMf452Lu1G5og4mJCxRI+/2P8iIvTgrWobZBtL983?= =?us-ascii?Q?on9vhAbr0DFVuIoBQgGVIFe6Sg79CLb0K2u2XwqcmGyAYkYHrjFv0PhKx7hr?= =?us-ascii?Q?zrCKQnklutIHJmMc+bqmY3oQzYIXQ1/sqEkFtEFg7ssjDKvfbOAGy1C9YoY1?= =?us-ascii?Q?ELwiDOw3o4mkqip+8JS/q2OpupwXrFHfMtMQGA3Amvhryg4WndxENppKIMm5?= =?us-ascii?Q?2JpLUep/nEKbcpL9UNPAzieIE8ysUxGAElhrC43Kncj/K1cwMqqJvRgTvDjJ?= =?us-ascii?Q?4A=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5ecef3e-3f1b-4900-5a1c-08da9fbb6c01 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 12:34:14.8574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OdMYeeA3Bpnf3moAuf65Nt7CXz0+3y4dLPEr8/CFcRt0/ykot5I9oI2jhBUR18AH5ytjyLc3/xgXlRVJrjGJ44bjIYxM53tEMNsRBMSnqMo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB4056 X-TUID: tRMex27/kzKO Am Mon, 26 Sep 2022 07:56:48 +0000 schrieb "Kanagarajan, Vijaikumar" : > > -----Original Message----- > > From: Henning Schild > > Sent: 26 September 2022 13:17 > > To: felix.moessbauer@siemens.com; Kanagarajan, Vijaikumar > > ; jan.kiszka@siemens.com > > Cc: isar-users@googlegroups.com > > Subject: Re: [PATCH v2 2/2] wic: Update to the latest revision > > > > Am Mon, 26 Sep 2022 07:57:41 +0200 > > schrieb "Moessbauer, Felix (T CED SES-DE)" > > : > > > > > > -----Original Message----- > > > > From: Kanagarajan, Vijaikumar > > > > Sent: Monday, September 26, > > > > 2022 12:53 PM To: Moessbauer, Felix (T CED SES-DE) > > ; > > > > Schild, Henning (T CED SES-DE) Cc: > > > > Kiszka, Jan (T CED) ; isar- > > > > users@googlegroups.com > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Moessbauer, Felix (T CED SES-DE) > > > > > Sent: 26 September 2022 07:11 > > > > > To: Kanagarajan, Vijaikumar > > > > > ; Schild, Henning (T CED > > > > > SES-DE) Cc: Kiszka, Jan (T CED) > > > > > ; isar- users@googlegroups.com > > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > Hi Vijai & Henning, > > > > > > > > > > Are there any news on this? > > > > > I just discovered that still many (if not all) of our images > > > > > are affected by this bug. > > > > > > > > Hi Felix, > > > > > > > > Unfortunately not. If we already have the latest wic, > > > > --no-fstab-update[1] might help.(untested). > > > > > > We already have a wic version with this option, but it doesn't > > > look right to add it to the root partition. Instead this option > > > can be used for partitions that should not show up in the fstab > > > at all. > > > > We do want the one from WIC. It is only coming since we patched WIC > > to support /. > > > > > Indeed, the fstab entry has to be set by WIC to set settings like > > > UUID and filesystem. But this requires that we either remove the > > > entry set by ISAR in image_configure_fstab, or we remove the > > > entry after generating the rootfs, but before WIC. > > > > I think we should try and remove the entry from that template. It > > should not be required. > > > > If we decide to solve the problem somewhere in/with WIC, we should > > do that upstream in OE. They have the same "we now have two" > > problem, where wic adds on top of a template instead of replacing > > the original. > > This seems to me like the approach we should take. Make wic replace > entries in fstab instead of appending to them like how it does now. That is the more complicated way. I do not recall all the details but i think we should rather drop the / line from the template. Such a line is usually not needed, having it is rather limiting the use of the rootfs because you might have a device name standing there which might be wrong ... i.e. sda1 vs vda1 vs nfs I think we could contribute both to OE. The removal of the / line from their template, and the "wic will try and update not append". But we could also simply drop the template line in isar ... not care about OE and making our non wic images better in fact. There might be weird cornercases, maybe a too old raspi image ... where that line is needed. I would move it to those corner-case images if there are any. Henning > Thanks, > Vijai Kumar K > > > > > Henning > > > > > Opinions? @Kiszka, Jan (T CED) > > > > > > Felix > > > > > > > > > > > Thanks, > > > > Vijai Kumar K > > > > > > > > > > > > > > While it is not serios, having error messages in the journal > > > > > is still pretty bad: systemd-fstab-generator[1491]: Failed to > > > > > create unit file /run/systemd/generator/-.mount, as it > > > > > already exists. Duplicate entry in /etc/fstab? > > > > > > > > > > Felix > > > > > > > > > > > -----Original Message----- > > > > > > From: isar-users@googlegroups.com > users@googlegroups.com> > > > > > > On Behalf Of Kanagarajan, Vijaikumar > > > > > > Sent: Friday, June 17, 2022 1:46 PM > > > > > > To: isar-users@googlegroups.com > > > > > > Cc: Kiszka, Jan (T CED) ; Schild, > > > > > > Henning (T CED SES- > > > > > > DE) > > > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest > > > > > > revision > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Kanagarajan, Vijaikumar > > > > > > > Sent: 13 June 2022 14:48 > > > > > > > To: 'Henning Schild' > > > > > > > Cc: isar-users@googlegroups.com; jan.kiszka@siemens.com > > > > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest > > > > > > > revision > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Henning Schild > > > > > > > > Sent: 13 June 2022 14:32 > > > > > > > > To: Kanagarajan, Vijaikumar > > > > > > > > Cc: > > > > > > > > isar-users@googlegroups.com; jan.kiszka@siemens.com > > > > > > > > Subject: Re: [PATCH v2 2/2] wic: Update to the latest > > > > > > > > revision > > > > > > > > > > > > > > > > Am Mon, 13 Jun 2022 13:24:01 +0530 schrieb Vijai Kumar K > > > > > > > > : > > > > > > > > > > > > > > > > > Update to the latest wic from OE-core. > > > > > > > > > > > > > > > > > > OE-core Revision: > > 06ed2aa93fc25a681e3a00ee120d9395b04845da > > > > > > > > > > > > > > > > > > Signed-off-by: Vijai Kumar K > > > > > > > > > > > > > > --- > > > > > > > > > RECIPE-API-CHANGELOG.md | 19 > > > > > > > > > +++++++++++++++++++ scripts/lib/wic/help.py > > > > > > > > > | 6 ++++++ scripts/lib/wic/ksparser.py > > > > > > > > > | 1 + scripts/lib/wic/partition.py | 1 > > > > > > > > > + scripts/lib/wic/plugins/imager/direct.py | 5 +++-- > > > > > > > > > 5 files changed, 30 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API- > > > > > CHANGELOG.md > > > > > > > > index > > > > > > > > > 2998824..436b204 100644 > > > > > > > > > --- a/RECIPE-API-CHANGELOG.md > > > > > > > > > +++ b/RECIPE-API-CHANGELOG.md > > > > > > > > > @@ -406,3 +406,22 @@ groups are now created after all > > > > > > > > > packages are installed. > > > > > > > > > Changes in next > > > > > > > > > --------------- > > > > > > > > > + > > > > > > > > > +### Wic adds / mountpoint to fstab > > > > > > > > > + > > > > > > > > > +In the older version of wic, any mount point named / > > > > > > > > > is +skipped from > > > > > > > > > adding +into the fstab entry. > > > > > > > > > + > > > > > > > > > +With the latest wic, this is not the case. / mount > > > > > > > > > point, if +any, is > > > > > > > > > added +to /etc/fstab for automount. > > > > > > > > > + > > > > > > > > > +Any wks file which assumed that / would be skipped > > > > > > > > > from +/etc/fstab > > > > > > > > > should +now be corrected. Otherwise, it might result > > > > > > > > > in multiple / entries in /etc/fstab. +One by the > > > > > > > > > image_configure_fstab function from image class and > > > > > > > > > one by wic. + > > > > > > > > > +Below is an example wks entry that might cause an > > > > > > > > > issue. +Replace "part /" with "part" to avoid adding > > > > > > > > > duplicate entry for /. > > > > > > > > > > > > > > > > I am not sure multiple entries would be an issue, i > > > > > > > > think the last one will simply always win. It is good > > > > > > > > to have a note about that change, but i doubt people > > > > > > > > really have to do anything. And if anything has to be > > > > > > > > done, isar should drop the first one centrally. > > > > > > > > > > > > > > > > The fstab entry for root is purely for adding some weird > > > > > > > > mount options, usually root is not mounted with fstab > > > > > > > > but with cmdline and initrd. And not having / in fstab > > > > > > > > just makes that rootfs more generic ... it can become > > > > > > > > part of nfs and next guy takes it as btrfs while next > > > > > > > > guy > > > > > > > takes it as ext4. > > > > > > > > > > > > > > > > Note is good, advise is not > > > > > > > > > > > > > > Noted. Will change the text accordingly in V3. > > > > > > > > > > > > Ok we cannot drop / mountpoint name(though optional). We > > > > > > would be > > > > > lose > > > > > > the ability to find out UUID of root using rootdev api. > > > > > > This is used by some plugins. So the better way would be to > > > > > > use the --no-fstab- update. Seems like we can set them per > > > > > > partition now. > > > > > > > > > > > > Thanks, > > > > > > Vijai Kumar K > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > Vijai Kumar K > > > > > > > > > > > > > > > > > > > > > > > Henning > > > > > > > > > > > > > > > > > + > > > > > > > > > +``` > > > > > > > > > +part / --source rootfs --ondisk sda --fstype ext4 > > > > > > > > > --label +platform > > > > > > > > > --align 1024 --use-uuid +``` diff --git > > > > > > > > > a/scripts/lib/wic/help.py b/scripts/lib/wic/help.py > > > > > > > > > index 4ff7470..73e3380 100644 > > > > > > > > > --- a/scripts/lib/wic/help.py > > > > > > > > > +++ b/scripts/lib/wic/help.py > > > > > > > > > @@ -940,6 +940,12 @@ DESCRIPTION > > > > > > > > > quotes. If not specified, the > > > > > > > > > default string is "defaults". > > > > > > > > > > > > > > > > > > + --fspassno: Specifies the order in which > > > > > > > > > filesystem > > > > > > > > > + checks > > > > > > > > > are done > > > > > > > > > + at boot time by fsck. See > > > > > > > > > fs_passno > > > > > > > > > + parameter > > > > > > > > > of > > > > > > > > > + fstab(5). This parameter will > > > > > > > > > be copied > > > > > > > > > + into > > > > > > > > > the > > > > > > > > > + /etc/fstab file of the installed > > > > > > > > > system. If not > > > > > > > > > + specified the default value of > > > > > > > > > "0" will be used. + > > > > > > > > > --label label: Specifies the label to give > > > > > > > > > to the filesystem to be made on the partition. If the > > > > > > > > > given label is already in use by > > > > > > > > > another filesystem, diff --git > > > > > > > > > a/scripts/lib/wic/ksparser.py > > > > > > > > > b/scripts/lib/wic/ksparser.py index 0df9eb0..a49b7b9 > > > > > > > > > 100644 --- a/scripts/lib/wic/ksparser.py +++ > > > > > > > > > b/scripts/lib/wic/ksparser.py @@ -155,6 +155,7 @@ > > > > > > > > > class KickStart(): > > > > > > > > > part.add_argument('--change-directory') > > > > > > > > > part.add_argument("--extra-space", > > > > > > > > > type=sizetype("M")) part.add_argument('--fsoptions', > > > > > > > > > dest='fsopts') > > > > > > > > > + part.add_argument('--fspassno', > > > > > > > > > dest='fspassno') part.add_argument('--fstype', > > > > > > > > > default='vfat', choices=('ext2', 'ext3', > > > > > > > > > 'ext4', 'btrfs', 'squashfs', 'vfat', 'msdos', 'erofs', > > > > > > > > > diff --git a/scripts/lib/wic/partition.py > > > > > > > > > b/scripts/lib/wic/partition.py index 09e491d..e50871b > > > > > > > > > 100644 --- a/scripts/lib/wic/partition.py +++ > > > > > > > > > b/scripts/lib/wic/partition.py @@ -33,6 +33,7 @@ class > > > > > > > > > Partition(): self.include_path = args.include_path > > > > > > > > > self.change_directory = args.change_directory > > > > > > > > > self.fsopts = args.fsopts > > > > > > > > > + self.fspassno = args.fspassno > > > > > > > > > self.fstype = args.fstype > > > > > > > > > self.label = args.label > > > > > > > > > self.use_label = args.use_label diff --git > > > > > > > > > a/scripts/lib/wic/plugins/imager/direct.py > > > > > > > > > b/scripts/lib/wic/plugins/imager/direct.py index > > > > > > > > > 4d0b836..c44159b > > > > > > > > > 100644 --- a/scripts/lib/wic/plugins/imager/direct.py > > > > > > > > > +++ b/scripts/lib/wic/plugins/imager/direct.py > > > > > > > > > @@ -117,7 +117,7 @@ class DirectPlugin(ImagerPlugin): > > > > > > > > > updated = False > > > > > > > > > for part in self.parts: > > > > > > > > > if not part.realnum or not > > > > > > > > > part.mountpoint \ > > > > > > > > > - or part.mountpoint == "/" or not > > > > > > > > > part.mountpoint.startswith('/'): > > > > > > > > > + or not > > > > > > > > > part.mountpoint.startswith('/'): continue > > > > > > > > > > > > > > > > > > if part.use_uuid: > > > > > > > > > @@ -138,8 +138,9 @@ class DirectPlugin(ImagerPlugin): > > > > > > > > > device_name = "/dev/%s%s%d" % > > > > > > > > > (part.disk, prefix, > > > > > > > > > part.realnum) > > > > > > > > > opts = part.fsopts if part.fsopts else > > > > > > > > > "defaults" > > > > > > > > > + passno = part.fspassno if part.fspassno > > > > > > > > > else "0" line = "\t".join([device_name, > > > > > > > > > part.mountpoint, part.fstype, > > > > > > > > > - opts, "0", "0"]) + "\n" > > > > > > > > > + opts, "0", passno]) + > > > > > > > > > "\n" > > > > > > > > > > > > > > > > > > fstab_lines.append(line) > > > > > > > > > updated = True > > > > > > > > > > > > -- > > > > > > You received this message because you are subscribed to the > > > > > > Google Groups "isar-users" group. > > > > > > To unsubscribe from this group and stop receiving emails > > > > > > from it, send an email to > > > > > > isar-users+unsubscribe@googlegroups.com. To view this > > > > > > discussion on the web visit > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > > > > grou > > > > > > > > > > > ps.g > > > > > > oogle.com%2Fd%2Fmsgid%2Fisar- > > > > > > > > > > > > > users%2F8babb01d7eae44e0b9faecad59cdc1d4%2540mentor.com&dat > > > > > a= > > > > > > > > > > > > > 05%7C01%7Cfelix.moessbauer%40siemens.com%7C237b0db9bb724580ca540 > > > > > 8 > > > > > > > > > > > > > > > > > da5024a3ad%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C6379104 > > > > > > > > > > > > > 15537105828%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ > > > > > Ijo > > > > > > > > > > > > > iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sda > > > > > ta > > > > > > > > > > > > > =%2F%2F1Fxy%2B%2BEgDI4RfUEZ38qy1Q82esArdBuRftDuE1t6s%3D&re > > > > > se > > > > > > rved=0. >