Re: [PATCH 1/1] expand last partition supports btrfs

[Henning Schild <henning.schild@siemens.com>]

Am Fri, 30 Sep 2022 13:29:52 +0200
schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:

> Il Ven 30 Set 2022, 12:58 Henning Schild <henning.schild@siemens.com>
> ha scritto:
> 
> > Am Fri, 30 Sep 2022 09:43:23 +0200
> > schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:
> >  
> > > Hi,
> > >
> > >  the patch is in attachment, I am sorry. However, it has been
> > > created with git format-patch as requested by contributions rules.
> > >
> > >  This patch extend the last partition to btrfs because only ext4
> > > was supported.  
> >
> > We had a similar patch floating around, but as already mentioned our
> > current understanding is that systemd-resizefs will be the way
> > forward.
> >
> > So this patch should not be merged while we still hold on to that
> > idea and wait for that systemd patch to arrive and cover the one
> > corner-case it still leaves open.
> >  
> 
> Is the btrfs a corner case? ;-)

No. We appreciate btrfs and see it as a very valuable fs some people
might want to use for their images. Several Isar users already use it
today.

The corner-case is systemd-resizefs not working in Debian9, while Isar
still supports this. So a patch has to deal with that until we drop the
support for that EoL distro.

> It is OK do not let go it into the mainstream. After all the btrfs is
> less performant than ext4 but it has a data corruption feature that
> cannot allow corrupted data to be read. It might worth a
> consideration in some fields/applications.
> 
> It has been designed just to be a transitional quick-patch.

Such things cause more headache than a proper solution would. And that
solution is very much in reach.

Feel free to apply that patch in your layer, you can likely bbappend
somehow and do not actually have to patch isar.

Henning
 
> Thanks for your opinion and feedback, R-