public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Felix Moessbauer <felix.moessbauer@siemens.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Henning Schild <henning.schild@siemens.com>
Subject: [PATCH] image: remove / entry from fstab template
Date: Tue, 4 Oct 2022 13:46:29 +0200	[thread overview]
Message-ID: <20221004114629.27275-1-henning.schild@siemens.com> (raw)

An fstab entry for / should usually not be required. It just makes a
rootfs less portable (USB vs. NFS, vs. SSD). The kernel is the one
that should know which fs to mount and how. That is done via a bootloader.

Should additional mount options be needed for a concrete image, an
imager like wic might add an entry. i.e. for adding fspassno or
x-systemd.growfs

So to make the rootfs more generic and to allow imagers to add their
individual / lines, instead of having to modify an existing one, remove
the line from the template.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/image.bbclass | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index ccff81066178..d8d605d3af07 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -327,7 +327,6 @@ image_configure_fstab[weight] = "2"
 image_configure_fstab() {
     sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF
 # Begin /etc/fstab
-/dev/root	/		auto		defaults		0	0
 proc		/proc		proc		nosuid,noexec,nodev	0	0
 sysfs		/sys		sysfs		nosuid,noexec,nodev	0	0
 devpts		/dev/pts	devpts		gid=5,mode=620		0	0
-- 
2.35.1


             reply	other threads:[~2022-10-04 11:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 11:46 Henning Schild [this message]
2022-10-04 11:53 ` Henning Schild
2022-10-04 11:54 ` Jan Kiszka
2022-10-04 12:21   ` Henning Schild
2022-10-11 18:03 ` Anton Mikanovich
2022-10-13 15:00   ` Henning Schild
2022-10-14 12:08     ` Anton Mikanovich
2022-10-14 16:27       ` Klincov, Wadim
2022-10-14 17:18         ` Anton Mikanovich
2022-10-14 12:10 ` Anton Mikanovich
2023-01-05 13:08 ` Florian Bezdeka
2023-01-06  4:58   ` Moessbauer, Felix
2023-01-06  8:54     ` Florian Bezdeka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221004114629.27275-1-henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox