From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7150622362639007744 X-Received: by 2002:a05:6512:22d3:b0:4a2:3b96:e980 with SMTP id g19-20020a05651222d300b004a23b96e980mr4052378lfu.352.1664884436309; Tue, 04 Oct 2022 04:53:56 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:bc09:0:b0:26d:cf5c:d952 with SMTP id b9-20020a2ebc09000000b0026dcf5cd952ls1223991ljf.5.-pod-prod-gmail; Tue, 04 Oct 2022 04:53:55 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7DCfJJgfe3bWd6HjegBGg+399L1eGDKqrZAYAlQfy7kS24g2JZZcANFmHWP78m5JX1YHnD X-Received: by 2002:a2e:a910:0:b0:26a:ed13:cda6 with SMTP id j16-20020a2ea910000000b0026aed13cda6mr7611676ljq.250.1664884435058; Tue, 04 Oct 2022 04:53:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664884435; cv=pass; d=google.com; s=arc-20160816; b=AoOr8rdb2p1bfQ+2Klg+WhGJ+Fu2daTNSdHibkTTssW27fbC61VxAM/SLdViaXIzj2 BsMvqHbnv8ztNfjw0B/rIrWfRz0rlbYmmPEStPwTB9CPi4d0MVs5GTx91f+xRK4LOHVE xP2sJehyPwvkCIhylMS/+Fmp5h0a0jdmw783PVHH2/APnZDvhVAUc26b8XQ7kcKVSHgp eKfaQCxLeura/yUGioppBr/XtmcFZGBjMfD8490l1TlpiczRTe5zSadlhbi3RGvuStv/ ghM+C43sdBRfGGYOPOHofypgnmHEgByNZmqeNI1WKe1EuvT4mXE1XKJwbb9X+K17v9Sa BtMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=EXx2paeqVaZ4ZcSGgxfWyfg7zJ7f7rdth8j/MYDlPRM=; b=l56SqVBC/5f8CdLcsk/vxd9OVtwd/cUDmWYFBpaPkAVgIs/bDaUkezvDxhTEXj5F2f GuZlwWssg7heQJi4hSKahvG+nN8n/8/1sVMoclf6B4o+7ptrh8Xq0LsqQ3S82J1KsB7+ a6vrgTfc7ZSxCUzFnQmXEeETvCk71ArKFx+F+pg+Y/trJ9zA3XEOUjfWAU+qWISA1+fA al/djiypjoSRLJgsWFWmRY0dKdPLQ2hmAkaKbkhf7hDuscCi6qCyskno85T5NI4aLnaY dbBEZz/7lHWHMJCzLuudK1TO1Kj/Dlk+LGrZxQSxPkFVBlGeNNu69euInzCJhoL1r0u1 J5Pw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="l9Po/VSh"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.83 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2083.outbound.protection.outlook.com. [40.107.21.83]) by gmr-mx.google.com with ESMTPS id t29-20020a19911d000000b004a225e3ed13si337902lfd.13.2022.10.04.04.53.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2022 04:53:54 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.83 as permitted sender) client-ip=40.107.21.83; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="l9Po/VSh"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.83 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i3qoZOFCxTKNmcUdWJp+gMZaW/uJggWn+gvey5a696FhQTl4vTvr9M8eGrcOlWznCLEFeMPrPutPATyDHRXPWMcKVme0rpoFVesrs3GnsGmtyI36rBLX4667uycUy/pwnInuHEpgowczu3yoeYFU7RymgGL+31PiF6kAIPFWkX3fU/XPRlXHLxhZOZwZ2YxocXvCuLRlOsjpBQ7h4oBVkEt9SRFRnbMzR8gmQmHCd4kjSnNzI4kAdDAZuZICPi0sWY1BMM1yazQsoBgwzynLjImfVZngE5Q7j+HKBxPOct+WzsSK5GmNGWeGIC9Xe8ffUB2JGkRM0ZbjEoJGGUbCqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EXx2paeqVaZ4ZcSGgxfWyfg7zJ7f7rdth8j/MYDlPRM=; b=IUQoL2i7frkSPkw447r3vlUzdye2p2VqPdNtP+cALNhHlNsIABNaGeFz2B1PLuMNSp/IckPfLV4Z9qf2SXNUfC42spqwaHK65/hMa2UeOyuK2bRod187+IgVlQvVpjANaka9bcznsg+XRQPd1LYzp4k/UEcPEVn4S6WLfRlzn2Eq9UnA0hcnWfL7Le83G3VNhe/DYBMQI0bEgEYxaq+RQFXjuU2xX9LbsFT4A+XUPor7s+2Rlw/j1pOHB+XBLHorkurtlixjCu6iAucFPQKWIdRnwxXyX3JbhG9Gn3vWGIHpAg+RgGH6H+LsC2pCGZyzBD0YU+mr21aeWWdE8csdOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EXx2paeqVaZ4ZcSGgxfWyfg7zJ7f7rdth8j/MYDlPRM=; b=l9Po/VSh1JsgPa/GbjRIKf9ta9EldMnPnKvsAmk8HGbSMRcGL7PRv9dYprbdc2G+nfsPPHS2p0+fa9DZnzHIsKCGUuPSqySdxa+dnnJ8MO2NJ1IyDsj3odclL6Sq6rqvxj84Phm9okvqjBk74l7oUDswQsNwjaVZ9LXloNwLaRm/w3PDSMe8InMGr3V5jsG1xaRRB0Zoqc7DEUfAmwr/FY7J2KhOlK1G0R9f+ueZirSbypl7OqdknAkREdad4tzuDv13XxpJMbr0dC4/Wwpp+UV++IkBLVi8fmo8Wx5gX2/NJqnD5ZRM4xjVgFuZMcnh7NSQ2w2zwYjqpfdTpfU0OA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AM0PR10MB3635.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:153::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct 2022 11:53:53 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1%7]) with mapi id 15.20.5676.024; Tue, 4 Oct 2022 11:53:53 +0000 Date: Tue, 4 Oct 2022 13:53:49 +0200 From: Henning Schild To: Cc: Felix Moessbauer , Jan Kiszka Subject: Re: [PATCH] image: remove / entry from fstab template Message-ID: <20221004135349.0086c50e@md1za8fc.ad001.siemens.net> In-Reply-To: <20221004114629.27275-1-henning.schild@siemens.com> References: <20221004114629.27275-1-henning.schild@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::17) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|AM0PR10MB3635:EE_ X-MS-Office365-Filtering-Correlation-Id: e95f67bc-a83e-4f01-58af-08daa5ff1c30 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QN8oG0pjiWG1dWtzllWzeFIn3D+0W6camPZh5I3T7J8gQLIueefQXbSGqceOFWkglFHwTb5ZF6QanWj8S+cUiX2vPvwY8MJv0AEDFBRqQ+lZ3Fd6PpUR5BvVkn7T9jIuUcXgXvBDfMl8S3Szij2h3FnmuM+24dS8it8kJ587cP5xudlYNkP5QQxy7JqTrWNEo0ahRL0Ltu7FvckacOBZxgDRFIXKd0TDBukPkn6j+7uJdcBS14qexPbCxeUJTs4LWEJVRM2yk4xIoV6gCUyLnj7Lol/0VY2BTP+hNjPvLsxnFP8S86JY+9+AyBdMrWaEYuYem+fc92WC50co2T0aWkd/eYRM1usAXfHa9nAb7nJ2CN6iaqLa0by99fnIIsFKXmjgxJNnrinBUlv4VXPj0Nb6ik9RbbKhI2iaujsbCKZdJMYqTna7YDPaUcVi8mRRBs/yTZ1/gCqajOyBCsXdwNsYy9KX6ZO3xe9Qz+0Xulj2OObI/A6jFaWUT5GPM7azjRiouNriG4hl19TEEw3+UpYvvQ9YssgUkQOMjWHWL/B6nDmV1Kb/uvVGX+7/17+P3Hlm7l9hEpE6bX7ynLEfGnWjxYaaxQR0IL+OvATwmNr4VhHB6S5s4ho9MmEMISIPAzmD/B57TpNFgksaDUlX6ClVnTaSl/c9k2aixgw/eF/yE7CzA3/HDA9gbWSloY8yWfUOth5uD3GxP6VOk17/VQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199015)(38100700002)(186003)(83380400001)(82960400001)(1076003)(6512007)(107886003)(9686003)(6506007)(478600001)(6666004)(86362001)(6486002)(41300700001)(6916009)(4326008)(316002)(5660300002)(54906003)(8936002)(8676002)(66556008)(66476007)(44832011)(66946007)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1itsDnRWI3KFQUJ+R4zlGd3njITprJLrEqfr3+h+3OKJjZOZGp8WomtiZNpR?= =?us-ascii?Q?HqN06aTqrTMPILgeHKB1RVLJax53zJb5P4SlbLg5H2IIXZVfqnQY/uuP91H4?= =?us-ascii?Q?2BqXD3rD+cIs/45Hi9eTSgpsGI3FuWwq1ySCpPlkTfNobbcHxfpSX/vFVxCQ?= =?us-ascii?Q?4lfF/3tbt49SfYeOUsotQ/dDWxhnK6RRFOEcBW3/zsGLjk5ciAK63dCY1GrB?= =?us-ascii?Q?hRtT8taWrPgujW4STyhfQUXcfFxvvIZRp4qS0zlkvfJ5N4nShzDGSkCO7XYK?= =?us-ascii?Q?NTivfWi/g+885oOEHnvOhevl5qVEoUVAYAyDZ/XCJ40z6sBWVVy5aQJgqOjN?= =?us-ascii?Q?2APw0B4pdm+S/kcgCJ1Nv9dfzSMShN0eACPY6A1qun1zuZqxNTjK3W+NZg0H?= =?us-ascii?Q?WGiaTWqd+EwJkqT8DINLfaRQx73l663XcEG63d8UkO0PIeRRjcL+gNsCS7x4?= =?us-ascii?Q?WjFrs1O0M7Ge6/svdcOqenNgc0WGVAcIoErc7NdaUff5rpA2bexyIyKU41bR?= =?us-ascii?Q?KUjraAZ6QOmIWKGF6quLOak9RVDO8hjNn86/OeLa9dKw0NqpD4m0z2BCc6kb?= =?us-ascii?Q?JGQwz6Iw8UClLjNkGblUMzvTgeMprJNWtCDB2w6J1qJhbpIUqhFXRKy3P3zD?= =?us-ascii?Q?m50GMYN3ioHIzx6UUxWkg02cut8uvQaxWVqbYV97KSG0WAd/Sxnn+NBnfZ31?= =?us-ascii?Q?OjRJVcr+dyQKdmiiWHNohQEh7bXdvi1PlZ9cE8VawL/e7+gX/ytoB4KcR+EB?= =?us-ascii?Q?xB1wy0iTSwzIz6c56OzPT3LZ/9x1aealUEu6msjZiYmHCAgv3pkGApTyrMpA?= =?us-ascii?Q?ypd7eNMJA/+1I8VzKXM/m4TH9CAd0M5AsoydkwHkgN6QTG6aC9VH289QBqrL?= =?us-ascii?Q?PmJqWz8T9Lp4Pd4vvdBQbrFnTfw2XbBy2+X+pLuDHU7/FkzT0fsaC2hlCnzs?= =?us-ascii?Q?8RKfV7KD0c/yi/kj4z49sHFmltOyxbPQFqutC+mV5UIDHcvXq5FAtOGdOsIp?= =?us-ascii?Q?Ey54VcGQZht8JvJd2+A4XUbxDDuqLUMvOXgNMEvsDIvX6wqAoqjO79J8bCNH?= =?us-ascii?Q?zJSR5HqfAhpoReuKr4ymXVbP7LKagdi9G4uMdDPUlecfbzDpQ1CtrtALnhuD?= =?us-ascii?Q?f1IFGzhPHd8ZRFIE2KNHCncyV1RpPFMZhjNd/I87D7m3nmq+FkmwU5zZkmko?= =?us-ascii?Q?M77h+W+Y7apH+bVVO6ncEG92aS7EWAYIgdJ8eOP7f9yI6h2dUPUba/iectj2?= =?us-ascii?Q?azp+C19+JS5aI5NdyvHzf1Pm0oqoP2tn2PPhQUgsRqeIfJwqGf3DaaXykswD?= =?us-ascii?Q?f50hEPufQlEINgEHu8qBYpLc2lTBJKZb0phFWzDgcioB3rQT4qYwwjbv7Epv?= =?us-ascii?Q?88+aoi06aiZ6biacVQHWQUrJB33VrJcBCHfcduIKbhF74emzjHh1YaHhojrO?= =?us-ascii?Q?p2iSE2gYK1qG+b6Cw4DMzzTA5bcLKibujXyhFAXtsaBI0qqxIEhok+8W/Rk9?= =?us-ascii?Q?BxAKj+t+wLYreGOhojdX8jLSsUkdQ4vNT/TQG+1d1Ea1qHW5Mnq526ZGqWbf?= =?us-ascii?Q?qmf1uqf6ATdgtDAYAHG4vRqyk92MPWrQjoGrRexZ4d1oC8tLv12+48X56UKk?= =?us-ascii?Q?5GEZqb/Nn9NH/gNxJ7WbUHpZ/y++ZIYcWw0sF7pUkw6ujZe06uExUFogX89m?= =?us-ascii?Q?A8jTcA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: e95f67bc-a83e-4f01-58af-08daa5ff1c30 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 11:53:53.5770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ul0Btk6J0GnzAwE5aAZimH0N57Qe6xB3kB0lEt/PcKOsxR/q6e3EI3C10SAXRjNjhsy+lANK+zV7U2/cwcPl1UunPVpCBUEXryJ15R32Ark= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3635 X-TUID: WaswYYNObs0q Hi, i think this one does not need an entry in the recipe changelog. But i am not sure about recipes-support/enable-fsck, it might be affected by a missing / line. Unless it is only used together with wic, in which case the change it does at first boot can maybe be moved into the wks. I think that whole package was written at a time where wic could not yet create / lines, which it now can. regards, Henning Am Tue, 4 Oct 2022 13:46:29 +0200 schrieb Henning Schild : > An fstab entry for / should usually not be required. It just makes a > rootfs less portable (USB vs. NFS, vs. SSD). The kernel is the one > that should know which fs to mount and how. That is done via a > bootloader. > > Should additional mount options be needed for a concrete image, an > imager like wic might add an entry. i.e. for adding fspassno or > x-systemd.growfs > > So to make the rootfs more generic and to allow imagers to add their > individual / lines, instead of having to modify an existing one, > remove the line from the template. > > Signed-off-by: Henning Schild > --- > meta/classes/image.bbclass | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index ccff81066178..d8d605d3af07 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -327,7 +327,6 @@ image_configure_fstab[weight] = "2" > image_configure_fstab() { > sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF > # Begin /etc/fstab > -/dev/root / auto > defaults 0 0 proc /proc > proc nosuid,noexec,nodev 0 0 > sysfs /sys sysfs > nosuid,noexec,nodev 0 0 devpts > /dev/pts devpts gid=5,mode=620 > 0 0