From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7150622362639007744 X-Received: by 2002:a05:6402:2787:b0:459:5139:7e4c with SMTP id b7-20020a056402278700b0045951397e4cmr3089097ede.17.1664886121736; Tue, 04 Oct 2022 05:22:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:7f02:b0:776:305f:399f with SMTP id d2-20020a1709067f0200b00776305f399fls944095ejr.1.-pod-prod-gmail; Tue, 04 Oct 2022 05:22:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7yfGswTauK6E8QIjzrlawQtTpeEu6f2FCmYyu3fGeaMmjPPb9YJWGF4UG5liOjqektl7ZD X-Received: by 2002:a17:907:c03:b0:781:fd5a:c093 with SMTP id ga3-20020a1709070c0300b00781fd5ac093mr18644502ejc.89.1664886120599; Tue, 04 Oct 2022 05:22:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664886120; cv=pass; d=google.com; s=arc-20160816; b=QwYqC5GU1CYdKXaACqh6bL+0w7C08TFc7ilb5A6vPnuRhhln+YP21ofK6NG4RqdjmN 68dOwudbDR1/5Xdh5Q/JUuXM6/Kxghw+fX5uyZGA8/1xkPN11J06WSWy6YP4CCobNzE0 RveWKdudoDiKpNREkLafgAmbmDvA32JQ9BLHmr8eH+Aea8bXeqST+9HSd8nVK8/m8dGm v4mCdDtIQnVj6+jcGo9OqQhuwmiFCWDtdI52DkNXvJn0LPOv86JB3nxRqSzAOZIOw/bW IQSTjvOQQ7W7Z6tjM4/hQEEkqhl2bkiQU1z9gO/MLNbdmMTaP+E+2Mqh1T1W8pKpWA0i 86Lg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=yIzc8iLSJ3fwHNvktl9pILX6Yj8BF9iT/rmd8JfyWDs=; b=dRCO+Dv/TDfZl/adhH/axeYsHVegpVf1c1nvn0aFOBVNJv+4mr019+ZZ4u9Ge/aUli fbVdE+HqPg73JG2/vI3dw47fvnyz+6/lhgfC/RR8S8YimAtZDdfAnQfQXt0pIHVmE6zK nXdU/sWtzGVFvSYanX5y8NGPb46OQDkvZ7RIZSS0D6xELTCMxGAdS2GBPmwMNfdxenWF Zn8+wofXYsMlC9fJkw/PyYHminNZs68ya/R7LdM2cDFHpQoRSPczAeUvCHibfu3+xabb pCq1HkdTgFRlMyRCZpFqKrlRSRSxWxsiTzsMsXUUhl03p0yumhntDiA3u2DUlS/n3Iwk NK9Q== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=BJeclAbO; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com. [40.107.22.40]) by gmr-mx.google.com with ESMTPS id n8-20020a056402060800b004593fb0c160si104086edv.1.2022.10.04.05.22.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2022 05:22:00 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.40 as permitted sender) client-ip=40.107.22.40; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=BJeclAbO; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fy2cQ3BmWBYCi4wcXp0IYDpUoZBVl4aFgfJ9UeWJ5OqrjU/glvxjjVhrwT1PHOFlhcnhxiumM7qcsO8YrQ2vnXutDrNS/rrnMqzkWmGuX2c9nSmTH8AaVlDj+W7ujs2JhuvXur/D7kh/rme9PpP7GZf1OmzsemfuYtkMjcC3KFlU35J5/nSgKPMzx/j6EY9asbpS0aJYGhlcaME5lmFDYjDlGPoTqHlZKu3Xt63u7J/K5bV+1tre1iWNSV6Il0f9HRzl5dD3CFwLgbYRCV3NjjS4r0J7uU3d/rv5i0In/LItPr5WPFTaAqCDbfl5BYwajZhu2kIQLyhwMju8UVwzww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yIzc8iLSJ3fwHNvktl9pILX6Yj8BF9iT/rmd8JfyWDs=; b=C9yZaXpC+g/V76RKiXiryuz5MxZgSEAGY1+W5pM8EPhp+4+5gaojjNzfk0qs8lKdb3drhGlvDGo6aUIVZNAitL6nR7b2kRmyjvpvVD1n0vOsCYrrDL4TbpufpTnqqDz2RkDNBzb+DGlC5hmW7HT660600yyc2zNt9cjz5/MTBaoXCjChbqXyViK/Yk3L3eJczYaiUJAlOsoQR84rqZsZIiQTOuuvnytph1AoompFUdBIYXrXu+Su48qpQDtQ/cpT4i1Rpaw16bFlTeJkQel8XCvmKTdZ879j5Q1rMQgmvjcVd+yoZC/Zx4rPzTHcCMx6lbLsVdYhAdjQwuoLpY5eyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yIzc8iLSJ3fwHNvktl9pILX6Yj8BF9iT/rmd8JfyWDs=; b=BJeclAbOS9SZWvr8oim2Fi4LzxkhsuDpsbZfWQFPonL26G9rnZ40H+r02mYgfL2CCifKe/hs0AfiWsLod1Jb5cAFhWW1pD7B68xg4qBvwaWgQMqgBjgQZEn30nZ6qZJllORuaYI5J+yoSP9PTRv8D/D4XCZ6pXaosVSVxAcHWw38UeQII5lMsbHUoEj/N+VU57Ssi6W3mildC4+X5QYrYgQKLDBGcu+VSp/2etJ7qmgHHPOob4cFw0cNgExiD+lx9oUaqVaL7Jx2JR9ZeDhWYYdbjMTvUHuH4/hfkJ57a/o65B4Iyki24eDhJNOnhoudWllQUTkpwiwbWWLuX/1hQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by GV1PR10MB6731.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:87::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 4 Oct 2022 12:21:59 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::e4a0:49e4:2152:11b1%7]) with mapi id 15.20.5676.024; Tue, 4 Oct 2022 12:21:59 +0000 Date: Tue, 4 Oct 2022 14:21:57 +0200 From: Henning Schild To: Jan Kiszka Cc: , Felix Moessbauer Subject: Re: [PATCH] image: remove / entry from fstab template Message-ID: <20221004142157.6b640697@md1za8fc.ad001.siemens.net> In-Reply-To: <362411aa-2aea-1c83-8c34-94d1b9154acc@siemens.com> References: <20221004114629.27275-1-henning.schild@siemens.com> <362411aa-2aea-1c83-8c34-94d1b9154acc@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::16) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|GV1PR10MB6731:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b37e23c-a08b-4cce-6545-08daa6030904 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +C8jexekQKs0aYC6ClorqmCD0DnyCwuKcReutgLzRelcQgghqDTge6kB+hvgOSslbnn+PqUA0jkvC2Uy1+nJNn7xLJj81sOk6390JkzSxzW4j+tT39+dno4AxqHGfvFYlInX+g6MyMd8HizjRlpZd7D0Q34wFbyWueLuL0AvWf4nEy8ZFL2L3ZdIeT08jYp7g3B9wWCcgc6P8eI55GnhFiB1ua1+DVlbWSMRKalkzjq5kZKP+saEXVVazTSuJsWE1B+EdfeLVUcDJ8z2vvmF4QBBNnE8FmYuQT9jJUhi5sQcIIbNauqgLO0Xe65Do7WVQskiKQZzQRJ1M94LXs+iNrB/9KYiwIpALp2jyJLrpUlhlelHvHBC5sgkhTutzUEIcFnsBf8GgqfaxRREaok5LJDB7rcNdUptXoZom8c1s4GC9kveFsbCzS5rI11F4aIa5Vp2Sz8pkQcUF0B+gJgFo+TYSZI7Gu16E2jtjtWG/O+1y3ZYJ3wdi9iemhyZlHhvs4ZoDzp6W+Z/H2xNuhNB8ieN+iTDk+ysqONW5s7pL9dLDDwelOO2fnrlPtARzec5rnH0mg+8A1ZVDHb0sGW9H41ngbQR3O8Hv7xJwKLt38PvEvUO43kVdyj/VsG2AD0VAEPNKGyqwWrHzJYM32fX95PAujTgclnVyno+UBcpzoc0uXmEI7jaR+75Gf66q53Kf1URpAuQYbKIZ6EYZ3R8cg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(396003)(376002)(346002)(39860400002)(451199015)(5660300002)(54906003)(8936002)(6862004)(44832011)(316002)(86362001)(66946007)(83380400001)(38100700002)(6486002)(66476007)(66556008)(478600001)(8676002)(4326008)(2906002)(41300700001)(6506007)(107886003)(186003)(1076003)(53546011)(6636002)(82960400001)(6512007)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1AJwJ/JdnivwdxfsK0blWVLUrp7ogkZkgTt5dChTwZjXnYzRklTeiifZPy6a?= =?us-ascii?Q?/plfS7h7hbUyNWTUcLa6EILtCuqX8lmq0Lca0WGhu18xPeKVkILaaV6Fu/Mk?= =?us-ascii?Q?y1e1HLoOHOJ21U9NE3yyYPHf1/cqSJX1AKlDiyvWJu2HLAuGH0rKQZYXN3K5?= =?us-ascii?Q?/iCnfH9yzbSUgJ9eKmp95cEHaMR9wpSd2DWZ7QVtn9r6+VNW4l066Qa/vdgh?= =?us-ascii?Q?/kx4S2CNC3suzX+Xywaj3CSfAFkCoHYceVBaKOqTVpbFfg7OfmX6K1dX6VQx?= =?us-ascii?Q?0aofLDRMEHVGqYBfw0VI0LFiPBivZOZowDOcnH2t+Z2V4XWcU2PBzpiDDh0l?= =?us-ascii?Q?Vp6Fu4YabmWUoOERqAnkWpl2dcgJahypoL8eCSKXYHyYK11kdK57ZpV/MyeZ?= =?us-ascii?Q?Za4HFk/n0DujSUrrVOx3IWANd2VXhUUX9ShrYv4fUuoalDW8PNTI/F9ti12m?= =?us-ascii?Q?pRxnOk2ac2iucx3XO9SRP7ukPUtae95Plp5BLLjlzdIJc2+woeuEqkG81KWE?= =?us-ascii?Q?xTkl1l8OLGVFp7pFrPmIy9zhg+lFLi8d1xow3CNTdNnxUkTL1SYze0nC8wEg?= =?us-ascii?Q?EDd24Pgqt3dnmcJfaGI54tGzkKUj2iS6PwoWngnqyw9BQ7JxRWmn1Jv8SFLK?= =?us-ascii?Q?0nIbTV35NyGnXU2ZbkrIABWqdxyvuAol7yH4DbKgHUzWrAVhQkWYaYUl/PhH?= =?us-ascii?Q?oDiZ4jrCIZbr40DXk2/9pSSq/GasdU8X0fTtp0W5/Haisl8AvwHlghADFQdi?= =?us-ascii?Q?J1ourGT63RHTMjdfnqnwwN7Mpzm6Bi1ESnd8deAFuxQmc+36cnnAA+mLgCQn?= =?us-ascii?Q?DV/PRcVU1fWSQx1nrpQizZwD1yAWX+Guuto9DUTQIkPUHtI/cGv8XCgVEGxf?= =?us-ascii?Q?RlD6ch6l7Uh6TUg05t/4BxAy6I99yQWASwRUIWf4kE7aXWfuxupu5F7kNAYJ?= =?us-ascii?Q?Sql8rvZWruBWvnRzMk/w/nH4ytDag6muA46Xyx/bB43DqUuj+E2UGpwL6qot?= =?us-ascii?Q?LphXooYz5AHX+ta/OrJsLqFaVGBL6OjBMjX9XqJ60Ej1+q8m8WtR9Frj9Xwl?= =?us-ascii?Q?mWSDDVwdsJ37wk1TbS0bGocu0JMyUsniVmfVJKweVwOOn4sizQeO/TvHAA5m?= =?us-ascii?Q?k4BbYsXbS4avX0tD6+15KvILnHYpqyUuEDvA8cxRPnV6tUmifPVzGMh4oO9g?= =?us-ascii?Q?EuYLP8iINDNe+9Da7ZGEGfN3gA6fQ5UcH71+29Gt7QtCJlC6w2iN/Z5f3ks9?= =?us-ascii?Q?eZKKGm0KCdY2kke6GvAdC8A/QiWfs2IPua2QAFff7j9SaWk23r8ic2xPeRhK?= =?us-ascii?Q?sp2Cxq1T+XhRAkpTOFGiGBQ2FiyS2Za+wykuW9xcCfhOb6aN0O1b8xwwwsXg?= =?us-ascii?Q?O9fNzY4NcbkAPZxr7sBQ4qE2xLe73Xu03NU/zP6yDWH6nODSSlNNUsOv8ucc?= =?us-ascii?Q?ckEhYWRe9yZxv9020oT957Sha4rZoNHN5S7m78LJ+vKxUCRsGF47Q38+QFmI?= =?us-ascii?Q?eW8VPvIbWur3j6XCg5Ffd/PSdAZJcxvMFyrJVrCesSm5V5C2APQSgSWjrA+x?= =?us-ascii?Q?biLg+PFuOCv6gomk5K8Enxd9TC+0SePtUj0drG/AM8fyFG0XL2WlokwrA3K7?= =?us-ascii?Q?04C1V9PZ/NvQgVydK4/XJVhzclJyrWnDYg3ayirO/UuVdUKMjEgKWwnTQJ9W?= =?us-ascii?Q?/oPaAw=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b37e23c-a08b-4cce-6545-08daa6030904 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:21:59.4304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dx+E3/xmPNskslhKDlrFhEKLlbt/mF3QzYZXZCJLMlnGhiOVl59kVuzxuLdAiHMDmJ62GCUA5PR0T16MD2+WO5pfEpxvCveI51YMBW/FLlU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB6731 X-TUID: 9e37HpZqEen+ Am Tue, 4 Oct 2022 13:54:38 +0200 schrieb Jan Kiszka : > On 04.10.22 13:46, Henning Schild wrote: > > An fstab entry for / should usually not be required. It just makes a > > rootfs less portable (USB vs. NFS, vs. SSD). The kernel is the one > > that should know which fs to mount and how. That is done via a > > bootloader. > > > > Should additional mount options be needed for a concrete image, an > > imager like wic might add an entry. i.e. for adding fspassno or > > x-systemd.growfs > > > > So to make the rootfs more generic and to allow imagers to add their > > individual / lines, instead of having to modify an existing one, > > remove the line from the template. > > > > Signed-off-by: Henning Schild > > --- > > meta/classes/image.bbclass | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > > index ccff81066178..d8d605d3af07 100644 > > --- a/meta/classes/image.bbclass > > +++ b/meta/classes/image.bbclass > > @@ -327,7 +327,6 @@ image_configure_fstab[weight] = "2" > > image_configure_fstab() { > > sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF > > # Begin /etc/fstab > > -/dev/root / auto > > defaults 0 0 proc /proc > > proc nosuid,noexec,nodev 0 0 > > sysfs /sys sysfs > > nosuid,noexec,nodev 0 0 devpts > > /dev/pts devpts gid=5,mode=620 > > 0 0 > > This works also for other imagers than wic? Just poking to avoid that > we miss the case where this was once added for (if that exists). AFAIK there are no other imagers that create fully bootable images. We have ext4, probably usually combined with "qemu -kernel" as "bootloader". And "tar.gz" usually combined with NFS and pxeboot or any other external bootloader like uboot on a flash. Both should remain working without the line, at least for qemu CI will shortly tell. And for NFS i am pretty sure it will just work. I can test that on request. Looking at its git history, that is very old and hard to say why it was ever done like that. Likely predates systemd and was taken from an older OE or raspbian. Henning > Jan >