From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7159568423188430848 X-Received: by 2002:a17:906:30c5:b0:782:707:9e2d with SMTP id b5-20020a17090630c500b0078207079e2dmr46098255ejb.286.1666967015918; Fri, 28 Oct 2022 07:23:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:5295:b0:797:e443:f845 with SMTP id c21-20020a170906529500b00797e443f845ls1284053ejm.5.-pod-prod-gmail; Fri, 28 Oct 2022 07:23:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7pOZPy9xufhdnRKjm9uJBqm253FE6JPoACBSM2m+4j1A92SywsMpaP6QGxA4+KIKUoF3gh X-Received: by 2002:a17:907:94c7:b0:78e:1c4f:51f9 with SMTP id dn7-20020a17090794c700b0078e1c4f51f9mr49342341ejc.200.1666967014849; Fri, 28 Oct 2022 07:23:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666967014; cv=pass; d=google.com; s=arc-20160816; b=RiyTUeuq21ZUM+Un3VnxZOeo6zPklhXbbq37irQMWL7rejLfAlEhXYfMkONwP/Cz/9 /wGkDRJ51uaZeYFXEKzNvMujeiTpNR2Ie2zAFLOUGmYCvTHpILd9Neklxe/ogSDNRt/O lXBe9vi5iHX4Opltxour91K9aWgRteOtdn0lqETS7iUm1REGh1TKT9PSDxuvUabsdTCR qwRaqvX1D0/wunR6EMifvstdDRtfCkt18YzdwYz4vHiM+yv89VP164wNN6IXx+cqFj9+ pcvL2ctqruxhfVHMxuD+HHJ/aZi+DC+MugtuKFOUOt7ai5Jsc6g7LrqBPa+C65VB+gUW mGVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=U2FJxkqNBNWJQ9t42RCeLm5wO0Cb+5N9dePqZyQ//EA=; b=fbShomfi9VAegOxX7IRsEvhCsWz/QPh87eeuCc3WJM0jnaLmGBeovc/3WmA/6trHbd ScE/NCp8u58s8WTaPOgBfjHgNmlyf2mUgKaPfJ2PiKCrHSIV7/23P6mJSbRKt8tSN1Xy eEYNEeE2g4Q8lZs2dyQA/dVEBCtPZZ5SgJ0dpn6fSZd1PBC5I5pfZKnG867+p2dc2yDc /71f8h/cfcZAhzUflGtBxHydpTVrRTOQwwslUSpvM8ACq2V9nmZJJqcn9xwJ3gm9PL5F VDiCUOZLg68o4xtAJx+j3GpRf0V77emJFPNj4GlNEHOT5RqLSoMNMCeFRdetdCohmeJq NwpQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=HDJDN6hN; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.63 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2063.outbound.protection.outlook.com. [40.107.20.63]) by gmr-mx.google.com with ESMTPS id gv28-20020a1709072bdc00b007a5f25d9f11si137872ejc.1.2022.10.28.07.23.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2022 07:23:34 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.63 as permitted sender) client-ip=40.107.20.63; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=HDJDN6hN; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.63 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y0kY2sQ/Bivydne1Y+PuBZy4QnDQMYimcKxksOdfcrr7KEJf6CPd49XkeilEi71lSOKkf8qenbPhMSBuHBtpx1VfYHGDkQWuIav0OqWvDxsOZ/+yJ2N8qTQ2oDTTZSa63uVWwfHhWMAYqmXOLn0U0Hchsl8z7gaOjV6CCKWCk075+Yb/x21s4+oQeipisZu0bAtJck9pQbFfRPmNdB4CMc9g5dWjZCtA0LQk97bd9S78eNfpFqb/vj8wTeSNj9dYqFAmNDRW1wIRrg5mAyov/AFv8aVr3WYzYCfHYCfw46aMtu9+in7UrWah2VPDd3WTBDKRqd/VyHctJgZrwdq3Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U2FJxkqNBNWJQ9t42RCeLm5wO0Cb+5N9dePqZyQ//EA=; b=HE79gqoUjgucgk97b1NL8uT6UZKB6WWDGl7UIbo7WsHt0fdK1XWyEyijzfg9uNZHX5/MSSASBGf5yaIpnszmblOnaum2xBugsguvVUJuvwlbyoRw9nf3EU1KYTXsELHkmNQ8zpHrwwJssZNkFXlBk5bL09XWQxduaLgHgwPKdmBtPvJNWSuBg7sY0kU0CpamxB5M8xM25vCnTzS/qvy7k5d8j2jJ8jT8DRyUPfAD4bymwOgEFeQyPZ0TA5nl9X9IcmhKjbjJ0T1xwBjgAEQyJsUaS1I9haQXyIbDYUqE4dXJ414o7JQonudBboN/+sD6xkZhYzjP2xj3E7DTMH7vrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U2FJxkqNBNWJQ9t42RCeLm5wO0Cb+5N9dePqZyQ//EA=; b=HDJDN6hNnqUR/FocgQqibLxe1zYE48cJrS/p0WwPh5RravhPk+tAuL7Rd8hrL1laakzFvUFx+2MZciZ5/iiCN1lE+nIvymclioPTGYmtajs/+2KM0Lmgtk0vOAGw8f5pWbz+Olw8dvFRB1XxtBVPH5itBIYfDoquMK0xIdCFCjJEtpIDAo0jfGkzvEjZswoOke7/yvMii+2/srY8VzzSaj/RLyHtorKiY5HhvJ2aXsSshMy5vFOHK6I5/P5IKZsjeuEyzRnoHJYpEaZcXJPRLaj/bYpzgjmUxVNd3uA0Pb9uS5pyJORhNNsIrnHYk+VvDszLCXhqy7WW7PKlrpbd0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DB8PR10MB3893.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:16f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct 2022 14:23:33 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::1cd8:9066:48b1:b1c2]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::1cd8:9066:48b1:b1c2%9]) with mapi id 15.20.5746.028; Fri, 28 Oct 2022 14:23:33 +0000 Date: Fri, 28 Oct 2022 16:23:18 +0200 From: Henning Schild To: Cc: Tobias Schmidl Subject: Re: [PATCH 1/2] CI: improve cibuilder readability Message-ID: <20221028162318.49991fa9@md1za8fc.ad001.siemens.net> In-Reply-To: <20221028142145.4428-2-henning.schild@siemens.com> References: <20221028142145.4428-1-henning.schild@siemens.com> <20221028142145.4428-2-henning.schild@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR02CA0026.namprd02.prod.outlook.com (2603:10b6:610:4e::36) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DB8PR10MB3893:EE_ X-MS-Office365-Filtering-Correlation-Id: 76cbdd99-e24d-4789-8baa-08dab8effe6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e9SWy3YxXeW2NFF9MkCptnOwJXfpOM33r1R5+DT2rsntRCb7nIVDRYolO7NJTq/koehhSe2/bYZRaaJeb3OCmSAFj5dwwk60KSGITgoQaLwlXSSe1AXK1z6loYW9vLBuEdXpUiMRyz8NVq42q2s80Mo2YfTMrFjabNkyfx7bK/2009LG5ukdvCUZ8ZZwOenCihpdFmNCePaFbHBJ6yYGp8jQQINilXQHk+wK3ljCn8rnHwkPiHG2V2ZH8uVOsRpAlWOuXMVsdWt1ROplNwC8o1J05KShx4lYDU+72A6X4hMpmMVR03a5iAs8v+ZfOF+ZtFN1UzEWmp/ou8XS+zpV2IsaApRzcDtu9CpyaGu+mfeGj8nw99dL3QnuIBFpHOsp8mtbrnJLrihw56MBscpa02LS+Pk+WRP39Ahzq0S0aoBQDUFFZ6SkSZaJVzfYEHIRY4ArfKWFxD5HAzgNEwXQMuNmt+rRU1FGK3GnTpGPXYGQvjTYh1XA/A3TmFp1KO3gpajx1n2V8mDGRVBh2wqSmABNkDjDm5VZq+eMC2vLEXiAcW5SQi8wCSsCYqXIXlS9ZblJpq553oZbv8KhZavCK5FuabAoDdp8jAznn46Gx2601IUSzQv5bSxxdaV224lsprfnjKBCvOZB0K7mKajhvgBAo33XPYkJnjuXPqEkel0aQRTxUxDKG7iD/qafKu9Ja2xWEwhszi4b9lXvloJ01g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(39860400002)(346002)(136003)(451199015)(8936002)(44832011)(2906002)(1076003)(186003)(478600001)(6486002)(107886003)(6666004)(316002)(6916009)(66946007)(82960400001)(83380400001)(8676002)(66476007)(4326008)(66556008)(6506007)(86362001)(5660300002)(6512007)(9686003)(41300700001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?00xwPBJUHxO0VhoERYCsPhZI/PioSWNr8JmP9+MAU9AlqUkXN+wK4du3lUtD?= =?us-ascii?Q?zbJ3bindShCDU3BCrFwfAuj2gtGCy9qTwFK4/MFCdJLYXIBd5E6Qx6AVcSOA?= =?us-ascii?Q?OsAto1Wls6yxsd3v5BO3jVHpJC5ofj/TKEdJsPs8BlTtBlBKuXuY6csbUdTN?= =?us-ascii?Q?EjyBjPA1qCGl0TGIquxWRUWUG85LQqFGTu6IzqFFCks3JVQHnIoKpJ2SnCDW?= =?us-ascii?Q?iliKSNSQ2B1PeeZXexhm2X6eF0G8OB++TomNx9xadOx//ApaLtWXrNsz6NtB?= =?us-ascii?Q?k9zKYZxQZ+KrE9lrmEI3owwy2RTV1vaK/vZubO8unIrpWG9NAZU9bzOHekuZ?= =?us-ascii?Q?WeAvtN3fmodZd4e8gjKgC8I/e09I7/MG5E1vSACzmWCiWsIyOceRZKaCGvwb?= =?us-ascii?Q?Vnc6f1rBx++e8DAqJKhS+o5zuQwaQsfM3lPHSOAblakBMvnrcJrTlJ85jhiA?= =?us-ascii?Q?/87ndxPzsb0p8XFTjOcXJ2Tt2vhnJWgeDTYH9w5zunvg7zzc2/K1qr2ncw4h?= =?us-ascii?Q?2dc9VBe5NKnJDXmgsLiUHJdZti/PYxHqQOD7bZCZw4vkpY4elEw82tabRLcB?= =?us-ascii?Q?9vC1WPH8pd+uNEzOP72WZbR70SgGtEwETdDrj67HwblVWndExdeDt+wcbhYZ?= =?us-ascii?Q?Hz2px36S/WK/WSRYeH1cS9u1z0NFcSy5QyjFMwtqzZfrJqfkyGZO65osNf5+?= =?us-ascii?Q?ZX/1FHRuz+nLz/2uPMOK6H4QOhbmU7vrxYjKtBYYMsMRnoA4ZcEpEzeIVht7?= =?us-ascii?Q?Vzl+gd4aPCdZd4b3Vxi0ugoKW69GZCfDvs76J3ReKv8u0NamAQMDzi01UMhv?= =?us-ascii?Q?pjW8cVEA0fxVymvIQ6ScvidwbkthLFc4L+RIeph1V4+pPtDmL8vXPsIroFT3?= =?us-ascii?Q?I9X9bEe+J2jhiDnP2Z1a9t1/GjrwCOKvGVlGqFrYSy3dPHeXK59tb+J6QRLo?= =?us-ascii?Q?mmi+rGPWlzQhDFWLyMZG9DpD/HI3gQVVapdqjcun9LkYu9/K/luhgfxNtJXn?= =?us-ascii?Q?nS85bSBdd3CzC3ooc5EOCiteV+2jYcNHaWpFmVor+qTyOONoLS0MKGJJVqbe?= =?us-ascii?Q?CEgCqpPUF2+1QN22P5dwANpjwF7m6+DpiAIUrxYPnFa9JPA00JIwY0rbPzbh?= =?us-ascii?Q?oQlDzyXHpADxlM8IltzWXlv+23EMKksH/GUIm2zkVJVUelUnYcFwCWzNq1Fr?= =?us-ascii?Q?uw8Bh1rsLNUL7E2fmO4wOs/kgFWnSCAa3n5P0g9+qbaRuMI7iBzJDCPrQjIW?= =?us-ascii?Q?KrgdEkQQfF/XT1Xo6qeMNQEyEw+DAVzvwA6DRZqxSnTZUCI5DwsFkCnColg7?= =?us-ascii?Q?yEnRCoo6v4H5kf5HTOwPvK0wTOhIsHryXIGobwQNbTV48k+MTCbMZ5mo+0yV?= =?us-ascii?Q?jnKkZ7MKdTR6iUbuzgn4uLxcQCL9F8CStNEAgJ28mR0hv1WS865j08RKjjYi?= =?us-ascii?Q?5/2XAmi4c5iHjv0s/N/iSylRMWjOn+Urf4X3HcSNFn4O1iAtNKYeuR+sDUjV?= =?us-ascii?Q?njKNWENd2Ok/Of2IW0nfayL21qQxnasgRJfsWR1sr/1/Qak+mMLgb+t1RJQG?= =?us-ascii?Q?l8od/6gubGwpUC0oS/vOk5vEAAkNl90CZYzPSDdUf8tGkMIBmTEgrGF2E/Vx?= =?us-ascii?Q?VtvBI7hMJfhEarbFMfrwtfoieu51/iK1epcWNvQYTUvtnD4luqdaXUadVBH1?= =?us-ascii?Q?fp8I1Q=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76cbdd99-e24d-4789-8baa-08dab8effe6b X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 14:23:33.3845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: blEbRwSrn/Qpj43jn2drQy8lMG9wOCXwAjT/QYQVzDIU4x82Z0ov9ijd27nMe20yBN+6cOBSUV91EdynNrJY+Rvl2/EgbQKfatvmXrM5uWo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3893 X-TUID: bPdtkMLi/Kst Say there are longer discussions. I think this one can be picked and might not need much talking about. Henning Am Fri, 28 Oct 2022 16:21:44 +0200 schrieb Henning Schild : > What was called "servive_prompt" is not a prompt nor a service. > Document what that is and rename the variable. > > Signed-off-by: Henning Schild > --- > testsuite/cibuilder.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py > index d5c83b222d50..07a9edc56d9c 100755 > --- a/testsuite/cibuilder.py > +++ b/testsuite/cibuilder.py > @@ -229,7 +229,8 @@ class CIBuilder(Test): > self.log.info('QEMU boot line: ' + str(cmdline)) > > login_prompt = b'isar login:' > - service_prompt = b'Just an example' > + # the printk of recipes-kernel/example-module > + module_output = b'Just an example' > > timeout = time.time() + int(time_to_wait) > > @@ -263,7 +264,7 @@ class CIBuilder(Test): > if os.path.exists(output_file) and > os.path.getsize(output_file) > 0: with open(output_file, "rb") as f1: > data = f1.read() > - if service_prompt in data and login_prompt in data: > + if module_output in data and login_prompt in data: > return > else: > app_log.error(data.decode(errors='replace'))