public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: roberto.foglietta@gmail.com
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH] linux install.tmpl: added CONFIG_HAVE_OBJTOOL in OR for objtool
Date: Mon, 7 Nov 2022 10:02:35 +0200	[thread overview]
Message-ID: <20221107100235.48b07775@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <4uib2il4q62q.q_EMhEP7Ci2DAvn54u8ALw2@16F0H.trk.elasticemail.com>

Am Thu, 03 Nov 2022 15:55:19 +0000
schrieb roberto.foglietta@gmail.com:

> From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
> 
> linux install.tmpl: added OR with CONFIG_HAVE_OBJTOOL for objtools
> a fix for newer kernels (since 5.19 for sure) to include objtool
> 
> The newer kernels (e.g. v5.19) when compiled and packaged by an ISAR
> do not include the objectool anymore in linux headears package. This
> obviously breaks any activity which expects to use that binary
> executable.
> 
> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> ---
>  meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index
> 0a8645d..8a604e4 100644 ---
> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++
> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -177,7
> +177,7 @@ kernel_headers() { echo Module.symvers >> ${obj_hdr_files}
>      fi
>      (cd ${O}; find arch/${ARCH}/include include scripts -type f)
> >>${obj_hdr_files}
> -    if [ -n "${CONFIG_STACK_VALIDATION}" ]; then
> +    if [ -n "${CONFIG_STACK_VALIDATION}" -o -n
> "${CONFIG_HAVE_OBJTOOL}" ]; 

!x || !y is the same as ! (x && y)

i would find the latter more readable

Henning

> then (cd ${O}; find tools/objtool -type f
> -executable) >>${obj_hdr_files} fi
>      if [ -n "${CONFIG_GCC_PLUGINS}" ]; then


  reply	other threads:[~2022-11-07  8:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 15:55 roberto.foglietta
2022-11-07  8:02 ` Henning Schild [this message]
2022-11-07  9:46   ` Roberto A. Foglietta
2022-11-17  8:30 ` Anton Mikanovich
2022-11-17 20:28   ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221107100235.48b07775@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox