[PATCH 1/1] fix apt-retry spec used by apt running in rootfs

[PATCH 1/1] fix apt-retry spec used by apt running in rootfs

[Felix Moessbauer]

The configuration to let apt retry failed downloads belongs to the
'Acquire' group but not to the 'APT' group of apt.conf.
Previously this had been placed in the invalid group and hence did
not have any effect.

According to the manpage of apt.conf, the new location is at least
valid from debian stretch on and from ubuntu bionic on. By that,
all distros supported by ISAR are covered. The same configuration
entry can also be seen in the debrebuild script in /usr/bin.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/classes/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index bbb5ac0a..d19ac037 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -107,7 +107,7 @@ rootfs_configure_apt() {
 
     mkdir -p '${ROOTFSDIR}/etc/apt/apt.conf.d'
     {
-        echo 'APT::Acquire::Retries "3";'
+        echo 'Acquire::Retries "3";'
         echo 'APT::Install-Recommends "0";'
         echo 'APT::Install-Suggests "0";'
     } > '${ROOTFSDIR}/etc/apt/apt.conf.d/50isar'
-- 
2.30.2

Re: [PATCH 1/1] fix apt-retry spec used by apt running in rootfs

[Henning Schild]

Did not try but LGTM

If that never worked you could include a "Fixes" on the blame to get
better story telling.

Henning

Am Fri, 18 Nov 2022 10:18:52 +0100
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:

> The configuration to let apt retry failed downloads belongs to the
> 'Acquire' group but not to the 'APT' group of apt.conf.
> Previously this had been placed in the invalid group and hence did
> not have any effect.
> 
> According to the manpage of apt.conf, the new location is at least
> valid from debian stretch on and from ubuntu bionic on. By that,
> all distros supported by ISAR are covered. The same configuration
> entry can also be seen in the debrebuild script in /usr/bin.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes/rootfs.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index bbb5ac0a..d19ac037 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -107,7 +107,7 @@ rootfs_configure_apt() {
>  
>      mkdir -p '${ROOTFSDIR}/etc/apt/apt.conf.d'
>      {
> -        echo 'APT::Acquire::Retries "3";'
> +        echo 'Acquire::Retries "3";'
>          echo 'APT::Install-Recommends "0";'
>          echo 'APT::Install-Suggests "0";'
>      } > '${ROOTFSDIR}/etc/apt/apt.conf.d/50isar'

Re: [PATCH 1/1] fix apt-retry spec used by apt running in rootfs

[Moessbauer, Felix]

On Fri, 2022-11-18 at 21:35 +0100, Henning Schild wrote:
> Did not try but LGTM

This is anyways hard to try.
You have to simulate a broken network and then check the logs for
traces. But in CN we quite consistently saw build failures due to
instable connections to local mirrors (or rate-limiting...).
With the fix, everything is running smooth so far.

> 
> If that never worked you could include a "Fixes" on the blame to get
> better story telling.

Done. Sent out a v2. Actually the issue was introduced when moving the
apt config from the cli to a file.

Felix

> 
> Henning
> 
> Am Fri, 18 Nov 2022 10:18:52 +0100
> schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
> 
> > The configuration to let apt retry failed downloads belongs to the
> > 'Acquire' group but not to the 'APT' group of apt.conf.
> > Previously this had been placed in the invalid group and hence did
> > not have any effect.
> > 
> > According to the manpage of apt.conf, the new location is at least
> > valid from debian stretch on and from ubuntu bionic on. By that,
> > all distros supported by ISAR are covered. The same configuration
> > entry can also be seen in the debrebuild script in /usr/bin.
> > 
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> >  meta/classes/rootfs.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/rootfs.bbclass
> > b/meta/classes/rootfs.bbclass
> > index bbb5ac0a..d19ac037 100644
> > --- a/meta/classes/rootfs.bbclass
> > +++ b/meta/classes/rootfs.bbclass
> > @@ -107,7 +107,7 @@ rootfs_configure_apt() {
> >  
> >      mkdir -p '${ROOTFSDIR}/etc/apt/apt.conf.d'
> >      {
> > -        echo 'APT::Acquire::Retries "3";'
> > +        echo 'Acquire::Retries "3";'
> >          echo 'APT::Install-Recommends "0";'
> >          echo 'APT::Install-Suggests "0";'
> >      } > '${ROOTFSDIR}/etc/apt/apt.conf.d/50isar'
>